Commit Graph

13395 Commits

Author SHA1 Message Date
51d86c9e62 Consistency around SdrAngleItem in svx/sxciaitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17 15:36:13 +02:00
b9789a6319 There is no ExportCGM
Change-Id: I84b0d4daa3a6090aadaa7f64bdb9277efbba371f
2014-10-17 14:23:46 +02:00
fc78d8dfba Pass args by const &
Change-Id: I510e1aba6772e1f8d4013b235e95a1e5599fd601
2014-10-17 14:23:46 +02:00
582ef22d3e fdo#84854 it seems long is not enough on 32 bit
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
d49eabcc56 ensure UserData dtors are done while SolarMutex is locked
otherwise I can't even reorder two slides in the slide pane with
dbgutil enabled without a SolarMutex assert in RemoveListener

(and we have two SolarMutexes here for some reason, one should be enough)

Change-Id: If224568f1b90d62c17bde65a896534aa10f8a661
2014-10-16 11:16:41 +01:00
165059674d Restore my pretty slide highlighting
and which got horribly destroyed by merge-conflict resolution of

78f6407978aa48c3cbb116bc281940dbf1f2dcbc

Change-Id: Ie560416f4aa435e80c57a4449ee499fc5af20022
2014-10-15 17:38:19 +01:00
ad9498f8b8 More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
d9fa1247be fdo#84938: replace SYMBOL_TYPE constants with enum
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15 10:13:04 +00:00
da77897d19 nDrehWink -> nRotationAngle
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
72cb37b685 fdo#84236 Remove view modes from sd context menu
Change-Id: I7146ee946c7f882decae2c8d93c63002d00dd511
2014-10-14 16:34:00 +02:00
a24f9d9197 remove duplicate definitions of PPT_TRANSITION_TYPE constants
Change-Id: I8b6743c4f2c5c3d52c7df33953ed3dd7b32a1a46
2014-10-14 15:51:36 +02:00
2fff4927c4 coverity#1242426 Dereference after null check
Change-Id: I59c96846aa5bf4780e4c5bfb0b71242e3b928976
2014-10-14 13:42:19 +01:00
ba39577890 fdo#84938: convert EPP_LAYOUT constants to enum
Change-Id: Ibf43bf9ca241c6286659a16906a45bbafa798748
Reviewed-on: https://gerrit.libreoffice.org/11961
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14 12:18:42 +00:00
1175b25bf2 fdo#84213 Add show/hide ruler to sd context menu
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13 21:21:25 +02:00
1c8695ecf6 boost::rational throws if 0 is passed as denominator
Change-Id: I312fd6b964555b3b4aa4e22cec6054c9a83b2c52
2014-10-13 10:02:26 +02:00
4d7806f73b Wording: 'Audio/Video' -> 'Audio or Video'
Change-Id: I9572d4c7fb5f50b869e69436302ac8c20e500392
2014-10-12 15:30:16 +02:00
475df8db91 fdo#84916 Fix string: Insert Audio/Video
Change-Id: I76cd8502f9cb2af379dd732d2081feb094599aca
2014-10-11 17:37:16 +02:00
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:52 +00:00
cb7ede2d99 convert vcl StateChangedType to enum class
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:32 +00:00
8a2da50632 coverity#704776 Dereference after null check
Change-Id: Ifbad1fc30665ff6b9238b5fb4728fc302b0458fa
2014-10-10 12:50:23 +01:00
86b0762bbb coverity#708132 Uninitialized scalar field
Change-Id: I830210b44459cf94eabb983b99bfcc104f865492
2014-10-10 12:50:20 +01:00
a1b7164742 coverity#1242757 Result is not floating-point
there was two of these, see

commit 164bd64255d71d96e35e908f6425acf8372795fb
Date:   Thu Oct 2 04:44:33 2014 -0500
    coverity#1242757 Result is not floating-point

Change-Id: I1f66191f329b2d87bdeb52aa1a7528ca662064a6
2014-10-10 12:50:18 +01:00
cb3b90751b coverity#1244953 Uncaught exception
Change-Id: I3c4aeb3318af7cdb964128dd78f7d2cfba48000e
2014-10-10 12:50:16 +01:00
86de557ea2 Unused PowerPointExport::mpMasterFSArray member
Change-Id: I02b9c31146396a39a624fbb869a5880b176e0f9e
2014-10-10 13:50:02 +02:00
fb365e63ab cid#1244955 Uncaught exception
Change-Id: Iedf06cc78cda022112699be3db650d11c7249adc
2014-10-10 10:14:18 +02:00
1958ca235b German comment translation.
Change-Id: I479da454235a7cfc084ae1517ab9ffa07580ab0c
2014-10-09 17:44:58 +01:00
c78d5fae81 German comment translation.
Change-Id: I98526bfd6f69d95d5c309e67c397bc85fb8817ab
2014-10-09 17:44:58 +01:00
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09 11:33:33 +00:00
04a810cee4 back out more wrong and confusing tools::Time comment changes
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...

Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
62aa0f83fa fix build after PathKind enum commit
after my hasty commit
bc00203  "convert PathKind enum in SD to enum class"

Change-Id: I97263e907bf7363121dc1b437eaf564efdb66ad2
2014-10-08 12:42:24 +02:00
bc0020344c convert PathKind enum in SD to enum class
to get the NONE constant out of the global namespace

Change-Id: Iecbe39126c1ec08aa852fcb903cee1a6e6f4594b
2014-10-08 12:22:55 +02:00
4b7b013491 Resolves: fdo#44998 crash when opening context menu of a field
If you right click on a field in an inactive text box, then a mouse down,
context command, mouse up sequence is sent. The mouse up is supposed to be
captured by the context menu here. But it doesn't because the mouse down in
draw sends an artificial mouse down to the editengine which eventually sets up
a MouseCapture window so the context menu doesn't get considered (because it
occurs before the capture window is released) so the mouse up gets send to sd
while the context menu is up and that causes all sorts of havoc.

Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-10-07 16:55:08 +01:00
fb6d3b883b disambiguate uniform_int_distribution
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07 14:21:16 +01:00
6ced5dbd1a Disable sdremote by default, and improve flow control.
It was intended to disable sdremote by default when it exited
experimental mode.

This reverts commit 576943b9bf7506829de97d2194c4bee35a485436.

Change-Id: I2c1b5443e334021bd9574316167f48b1af6200e5
2014-10-07 10:31:06 +01:00
60a67da70f ~SdUnoPageBackground() gets a SolarMutexGuard
Change-Id: I76582bb6a1a8dee56611f1463d3e63246eefb310
2014-10-07 00:27:18 +02:00
54e86f708c Missing include
Change-Id: I47ddb95018109e5e771324b699dfdc10f529dfc4
2014-10-06 16:49:26 +02:00
b1d48f0d9a fdo#75757: remove inheritance to std::vector
from PptSlidePersistList.

This also puts in assertions that every entry in a PptSlidePersistList
is non-null.
Cf. 9536a28ede89e8c29940e8ba225215a45667062c

Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a
Reviewed-on: https://gerrit.libreoffice.org/11807
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06 14:09:20 +00:00
8f436d3de7 use comphelper::rng::uniform_*_distribution everywhere
and automatically seed from time on first use

coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand

Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06 14:13:27 +01:00
a836afe471 fdo#73151 Always open Styles&Formatting dialog in the sidebar
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed
Reviewed-on: https://gerrit.libreoffice.org/11648
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06 08:15:42 +00:00
164bd64255 coverity#1242757 Result is not floating-point
Change-Id: Iae8ac2ad9d1713512619c5c33eeee9a21b5835f1
2014-10-04 09:36:28 -05:00
beadebc0f7 coverity#1242802 coverity gold(?) Structurally dead code, loop doesn't loop
Change-Id: I2be3e6d88472ba8b69f012aaf975a91f0ab4f693
2014-10-03 16:30:28 +01:00
f3259873e1 coverity#1242533 silence Arguments in wrong order
Change-Id: I7031e7408f5bcd9ae85fc50952253e14d2fb2edf
2014-10-03 09:07:53 +01:00
2a28668260 fdo#84617: Guard the destructor with SolarMutex.
The same pattern as introduced elsewhere recently.

Change-Id: Ie7b4fd1ec26d417f63bee26dd336dfc54f4847dc
2014-10-03 08:20:23 +02:00
ede0abe6b1 Bin EE_CNTRL_URLSFXEXECUTE which was only set, never tested
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02 21:09:52 +03:00
96d210bf9c bnc#657899: Paragraph vertical spacing differs from PowerPoint
We need to set the "paragraph summation" flag also for .pptx import. (As is
already done for .ppt import.)

This is what in the Options (Preferences) UI is called "Add spacing between
paragraphs and tables (in current document)", on the LibreOffice
Impress:General page. This is a setting that when set becomes local to the
document. I actually don't really understand why this needs to be a
user-visible option, wouldn't it be enough for it to be an internal flag that
is set for documents imported from .ppt and .pptx, and is clear otherwise?

Change-Id: I525178957276e7d587b6ac4be8ae7919fc245a27
2014-10-02 21:09:52 +03:00
a7232e3f54 coverity#1242520 silence Arguments in wrong order
Change-Id: I88b96d42f5ee96641dc21e3e55415f6dc32b3951
2014-10-02 14:49:10 +01:00
37f62f86af coverity#1242496 Resource leak
Change-Id: I419b217df306d41ed99e603bae9381f54c633598
2014-10-02 14:49:04 +01:00
ef6a120af6 coverity#1242497 Resource leak
Change-Id: I2c4295c7d308257290aaf04181805d7dc71d6553
2014-10-02 14:49:03 +01:00
d82057a3c7 coverity#1242800 Result is not floating-point
Change-Id: Idcd1b3bd542512707b722708e4b3336c71fbff80
2014-10-02 14:48:59 +01:00
a165aa38d9 coverity#1242906 Unused value
Change-Id: I7a282e5adc60e4b123469f46fb480805377626b4
2014-10-02 14:48:51 +01:00