Commit Graph

1178 Commits

Author SHA1 Message Date
9c9831f79c usage info: Checkbox to turn it on and off (Tools -> Options... -> General).
Change-Id: I67143e604314f5553026c369bbed3fdd683c39a6
2014-10-16 10:58:06 +02:00
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:52 +00:00
cb7ede2d99 convert vcl StateChangedType to enum class
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:32 +00:00
8d1749430f Fix build.
Change-Id: I9676e38029c511678efed1679f9488f1f15f4f8d
2014-10-08 11:33:06 +02:00
5a890f4a2c usage info: Improve the 'what is this for' comment.
Change-Id: If423bd3fde53695be33a4f890f7d363ccce8dbf0
2014-10-08 11:09:37 +02:00
35da89fa14 usage info: Code to collect actions that the user performs.
Handles the .uno: and .slot: commands.  Cannot load / save the info yet, only
dumps it to the screen at the application exit.

Disabled in the code now, needs a configuration option.

Change-Id: I4e689f534fe5c8a5af84df472e47f276fb7af89b
2014-10-08 11:00:53 +02:00
01fbbf4268 coverity#1242921 Result is not floating-point
Change-Id: Iaeb1d6074fa7c9f66810cee563be0850ccc1d769
2014-10-02 14:48:49 +01:00
26cb920cf0 fix for older compiler, doesn't like <::
Change-Id: I2d05af506ae38ec3e61c9b6afaf2b39521067005
2014-10-02 08:39:38 +02:00
039b887c54 loplugin: cstylecast
Change-Id: I4a230f45e91773fca7d537e91c9e9fb54773cf10
2014-10-02 07:37:20 +02:00
af046d12d2 fdo#75757: remove inheritance to std::map
from SfxItemPtrMap.

Change-Id: Id7e9667f9b918afaf92d9e71bf0e2c2e9c296474
Reviewed-on: https://gerrit.libreoffice.org/11696
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-01 20:04:44 +00:00
cfd1310bef fdo#75757: remove inheritance to std::vector
from SfxVerbSlotArr_Impl.

Change-Id: I84582f10095638a0fef82aa46f721d57a8b27c27
Reviewed-on: https://gerrit.libreoffice.org/11662
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-28 17:45:04 +00:00
b75b473e2c fdo#75757: remove inheritance to std::vector
from SfxFoundCacheArr_Impl, by typedef'ing it as
boost::ptr_vector<SfxFoundCache_Impl>.

Change-Id: Id0e50370b440fb53dbb56dabca9743b27a08b90d
Reviewed-on: https://gerrit.libreoffice.org/11650
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-26 08:20:19 +00:00
5911154175 Start Center Template Manager Tweaks
Template Manager and the related Start Center view has same
transparent highlight color as Recent Documents. Also Template
thumbnail containers should have the same size as Recent Docs view.

Change-Id: I22e417a5c5ca5a849577d5a438a193371368fe24
Reviewed-on: https://gerrit.libreoffice.org/11467
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25 12:28:41 +00:00
456fb84511 Fix miscellaneous memory leaks
thumbnailview.cxx: ::ImplInitSettings is called from various
places other than the constructor, so mpItemAttrs must be
freed each time
gloactiongroup.cxx: Must call g_list_free on list returned by
g_hash_table_get_keys

Change-Id: Id5a592520987a1596debdbc48bfa171a537e400b
Reviewed-on: https://gerrit.libreoffice.org/11638
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25 12:16:06 +00:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
3ddae219e4 remove unused fields pName and pMethodName in SfxSlot class
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-22 07:29:17 +02:00
764e3016b6 fdo#84086 Fix assorted use-after-free bugs
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65
Reviewed-on: https://gerrit.libreoffice.org/11553
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-22 05:15:53 +00:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-12 06:08:32 +00:00
ed00d0ddd6 create a master document template type
of application/vnd.oasis.opendocument.text-master-template with
suffic otm

https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html

desktop/icons/oasis-master-document-template.icns is just a copy
of
desktop/icons/oasis-master-document.icns
because I can't draw

Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1
Reviewed-on: https://gerrit.libreoffice.org/11350
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-11 09:38:21 +00:00
39e91c585d Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULT
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-09-10 16:37:20 +02:00
047d2f953a Doxygenize comments, and move them in front of the functions.
Change-Id: I03723d1078b7ba726c8cc94887ca854324e3f9d8
2014-09-09 06:58:27 +02:00
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:47:44 -05:00
f6c0803e99 itemdel.[ch]xx is only used in sfx2
Change-Id: I240f15f87e27ba8a52bab244f8c784d527bff179
2014-08-26 13:34:04 +02:00
fe9f8144c7 move method documentation to the header file
Change-Id: I7d4f77c50a8b6b2b0d7c0868c73b0cb13f952421
2014-08-26 13:34:03 +02:00
9970fb3cec remove whitespace and put comment before method
Change-Id: Ia3f22787a07628b1b531c61f21d345def5f6e99d
2014-08-26 13:34:03 +02:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
2ccfaafb3e warning C4245: '=' : conversion from 'int' to 'sal_uInt32'...
...signed/unsigned mismatch

Change-Id: I852ddf97dd1749e409baf74d9af72ec459f574ee
2014-08-13 10:10:48 +02:00
b866f86191 qsort and bsearch need different kinds of callback functions
Change-Id: I4a661434c3a51169ec14336bb39a1d2ceeb139ad
2014-08-08 17:43:01 +02:00
2568a0bb72 hidpi, startcenter: Don't set fixed font heigt in the startcenter.
Change-Id: I68efbd08d21b514ab1659cd6bddfc2c4788c4a74
2014-08-01 15:25:02 +02:00
3108a3dd38 sfx2: remove another DBG macro that arose from the grave
The callers in dispatch.cxx use methods that were removed by commit
a1ce4fb4f0dbc3c4141f510e5b2b732a24d862c8 - not sure if this warning is
useful or not.

Change-Id: I8bb654de8e26c054318dd2037055a85d013c8bfa
2014-07-24 14:11:40 +02:00
88a874fcb3 convert SfxItemState constants to a proper enum
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
8416a65af1 fix spelling structur -> structure
Change-Id: I7aa4a9bf72732db95a67cee368f3a83a0d71bb9c
2014-07-17 14:49:41 +02:00
50a402b3c2 coverity#708816 Unused pointer value
Change-Id: I2ea7d4a8b142d67afa43ce165b51d81f65d251de
2014-07-03 12:49:40 +01:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
0de1e3a015 remove spurious com::sun::chaos
Apparently some time before inital CVS import a global
search-and-replace went horribly wrong and added spurious namespace
prefixes everywhere.

Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
2014-06-25 15:04:46 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7c2f000085 loplugin:staticcall
Change-Id: Ie5e9e21f4c592c58094afc954f1de54512719fd5
2014-06-13 17:54:32 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
2484cda486 coverity#1000658 Missing break in switch, assuming its intentional
Change-Id: Id208942e98c8b8fc685aa77c3c11468ed2af832d
2014-06-05 13:35:53 +01:00
cc93bcf751 coverity#982646 Missing break in switch
Change-Id: I83cdafe9a27f026e2b6c8e9153de9e8270304686
2014-06-04 12:34:16 +01:00
da6df38b41 Related: fdo#79392 std::out_or_range -> terminate
Change-Id: I0aada90e9ea4e9fc92fd9c365aa9c7171cb10a55
2014-05-29 11:02:46 +01:00
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
435c1b15dc fdo#78782 startcenter: open document on enter key
Change-Id: I501dbd6a0f4e5323a003afbb19707aad67897cd0
2014-05-17 21:56:17 +03:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
0c53ccd11f Fix warning
Change-Id: I90187024bc599f66bb99295ed342e106080adeb7
2014-05-14 22:58:16 +03:00
ed1d0f0c45 fix build
Change-Id: I40b7f9388388e05ab5b034ac81861aa34a23d2a8
2014-05-14 22:46:33 +03:00
f22d651487 startcenter: another attempt to fix mouse up issues
see commits
1a2a961c1e7cdef648c28e211433e8de6e8a831b
4a902e0c59b0dd01e6459c226268bdee4f15489a

Change-Id: I94b90dfc5db779317d4dda1171aeceeac6373548
2014-05-14 22:32:19 +03:00