Commit Graph

819 Commits

Author SHA1 Message Date
c9d4a2887c fdo#82577: Handle PolyPolygon
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26 15:26:48 +02:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
d49d0139a7 callcatcher: update unused code
Change-Id: I2ddda0600ee876e9886ee3221f0ac5ad515fbd22
2014-09-17 09:55:42 +01:00
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-12 06:08:32 +00:00
da44e4cce8 Use size_t consistently, constify, reduce scope
Change-Id: Ie5de70645becc5ac584f1b3ffe6048969d2a19a9
2014-09-06 12:08:13 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
535971f3a1 Refactored IDocumentStylePoolAccess out of SwDoc.
Added non const SwDoc::GetDfltTxtFmtColl and SwDoc::GetTxtFmtColls
and SwDoc::GetCharFmts.
Had to make the manager friend of SwTxtFmtColl and SwConditionTxtFmtColl
Had to make SwDoc::_MakeCharFmt and SwDoc::_MakeFrmFmt public.

Change-Id: I19a36d91f92b3781a6c4313ec12eb8f7d4dfacc3
2014-08-12 23:26:38 +02:00
64e13a1456 Refactored IDocumentState out of SwDoc.
Into the new class DocumentStateManager.

Change-Id: I91c9097b091ff6118d58fd15fff2a4cefe0171fd
2014-08-12 23:26:38 +02:00
9cc617afcd Refactored IDocumentStatistics our of SwDoc.
Into the new class DocumentStatisticsManager.

Change-Id: I281232dc09dbd79c2faf3c2a78ae49625bbe88ee
2014-08-12 23:26:37 +02:00
69e5f335ab Refactored IDocumentFieldsAccess out of SwDoc.
Into the new class DocumentFieldsManager.
Removed SwDoc::_MakeFldList because it is not defined anywhere.
Also moved a few non interface methods that belong to the manager.

Change-Id: Icefd7ca7adcbb05a18d6fae0529fc54150b862fd
2014-08-12 23:26:36 +02:00
274f1811b9 Refactored IDocumentRedlineAccess out of SwDoc.
Into the new class DocumentRedlineManager.
Added an non const version of GetRedlineTbl to the interface.
Also Moved SetAutoFmtRedlineComment which is not part of interface.

Change-Id: I600d5821d5d5831557f5fc5375fb1203fe67a295
2014-08-12 23:26:36 +02:00
05dda9a913 SwpHintsArray/SwpHints and related: sal_uInt16 to size_t
Change-Id: I9a7674109b05683287e12cbce6bc417b40ca5084
2014-07-22 23:50:42 +02:00
f634ec520f Refactored IDocumentContentOperations out of SwDoc.
Into the new class DocumentContentOperationsManager.

Made SwNodes in sw/inc/ndarr.hxx friend class to
DocumentContentOperationsManager so it can call DelNodes at end of
DocumentContentOperationsManager::DeleteSection .

Added DeleteAutoCorrExceptWord to SwDoc, its needed in the Manager.

Added a non const version of SwDoc::GetDfltGrfFmtColl() to SwDoc
because its needed in the Manager.

Made SwDoc a friend class to DocumentContentOperationsManager so it
can call SwDoc::checkRedlining and SwDocL::_MakeFlySection.

Moved SwDoc::CopyImpl_ , SwDoc::CopyWithFlyInFly and
SwDoc::CopyFlyInFlyImpl into the Manager.

Moved "struct ParaRstFmt" and "lcl_RstTxtAttr" from docfmt.cxx
in DocumentContentOperationsManager.hxx .

Change-Id: Icaab57f4a8c158a85e549ecb4aacc752bc95bbc9
2014-07-15 15:44:04 +02:00
54ca3a6efa Refactored IDocumentLinksAdministration out of SwDoc.
To the new class DocumentLinksAdministrationManager.
Additional to the Interface methods SwDoc::SelectServerObj was also moved
and sw/source/core/doc/docdde.cxx was deleted as it became empty.
Also fixed OUString usage in IDocumentLinksAdministration.hxx .

Change-Id: I1f2bf0881a7d4add9c657b6441851ae14ad8d161
2014-07-15 15:44:03 +02:00
c88a3d3e8c Refactored IDocumentChartDataProviderAccess in SwDoc.
Into the new class DocumentChartDataProviderManager.

Change-Id: I3be038ba276642546223c0c2fba3bea21980b33d
2014-07-15 15:44:02 +02:00
82f291d2f7 Resolves fdo#79276 Add fallback system for autocorrection of French variants
1) Replace the creation of acor_fr-FR.dat by acor_fr.dat since there's no specific for variants of fr
2) Add a fallback system to use it

Change-Id: Ia3e11fff0f266839dc148077b50c1b2f798d1c50
Reviewed-on: https://gerrit.libreoffice.org/9825
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-03 12:43:28 +00:00
b733d208b0 Related: #i78498# Do not keep OutlineLevel attribute at paragraph...
when a Paragraph Style is assigned.

(cherry picked from commit 6a1564284d90c7e175f7848520924f7f6a5884b7)
(cherry picked from commit 4a381b1124f60b76cabb558fa24827448a1caab0)

Conflicts:
	sw/inc/doc.hxx
	sw/inc/editsh.hxx
	sw/inc/fmtcol.hxx
	sw/inc/ndtxt.hxx
	sw/source/core/attr/format.cxx
	sw/source/core/doc/docfmt.cxx
	sw/source/core/doc/docglbl.cxx
	sw/source/core/doc/doctxm.cxx
	sw/source/core/doc/fmtcol.cxx
	sw/source/core/edit/edfcol.cxx
	sw/source/core/txtnode/ndtxt.cxx
	sw/source/core/undo/unfmco.cxx
	sw/source/core/unocore/unosett.cxx
	sw/source/core/unocore/unostyle.cxx

Change-Id: Ifa1214876df296f2e1210cc4a35f2df67f9f6bc4
2014-06-27 17:22:09 +01:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
4161070eb2 Removed IDocumentSettingAccess.hxx include in SwDoc.hxx
Because it is not needed there anymore with IDocumentSettingManager.

Change-Id: Iad5e0a03f2628c9d26698d23e691b3e6228eee0b
2014-06-03 19:12:02 +02:00
6f77ce5870 Removed DocumentSettingManager methods from SwDoc.
And moved all calls to those methods to GetDocumentSettingManager().

Change-Id: I9b6cc8c3aa9b57bbc0c39f39499dfb4f5f254ad9
2014-06-03 19:12:02 +02:00
0a3fe4c281 Remove ASCII art and useless comments from sw module
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2
Reviewed-on: https://gerrit.libreoffice.org/9494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:46:44 -05:00
78b9537b6a various: sal_Bool->bool
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-08 11:48:14 +02:00
45cb8e3d1e sw: hypothetical crashes if last node is not SwTxtNode
Change-Id: I16c476ae83d01ea23891af36fd4bcca4e8992228
2014-05-03 00:49:14 +02:00
af10cb2c9c Rename SwDBMgr -> SwDBManager.
We were renaming it recently from SwNewDBMgr, let's use the full name to make
it more readable.

Change-Id: I2ceb3f1790321b70d5936c35e13870439969e64d
2014-05-02 21:32:23 +02:00
6aa35db393 sw: sal_Bool->bool
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-30 08:44:42 +02:00
4a60f9387d allow accepting/rejecting changes in a selection (bnc#874790)
Adds 'Accept Changes'/'Reject Changes' to the RMB popup if appropriate,
more convenient than handling them one by one.

Change-Id: I4e2670aa9fdacaaaa1b7ecca36b9c150c82e2e72
2014-04-28 19:21:02 +02:00
043bbbf198 There is nothing "new" with SwNewDBMgr any more
Change-Id: Icbf3d5663a358bf31b58ab8086ffe9160c26bf8f
2014-04-22 10:06:41 +03:00
e152235827 More hacking on --disable-database-connectivity
Work in progress, still lots of undefineds when attempting to link
TiledLibreOffice.

Change-Id: I80fa330768d9f9fa9ef65e3693f1d777c0713210
2014-04-22 09:43:44 +03:00
b166e7af2b There is nothing "new" with SwNewDBMgr any more
Change-Id: I28c48be099ba680a5d6ea91981a1e1bfadff3f84
2014-04-22 08:07:17 +03:00
71e71d4b5a coverity#1202830 Out-of-bounds access
Change-Id: I25edea176b69c1c1f87bdbff790a39298a813660
2014-04-18 12:21:43 +01:00
2afe4c170d Clean up function declarations and some unused functions
Change-Id: I58c425ab9d2c01f8844226aff820dd56d88ec09c
2014-04-15 13:56:21 +02:00
788c433a4a coverity#708418 Uninitialized scalar field
Change-Id: Id33b99cbad88eea79a7ac75d8d99ffcc71d4f7b4
2014-04-10 21:07:57 +01:00
f4175a127f coverity#704354 Logically dead code
also coverity#704355 and coverity#704356

Change-Id: I132b9881792fcc4bac59d8227141e53dda7ee725
2014-03-29 18:12:07 +00:00
38e4ef50d4 Related: fdo#73936 for spelling restrict formelements-as-fields..
to dropdowns to be on the safe side for now anyway.

Change-Id: I88a73fe37b39306c6b24226e3b02c702d992ecb0
2014-03-28 08:57:49 +00:00
c76b8783e2 Related: fdo#73936 detect dropdown form fields as fields for spellchecking
so they will appear grayed in the spell check preview (they don't appear
at all yet, they will in later commits)

Change-Id: Ic0c6fe2979c7c731d0efb85c747afca2268abc53
2014-03-28 08:57:46 +00:00
04187aaf09 Resolves: #i124371# When changing the numbering or bullet styling...
of a set of paragraph which have more than one different List Style applied
create a new List Style and put the paragraphs into a new list.

(cherry picked from commit 0087ca89e3905009ed947c651f3dc70f3d61ea93)

Conflicts:
	sw/inc/doc.hxx
	sw/inc/docsh.hxx
	sw/inc/editsh.hxx
	sw/source/core/doc/docnum.cxx
	sw/source/core/docnode/ndcopy.cxx
	sw/source/core/edit/autofmt.cxx
	sw/source/core/edit/ednumber.cxx
	sw/source/core/uibase/app/docst.cxx
	sw/source/core/uibase/docvw/edtwin.cxx
	sw/source/core/uibase/inc/textsh.hxx
	sw/source/core/uibase/shells/listsh.cxx
	sw/source/core/uibase/shells/textsh1.cxx
	sw/source/core/uibase/shells/txtnum.cxx
	sw/source/core/uibase/uiview/formatclipboard.cxx
	sw/source/core/uibase/uiview/view2.cxx
	sw/source/core/uibase/wrtsh/wrtsh1.cxx
	sw/source/core/undo/unnum.cxx
	sw/source/core/unocore/unocrsrhelper.cxx
	sw/source/filter/ww1/fltshell.cxx
	sw/source/ui/misc/num.cxx

Change-Id: Iadb5b386cada296d90d96aa75574024baac7ae3e
2014-03-19 15:34:18 +00:00
769a6c20c4 sw: prefer passing OUString by reference
Change-Id: Iaa846ec8f19567f0a9f30154d74cc53df93eff16
2014-03-17 13:30:51 +02:00
2e26e6fd91 sal_Bool to bool
Change-Id: I3548bdc15cf779495a966b4b36bb6d209fd3ee8f
2014-03-16 09:39:14 +01:00
58f0208479 sal_Bool to bool and minor optimizations
Change-Id: I48f53fe40a1732081ed3797d9f8fdf4a0ea81176
2014-03-16 09:38:02 +01:00
8578aabbc4 "prefix" and "postfix" are single words
Change-Id: I32824c614d070cd4649e18da4a0b91b03bccfaba
2014-03-14 07:57:18 +02:00
f9b62506b2 fdo#75110 SwEditShell::DeleteSel fix start of selection when bSelAll == true
Change-Id: I3e8ce585b29619061b18ab1ab8f0cf6c7d421074
2014-03-12 18:11:40 +01:00
3ae74fb26d coverity#1103650 Unchecked return value
Change-Id: I8c674269174a9e17d2195d1014f67aa7a81ba138
2014-03-10 11:36:25 +00:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
c94f12a389 nOrigTxtStt is never read
Change-Id: I9ace298d66aaaa46cecdeacfc633144715535e50
2014-03-02 20:18:03 +01:00
d0feb9d89d Rework SwAutoFormat::IsBlanksInString
The old code was convoluted and suffered the following issues:
* Relied on OUStrings being zero-terminated, which is not granted
* Systematically missed the end of string, accessing unrelated
  memory, in case there was just a single trailing space

Change-Id: I98dd0f94a8f48f40c467a02dfd01c7866266d9d4
2014-03-02 20:18:02 +01:00
e9ac4088d9 Avoid consecutive OUString appends and a temporary
Change-Id: Iee8998a4947a253f869fefb7bde316e3d3b4129b
2014-03-02 20:18:02 +01:00
0ea119318a Use mutable instead of casting this
Change-Id: Ifdf6334af72637b1c18a9ea2bd2be317d5ae8b20
2014-03-02 20:17:59 +01:00
22aea93d50 Related: #i123480# assure correct Undo/Redo with not shown tracked changes
(cherry picked from commit e8613c7e3b76a83d804d28199fdeacc6369569c6)

Conflicts:
	sw/source/core/doc/docedt.cxx
	sw/source/core/undo/undobj.cxx
	sw/source/core/undo/unredln.cxx

Change-Id: I45c25aa957995109b202e2130e5344b1bbb09669
2014-02-28 11:38:30 +00:00