03c7c26cbe
java: final fields that can be static
...
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
fa22664be2
java: always use braces for while loops
...
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16 08:15:52 +02:00
973eb2f6db
java: reduce the depth of some deeply nested if blocks
...
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-16 08:15:48 +02:00
d0be30e8ee
java: Collections.addAll for adding an array of elements to a Collection
...
Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09
Reviewed-on: https://gerrit.libreoffice.org/11953
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-13 15:18:56 +00:00
3c27e31628
accessibility: ensure that the stream is cleaned up before the method returns
...
Change-Id: Ib46d24be831b5c9bda0582bd7064f34528e1d609
Reviewed-on: https://gerrit.libreoffice.org/11938
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-13 06:55:53 +00:00
581234b213
accessibility: Calling String.toString()
...
Change-Id: I125d2c337df606c6388ddbd41030e51a558ad054
Reviewed-on: https://gerrit.libreoffice.org/11920
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 23:49:44 +00:00
d802b6d242
unchecked call to getDeclaredMethod(String,Class<?>...)
...
http://docs.oracle.com/javase/tutorial/reflect/class/classTrouble.html
Change-Id: I293e7ad3ace1a8876c34d7ffd070b49807a8b0a6
Reviewed-on: https://gerrit.libreoffice.org/11882
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-10 06:19:42 +00:00
14cccfab81
As of JDK version 1.5, show() and hide() in Dialog have been deprecated
...
Change-Id: If96e40ebe2c59f31ca4e2b81c6583eb7f8d5ec81
Reviewed-on: https://gerrit.libreoffice.org/11873
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-09 11:37:52 +00:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
22248b89c0
complex: Use 'import com.sun.star.beans.UnknownPropertyException;'
...
Change-Id: Ib42baf6f18fd407a879313c042efd74c8f724aa4
Reviewed-on: https://gerrit.libreoffice.org/11864
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-10-08 20:30:03 +00:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
fbf3aa391b
spelling: instanciated -> instantiated
...
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-08 11:02:55 +02:00
68fa141097
java: use isEmpty() instead of "size() == 0"
...
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07 13:20:03 +02:00
04ace01ec5
java: remove unnecessary adding of empty strings
...
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-10-07 13:20:01 +02:00
610f3388c7
java: no need to check for null before calling instanceof
...
the instanceof check returns false when passed a null value
Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
2014-10-07 13:20:00 +02:00
ad5e8b30ac
fix for invalid dynamic_cast
...
after my loplugin-cstylecast commits.
this is a follow on to the bug reported in fdo#84608
Change-Id: Icc4f4baf3690e939c07a71a949200270bf1f4614
2014-10-04 20:13:07 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
c9d4a2887c
fdo#82577: Handle PolyPolygon
...
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.
Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
8dbde0845a
fdo#82577: Handle Region
...
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.
Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
1467751fd8
toolkit: std::auto_ptr -> std::unique_ptr
...
Change-Id: I4566a0b7215b729f04591bed0ad5bed42f71f227
2014-09-29 18:37:50 +02:00
00bd457156
loplugin: cstylecast
...
Change-Id: I20358c271e32b4af11d3258c950bde836596933a
2014-09-29 12:50:36 +02:00
d46b16e1e4
remove unnecessary casts's
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26 15:25:40 +02:00
c91dec0dad
comphelper: std::auto_ptr -> std::unique_ptr
...
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-25 08:40:11 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
69ac0fa53b
toolkit: sal_Bool -> bool
...
Change-Id: I8819d408e8556bbf38605c2feef2fa87d8dd41c3
2014-09-12 10:04:59 +02:00
037d03b9fa
Typo: (N|n)ormaly->(N|n)ormally
...
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10 22:35:39 +02:00
7af850c896
vcl: sal_Bool -> bool
...
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-10 08:36:06 +02:00
cc5eb804fc
toolkit: use String.length()==0 instead of String.equals(empty string)
...
Change-Id: Id38f28e7138460493fde982cc1ebc75c3cb0b386
Reviewed-on: https://gerrit.libreoffice.org/11365
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-09-09 18:39:44 +00:00
91853c8264
toolkit: fix javadoc errors
...
Change-Id: I6d2268786d22f967be2d5e0dbcda14a074af4475
Reviewed-on: https://gerrit.libreoffice.org/11248
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-09-02 02:08:40 -05:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
7e2b9fa213
Remove some useless tools/debug.hxx includes
...
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
2014-08-22 16:33:18 -05:00
c0415d5f1e
java: remove unnecessary constructor declarations
...
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
34352e7f1b
fix exception not caught
...
Change-Id: Idf1942d76f3c13e207f2e54494557ee01013c833
2014-08-20 11:45:28 +02:00
ccbb51ad96
use correct loop index variable
...
Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37
2014-08-20 10:35:52 +02:00
619dc5d4c8
remove some dead Java code
...
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20 10:35:52 +02:00
252ed1708a
double-checked locking is not thread-safe in Java
...
found by PMD
Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-20 10:35:51 +02:00
4b4bff3402
java: no need to instantiate String objects directly
...
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
ff0ad0493e
java: use 'Integer.valueOf' instead of 'new Integer'
...
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc
java: use Boolean.valueOf instead of instantiating Boolean objects
...
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc
java: classes in java.lang package do not need to be fully qualified
...
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
3a8d351988
java: remove unused methods
...
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
cc4f4e2054
catch UnknownPropertyException
...
Change-Id: I3134c574a124a2359c40b139eb5b41198b0e4611
2014-08-17 19:20:55 +01:00
0d916bb240
java: remove unused imports
...
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5
java: remove commented out code
...
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
34bcf9b498
java: remove dead methods
...
found by UCDetector
Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
68cd011c90
java: reduce scope, make some methods private
...
found by UCDetector
Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f
java: reduce scope, make member classes private
...
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
