751570534f
coverity#1247636 Uncaught exception
...
Change-Id: If9d635b7345683da0bf6ef7c7b0ffba0450f5dbd
2014-10-17 15:19:41 +01:00
03c7c26cbe
java: final fields that can be static
...
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
f6047410e1
coverity#983990 Uncaught exception
...
Change-Id: I78c58822cc92c8964e0b69f44d841c5cdb84b1bb
2014-10-11 17:33:50 +01:00
7e3a84d170
coverity#1130163 Unchecked return value
...
Change-Id: Iffc4ba146ac8f851239e93a1ace53c6b34234824
2014-10-11 17:33:49 +01:00
430e19e4f9
coverity#1241375 Uncaught exception
...
and
coverity#1241356 Uncaught exception
coverity#1241415 Uncaught exception
coverity#1241449 Uncaught exception
coverity#1241146 Uncaught exception
coverity#1241169 Uncaught exception
coverity#1241408 Uncaught exception
coverity#1241452 Uncaught exception
coverity#1241443 Uncaught exception
coverity#1241236 Uncaught exception
coverity#1241157 Uncaught exception
coverity#1241283 Uncaught exception
coverity#1241409 Uncaught exception
coverity#1241229 Uncaught exception
coverity#1241387 Uncaught exception
coverity#1241050 Uncaught exception
coverity#1241371 Uncaught exception
coverity#1241048 Uncaught exception
coverity#1241112 Uncaught exception
coverity#1241351 Uncaught exception
coverity#1241370 Uncaught exception
coverity#1241329 Uncaught exception
coverity#1241162 Uncaught exception
coverity#1241103 Uncaught exception
coverity#1241342 Uncaught exception
coverity#1241271 Uncaught exception
coverity#1241219 Uncaught exception
coverity#1241245 Uncaught exception
Change-Id: I3418bb54b5c385110201a99a339eba0d0d3048f5
2014-10-10 18:14:35 +01:00
fbf3aa391b
spelling: instanciated -> instantiated
...
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-08 11:02:55 +02:00
3b59dbbffd
remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro
...
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html
Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02 20:00:18 +02:00
86cd29772e
remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
...
This has been supported by GCC and clang for a very long time.
Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
1eb35713bc
Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP
...
...from times when code used std::auto_ptr.
Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01 18:48:14 +02:00
ee8e81ad86
ucb: std::auto_ptr -> std::unique_ptr
...
Change-Id: I779b7a172cecd927f7d18fcbbc0f898f18089d0a
2014-10-01 17:35:13 +02:00
b0f43c629b
Fix warnings in ucb/source/ucp/webdav/ (--with-webdav=serf)
...
Change-Id: I6e45a8b00952dc3ef54f29536cf333bfdcee787d
2014-10-01 17:35:12 +02:00
15b45dacbc
Tired of seing changes made to effectively dead workben code
...
Change-Id: I437fdceedac57bbeea7fd2a5fb7098bb71e0b259
2014-10-01 17:35:12 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
0ecf6afbd1
loplugin: cstylecast
...
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-29 12:50:35 +02:00
be7a99bca7
coverity#1240266 Logically dead code
...
Change-Id: I97256c687c6d56beef2c3664bbba8c43f685228b
2014-09-25 11:36:34 +01:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
32d6415617
fdo#83512 Make use of OUStringHash and OStringHash
...
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-09-18 13:12:48 +02:00
007864407b
ucb: prevent out of bound access in OUString
...
Change-Id: I451bf13cbf39ec13152d083a6a6728cd043f9fbd
2014-09-12 01:45:29 +02:00
8d2818ff98
ucb: sal_Bool -> bool
...
Change-Id: I333ffa13159eac5cc53c9f3985dde5a33daf8067
2014-09-11 17:08:12 +02:00
db9cfa672c
fdo#55380 replaced use of obsolete interfaces
...
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef
Reviewed-on: https://gerrit.libreoffice.org/11256
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-09-10 11:48:43 +00:00
a6e28fe9c6
Fix *_component_getFactory function type
...
Change-Id: I6b7a9e15da83f1d53a5e59d26b643c363e652619
2014-08-28 18:07:53 +02:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
0764292c5d
java: use 'Short.valueOf' instead of 'new Short'
...
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
ff0ad0493e
java: use 'Integer.valueOf' instead of 'new Integer'
...
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
56ef5533fc
java: classes in java.lang package do not need to be fully qualified
...
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
0d916bb240
java: remove unused imports
...
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5
java: remove commented out code
...
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
4155c28ae1
java: remove unused interfaces
...
found by UCDetector
Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
2014-08-13 09:44:17 +02:00
8583da1e93
java: remove unused fields
...
found by UCDetector
Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
70f56bc22f
java: reduce scope, make member classes private
...
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59
java: reduce scope, make fields private
...
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
1c496506bc
java: remove useless javadoc tags
...
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b
java: add @Override annotation to overriding methods
...
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
e5bc8b60ec
java: variable cannot be null
...
remove null check where null-analyis reveals the variable cannot be null
Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
2014-08-08 09:48:19 +02:00
b58c053fed
java: remove unnecessary semi-colons
...
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08 09:48:18 +02:00
2d700944b5
java: remove unused imports
...
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
8d6cf7a147
java: remove dead methods
...
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
0c5f51ebbc
java: remove commented out code
...
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05
java: remove unused fields
...
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
f493555623
java: remove some casting in lib.TestParameters#getMSF
...
where the return value is always cast to XMultiServiceFactory,
so just do the cast in the method and avoid noise at the call sites.
Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-08-04 13:38:30 +02:00
0a7b80a02e
fix spelling compilant -> compliant
...
Change-Id: I5a469226a576906f0dd860c008d2e3fab1659ff7
2014-08-04 13:38:29 +02:00
a227c575bb
Linked the sax library to CMIS
...
This is needed for the use of DateTime converter. I forgot to add the makefile
when I commited this patch: https://gerrit.libreoffice.org/#/c/10586/
Change-Id: I7cb9ab40fab549a95beb6818ab4ad4befdd3dea1
2014-07-28 12:48:35 +03:00
fb6e0da4d8
UNO to CMIS properties conversion fix
...
The initial code always extracted Strings from the UNO instead of extracting
the same data type that was written into it. This patch extracts the
properties according to their data type and formats them to be reconstructed
into CMIS properties.
Change-Id: Ib160020e9d923a46e2c4f90924da847f2dac5e7a
Reviewed-on: https://gerrit.libreoffice.org/10586
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
2014-07-28 09:03:17 +00:00
a8b395bff2
Avoid possible memory leaks in case of exceptions
...
Change-Id: I9983e858c4e634b4cac8ad42fa9b06b7ccc167d6
2014-07-25 10:09:15 +09:00
89361fa68a
fdo#72277: don't build and use nsspem when building against system curl
...
System CURL will know how to get the CA bundle from the system openSSL.
There is no need to have internal NSS CA database support.
Change-Id: Ie5074c78f7d78b2c2f452d4d4e11c98222529883
2014-07-17 10:39:35 +02:00
165075e0d7
fdo#72277: Use NSS CACERT in cmis ucp with internal curl
...
This fix contains two parts:
* initialize NSS in the CMIS UCP right before sending an HTTP request
in case internal curl is used. This makes internal curl find the NSS
CACERT database from the user mozilla profile.
* add nsspem to allow curl to use CACERTs from libnssckbi. Without
libnsspem curl is unable to read the certificates from the NSS
database. The nss-pem code has been extracted from the fedora-hosted
repository: https://git.fedorahosted.org/cgit/nss-pem.git
Change-Id: Ie8dedf020480cca01bf9761382886566a1150778
2014-07-15 11:15:45 +02:00
89df4412dc
webdav: Do not return reference here.
...
This was missing in e07cefb4f7ba39d59d25815e208ed61269079142.
Change-Id: I1c9a3f88981ee67d9d5748f9e43eed1237422fb1
2014-07-11 12:55:31 +02:00
9da4e46957
webdav: fix locking in webdav_ucp::Content::getResourceType()
...
This commit cherry-picks 49a454225e35699d7351faaba3d296e1858c6107
for serf webdav version.
Change-Id: Ic5aba4fba8f8a2a521224b08865500dd932e85bf
2014-07-08 09:14:57 +02:00
b807a02850
InteractionSupplyName is a detail of SimpleNameClashResolveRequest
...
Change-Id: Iecc77b1c4749bd14ce79f1a7f3e98f45fa3abbba
2014-07-02 14:56:53 +02:00
