b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
2ff57a77d8
coverity#738611 Uninitialized scalar field
...
Change-Id: Ib80c34fa3f6e6cbfc14cc4fa97afec24228c382d
2014-02-21 12:40:31 +00:00
b9179d8798
coverity#738612 Uninitialized scalar field
...
Change-Id: I6d2ffdfe3a4e70c6588988be9026e28411ee273a
2014-02-21 12:40:30 +00:00
e0e370a13d
cid#707727 Uninitialized pointer field
...
resolved by removing the field, since it is unused
Change-Id: Ia543877ee645023bf6e1ee3c4f396cb082517f82
2014-02-21 11:59:06 +02:00
c92753e395
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: Iafdebacd43ed24a30fb8e2d041fe975a1adbcfa0
2014-02-20 11:25:30 +09:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
c2b50457ef
coverity#707725 : Uninitialized scalar field
...
Change-Id: Ia5ebaca5bbb35946250854abf78ab9ab2041757f
2014-02-01 15:29:58 -06:00
9cc60839f3
bool improvements
...
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
2014-01-28 20:26:29 +01:00
d786af6820
coverity#705141 Missing break in switch
...
Change-Id: I9b94f1056fa62b2c0c609f6d448e1750bb0e9ce5
2014-01-28 15:19:33 +00:00
eab105e943
coverity#705140 Missing break in switch
...
Change-Id: I1b08e9afda2eeb3c4c79154376f34cad3e1f0a4c
2014-01-28 14:30:44 +00:00
5b2ba8ed5d
DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Conflicts:
dbaccess/source/ui/dlg/tablespage.cxx
Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:20:10 +00:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
2ac31b06ae
Unnecessary use of OUString constructor inside OUStringBuffer constructor
...
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
2042665c6d
fdo#72696 set parameters when they have changed
...
Change-Id: Id470f98456200ed51418e31904e8a9a457fda638
2013-12-16 04:17:33 +01:00
dd0990db74
fdo#72463 RowSet: on execute when not dirty, rebuild cache
...
Change-Id: I3f27b7572b88cd1200483121614c29d414c37e20
2013-12-12 20:19:06 +01:00
afd32065b6
fdo#54938: Convert dbaccess to use cppu::supportsService
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
Conflicts:
dbaccess/source/core/dataaccess/connection.hxx
Change-Id: Id7602b969790b13538868b937842bc945ce3e31e
2013-12-10 08:33:25 +01:00
c5b7a5fd19
fix equalsAscii conversion. Noticed in fdo#72391
...
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-09 12:53:18 +02:00
b0926378ac
Clean up includes of comphelper/stl_types.hxx
...
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
f51877b147
Combine comphelper::UStringMixEqual, comphelper::TStringMixEqualFunctor
...
Change-Id: I3ab3777a65fd68f8cbaf17a8e2a989dc4ad7b1cc
2013-12-06 14:28:37 +01:00
1a715d4d67
Get rid of DECLARE_STL_STDKEY_MAP
...
Change-Id: I099f94922acba0bf9cde22fbbb3eefc230776868
2013-12-06 10:37:50 +01:00
4a8175ebeb
Get rid of DECLARE_STL_USTRINGACCESS_MAP
...
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
56d4f4b7b9
fdo#70144 Don't reset Document's modified flag when inserting new table.
...
It is unclear why the modified flag should ever be blindly overwritten hence
we no longer touch the modified flag here. (This change appears to have no
undesired side-effects.)
Change-Id: I246eb7d84249794fa4d52fcd9b008d8340bbc82d
Reviewed-on: https://gerrit.libreoffice.org/6632
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2013-12-04 07:53:35 -06:00
56cdaa1869
fdo#72163 belts and suspenders
...
1) Do not dispose m_xComposer, might still be used by our m_pCache
2) Do not create a new m_xComposer if the previous one will do, so
that we do not gratiously use a different one than our m_pCache.
Change-Id: I6540c035c9159017c694b36e676721ec3e42db51
2013-12-02 23:57:16 +01:00
d4b7e3d12a
fdo#72163 after updating m_xComposer, command facets are not dirty anymore
...
Else we dispose m_xComposer too eagerly; still used by m_pCacheSet.
Change-Id: I205488465c19a356534df17b8a5e9a20ce6766c9
2013-12-02 23:57:15 +01:00
071c3f3e93
remove unnecessary use of OUString constructor in equalsIgnoreAsciiCase
...
Convert code like:
sType.equalsIgnoreAsciiCase(OUString("VIEW"));
to:
sType.equalsIgnoreAsciiCase("VIEW");
Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
2013-11-22 08:07:18 +02:00
363cc39717
convert equalsAsciiL calls to startWith calls where possible
...
Simplify code like:
aStr.equalsAsciiL( "%", 1 )
to
aStr.startsWith( "%" )
Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
3ef88d370e
remove unnecessary use of OUString constructor in DBACCESS module
...
Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0
2013-11-11 11:21:24 +02:00
fed3c2bf20
dbaccess: cleanup
...
* remove an external guard
* fix some include guards
Change-Id: I4e5b5fc5c50acfd81321377e7956e33c838edeba
2013-11-05 09:28:54 +01:00
bfbe8c0b5b
fixincludeguards.sh: dbaccess
...
Change-Id: Iadd4326d58a5df5761a0ed5ce7fd5fb01fb87d11
2013-11-05 09:28:52 +01:00
5285beeaa4
remove redundant calls to OUString constructor in if expression
...
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
45e366eadb
drop unnecessary tools/string includes
...
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
d9eac2ceb8
make sure value passed to updateBoolean is treated as a boolean
...
Change-Id: I69549fd8ab95cf92ccb06fd9aed1b9dba2935d7d
2013-10-16 18:45:21 +02:00
1883d4f10f
when reading a bool from a database, treat is as a bool
...
This in particular allows recognition of strings "true" and "false".
Change-Id: I590a5357206e4fb0b92b78b8ee4655e445e6f152
2013-10-16 18:45:19 +02:00
a102d822c9
janitorial: more const, comments
...
Change-Id: I5366840ab67fdf89575e890a0d97602b8e78f71a
2013-10-02 19:02:33 +02:00
34063e35f7
-Werror,-Wunused-variable
...
Change-Id: I805b898faaae631d047ec82e7139c6d6ccaea3b1
2013-10-02 18:40:14 +02:00
0ff379fa1c
-Werror,-Wunused-variable
...
Change-Id: I0d587538c3bee7ad71acb2272c7f85f5f7454158
2013-10-02 18:40:14 +02:00
2ec606730b
fdo#62475 removed pointless comments
...
Conflicts:
dbaccess/source/filter/xml/xmlfilter.cxx
dbaccess/source/ui/dlg/ConnectionPage.cxx
dbaccess/source/ui/dlg/detailpages.cxx
dbaccess/source/ui/dlg/odbcconfig.cxx
dbaccess/source/ui/querydesign/querycontroller.cxx
Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz >
Tested-by: Petr Mladek <pmladek@suse.cz >
2013-08-27 16:11:09 +00:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
67876ed105
SAL_INFO output contains the current thread ID anyway
...
Change-Id: Ie51865e57a33e31c2aa115b68eed0fc0a1972c40
2013-08-21 11:42:13 +02:00
1c7af455ab
Re-work 8bit characters in source code, or remove them.
...
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@suse.com >
Tested-by: Michael Meeks <michael.meeks@suse.com >
2013-08-20 19:30:59 +00:00
c9db5e6f08
Do not use this ptr in ctor
...
...offload to init() instead and wrap ctor in create(). That removes the need
for refcount fiddling and additional OContainerListener class. Which in turn
removes code using dynamic_cast on UNO interface classes, which my claim at
<http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130812/
086127.html> "ubsan: check type_info equality via strcmp" that "there should not
be uses of dynamic_cast involving [UNO] classes in the LibreOffice code base"
made me wonder about...
Change-Id: I5d72650f6bf081f971f7bd6bb65f4e58a342f791
2013-08-16 15:02:30 +02:00
76b5ac2193
doing it once is sufficient
...
Change-Id: If31845aa575b3f9459507deefb1b469ac3715e35
2013-08-14 17:39:58 +02:00
91f3d77b98
tweak comment translations
...
ede5f05c fb3a1bb9 5e04331f fd6089b9 66a1d406
Change-Id: I5077ce5f6182f9193cebaaf63190450d375679dd
2013-08-08 23:25:25 +02:00
3d5a27bf5a
for later...
...
Change-Id: I266d2992bcd212a6539e4b50c9daf2c53ff98904
2013-08-02 13:57:51 +02:00
a8f327a9fc
make comment actually describe the code
...
Change-Id: If4dda13ff8018d7fd855457a76db2acf8077a477
2013-08-02 13:57:49 +02:00
0fafb92e97
janitorial: more const where possible
...
Change-Id: If579b2b2990c3cdd4785077aa1b34c33bcc241b6
2013-08-02 13:57:48 +02:00
6fc71eea1d
SingleSelectQueryComposer: the name of a non-SELECT column is its "real" name
...
That is, the name in the table.
Change-Id: I95326915f381ec0cf72c66f13352ce76d82e9517
2013-08-02 13:57:47 +02:00
bcd5f5ebd4
fb-sdbc: Added temporal debugging in dbaccess
2013-07-16 16:40:07 +02:00
d6855a708c
Debug info and some API methods implementation.
...
* getTypeInfo
* getTables
* prepared statements.
Change-Id: I549f4a9468b5346e22479363fe0fb81039bc6665
2013-07-16 16:40:04 +02:00
