Commit Graph

311 Commits

Author SHA1 Message Date
819cc64318 coverity#735751 Dereference after null check
Change-Id: Id7e11fefec40d11c509bde01533122ca68db7402
2014-02-24 12:53:08 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
2b9fe0c75e cid#707865 Uninitialized pointer field
Change-Id: I86c90a95093d6c90cbc733164a3b773468575b5b
2014-02-21 11:59:09 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
cabf650ad0 sal_Bool->bool
Change-Id: I3589b3fb44ad57140567338809513b3df7c7eba5
2014-02-19 13:04:57 +02:00
ae2f7da4f9 sal_Bool->bool
Change-Id: Id5cbf2c94e3d3ff27cdb8998e2b7b3b712b537ec
2014-02-19 13:04:57 +02:00
4003da2f87 sal_Bool->bool
Change-Id: Id314bacb8af5c75ecce73a0b7cfee45f36db93da
2014-02-19 13:04:56 +02:00
2e71918d49 sal_Bool->bool
Change-Id: I628c1506573c7d5ec182048a20ed996c9ae879c4
2014-02-18 10:08:03 +02:00
0b9f65d05c coverity#1169835 Improper use of negative value
Change-Id: I73b9ea3f1da05c8ddfd8e0b2da526b65dc1891bb
2014-02-09 15:30:28 +00:00
8185ecf65a fdo#73146 Add Excel 2010 functions
PERCENTILE.EXC, PERCENTILE.INC
PERCENTRANK.EXC, PERCENTRANK.INC
QUARTILE.EXC, QUARTILE.INC
RANK.EQ, RANK.AVG

Function ScInterpreter::ScRank() has been rewritten to give the function
the same way of computing as the related functions in this patch.

Change-Id: If3096b265bd47ca5f4afcab7ff746f7c8511df82
Reviewed-on: https://gerrit.libreoffice.org/7319
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-30 12:30:56 +00:00
9b667561c3 coverity#1158192 Improper use of negative value
Change-Id: Ie5b455f3895e9ff53caf773e319d3342642b9945
2014-01-29 13:23:54 +00:00
78ddd6090c bool improvements
Change-Id: I9be9755170694a0071720080af4b8f2c9298f916
2014-01-28 20:26:28 +01:00
5b1e440304 fdo#72793 Add Excel 2010 functions
T.DIST, T.DIST.2T, T.DIST.RT, T.INV, T.INV.2T, T.TEST
Also, fixed some incorrect string assignments in
formula/source/core/resource/core_resource.src from previously
added Excel 2010 functions.

Change-Id: Ia4d13e7597d2a054d345a08b66b878f91c43f872
Reviewed-on: https://gerrit.libreoffice.org/7226
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-27 14:14:19 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
00d0a50e3b Window::Notify should return bool, redux
Change-Id: Ib41ed9ace428081e1948cf109de095ea9e7c45c2
2014-01-17 18:45:17 +01:00
9c09211bce Add internal cell function __DEBUG_VAR to sniff arbitrary internal state.
Useful for debugging in a more flashy way.  But never ever document this
for end users.  If you are an end user reading this, use this at your
own risk.  You have been warned.

Change-Id: Ibbdb45f576287f707106327704754ffaec27ba3c
2013-12-20 20:09:51 -05:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
924f9d7ea8 fdo#72158 Add Excel 2010 functions
LOGNORM.DIST, LOGNORM.INV, NORM.DIST, NORM.INV, NORM.S.DIST, NORM.S.INV

Change-Id: I695e0645642af1757a1dd7d7f0f15c9515e21309
Reviewed-on: https://gerrit.libreoffice.org/6883
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-16 20:25:45 +00:00
d1e1cd128c remove unused code (ancient Calc function ZELLERROR)
code has no function, except that calc documents with formula
ZELLERROR will not produce an error. But the formula is not
interpreted, so remains 'dead code'.

Change-Id: I6e7df7040a0273bcd3ebd497055924b7afdd3311
Reviewed-on: https://gerrit.libreoffice.org/7018
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-13 14:09:18 +00:00
e7c10fba90 remove usage of STRING_NOTFOUND in formula.cxx
and tidy up the method a little

Change-Id: I408fd96286749ec9e3743dbdad8cf424a7bb9035
2013-12-04 08:55:35 +02:00
a0be5278c2 remove condition that cannot be hit
GetFunctionEnd cannot return STRING_NOTFOUND

Change-Id: Ic9abee0ea77789e01acedf57c6c13edb0a5c08d9
2013-12-04 08:55:35 +02:00
ca015ac131 convert formula::FormEditData from xub_StrLen->sal_Int32
Change-Id: I0127079ef3ee6bde8e36f2a83ef1f568b9f15568
2013-12-03 11:34:48 +02:00
c310019e75 convert formula::FormulaDlg_Impl from xub_StrLen->sal_Int32
Change-Id: Id3229083c1e2ad0cfcb01e9dfa6fa66eb5f5604a
2013-12-03 11:34:48 +02:00
b882c046ee convert FormulaHelper from xub_StrLen to sal_Int32
Change-Id: Ib866c39b2bb5a3cf81b899dc38ea548e3762fc9e
2013-12-03 11:34:48 +02:00
d9b4c8ea81 Convert FormulaHelper::GetNextFunc xub_StrLen->salInt32
Change-Id: Ief8c4b4699b3f6ffe1cb02d3dae43ad5a0c4c89e
2013-12-03 11:34:47 +02:00
418b5df94b convert getSuppressedArgumentCount from xub_StrLen -> sal_Int32
convert IFunctionDescription::getSuppressedArgumentCount from xub_StrLen
-> sal_Int32

Change-Id: Iee7a094a6f067fa57ee828c434417f7583c0f32b
2013-12-03 11:34:47 +02:00
35afee4de1 convert IFormulaEditorHelper::*Selection methods from xub_StrLen to sal_Int32
Change-Id: Ia7a6241c651106427e636bdc08085b97a2a41407
2013-12-03 11:34:46 +02:00
8302495a21 store internal CONVERT to .xlsx/.xls and distinguish from CONVERT_ADD
Change-Id: Ie9b5f6ade1c25618aa990ce17bd7b2a2b46a250a
2013-12-02 18:58:00 +01:00
bd77c4d178 Remove useless comments in funcutil.
Change-Id: I2a5f70a45e1101c72a9dc973e1a783f716400ad2
2013-12-01 13:07:25 +01:00
62e1a27dc7 our UI DURATION is ODF and Excel PDURATION
Change-Id: Iaf0e5f8096554b8b5d80265b6dc5296b3294f134
2013-11-29 21:48:11 +01:00
8539039e0c fdo#71936 Add Excel 2010 functions GAMMA.DIST, GAMMA.INV, GAMMALN.PRECISE
Change-Id: I96f6beb34c1ce7f7191c6e9d379145ba98320c87
Reviewed-on: https://gerrit.libreoffice.org/6775
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-11-29 11:12:20 -06:00
2f973aa90d Integrate branch of IAccessible2
Change-Id: Id8c4ff1d10eccda2d7279d625822759c1f520a46
2013-11-26 12:08:54 +00:00
e434c1ce05 fdo#71722 add Excel 2010 functions
EXPON.DIST, HYPGEOM.DIST, POISSON.DIST, WEIBULL.DIST

Change-Id: Ib9f648739ec0af90cdf2f576c7f548a6acb7b4a6
Reviewed-on: https://gerrit.libreoffice.org/6748
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-11-22 05:37:39 -06:00
5a1fa54952 fdo#71436 add Excel 2010 functions for F-distribution
Added F.DIST.RT, F.INV.RT, F.TEST, which are renamed
FDIST, FINV and FTEST and handle the right tail F-distribution.
Added F.DIST and F.INV, which are new functions and handle
the left tail F-distribution.

Change-Id: Ia7fa26a25f3188249f280733d6111951e2600704
Reviewed-on: https://gerrit.libreoffice.org/6701
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-11-20 12:25:18 -06:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
3f5987421e Fix indentation.
Change-Id: I260649aca445e03c52423d8f0a63eb4681d2a876
2013-11-18 17:25:39 -05:00
8819e69095 Remove unused member.
Change-Id: I8331251f77fb202375370a425e01862aa0f6310d
2013-11-14 23:53:52 -05:00
d9a914fe5b Identify methods that don't modify internal state and mark them const.
Change-Id: Ie63d93d51640bfb80dc02bb226d742c2f9be96d8
2013-11-14 23:53:51 -05:00
53b2d2ce0c fdo#71350 add Excel 2010 function CONFIDENCE.NORM and CONFIDENCE.T
Change-Id: I341b0c7a61047627aac1f12bc4653b6f9e65b2e3
Reviewed-on: https://gerrit.libreoffice.org/6625
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-11-14 19:03:53 +00:00
4cdb874b11 OOXML FINV is ODFF LEGACY.FINV, _xlfn.FINV is something different
Change-Id: I5a61298229643c0b0e24d3a30069a95ddda6842f
2013-11-14 19:14:22 +01:00
b26edbb449 moved erroneous _xlfn. from ODFF to OOXML
Change-Id: I58e7d1ba611b4482cfe4ac5f5d37feaf33691a37
2013-11-14 13:59:39 +01:00
85341404d7 all functions new in Excel since OOXML have _xlfn. prefix
Change-Id: Ie22292da1ee79f2693da73cc27944a53b2213150
2013-11-14 13:53:07 +01:00
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
10515c6c6f fixed file format mappings always have RESOURCE_BASE separators
Change-Id: I7ac93f742b469156cd8eb3f8171c7e05a98598ad
2013-11-13 18:38:52 +01:00
e59cc6448c c++11 we love you
Change-Id: I6ff8610f6b31481334d609a0e150285e6eef6096
2013-11-13 16:48:01 +00:00
debe0835ca introduced FormulaGrammar::GRAM_OOXML with FormulaLanguage::OOXML
FormulaLanguage::XL_ENGLISH is not OOXML, unconditionally using
SymbolsEnglishXL with RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML spoils
the grammars of FormulaLanguage::XL_ENGLISH that are not OOXML.

Change-Id: Id885d1c033cd15dc7b11c6490be3a98500027d37
2013-11-13 17:15:59 +01:00
dbd3da10da More Excel functions with _xlfn. prefix.
Change-Id: I49d29fe626ea3079273b4e654a6a3803f7dbd614
2013-11-11 17:03:55 -05:00
01ea75c0f0 Add separate list of function names for OOXML import.
Change-Id: Id6bb9ed65f94a56e82c0c4a6fee241dec4eb9138
2013-11-11 16:17:30 -05:00
3ac4277ba1 Thread-safe way to check for presence of references in formula tokens.
Change-Id: I995668d1e183dc0dae4f354889bc13053e858723
2013-11-11 16:17:28 -05:00