Commit Graph

141 Commits

Author SHA1 Message Date
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
2b9fe0c75e cid#707865 Uninitialized pointer field
Change-Id: I86c90a95093d6c90cbc733164a3b773468575b5b
2014-02-21 11:59:09 +02:00
9c09211bce Add internal cell function __DEBUG_VAR to sniff arbitrary internal state.
Useful for debugging in a more flashy way.  But never ever document this
for end users.  If you are an end user reading this, use this at your
own risk.  You have been warned.

Change-Id: Ibbdb45f576287f707106327704754ffaec27ba3c
2013-12-20 20:09:51 -05:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
3f5987421e Fix indentation.
Change-Id: I260649aca445e03c52423d8f0a63eb4681d2a876
2013-11-18 17:25:39 -05:00
8819e69095 Remove unused member.
Change-Id: I8331251f77fb202375370a425e01862aa0f6310d
2013-11-14 23:53:52 -05:00
d9a914fe5b Identify methods that don't modify internal state and mark them const.
Change-Id: Ie63d93d51640bfb80dc02bb226d742c2f9be96d8
2013-11-14 23:53:51 -05:00
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
10515c6c6f fixed file format mappings always have RESOURCE_BASE separators
Change-Id: I7ac93f742b469156cd8eb3f8171c7e05a98598ad
2013-11-13 18:38:52 +01:00
e59cc6448c c++11 we love you
Change-Id: I6ff8610f6b31481334d609a0e150285e6eef6096
2013-11-13 16:48:01 +00:00
debe0835ca introduced FormulaGrammar::GRAM_OOXML with FormulaLanguage::OOXML
FormulaLanguage::XL_ENGLISH is not OOXML, unconditionally using
SymbolsEnglishXL with RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML spoils
the grammars of FormulaLanguage::XL_ENGLISH that are not OOXML.

Change-Id: Id885d1c033cd15dc7b11c6490be3a98500027d37
2013-11-13 17:15:59 +01:00
01ea75c0f0 Add separate list of function names for OOXML import.
Change-Id: Id6bb9ed65f94a56e82c0c4a6fee241dec4eb9138
2013-11-11 16:17:30 -05:00
3ac4277ba1 Thread-safe way to check for presence of references in formula tokens.
Change-Id: I995668d1e183dc0dae4f354889bc13053e858723
2013-11-11 16:17:28 -05:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
4efc5fa376 Protect those global symbols containers with mutex during initialization.
Change-Id: Id15b3e1a2bfebd2ea795fd412a259f125f5d9bab
2013-11-06 20:40:25 -05:00
2b01553fa5 fdo#54938: Convert svx to use cppu::supportsService
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-30 18:17:11 +01:00
3629a512b5 New constructor that takes both numeric and string arrays.
Change-Id: I9c48f340a0349e5f1ba772fcd783924c79b07616
2013-10-18 23:22:40 -04:00
c30a2c4baf More eye-pleasing way of checking for valid vector array...
Change-Id: If2f47a7d98a4cbc9e09dc98c1bb0e11f8f889265
2013-10-18 23:22:39 -04:00
7586151cbe Allow vector array tokens to store both numeric and string values.
This is achieved by storing two physical arrays in each vector
reference array.

Change-Id: Iafb9e57b86e57e75eed8ff692a6d882c2049f710
2013-10-18 23:22:39 -04:00
7333881bb7 Formula tokens, formula cells and formula interpreters to use shared strings.
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
2013-10-11 12:14:27 -04:00
9fc44bd235 convert remains of String to OUString in formula module
Change-Id: Ieca67b54535a6e11ba8fc20f6d02c501f6b7affd
2013-10-01 10:08:38 +02:00
7f83faa795 convert the rest of the formula module from String to OUString
Change-Id: I27ee0cf3e9f97e94234c5e32080bf102b4cf0dc9
2013-09-17 09:04:31 +02:00
85eb736bee convert the resust of include/formula/FormulaCompiler.hxx to OUString
Change-Id: I7cbc371e90869c481a23450722a1a025b110b235
2013-09-17 09:03:54 +02:00
7625372d55 convert formula::OpCodeHashMap from String to OUString
Change-Id: Iabf95a16cc4df3a612b90ed9e07f2216f72bb976
2013-09-17 09:03:40 +02:00
c88ce9033b convert aCorrectedFormula in formula::FormulaCompiler to OUString
Change-Id: I048ec33effc33e94943f5110d6a9a0937a1dfdfe
2013-09-17 09:03:23 +02:00
8f23a3b0e2 convert formula::FormulaCompiler::OpCodeMap from String to OUString
..and add some convenience methods
  sal_Unicode getSymbolChar
  sal_Unicode GetNativeSymbolChar
since most call sites are only interested in the first char of
the symbol.

Change-Id: I6aeb43b055b849e71cb1f62c3efe79d6a4cc10bd
2013-09-17 09:02:18 +02:00
12d44973d9 convert aCorrectedSymbol in formula::FormulaCompiler from String to OUString
Change-Id: I426b305fb8befffe0452e280d2097b6560843eef
2013-09-17 08:06:13 +02:00
3ec486639b introduced putCopyOpCode() to handle copyFrom()
... and added bOverrideKnownBad handling

Change-Id: I1b669771ec1aa0cdfa1c1bef0bcfccfad96fe727
2013-09-17 01:04:14 +02:00
4fc4a3f2e5 better SAL_WARN_IF diagnostics
Change-Id: I74fe8e145dda41466f21f20369681d6f1e5274df
2013-09-17 01:04:13 +02:00
2e60a634ec deuglified for readability
Change-Id: I81e09500dd8fe4e3af9fc2e9f623fb519635266d
2013-09-16 20:47:09 +02:00
2f2ee162ac Revert "get rid of unnecessary warning"
This reverts commit e5321437322fd812b93fee266af309e782479488.

OpCode 0 (ocPush) was deliberately included in the assertion as it is
never a mapping to a function or operator name.
2013-09-16 19:12:36 +02:00
7d0f3695a2 Correctly handle empty cells for string arrays too.
Because we need to make a distinction between an empty cell and a string
cell containing zero-length string, I decided to switch to using
rtl_uString* array and use NULL values as empty cells.

Change-Id: I5bedb593507f34782e41a8a900602d445e5b1f6f
2013-09-10 11:47:45 -04:00
801a657ea6 iString to OUString in some calc core code
Change-Id: I25fc70cfd01f5ad25f7362157796d3ddf06139e1
2013-09-07 12:55:45 +02:00
e462eb1183 Allow storage of string arrays in vector ref tokens.
Change-Id: Id2bc5a0343afeae387d896a9c369586a13081cd5
2013-09-06 01:38:31 -04:00
e532143732 get rid of unnecessary warning
A value of 0 for Opcode eOp produces a debug assertion that is
not in place as opcode with value does exist (ocPush, SC_OPCODE_PUSH).

Change-Id: If529cc2ecd8d4d3a5e31f084dfa72e13c9c0fe37
Reviewed-on: https://gerrit.libreoffice.org/5586
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-27 13:48:01 +00:00
b24e3a6042 differentiated warning for symbol/AddIn pair insertion, fdo#59727
Change-Id: I371bca810c40d4cfab0b9fcd47a070b4e68ee768
2013-08-16 17:54:30 +02:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
9c1ca6dca3 resolved fdo#35411 redefined MAXCODE 512 to FORMULA_MAXTOKENS 8192
Also renamed MAXJUMPCOUNT to FORMULA_MAXJUMPCOUNT but without changing
the value as the runtime array size of ocChose depends on it, should be
changed before.

Eliminated the duplicated and error causing redefinition of both in
sc/inc/compiler.hxx

Change-Id: I0e87d1439c9564a4f475fcb2870ab51c3b586942
2013-07-02 00:01:42 +02:00
e38d20c1e1 Handle range references for group calculation. This is still untested.
Change-Id: I1eb1c217db66615028faa85720838579056dc150
2013-04-30 13:10:44 -04:00
dfc3f290b5 Let's not use VectorArray struct. There is no use for it.
Change-Id: Ic011143206c13fcbc1b3403bf5b7df46c6934899
2013-04-30 13:10:43 -04:00
ee289aaf45 Let's not forget to check this in...
Curse the sc / formula split...

Change-Id: Ib8d17ba63d05eb4df7e6918e0034d91dd82869e3
2013-04-30 13:10:42 -04:00
20d4db0fe3 Add method to allow fetching of double array, and store it in token.
Change-Id: If094dbf139e18ad23c73d6cf5a78ac4844132b14
2013-04-30 13:10:41 -04:00
7fb73a8475 Initial cut on vector formula ref tokens. Not used yet.
Change-Id: I4b28c269759bc01bfc94cfdd6a1c651d03d829c7
2013-04-30 13:10:41 -04:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
292ffa80bc First cut on checking the token array on whether we could do vectorization.
Not tested yet.

Change-Id: I87f8a8595229d8d8e83526dc0334891d253cf2c7
2013-03-19 13:40:24 -04:00
3a09e0078a Use initializer in ctor.
Change-Id: I2721c083e26654f5ce5cc636d652cb4d50a158ad
2013-03-19 13:40:24 -04:00
0a0deec6f1 Fix indentation.
Change-Id: Ia277ac4e9eeb34a2b0244ebb5f09c428f5cf2b64
2013-03-19 13:40:24 -04:00
198a722974 Move GetHash() from FormulaTokenArray to ScTokenArray.
To allow access to reference tokens.

Change-Id: I3e2d2653722005c04b6d26e1a4ddfce0a459ef37
2013-03-19 13:40:23 -04:00
6433ab29af Implement (partially?) and test formula token array hash function.
For now, we don't factor in any differences in reference tokens in the
generated hash values.

Change-Id: Ie9836228eaad9c74edd884c3e8c4b273979760fd
2013-03-19 13:40:22 -04:00