0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
94bc29cb71
Typo: I/internaly -> I/internally
...
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-09 10:12:07 +01:00
6f0e7c36e4
Typo: seam(s) -> seem(s)
...
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-02-06 21:22:42 +01:00
eeb840d6ba
fdo#70376: Put only document (file) name in window title on OS X
...
Change-Id: I0b975a1a0e73c546beec96599fd4e5f87caa51db
2014-02-03 17:48:25 +01:00
a91de8efc9
fdo#54938 Convert framework to cppu::supportsService
...
Change-Id: Id0c7c845d128920ba278de4208f5c32dcf83ecb1
Reviewed-on: https://gerrit.libreoffice.org/7754
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-02-02 14:59:51 +00:00
612dac063a
bool improvements
...
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
2462159d7b
bool improvements
...
Change-Id: I754b47013d8f1aa3ecf6204fbe926a438887639d
2014-01-28 20:26:27 +01:00
4abe5e61dd
bool improvements
...
Change-Id: Id91399027008ffbda26f3212bd3ddbba22044f2b
2014-01-21 18:24:03 +01:00
a3f32769fc
Fix bogus mass-conversion equalsAsciiL -> startsWith
...
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
296fece62f
get master dictionaries in master core
...
and a janitorial drive-by in framework
Change-Id: I3106925423cb53f58b59714da49b7928c533e613
2013-12-28 17:18:03 +00:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
52bbd9cc00
remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
...
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
3af99e4d59
convert equalsAsciiL calls to startsWith calls
...
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-20 10:07:31 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec
remove most use of RTL_CONSTASCII_USTRINGPARAM macro
...
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
897bf27a95
cppcheck: reduce scope
...
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
2013-11-10 14:41:22 +01:00
5285beeaa4
remove redundant calls to OUString constructor in if expression
...
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
a1c126c264
-Werror,-Wunused-variable
...
Change-Id: I548eec1fdcc862b76361c56724667f2d9f6e0950
2013-10-02 17:35:11 +02:00
062855b4ae
-Werror,-Wunused-const-variable
...
Change-Id: I93796237cb953445e42fde5822ad51bc3edcce10
2013-10-02 16:49:31 +02:00
7f436c1fd3
typo fixes in comments
...
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
e8ecf30ea6
convert FRAMEWORK module from String to OUString
...
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
1817936b28
Bin unused remains of framework's own "debug framework"
...
Change-Id: I71937debf674ff11173d7d8fa5aa43dc12234ce6
2013-09-09 00:29:23 +03:00
9a8e2d09bc
Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2)
...
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).
Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
2013-09-08 23:51:41 +03:00
6aa0698828
Use SAL_INFO instead of framework's own LOG_WARNING
...
Change-Id: Ief44fceaf03d2567f4aacd9ff74d361436e5e05b
2013-09-08 23:51:41 +03:00
c6040d9bd4
Bin intermediate iterator + rename parameter function
...
(see example of http://www.cplusplus.com/reference/vector/vector/erase/ )
Change-Id: I8c0ee334abd91ea99b80a43581a04cbbf9a91fa3
2013-08-27 06:11:07 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
826be413d6
Mark as const/static
...
Change-Id: I9000ea607e1df140ac18d59f7c4d4abd999c71d1
2013-07-27 10:07:31 +09:00
189bb791d2
fdo#66691: Revert fix for i#121577 Allow setting toolbar name in Addons.xcu
...
...which incompatibly changed Addons.xcs and breaks extensions (and LibreLogo,
which adds to Addons.xcu even though it is not an extension). See the mail
thread starting at
<http://lists.freedesktop.org/archives/libreoffice/2013-July/054612.html >
"[Libreoffice-commits] core.git: #i121577# Allow setting toolbar name in
Addons.xcu" for details.
This reverts commit 85f072ef33ef47b5e3e0bcd51acb5c4179cde2c2
"Resolves: #i121577# Allow setting toolbar name in Addons.xcu" plus follow-up
af572d9fbb744c9691abe465815d7927a9d11510 "Related: #i121577# Allow setting
toolbar name in Addons.xcu," f13f9b5cc5267a7a5606b1a89db91b6d7aef5f9c "various
.xcus are gone now," and 37d9921797a3ad3be8257fbfee11326549fcd987
"odk/examples/python/toolpanel/CalcWindowState.xcu is still in use," plus those
parts of f97ca6f65182efc6542c53ac5e973b3ff398a5d1 "Resolves: #i116455# Make
toolbar style settings persistent" that apparently belong to the fix for
i#121577 rather than i#116455.
Change-Id: Ib744566f3d8da7d9008d7dad8bec60f1bf32e743
2013-07-24 16:36:55 +02:00
cb590428d8
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
Change-Id: Ib0edc828691c6a8edbd1f45d3c0e2851c32c865f
Reviewed-on: https://gerrit.libreoffice.org/5013
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-23 14:05:13 +00:00
386af68921
remove duplicate debug area for framework/
...
It'd be probably better to rename all the cryptic abbreviations instead,
but two different debug areas for the same thing simply doesn't work well.
Change-Id: I895fadb47ebf408a36d13dbb32386caa3f472f1c
2013-07-11 16:02:13 +02:00
009851223b
module svl: all String and some bool and related clean-up
...
Change-Id: I36eb559fa58dbe75384b7119c788af0048813aed
Reviewed-on: https://gerrit.libreoffice.org/4733
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2013-07-07 20:00:16 +00:00
a2f4aed322
fdo#66524 - defer loading and scaling AddOns images until necessary.
...
Avoid expensive scaling of images that we will not use, don't hard-code
the toolbar size - but query it instead from the toolbar/theme, unwind
various other tangles: still quite some cleanup left here including HC
handling.
Change-Id: Ia2a1a0f91e5910c2de01f11229b32ed71dd8cf28
2013-07-05 17:11:46 +01:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
126827b0fd
fdo#43460 framework,i18npool,accessibility: use isEmpty()
...
Change-Id: I4cd9841127b1d4a294d7f001b646259c61eb1172
Reviewed-on: https://gerrit.libreoffice.org/4443
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-06-24 21:45:42 +00:00
85f072ef33
Resolves: #i121577# Allow setting toolbar name in Addons.xcu
...
(cherry picked from commit 37894067213a63c51c7a73083d7b0ace5f5c40da)
Conflicts:
framework/inc/framework/addonsoptions.hxx
framework/source/fwe/classes/addonsoptions.cxx
framework/source/layoutmanager/toolbarlayoutmanager.cxx
officecfg/registry/schema/org/openoffice/Office/Addons.xcs
Change-Id: Icc8ed1bb5ac2cfecd6c03c53c137c503dc78bc66
2013-06-24 11:49:53 +01:00
e0cce521f1
Resolves: #i121504# Support for alpha channel in clipboard for all systems
...
(cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519)
Conflicts:
automation/source/server/statemnt.cxx
basic/source/runtime/methods.cxx
canvas/source/vcl/devicehelper.cxx
canvas/source/vcl/spritedevicehelper.cxx
drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
drawinglayer/source/tools/converters.cxx
dtrans/source/win32/dtobj/FmtFilter.cxx
editeng/source/items/bulitem.cxx
extensions/source/scanner/sanedlg.cxx
external/gcc3_specific/makefile.mk
filter/source/graphicfilter/eos2met/eos2met.cxx
filter/source/graphicfilter/ios2met/ios2met.cxx
filter/source/msfilter/msdffimp.cxx
fpicker/source/office/iodlg.cxx
framework/source/fwe/classes/addonsoptions.cxx
framework/source/fwe/helper/actiontriggerhelper.cxx
sc/source/filter/excel/xiescher.cxx
sc/source/ui/docshell/docsh.cxx
sc/source/ui/inc/viewfunc.hxx
sd/source/ui/app/sdxfer.cxx
sd/source/ui/unoidl/unopage.cxx
sd/source/ui/view/sdview3.cxx
sfx2/source/appl/fileobj.cxx
sfx2/source/appl/linkmgr2.cxx
sfx2/source/dialog/filedlghelper.cxx
sfx2/source/dialog/intro.cxx
sfx2/source/doc/docinf.cxx
sot/inc/sot/formats.hxx
sot/source/base/formats.cxx
svtools/bmpmaker/bmpcore.cxx
svtools/bmpmaker/bmpsum.cxx
svtools/inc/svtools/transfer.hxx
svtools/source/filter/filter.cxx
svtools/source/filter/wmf/emfwr.cxx
svtools/source/filter/wmf/enhwmf.cxx
svtools/source/filter/wmf/winwmf.cxx
svtools/source/filter/wmf/wmfwr.cxx
svtools/source/graphic/graphic.cxx
svtools/source/graphic/provider.cxx
svtools/source/misc/transfer.cxx
svx/inc/svx/xoutbmp.hxx
svx/source/sdr/overlay/overlaymanagerbuffered.cxx
svx/source/xoutdev/_xoutbmp.cxx
sw/source/core/view/viewsh.cxx
sw/source/filter/ww1/w1filter.cxx
sw/source/filter/ww8/ww8par.hxx
sw/source/ui/dochdl/swdtflvr.cxx
toolkit/source/awt/vclxbitmap.cxx
toolkit/source/helper/vclunohelper.cxx
vcl/Library_vcl.mk
vcl/Package_inc.mk
vcl/aqua/source/dtrans/DataFlavorMapping.cxx
vcl/aqua/source/dtrans/OSXTransferable.cxx
vcl/aqua/source/dtrans/PictToBmpFlt.cxx
vcl/aqua/source/dtrans/PictToBmpFlt.hxx
vcl/inc/vcl/alpha.hxx
vcl/inc/vcl/bitmap.hxx
vcl/inc/vcl/bitmapex.hxx
vcl/inc/vcl/pngwrite.hxx
vcl/inc/vcl/salbtype.hxx
vcl/inc/vcl/wall.hxx
vcl/source/gdi/animate.cxx
vcl/source/gdi/bitmap2.cxx
vcl/source/gdi/bitmapex.cxx
vcl/source/gdi/bmpconv.cxx
vcl/source/gdi/cvtsvm.cxx
vcl/source/gdi/impgraph.cxx
vcl/source/gdi/impimagetree.cxx
vcl/source/gdi/metaact.cxx
vcl/source/gdi/wall.cxx
Change-Id: I79938bc412c048c3d4e64f430f216e73bec16167
2013-06-13 14:50:46 +01:00
95c0d568fd
use uno::Reference#clear() method...
...
...instead of assigning an empty value. Reduces code noise.
Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
660b67a413
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: Id4e90b83a7275bfd30914f7514a609cebbfbf4ac
Reviewed-on: https://gerrit.libreoffice.org/4044
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-05-31 18:08:02 +00:00
5944137e02
Fix warning: unused variable 'aURL' [loplugin]
...
Change-Id: Ia7f3c2e774ece3cdc35a3a6d220d0eb44e5ad0f9
2013-05-24 12:40:46 +03:00
6a043e9c0a
Use the new type-checking Reference constructor to reduce code noise
...
Also create a Clang compiler plugin to detect such cases.
Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2013-05-22 10:44:29 +00:00
1768904fd9
Related: #i121442# Read Statusbar merging configuration
...
(cherry picked from commit b2db8c4c68553100b64af8f51bce2d496b12e882)
Conflicts:
framework/inc/framework/addonsoptions.hxx
framework/source/fwe/classes/addonsoptions.cxx
Change-Id: I3cd8f310990098fc61adb8287ef53596f4038fdc
2013-05-21 14:01:17 +01:00
cb6d67c21f
Spelling "separate" (etc) correctly is hard
2013-05-15 11:14:28 +03:00
44fb0ceeb9
Resolves: #i121233# Added bitmap scaling methods BMP_SCALE_SUPER
...
added from symphony, also BMP_SCALE_LANCZOS, BMP_SCALE_BICUBIC,
BMP_SCALE_BILINEAR and BMP_SCALE_BOX.
Changed defaults for internal scalings, enhanced PDF export when reduched DPI
is used, added BMP_SCALE_BESTQUALITY and BMP_SCALE_FASTESTINTERPOLATE as new
default for Bitmap::Scale
(cherry picked from commit bf734a151dc5169b65cf5d2a127e4142b765326c)
Conflicts:
canvas/source/vcl/canvasbitmaphelper.cxx
canvas/source/vcl/canvashelper.cxx
sd/source/ui/slidesorter/cache/SlsGenericPageCache.cxx
vcl/inc/vcl/alpha.hxx
vcl/inc/vcl/bitmap.hxx
vcl/inc/vcl/bitmapex.hxx
vcl/source/gdi/bitmap3.cxx
vcl/source/gdi/impgraph.cxx
vcl/source/gdi/pdfwriter_impl2.cxx
vcl/source/helper/canvasbitmap.cxx
(cherry picked from commit 593c86280b64d97725adde0c0a0cc4f090fb2310)
Change-Id: I41cf0a7e11bdbc6510e22e762486420995ba739b
2013-05-09 16:35:40 +01:00
60fbefc615
fdo#60724 informations -> information
...
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
6957d013b4
equalsAsciiL() -> operator==()
...
some more like 7e06132878a495ffb8ed9d54588e1a3ebbd0e8da
Change-Id: I42c2a208e30ce80e95d892c6123247057c823773
2013-04-10 00:42:02 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
2b7ee1db28
remove boilerplate comments
...
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
52770659d3
fdo#62096 Replace O(U)String compareTo with ==
...
Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
Reviewed-on: https://gerrit.libreoffice.org/3136
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-31 15:39:44 +00:00