Commit Graph

313 Commits

Author SHA1 Message Date
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
2462159d7b bool improvements
Change-Id: I754b47013d8f1aa3ecf6204fbe926a438887639d
2014-01-28 20:26:27 +01:00
c2c530da69 Introduce static inline cppu::acquire(), and make use of that.
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.

Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22 15:09:28 +01:00
f278397787 Change _get_implementation()'s not to do initialization directly.
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.

As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.

Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21 21:25:22 +01:00
1115adbb5d bool improvements
Change-Id: I1588e6dcbc095d8c5fcde3601eea9111fbae15fb
2014-01-21 18:24:07 +01:00
10074976b7 fwk: Use constructor feature for StatusIndicatorFactory.
Change-Id: I0595ec98df7bf4114dfb4c21aedd2d2744fda11e
2014-01-17 12:24:51 +01:00
9874547118 bool improvements
Change-Id: Ice9f38b615b325bce6c15fefe9fbb3f528d36b1e
2014-01-14 21:28:09 +01:00
ea65158833 The #ifndef MACOSX can surround even more code
Change-Id: Ia771d36711364bcf53789b3f7a623582451d175d
2013-12-26 18:28:08 +02:00
4274e6a9af WaE: unused variables
Change-Id: I42549eaa7048a6bcb248d3bd1bb28ca2c7c38763
2013-12-26 18:19:45 +02:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
24cad6a649 Move MediaDescriptor from comphelper to unotools
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14 11:13:24 +01:00
c4a593b6b1 remove unnecessary use of OUString constructor in FRAMEWORK module
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
2013-11-11 08:36:07 +02:00
b1f5986c57 StatusIndicatorFactory::impl_reschedule(): lock SolarMutex
... before calling Reschedule().

Change-Id: I244fdd1a4642ea0e1ad266f6d9c4c56527018952
2013-11-03 15:20:51 +01:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
e8ecf30ea6 convert FRAMEWORK module from String to OUString
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
7323bc3405 WaE: warning C4100: 'aEvent' : unreferenced formal parameter
I thought SAL_WARN_IF etc worked in such a way that any variables used
in the condition would be "used" from the compiler's point of view,
even in an optimising build case where SAL_DETAIL_ENABLE_LOG_WARN is
false and SAL_WARN_IF should optimise away?

Change-Id: I728e1eeb8559e1299abf403afceb0e2748d08857
2013-09-09 22:25:50 +03:00
2b3e225853 Bin some uses of the stupid DECLARE_ASCII macro
Change-Id: I076eef8069e848ec3cf9c69f1b489ad44586324e
2013-09-09 00:58:15 +03:00
895885652e Fix non-debug build
Change-Id: I5446c7fec62c1a934b1ffb21fefa1279b932ca09
2013-09-09 00:13:01 +03:00
9a8e2d09bc Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2)
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).

Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
2013-09-08 23:51:41 +03:00
d798d26bc4 Remove some occurrences of RTL_CONSTASCII_STRINGPARAM and equalsAsciiL
Change-Id: I7acc31f819be6552344073fa032085d01622fca3
2013-07-29 01:35:35 +02:00
e8be58a10b fdo#46037: 1 less occurrence comphelper/configurationhelper in fmwk/helper
Change-Id: I504789fb6b1e5332b0c131313ea9b9c538227d46
2013-07-26 20:50:55 +02:00
02931dc8c7 ouch
Change-Id: I927a688c28121d084bf3fd9a57dd1a9c2501a407
2013-07-26 12:51:27 +02:00
f277d2a8ca Don't dupplicate logic so that one can fix possible bugs only once
Change-Id: I58744a93d3edb3002e9a71c22e0d492cb9277e73
2013-07-26 12:44:08 +02:00
cb590428d8 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: Ib0edc828691c6a8edbd1f45d3c0e2851c32c865f
Reviewed-on: https://gerrit.libreoffice.org/5013
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-23 14:05:13 +00:00
9dbb8db06d Convert the easy cases in framework to WeakImplHelper
Change-Id: I6547c4aee2aa4d15ad516a6a45002b81b7a8ac13
2013-07-23 10:05:45 +02:00
19f3d9310c fdo#35785 LibreOffice's support of recent documents in Windows 7 broken
Change-Id: I916ba1335b0a0420f568ab9340632f273e3c9516
Reviewed-on: https://gerrit.libreoffice.org/4997
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-20 21:01:01 +00:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
8c799984cc fdo#46808, Convert the rest of XMultiServiceFactory in framework module
Change-Id: Ife3caf00ab37a8c344f0ab90e40337b3b5bc1571
2013-06-05 08:13:22 +02:00
e0fc16f769 fdo#46808, Convert some XMultiServiceFactory to XComponentContext
Change-Id: I8272ecab34711654ed27625a571cf2553ffd7468
2013-05-28 08:10:25 +02:00
c380b432e3 remove unnecessary parameter and field
Change-Id: I10311ea88f69566d9e30308c0cff193dd5ddcd11
2013-05-28 08:10:24 +02:00
5835d8d271 fdo#46808, Convert some XMultiServiceFactory to XComponentContext
Change-Id: Ia55bb7af6e5d1c76f3cf8001ea53892e1e1bdac0
2013-05-28 08:10:24 +02:00
95ec16b513 fdo#46808, Convert frame::LayoutManager service to new sty;e
Change-Id: I46c3950aee336548d6e0acc6a7d1da655c158175
2013-05-28 08:10:23 +02:00
fe1ac1bf90 fdo#46808, convert XMultiServiceFactory to XComponentContext
Change-Id: I5ed0b12bf37e7d235fc88182c006a6ed07ef2343
2013-05-22 15:20:07 +02:00
122e4bc598 fdo#46808, XMultiServiceFactory to XComponentContext
Change-Id: I2ca9a2930a921c600f5e93cc2e66d461220ea87d
2013-05-22 15:19:49 +02:00
60fbefc615 fdo#60724 informations -> information
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
244c7cdede fdo#46808, convert task::StatusIndicatorFactory to new style
the service already existed, it just needed an IDL file.

Change-Id: I84c8e48e176ec3a38ac48a7abcec7463390523b9
2013-03-04 14:22:33 +02:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
0c317af38a s/childrens/children/
Change-Id: I1731710811506383d29c835a613b07506e7232f0
2013-02-22 09:32:10 +02:00
9865cc0aee fix misuse of toAscii(Lower|Upper)Case
OUString are immutable so these api, contrary to what happen
with String, do not change the object but create a new copy

Change-Id: Ib48a8d11e485d4b8556f4427880aaaca32d4e82c
2012-11-28 01:32:06 -06:00
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
e8aa70b5d4 fdo#46808, convert comphelper::ConfigurationHelper to XComponentContext
Convert the helper methods to take an XComponentContext parameter,
instead of XMultiServiceFactory.

Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-24 11:29:53 +02:00
432c0f4917 fdo#46808, use service constructor for frame::ModuleManager
Change-Id: Iae2bd22a22213274d4a7697345b879f6573a30f0
2012-10-23 17:44:16 +02:00
a7efb9b8dd loplugin: fix some indents and unused OUStrings
Change-Id: I1d7256eea7a79453d3cdb85d1edcf824d58d775e
2012-10-14 16:37:00 +01:00
2f002e3a49 having two SetPosSizePixel is a blasted nuisance
Lets rename the multiargument SetPosSizePixel to
setPosSizePixel drop the various using Window::SetPosSizePixel
and work towards de-virtualizing SetPosSizePixel/SetPosPixel and
SetSizePixel and doing the work in a virtual setPosSizePixel

Change-Id: I7057654168001b67becee1791e97f9e9dc01f7b8
2012-09-28 08:48:39 +01:00
2beba8f93e reduce ascii noise and useless comments
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
49ad17e2b1 remove include comments and boxes
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
5f26c0fb0d gridfixes: don't be too generous with exceptions:
avoid where possible (by checking beforehand), and assert when caught
Conflicts:

	framework/source/fwe/classes/framelistanalyzer.cxx
	framework/source/helper/titlebarupdate.cxx
	framework/source/services/frame.cxx
	framework/source/uifactory/windowcontentfactorymanager.cxx
	sfx2/source/notify/eventsupplier.cxx
2012-07-06 20:29:11 +01:00