Commit Graph

121 Commits

Author SHA1 Message Date
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
c340131d16 fdo#63154 Remove unused solar.h reference in tools
Change-Id: Ic450a82a201cb4da3b0c2992908b597220038871
Reviewed-on: https://gerrit.libreoffice.org/8135
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-20 20:38:41 +00:00
9c9e4b1942 Add SvStream::ReadCharAsBool
Change-Id: I9dc0525e04de5ae79205872b779dcd0115a9cc14
2014-02-20 19:51:43 +01:00
7fa9530f8c fdo#63154 Remove unused solar.h ref. in tools
Change-Id: Iedcf030178c4bf875db01ba6b1f5202dae18bca2
Reviewed-on: https://gerrit.libreoffice.org/8134
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-20 11:44:08 +00:00
3db6d2cb99 GCC 4.9, LTO: libvcl uses GZCodec but it is not linked with the implementation
This is not valid C++ and GCC now resolves the virtual calls and inlines
destructor that leads to undefined symbols.

Change-Id: I841d25bc6f994f0e73665b174994f9471597131e
2014-02-18 19:57:31 +01:00
95401d5898 tools: sal_Bool -> bool
Change-Id: I3aad235d92b3972b44199294c0f3de65ad57f450
2014-02-18 08:18:29 +01:00
0c7f352775 remove SvStream::operator>> methods
in favour of ReadXXX methods.

Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 19:45:10 +00:00
b2878af322 more SvStream:operator>> conversion
Convert the template based read_lenPrefixed methods to regular
methods.

Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:32:11 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
570e5d70f3 fdo#74425 Remove deprecated static function ResMgr::GetLang()
ResMgr::GetLang() has been deprecated for a long time now. It is used
by only one function,
SubstitutePathVariables::SetPredefinedPathVariables() in the framework
module. I have therefore removed it from ResMgr and placed it as a
function in framework/source/services/substitutepathvars.cxx where it
is actually used.

Change-Id: I5f0d8f701aa45f8653020affeff6339f8fc9bc0e
Reviewed-on: https://gerrit.libreoffice.org/7791
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04 14:43:57 +00:00
e4be770ec8 add std::ostream operators for Region and PolyPolygon
Change-Id: I8f4129b840a27f3029643ad2a4852f9e10604905
2014-02-03 12:34:06 +01:00
3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
d1f88c2cbb coverity#984164 : Uninitialized scalar field
Change-Id: I5fa6608861b7049ad3964b695b0622ab583397d1
2014-01-31 21:27:24 -06:00
73d713a1b3 fdo#63154: Remove SVBT8 from solar.h
Conflicts:
	sw/source/filter/ww8/ww8par2.cxx

Change-Id: I4e500cf0ca89468494fd3f0892839f5ca6cce725
Reviewed-on: https://gerrit.libreoffice.org/7645
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30 16:54:16 +00:00
b4c2496f44 bool improvements
Change-Id: Ia3fd76aa70564cbc683d0d66cc39aa368bea29d9
2014-01-28 20:26:17 +01:00
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
29a287f3e2 drop unused STRING_LEN
Change-Id: I95446e7bcdfb19cea9eb8055ac880f7c8a04eb37
2014-01-21 14:55:45 +00:00
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
e13b06b129 ReadUniStringLine never called without explicit length
Change-Id: I1811cf798a9e4b9d2704cccb59213034d2dc2626
2014-01-13 13:54:50 +00:00
79a6d4c743 Use bool
Change-Id: I57cd7ddecc192a82632c62081b57895a86d8758d
2014-01-10 17:11:50 +01:00
3abb11b346 Use bool
Change-Id: I7b48d8b9e162f9e4447bfcfcc0bbd1158bd35f5b
2014-01-10 17:11:49 +01:00
6eeee04bad WildCard::ImpMatch should return bool
Change-Id: Ib851cbe072bca0d594440cc28164e112d0fe37cb
2014-01-10 17:11:49 +01:00
fd30e4a17a Use proper bool operations
Change-Id: Ie02ec90ec8c95e6552f0c8f7344b3a6dbfca84ea
2014-01-10 17:11:49 +01:00
de84529b55 Clang plugin to re-write SvStream operator<< to non-overloaded methods
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteUInt32.
Note that the rewriter is not perfect, and hand-tweaking the output
is necessary.

Change-Id: I0291c8192ca74d6334ed3cf8cb713212b2f0c67d
Reviewed-on: https://gerrit.libreoffice.org/7307
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:15 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
d6de313b04 STRING_NOTFOUND is no more
Change-Id: Ia8937e07786c497c5cb8485fa161fd68231c17f8
2013-12-04 08:55:36 +02:00
8d7cb7773d Moved 'DateTimeToOString' from 'filter' package to 'tools' package
After the move now other classes can convert DateTime to OString also

Reviewed on:
	https://gerrit.libreoffice.org/6816

Change-Id: I0ceb9a5cc26103a6cb36d7765a717770ec3fbe7d
2013-11-26 14:02:02 +01:00
4c55588cc3 -Werror,-Wshift-sign-overflow
Change-Id: I1ed8f81d52e9792d1511caa41da4ff9163ed0f92
2013-11-14 10:14:56 +01:00
acf93bbc97 remove more pragma instances of GCC system_header
Use "#pragma GCC diagnostic ignored" instead which does not prevent
generation of dependencies.

Change-Id: Ic9034f20ef71c1ee6e5363b73c831142c2813d20
2013-11-14 00:04:16 +01:00
f116128500 implement very simple SvScriptStream to read from process
It inherits from SvStream, so it could be used easily.
Basically, it's just a simple wrapper around
osl_executeProcess_WithRedirectedIO() and osl_readFile().

Change-Id: Ifa225c87d2c9be7e71ea113b0832a4fe83ec65b3
2013-11-13 10:33:18 +01:00
a2505ae731 SAL_WARN_UNUSED INetURLObject
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11 16:50:05 +01:00
b43343b0e7 fdo#65108 inter-module includes <> include/tools
Change-Id: I5f44f041e465230d10d562e8bd6f141848465e07
2013-11-09 18:48:48 -06:00
669128178f Make INetURLObject-from-OUString ctor explicit
...and clean up call sites.

Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-08 16:05:24 +01:00
48d4fa594e convert INetMIMEOutputSink::write from xub_StrLen to sal_Int32
Change-Id: I923a6cb4ee6641c9a289e28c32f431ba6c38d5dc
2013-11-06 08:51:23 +02:00
d22cf7e932 presumably this was intended as include guard
remove it, as it's nonsense

Change-Id: Id8171b81d42dfd3d391b7c5e6602d9271b6697c7
2013-11-05 09:28:54 +01:00
4e0670b763 fixincludeguards.sh: include/{toolkit,tools}
Change-Id: I5572c320431222be2405f8c2dc8adeafe4f3828b
2013-10-23 23:22:29 +02:00
bcc31e249f Simplify SVLIBRARY
Change-Id: Ib1c3cdca7652f5621ba79b1e3590a9241021c389
2013-10-22 23:49:06 +02:00
7e322f2d78 drop unused StringCompare
Change-Id: I09a350dbd35a04f737d360bff7804dab74fdce82
2013-10-22 18:27:58 +01:00
b37e2dd071 Resolves: fdo#38838 remove UniString
hammer silver nails into coffin and bury in concrete

Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-22 12:50:48 +01:00
b2e954e300 Related: fdo#38838 remove UniString::UniString(const ResId&)
Change-Id: Id881fe3f9c7c89a7bcc1a5d8f653e18494ffa913
2013-10-22 09:14:19 +01:00
cfda947d7c Related: fdo#38838 remove UniString::Copy
Change-Id: I566e3ade54962bbc6ace9b757f79c1b8ed9ffd00
2013-10-21 19:29:17 +01:00
6e03e292e5 Related: fdo#38838 remove a pile of ctors
Change-Id: I5d19eadc3dc24b0aeeb61c677f440eef83af78c2
2013-10-21 14:26:33 +01:00
958f7b512c drop CharSet typedef
Change-Id: Ia160d7cbaa2ee71773483c3f91306f89cdad5947
2013-10-21 14:26:31 +01:00
d486b2b324 Related: fdo#38838 remove/privatize String::Append
Change-Id: I5ae90b02e7ae5ddd19495fd0847b7e9dfc4419e8
2013-10-21 11:25:00 +01:00
48bb54aa7e Related: fdo#38838 remove String::Insert
Change-Id: I37e35b5a16d37b1fccc6aa47f5027ff406c67d98
2013-10-21 09:17:32 +01:00
9e6917c21e Related: fdo#38838 remove String::ToInt32
Change-Id: I6f90e9a06acaa5af88cd011015938dba2059ee0e
2013-10-21 09:17:32 +01:00
3714051f14 Related: fdo#38838 remove String::[G|S]etChar
Change-Id: I64711aa3e6580eff7c64a92243e3161ef2d7cb9e
2013-10-21 09:17:31 +01:00
9be876cd06 Related: fdo#38838 remove non OUString ::Append
Change-Id: I084ce5c4833964018849617632a1308dc74adda3
2013-10-21 09:17:31 +01:00
b42f8b451e STRING_MATCH now unused
Change-Id: Ieb0364d275d052a6d6d0b1398f8cf16145ff948d
2013-10-20 19:00:37 +01:00