Commit Graph

71 Commits

Author SHA1 Message Date
8b34d05cb1 sal_Bool->bool
Change-Id: Iab0165ef642dfee5bd315fc1f42f4bad8e86aa47
2014-02-14 14:15:15 +02:00
f44024d1a0 sal_Bool->bool
Change-Id: Iadc9f9ef444fe36d58304c2d6219021173385118
2014-02-14 14:15:15 +02:00
fd3c9e16e1 sal_Bool->bool
Change-Id: Ia453c7868e030e3f10a7f69c1e2d28244758fdef
2014-02-14 14:15:14 +02:00
83055835b1 fdo#74112 Preserve Chart displayunits properties during ODF import/export.
Change-Id: I38508b71ee5b3b966e1d36b0d253304fe17c0ec0
Reviewed-on: https://gerrit.libreoffice.org/7721
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-11 23:23:40 +00:00
cdddbf1991 coverity#1079007 Uncaught exception
Change-Id: Ic4b1805809aa0a2a78007d5808fd8ae6097b080f
2014-02-10 11:21:13 +00:00
feae30c4ce ODF export/import: text vertical adjustment attribute of text frames
ODF standard handle 'textarea-vertical-align' as a
'graphic-property' which "specifies formatting
properties for chart, draw, graphic, and frame elements".
So this change fit to the standard.

Change-Id: I956f512953380983c2c882e943178335fd4dbfeb
2014-02-08 02:59:50 +01:00
a4285867cd Typo: atribute(s) -> attribute(s)
Change-Id: I5434402e372c4567b2c3f96f5c175618ba3e5cfb
2014-02-06 21:32:04 +01:00
258e6f93e8 Resolves: #i124143# for draw:frame containing multiple draw:image...
and draw:glue-point it is necessary to move the GluePoints from the last
draw:image where they were automatically imported to the surviving one if these
are different

(cherry picked from commit c011af1087411a9bacd29cd479c807e698b2e92c)

Conflicts:
	xmloff/inc/xmloff/xmlictxt.hxx
	xmloff/source/core/xmlmultiimagehelper.cxx
	xmloff/source/draw/ximpshap.cxx
	xmloff/source/draw/ximpshap.hxx

Change-Id: I8f6c875767e9cbfee74838742401356df002b051
2014-02-05 11:36:35 +00:00
0b20f01a88 swpagerelsize: implement ODF import/export
Export rel-height-rel / rel-width-rel only in case rel-height /
rel-width is non-zero, though.

Change-Id: I36120cbd8679ac4fc072d1e7cf4dfc024836b5ac
2014-01-30 11:52:11 +01:00
fa189d7447 bool improvements
Change-Id: I238ab0ebe54cc804c85356a3de9fbdcc396057d3
2014-01-28 20:26:18 +01:00
b663316e83 Resolves: fdo#73355 reconcile legacy path bug detection
reconcile
 "223f6b631c1b087754c0f9051fb55f029f2503ce
    Resolves: #i123433# Detect pseudo-vertices at svg import..."
with
 "7a19798c73fd39d8d69ff6364f0696e68cdd1381"
    Compatibility option for incorrect relative moves after closePath (fdo#47406)
and
 "a2ee8055e9c136923f0244fe289cac6377933c31"
    Fix fdo#47406 incorrect relative moves after closePath

Change-Id: I1221099a40500aeb4165a3350d8ae2df1fd3111b
2014-01-24 12:56:09 +00:00
9f76437548 Removed unused solar.h reference
Change-Id: I1ff7d4bad068a8bc8cdc7f27dbfaee199d0f2e5f
Reviewed-on: https://gerrit.libreoffice.org/7513
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20 21:32:27 +00:00
5f9d7ab963 Resolves: #i123457# suppress import and export of hyperlinks without an URL
(cherry picked from commit 71d322a8ce0f5f5cbfd66fd689ff10b3490c1ee4)

Conflicts:
	include/xmloff/xmlexp.hxx
	xmloff/source/core/xmlexp.cxx
	xmloff/source/text/txtparae.cxx
	xmloff/source/text/txtparai.cxx

Change-Id: Ie8291c93c86815cab68482b35a5e88a3bd9b731e
2014-01-16 10:53:05 +00:00
2054af83fe fdo#72520 : Added property to store external data path in chart.
-  added new property entry to store xlsx external data for chart.

Change-Id: I3695865ad7e888359d1048e9bc380cba26108636
Reviewed-on: https://gerrit.libreoffice.org/7212
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-16 01:46:40 +00:00
0c9d002ecd bool improvements
Change-Id: I42127c096aa4310e3c8b6c9b6487b4de63e7ac9a
2014-01-14 21:28:09 +01:00
fc561bcdf7 xmloff: unused define
Change-Id: I77d072b3b6b9b7d86e6279a5cae3d96a21827eb2
2014-01-09 18:22:24 +01:00
6e12fb3be3 Consolidate XServiceInfo for classes derived from SvXMLImport
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
2014-01-09 10:12:19 +01:00
31911b3cdc Consolidate XServiceInfo for classes derived from SvXMLExport
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2014-01-08 14:11:58 +01:00
ebc1b2fe50 added bool bForExport parameter to XMLPropertySetMapper ctor
Set to true for export, false for import. If export true, an
XMLPropertyMapEntry with mbImportOnly==true is not added to the
mappings. This to be able to have more than one mappings for import
(for example a current extension namespace and the future namespace
proposed to the ODF-TC, or corrected typos in element or attribute
names), but map only to one entry on export, of course.

Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-12-20 03:26:57 +01:00
9dd7ee88bd prepared XMLPropertyMapEntry with mbImportOnly flag
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5
2013-12-20 03:26:56 +01:00
44b4973fbd just beautify this a little
Change-Id: Ibd7da12d88ec8e965f652499f7e7e32f81bd8ccc
2013-12-20 03:26:54 +01:00
dd902b8e25 reordered member variables for 4 byte alignment
Change-Id: Iaae7689d1ed3c74e261fcc90fa88b5521468e376
2013-12-20 03:26:53 +01:00
0fea9cbe18 Add new XML tokens for ODS, for calc data stream import & export.
Change-Id: I3b86a53a3fcbac8eab56a74c5c636e0ce0cb13e5
2013-12-19 15:33:08 -05:00
20bb1e6854 fdo#72304 Preserve Chart data table properties during ODF import/export.
Change-Id: I767bb32fdaddcaf742923055cc86bb19138b42be
2013-12-19 03:55:05 +01:00
58b46086e6 Remove unused SvXMLExport::mbEnableExperimentalOdfExport.
Change-Id: Ib2dbc4af73394c9c35a7f273fd8966b91ac3eb84
2013-12-11 17:54:55 +01:00
6e89666b4e write the correct 'sort-ascending' value, fdo#72548
... for <table:content-validation table:display-list='sort-ascending' ...>

Change-Id: I57d35cd08e3fce4eff5d571a19bb8793fde4a201
2013-12-10 11:56:51 +01:00
895e6e7bb7 Get rid of comphelper::UStringLess
...default std::less<OUString> is just fine.

Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05 18:36:22 +01:00
0c55303581 Get rid of DECLARE_STL_STDKEY_SET
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
2013-12-05 18:36:21 +01:00
2b243ba51e Support regression curve name in ODF.
Change-Id: Ic065d63eee507906febfa15eb6d5ae1e7de58280
2013-11-24 19:43:17 +01:00
f0a9ca24fd rhbz#887420 Implement "block untrusted referer links" feature
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks
configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and
SvxBrushItem::GetGraphicObject.  Checking in additional places will probably be
necessary to block /all/ unwanted communication.  Also, some places marked
/*TODO?*/ currently pass in an empty referer (which is always considered
trusted) and will probably need to be adapted.

Ideally, Referer URIs would never be empty (and consistently use something like
<private:user> for cases where access is explicitly initiated by the user and
should never be blocked), but that's a very daunting task, so start small by
identifying the places that potentially need blocking and adding appropriate
Referer URIs there.  Also, Referer information should always be computed as
freshly as possible from the context in which an access attempt is made, but,
again, always carrying the information from the context all the way to the
relevant functions is a very daunting task, so for now store the information
upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...).

The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already
used to track macro execution, and there is one place in
SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked
by the user) is done that needs the current document's URI as Referer to check
execution of macro URIs but needs an empty (or <private:user>, see above)
Referer to not block non-macro URIs.  Special code has been added there to
handle that.

Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14 11:13:25 +01:00
5ce50b8d17 Respect svg:font-face-format element.
Call libeot to parse font if value "embedded-opentype" is found.

Change-Id: I03a072fd4db47d151a3934e959ad17c1e24fcf09
Reviewed-on: https://gerrit.libreoffice.org/6144
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-13 14:37:53 +00:00
d6fec4ba5d fdo#65108 inter-module includes <> include/xmloff
Change-Id: I1d2da1dd3c82e95b8ad4883ce83b42f6dcb6200f
2013-11-09 18:48:45 -06:00
8b8ef8d633 Remove the xmloff::token::ResetTokens race condition
...where multiple parallel calls to xmloff::token::ResetTokens or
xmloff::token::GetXMLToken can see dangling pOUString pointers.  There is no
point in releasing this (bounded) amount of memory referenced from global
aTokenList, anyway.

There is still a race when parallel calls to xmloff::token::GetXMLToken write to
a pOUString pointer in parallel, but that's more harmless, and maybe calls to
GetXMLToken are synchronized by Solar Mutex?  Calls to ResetTokens (e.g., via
URP remote release request -> ~ScXMLExport -> ~SvXMLExport) were definitely
/not/ synchronized via any mutex.

The xmloff::token::Inc/DecRescheduleCount functions are now pointless and have
been removed, too.

Change-Id: I85905d4de1f042ed5c9a37589f942910d8ef80fd
2013-10-31 12:45:04 +01:00
b95ee1be9b fixincludeguards.sh: include/xml*
Change-Id: Iffab819621615c59709c087202cc578af00dd799
2013-10-23 23:22:28 +02:00
db9d9c1277 Bin some pointless comments
Change-Id: Ia7c5b1654f3decc549b363c4443863f40c3f26e6
2013-10-22 22:56:43 +03:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
94755bd8f2 Combine a pointlessly split class implementation and bin unused private field
Change-Id: I44cee32e256e0767bb3b40bdba93e15b717c9ba6
2013-10-13 14:36:21 +03:00
d87cb77b42 Resolves: fdo#68431 style:font-name unknown in non autostyles in impress/draw
Change-Id: Ib904af4fac5659821ba3b5dbbf62370df8243001
Reviewed-on: https://gerrit.libreoffice.org/5810
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-17 19:17:34 +00:00
0825d0cb76 sal_Bool to bool
Change-Id: Id32780e5cb565e85f0366a91282ce085ed7d2f3c
2013-09-16 15:08:18 +02:00
b69d152cfa fdo#68839: ODF import: fix name of multi-image frame
When multiple image child elements are inside a frame, each one is
imported and gets unique name via SwDoc::SetFlyName().  But the
retained one is not necessarily the first one, which is the only one
that may have the original name.

Also the solveMultipleImages needs to return a smart pointer, as nothing
else keeps the image contexts alive.

(regression from 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70)

Change-Id: I28a8a752f3eed176cc2ebb4c9af11a0dd4d18ea6
2013-09-03 00:54:14 +02:00
fa94ca9a84 ODF export/import of fine dashed border style
Change-Id: Ia81385dd9952e90cd5ebb3d1bba38aff6f84d079
2013-08-23 21:01:38 +02:00
21661ebfbe fdo#60740: Populate auto styles from edit cells without using UNO API.
Not using UNO API here alone made this code fly.

Change-Id: Ib3eff168bbe49e49fb413909b7a14057f808cdf9
2013-08-21 19:24:04 -04:00
dfee01afdf this Find is not actually implemented
Change-Id: I0d8e8903bdc5943079c6ed9f123e2fca2f72467f
2013-08-20 11:37:58 +01:00
47e24bfed8 CharBrd 8.1: ODF filters
Change-Id: Ib1a79678ffce7764638378b4002f5e87ae749d00
2013-08-18 09:49:49 +02:00
7c02faf535 Properly hide implementation details.
If we are to hide, let's hide all.

Change-Id: Ic68926ee099ac80d2d477d68e3769a7203dfea6c
2013-08-16 21:31:44 -04:00
643db96e93 add character shading value to ODT filters
The attribute is only exported for ODF versions > 1.2; use the new
loext (LO_EXT) namespace.

Change-Id: Ie44e4b851c4adf52d8cc4fc2cbe37d6c3a9941d8
Reviewed-on: https://gerrit.libreoffice.org/4830
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-14 16:03:07 +00:00
de9b067bd1 xmloff: add a generic LibreOffice ODF extension namespace
XML_NAMESPACE_LO_EXT can be used for elements and attributes that are
not yet specified by OpenDocument.

Change-Id: Id29392533d46f6592d964ce79c05ffefa4d69ebc
Reviewed-on: https://gerrit.libreoffice.org/5419
Tested-by: Thorsten Behrens <tbehrens@suse.com>
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-14 16:02:07 +00:00
a1190c9d2e fix reading fonts from .odp using style::font-name (fdo#65338)
b40bcde076f9fabf24810d2520e878d604d99637 made writing .odp use style:font-name
and office:font-face-decls, instead of using fo:font-family . But the reading
back was broken, as xFontDecls is not set
in XMLTextImportPropertyMapper::handleSpecialItem(), so the font data was
ignored. And xFontDecls was not set because it's set while reading
office:font-face-decls, which is at the top of the xml document, but even
before the xml is parsed, the call to SdXMLImport::setTargetDocument() calls
GetShapeImport(), which creates XMLShapeImportHelper instance, which calls
XMLTextImportHelper::CreateParaExtPropMapper(), and XMLTextImportPropertyMapper
is created with rImport.GetFontDecls() still being NULL at that point.

And it actually doesn't seem to make any sense to just pass around all
the pointers to XMLFontStylesContext, as eventually it's always just the one
from SvXMLImport. So simply dump all that and make the one single place
that actually uses it (i.e. XMLTextImportPropertyMapper::handleSpecialItem())
refer directly to SvXMLImport::GetFontDecls().

Change-Id: Ib1b3e4b1bcaf87ca3e4703d1cc1563ad6b3f9ce7
2013-07-10 17:35:27 +02:00
4935422b41 read/write ODF *:script* and *:rfc-language-tag*
This prepares to be able to read/write the attributes, it does not
enable proper handling of unknown language tags yet. An unknown tag
usually falls back to SYSTEM locale.

Change-Id: I4a78e8fd37deae188c69570157bc4589a712bc7a
2013-07-09 15:52:21 +02:00
9f1c9edb7a added rfc-language-tag* tokens
Change-Id: Ifef5ebf638863f4b0fa6f985ad2e84359b75b708
2013-07-05 12:46:47 +02:00