Commit Graph

9 Commits

Author SHA1 Message Date
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
fa2a7c1c95 Keep using component_getImplementationEnvironment in extensions
...instead of relying on the implicit CPPU_CURRENT_LANGUAGE_BINDING_NAME
convention.  Keeping that convention an implementation detail makes it easier to
do improvements in the future.  (Theoretically, the bundled extension in mysqlc
could be considered internal code and not adapted, but just be safe.)

Change-Id: Iae41a6e072dabc2bf7c1481ba6cfed61680edf37
2013-12-17 11:05:59 +01:00
f8b2265419 remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL calls
Convert code like:
    defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) );
to:
    defaultValue.startsWith( "nextval(" );

Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
2013-11-20 13:56:09 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
da5449da0c fdo#54938: More uses of cppu::supportsService
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d
Reviewed-on: https://gerrit.libreoffice.org/6423
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-25 08:07:04 +00:00
3af0114a29 Introduce O[U]String::toUInt32
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39
"Handle oveflow in O(U)String::toInt() functions" reduces values in the range
(SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied
on getting a correct (unsigned) value for the whole input range ["0" ..
"FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3
"Revert overflow checks in O[U]String::toInt{32,64} again").

Audited all uses of toInt32/64 with non-decimal radix.  (There is still a TODO
comment in oox/source/helper/attributelist.cxx, and
stoc/source/typeconv/convert.cxx will still need some love and test code.)

Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-06-13 17:08:36 +02:00
dca437578e Custom Panel SDK Example Fixes
- Remove unused boost header
- OUT_DEPLOY_URL must be an URL

Both break building the example on Windows

(cherry picked from commit 8af699cb89d9477b13d8701266b7c1fdf9356cfa)

Change-Id: Iedc1b1d6d9493390cdf8b9055afe7c712c6bfc31
2013-05-12 16:11:58 +01:00
b30c970602 Make Custom Panel example build and run
(cherry picked from commit 5aff353f227ecfeb36ef6b8be787495916610490)

Conflicts:
	odk/examples/cpp/custompanel/ctp_factory.cxx
	odk/examples/cpp/custompanel/ctp_services.cxx

Change-Id: I5b561fec12415b2c05ff1369629a8f88b420510b
2013-05-12 16:11:53 +01:00
379c701115 Move Custom Panel example to the SDK
(cherry picked from commit d0b30a0f10f506187fcff9775934d3594c140ead)

Change-Id: I898433cbdf9f779f425424d600ebb4f0946ccf20
2013-05-12 16:11:50 +01:00