Commit Graph

1565 Commits

Author SHA1 Message Date
662283db76 coverity#735810 Dereference after null check
Change-Id: I005ae6bf505fd2131c06e889f9fc3c12dae23c64
2014-02-24 12:53:09 +00:00
a53577e6ff Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I55292f5f0049e7c77d5bb0e5ef5fa187b815d159
2014-02-24 10:20:51 +09:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
b7180bd14f editeng: sal_Bool->bool
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21 12:19:24 +02:00
2bcd18892f fdo#72041: Intern strings in the external ref cache with the host document.
To ensure that string comparison with those from the external ref cache
works correctly in functions such as VLOOKUP.

Change-Id: Ib5a466cb6c4b26439abe61b0c17406fc8139f6c0
2014-02-20 16:09:01 -05:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
aecb68988b coverity#738803 Uninitialized scalar field
Change-Id: Id24edb82d99d576435a8f310bfaf8521a77f97b3
2014-02-19 20:36:39 +00:00
47f3b22854 sal_Bool->bool
Change-Id: I6c926b0b4dabd8c1dc0927f46ff76ff53d55920f
2014-02-19 13:05:10 +02:00
1118979789 sal_Bool->bool
Change-Id: I7e37926fc1e69da2b192a60df3b54807243c646f
2014-02-19 13:05:10 +02:00
53516e9c76 sal_Bool->bool
Change-Id: I857b81ea1eea27554980ca7c7a9f771d6aa7db61
2014-02-19 13:05:05 +02:00
a5d262df1a sal_Bool->bool
Change-Id: I2d5ee332adea2e7727717473e74288b9e59f4aa0
2014-02-19 13:05:05 +02:00
7e55f69c01 sal_Bool->bool
Change-Id: I243d12c71ffc532585e55eef9c8e3e7eef032be6
2014-02-19 13:05:02 +02:00
c8c118bee0 sal_Bool->bool
Change-Id: Ie96737c3e6d354bcdd82b2539f6b62eab65565fa
2014-02-19 13:05:01 +02:00
651d68fd47 sal_Bool->bool
Change-Id: Ieaaf39833367de54973163cae581e69292bd26e7
2014-02-19 13:05:01 +02:00
e23b79e4fb sal_Bool->bool, and remove unused parameters
Change-Id: I55a07cbcb7f388143f115d35b20daea96d1bed5d
2014-02-19 13:05:00 +02:00
d858c06847 sal_Bool->bool
Change-Id: I779608850fc81518c130e6f23d5dd1599a59fa14
2014-02-18 10:07:58 +02:00
d5cca704f5 sal_Bool->bool, and remove some virtual modifiers
none of these methods are being override anywhere, so remove
the virtual modifiers.

Change-Id: I84fa4211418b7eae38b60964b076ecd73013513a
2014-02-18 10:07:58 +02:00
a21ecc1611 sal_Bool->bool
Change-Id: I8a94c5f44645d3ef03f231fe7b38c7e5637f8c09
2014-02-18 10:07:54 +02:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
f242aa85ef sal_Bool->bool
Change-Id: I854458cb6f34976a275d479bb5d01548f7e464fd
2014-02-14 14:15:06 +02:00
3641863b57 sal_Bool->bool
Change-Id: Ic33d67ddb391c983c299b09c8a4274fc40921505
2014-02-14 14:15:04 +02:00
604426cc41 convert change chart data source dialog to .ui
Change-Id: Iecccfbcd6b1eaec9d14c594812293c3e2acfda46
2014-02-11 20:21:52 +00:00
2ec3127da3 Ensure that vector array has a numeric array of NaN's for empty range.
With this change, we ensure that mpNumArray is never NULL even when the
range consists entirely of empty cells.  For an empty range, mpNumArray
will be non-NULL and filled with NaN's while mpStrArray will be NULL.

Change-Id: If5cead26ebe917af150cf7e39e17afe3f310beb7
2014-02-11 15:12:21 -05:00
f39cf7f5b2 loplugin:implicitboolconversion, loplugin:literaltoboolconversion
Change-Id: I5cd55c9e65a4ac431642ba33da9daf0e2f6a194c
2014-02-10 14:08:54 +01:00
ec3c9a5f7f sal_Bool->bool
Change-Id: I1b45ccb419ce827ca9ddb475e67878c95d67d36d
2014-02-10 11:27:18 +02:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
e401b9c824 convert scenario dialog to .ui
Change-Id: I66f7fe04155ad4c6e42e6aa96bb2db71ba4f682f
2014-02-05 11:36:35 +00:00
3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
f74c0a42b0 Add RowHeightContext to stuff all parameters for SetOptimalHeights().
To help reduce the number of function arguments.

Change-Id: Ic29fff38f6cd844bdaac8ac4b440dfcaba55df61
2014-02-01 20:53:13 -05:00
1c3ce40d97 Translate German comments and fix a few missed one
Change-Id: Ieb5798a98453d0a6b0e368f7444150c758a9c7ac
Reviewed-on: https://gerrit.libreoffice.org/7753
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-31 01:28:07 +00:00
3d869cda8d fdo#74014: Brodcast only when pasting, not during file import.
Change-Id: I7cca5d459491fca782f24093dcdd7d0c1c69bdc9
2014-01-30 17:43:03 -05:00
a0bd814fb5 Speed up filling of random number generation over entire column.
Because nobody wants to wait forever...

Change-Id: Ie52bff944893b7e3fe9e7908be19d27c692fc1ea
2014-01-30 11:57:00 -05:00
19e16083c6 Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30 10:48:25 +01:00
8a36879eaf fdo#74014: More on broadcasting at appropriate places.
Also, call PostDataChanged() to re-paint re-calculated formula cells.

Change-Id: I63161329d4bfe937f754773fd68c37e3836c4950
2014-01-29 15:46:05 -05:00
2e3e1caf0e coverity#1158113 coverity gold, condition reversed
Change-Id: Idb5f82c0e0708c85cac7f984f0273350ca665e27
2014-01-29 13:23:55 +00:00
cc2606a785 bool improvements
Change-Id: I740c0e18eefc64cb5f1da5b88ceb77289790ec37
2014-01-28 20:26:23 +01:00
b477392490 fdo#39468 Translate German comments
Change-Id: I95d10209db3701c2511213c9830191fd5a797889
Reviewed-on: https://gerrit.libreoffice.org/7574
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-24 16:16:30 +00:00
b168814577 bool improvements
Change-Id: I7f814f53f67e2d6dd44013e7f9055ee256ec4811
2014-01-22 08:22:35 +01:00
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
1d7f9ceb1c sal_Bool->bool
Change-Id: Ia39a8e928b68d4e05696e9a664fad28f95b91828
2014-01-20 13:13:51 +02:00
989c7ce9a8 CID#1158211: out-of-bounds access 2014-01-19 19:35:54 +01:00
3e5ff1f8d4 Be explicit when using bool as integral value (as Link return value)
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17 18:45:14 +01:00
b6738a43dd sal_Bool->bool
Change-Id: Ib45e3ffd62eca88afa31b7dd1b8c72499826d84c
2014-01-17 13:43:50 +02:00
bf535c4772 DdeSetData should apparently return bool
Change-Id: Ie0e66ac6c76eabb80340d4c11b60dd7890c6a378
2014-01-15 15:17:15 +01:00
c72a7a6383 DdeGetData should apparently return bool
Change-Id: I603198b9fd2c6fea1c9ec7de09b23c61fe9d603c
2014-01-15 13:58:41 +01:00
3b614521b6 resolved fdo#73522 always create LinkManager if it doesn't exist yet
Regression introduced with 8fde2885236d5490be8f54e96dfe4a63d9bb9dec
Crash happened under ScExternalRefManager::maybeLinkExternalFile()
pLinkMgr->InsertFileLink(). ScDocument::GetLinkManager() introduced
GetDocLinkManager().getLinkManager(bAutoCalc) leading to the LinkManager
being created only if bAutoCalc is set, which may not be the case during
file import. Changed to unconditionally create the LinkManager again so
the link can actually be inserted. Whatever the intention was, that
needs rework.

Change-Id: I2ae66ac7f62c3cfd92c5bf1a147feb06b0155275
2014-01-14 12:52:27 +01:00
7c1415e06f Remove unused bForBrowsing parameter
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
2014-01-14 11:21:10 +01:00
0d0fd7b4fb PrepareClose should probably return bool
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
2014-01-14 09:31:58 +01:00
d4dd5c34db longparas: convert ValidateKashidas to sal_Int32
we can use -1 as the failure return code as return value is always checked and
isolated from the rest of the code.

Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-13 20:35:21 +00:00
b69864f3f8 re-write SvStream operator<< to non-overloaded methods
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:24 +00:00