Commit Graph

1073 Commits

Author SHA1 Message Date
83aa6d8180 Remove some temporaries around calls to SvNumberFormatter methods
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-24 09:08:35 +01:00
c19cb642db Adapt to osl_atomic_inc-/decrement
Change-Id: I848873b07ab05cefdc755a8bf1301907fdfbc299
2014-02-24 08:08:00 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
c4a766db25 coverity#441203 Dereference after null check
Change-Id: I166e9ab8d3693568cc2b6a0ecd7d49532508116b
2014-02-23 03:28:22 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
d13545987a callcatcher: update unused code lists
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18 10:10:01 +00:00
0d3082dbf2 callcatcher: update unused code
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12 13:03:50 +00:00
06d5616f65 svtools: add some missing locks in new code
Change-Id: I6f000fb0f205b437e4ff5238c8ede5735c403077
2014-02-11 12:52:22 +01:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
632c0e14ae convert link database dialog .ui
Change-Id: Ide66c2f088616b1677d03bad9095fa5829c4ffb7
2014-02-04 09:20:58 +00:00
6f50837b5e ensure selected calc sheet tab is always visible, and we use space sensibly.
Change-Id: I0f935f324ba31784185959a4a4d2c306d4b592d8
2014-02-03 22:16:26 +01:00
bd9581d46d bool improvements
Change-Id: I23e29995bc7af791067de4996923b6279f7f8892
2014-01-28 20:24:40 +01:00
604ce7566d coverity#708304 Uninitialized scalar field
Change-Id: If82964036862e309dc1c90036df59942a24fd7d6
2014-01-24 14:02:00 +00:00
3d95457572 Only allow approved border styles in cell borders.
Line styles such as inset, outset, embossed etc are not supportable in Calc.
So, don't show them in the UI.

Change-Id: Ie7be74193d01e13a79132a979e2d9a2e4d06de3f
2014-01-22 19:58:32 -05:00
2e10f314d0 boradcast->broadcast
Change-Id: I96720843f815bf6d499eb424c3e4ff579c2bbe23
2014-01-21 15:15:57 +00:00
ec1a3157c1 Better pixelization of dashed lines for screen rendering.
Now the dashed lines are evenly placed on screen.  For now, horizontal lines
only.  I'll work on vertical lines later.

Change-Id: I474e9c8214e5f079ea2cfca12b35381d8fcf2ae1
2014-01-20 14:37:02 -05:00
66ff6924d5 Related: #i56998# use FUNIT_PERCENT on fields that allow relative value
(cherry picked from commit fc6fc5b576b972a8ea0551091cc57aa1cfe1334d)

Conflicts:
	svtools/source/control/ctrlbox.cxx
	svx/source/dialog/relfld.cxx

Change-Id: Ic8f0f550dbbcab0678fbeb9bf45a478b0cea642d
2014-01-20 10:14:29 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
009b7be7c8 Revise the line patterns further. Now they look satisfactory to my eye.
Change-Id: I27f4e11bceac25c10de28a866bdcec9576027582
2014-01-17 11:33:16 -05:00
0a8ddb61b1 Apply dashing without consulting current map unit.
Using scaling is sufficient.

Change-Id: If976bec3940772432d814a77681170d7c99306d2
2014-01-17 11:33:15 -05:00
ba4324917a More fine-tuned stroke patterns.
Only the pixel map mode is visually inspected.

Change-Id: Ia8ac978a0d3049d7e7162f1157822b85d475dfdf
2014-01-17 11:33:13 -05:00
5cdb7a5934 Remove STYLE_* and use css::table::BorderLineStyle instead.
Change-Id: I187511dbf85ecdfe0c5d05c6f77cf4ac93363051
2014-01-17 11:33:11 -05:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
cf51afb026 fdo#54938: Convert svtools to cppu::supportsService...
...final part

Conflicts:
	svtools/source/filter/SvFilterOptionsDialog.cxx

Change-Id: Ie4a0a7ea8ec65b3e632d06627bba40a26c9a7a91
2014-01-16 10:24:56 +01:00
04d711e757 remove _STRING_HXX gibberesh
Change-Id: I618aa9a2752014d392516a578e454bf6443fc6ba
2014-01-13 20:35:20 +00:00
680a5290a0 Use proper bool operations
Change-Id: I758a84205044e51f1af6b18f145e2033f32921e1
2014-01-10 17:11:52 +01:00
347af397ca translated german comments
Reviewed on:
	https://gerrit.libreoffice.org/7275

Change-Id: I86fef5ab012c7c464271afec3a0a5fa4d3c72f31
2014-01-07 08:42:55 +01:00
455b403aaf translated German comments
Change-Id: I75c7611c36c15fb36e00de239f5b322adb182e73
Reviewed-on: https://gerrit.libreoffice.org/7273
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-05 19:06:44 +00:00
3982ce50f9 svt: All files are compiled with enabled exception handling.
So, merge these files.

Change-Id: Icc8e221a40c70dc24a9fb048e06cf4fe7635fd02
2013-12-23 10:28:38 +01:00
4c539fac01 vcl get rid of xub_StrLen and STRING_LEN in outdev3
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)

Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-18 01:54:16 +00:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
b273106226 convert OutputDevice::HasGlyphs from xub_StrLen->sal_Int32
Change-Id: Ic8f0ae3d263d6cb02e6faa7226db0241681fc45f
2013-12-04 11:29:14 +02:00
3b2f956ba6 Drop duplicate #include
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-12-02 01:02:06 +09:00
396dd770eb WaE: unused variables
Change-Id: I65fdfbba7e56d16554790f001bda818dd9f1d335
2013-11-25 22:57:01 +02:00
b755fb8c0f Integrate branch of IAccessible2
Change-Id: I3b5936bb92bb258f9e9e76402dd2b55f29aa686a
2013-11-25 16:52:36 +00:00
a5b4c3dc73 wrong border extraction mechanism
Change-Id: I70925b9e8f5eb0e735200e2f57a892ada9fad379
2013-11-20 12:51:13 +00:00
912d6d1716 fdo#65355 Ruler Comment control doesn't disappears
ImplDraw() should not be directly called because it avoids
overriden Paint() method.

Change-Id: I0f0f6b4af231c1ea50a23fb96f3c9018b5ce2d31
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/6707
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20 05:32:03 -06:00
19956d09e0 Convert chart axis scale tab page to widget UI.
Obs:
-Several widget positioning methods turned useless and were deleted
-Corner case related to axis origin untested (couldn't find where it is used)

Change-Id: I6a563c89ddcfbff62494ce7726f3e7d6089e6b57
Reviewed-on: https://gerrit.libreoffice.org/6730
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20 04:27:45 -06:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
ab5d1fbfb4 SAL_WARN_UNUSED com::sun::uno::Any
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
2d2e1267be xub_StrLen->sal_Int32
Change-Id: Ia17762919b57bc6febed5cc49e8931165870c117
2013-11-13 13:50:37 +00:00
a2505ae731 SAL_WARN_UNUSED INetURLObject
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11 16:50:05 +01:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
dd28837249 vcl: mark more Image constructors as "explicit"
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
91e181ea58 remove uses of COMPARE_*
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-21 14:26:32 +01:00
051731bbca post String conversion cleanup
Change-Id: I9747817edc76973af4a4ffdbf542b8d1467d7f08
2013-10-21 03:08:26 +02:00
e5dd19526f make font style size stable on switching fonts
Change-Id: I891fa5b9b8bd3be7dd4d73f2911ec56d16a3b09f
2013-10-07 11:46:59 +01:00
4df8a0ce1d Ruler: don't draw ticks out of the ruler area
Change-Id: I086e812b0db60fed094d21d2ba5aac1b9943e0d5
2013-10-06 13:09:09 +02:00