130a2baa83
error: enumeral and non-enumeral type in conditional expression
...
Change-Id: I30293ac22fb26e0f7c9bfd335ccaa9a2d263d02f
2014-02-24 12:28:18 +01:00
33740b7d5a
Replace exisiting TriState, AutoState with more generic TriState
...
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
146c7c5c89
toolkit: sal_Bool -> bool
...
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24 11:13:42 +01:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
02c17c1dd3
coverity#738917 Uninitialized scalar field
...
Change-Id: I6d1b6e201f3ec57c727e93ff69a212c8138998d6
2014-02-18 15:18:10 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
5b70503620
bool improvements
...
Change-Id: I27174aeadb37e56c701c46fe7f97853b98ba7333
2014-01-28 20:26:17 +01:00
478ec0126b
This has always only converted the condition of ?: to long
...
...not the resulting value, and seems unnecessary anyway.
Change-Id: I8c58b180af2bd36f2c3dbcad888c3dd0b9e4c87d
2014-01-28 18:31:05 +01:00
03cc76aad3
fdo#54938 Convert toolkit to cppu::supportsService
...
Change-Id: I3a35a86d9ad9419011f0305fdc41c8484ae63a04
Reviewed-on: https://gerrit.libreoffice.org/7646
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-01-25 16:14:15 +00:00
e515b8b121
tk: Constructor feature for last tk_ implementations.
...
Change-Id: I55fee30e64cdb591d73cfcadfd7a9efb10485ba9
2014-01-24 12:21:25 +01:00
b7e51c2077
tk: Ctor feature for the rest of dialogcontrol.cxx classes.
...
Change-Id: Ic96abfe99112b78244e4318aed5b36b5af1dd679
2014-01-24 12:21:24 +01:00
cbdc2cfc1a
tk: Ctor feature for UnoControlContainer(Model).
...
Change-Id: I7f0e457eaf5057d325226633936e544ace1f1620
2014-01-24 12:21:23 +01:00
60ec73ddea
tk: Ctor feature for UnoScrollBarControl(Model).
...
Change-Id: Ie37b81de21764186ab2ee9b19ac04d801880d2f9
2014-01-24 12:21:22 +01:00
68694f360f
tk: Ctor feature for StdTabController(Model).
...
Change-Id: I3792b8b4d240c212d332c676d53eaa1f5dca3902
2014-01-24 12:21:22 +01:00
472b283666
tk: Ctor feature for toolkit::(UnoControlRoadmapModel|UnoRoadmapControl).
...
Change-Id: Ic748e90e96285c394a3a2ac30ad1090b91ede160
2014-01-24 12:21:22 +01:00
e626b730df
tk: Constructor feature for MutableTreeDataModel.
...
Change-Id: I9cd12e3bdfc20d4305e3daec6d0a6cffa599e000
2014-01-24 12:21:21 +01:00
671ddc6f21
tk: Constructor feature for UnoSpinButton(Control|Model).
...
Change-Id: If01abff3f07b4b79247e8ee7100f2c34c46c001a
2014-01-23 23:39:15 +01:00
334248a08a
tk: Constructor feature for unocontrols.cxx.
...
Change-Id: Ia7bae618724f3d16774a3a7794d0ae59fb79cfc6
2014-01-23 23:39:14 +01:00
dec6d3e935
tk: Constructor feature for OGeometryControlModel<UnoControlDialogModel>.
...
Change-Id: I9afc83610ccc06ea090a10588fb8240159715197
2014-01-23 23:39:13 +01:00
6dbff3aae9
typo: wrong name
...
Change-Id: I7e041add4adc0f84dd7d9d9d74ccaf80ecc57776
2014-01-23 23:39:12 +01:00
11f63d1a61
tk: Constructor feature for UnoTree(Control|Model).
...
Change-Id: I83a9e621199b15672cd680e847d78dfb11437885
2014-01-23 23:39:11 +01:00
2bc11eb5f4
tk: Constructor feature for DefaultGridColumnModel.
...
Change-Id: Ia4d20eb2a3c91fbdb1dd85c37b8162c6856d0f28
2014-01-23 23:39:10 +01:00
a9f94e571c
tk: Constructor feature for DefaultGridColumnModel.
...
Change-Id: Id790c7af17b4b38de889a44ba1258dd1020054e3
2014-01-23 23:39:09 +01:00
8c04ab3dfe
tk: Constructor feature for DefaultGridDataModel.
...
Change-Id: I6ceb170d4aeb2d8339b96c74631ae61ca1950e76
2014-01-23 23:39:08 +01:00
4b36dcefe5
tk: Constructor feature for toolkit::GridColumn.
...
Change-Id: I6eec5539fe36328ea30d08d611b3dfeffc56808b
2014-01-23 23:39:06 +01:00
624b7e586d
tk: Constructor feature for SortableGridDataModel.
...
Change-Id: Ife0a9c58fd489550a17fce48e97c63ec94997234
2014-01-23 23:39:05 +01:00
d18a042815
tk: Constructor feature for toolkit::UnoGrid(Control|Model).
...
Change-Id: Ic512b0b1209d77e32bb4e37ce7fde8dd726e16cf
2014-01-23 23:39:04 +01:00
08d10512b4
tk: Constructor feature for UnoControlTabPageContainer(Model).
...
Change-Id: I0e32eb49235a1769f8dacc1af95ee863ee514621
2014-01-23 23:39:02 +01:00
badc48eb75
tk: Constructor feature for UnoControlTabPage(Model).
...
Change-Id: I7e6955c2d09e1860885f8e2eaa347332421c1c69
2014-01-23 23:39:00 +01:00
3b40356e84
tk: Constructor feature for AnimatedImagesControl(Model).
...
Change-Id: I44a398a16d61796b48ecd212832252f23c063ace
2014-01-23 23:38:59 +01:00
574f963fad
tk: Constructor feature for SpinningProgressControlModel.
...
Change-Id: I137cebba9743f6d703412d6d6f8a39d47d01738d
2014-01-23 23:38:58 +01:00
2c5b0bb345
Avoid code mixing bool with other integral types
...
Change-Id: Idf75d03a302df977a41f688eb48e40de31ff2816
2014-01-10 17:11:43 +01:00
1c80f3ab5c
Resolves: #i120358# apply patch to support properties from tab model
...
Patch By: hanya
Review By: jsc
(cherry picked from commit aa098b9e612b30a916cd4ce002133d499d7f711a)
Conflicts:
include/toolkit/controls/controlmodelcontainerbase.hxx
Change-Id: I4c038c08d24ceceba606154573abbb1cd41cf7cb
2013-12-20 15:26:15 +00:00
8233226fe4
No need for implbase1.hxx to include XComponentContext.hpp
...
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
c5b7a5fd19
fix equalsAscii conversion. Noticed in fdo#72391
...
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-09 12:53:18 +02:00
b0926378ac
Clean up includes of comphelper/stl_types.hxx
...
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
c78f7d85ab
Get rid of DECLARE_STL_MAP
...
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
2013-12-06 10:37:50 +01:00
363cc39717
convert equalsAsciiL calls to startWith calls where possible
...
Simplify code like:
aStr.equalsAsciiL( "%", 1 )
to
aStr.startsWith( "%" )
Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
0a9ef5a18e
convert OUString 0==compareToAscii to equalsAscii
...
Convert code like:
0 == aStr.compareToAscii("XXX")
to
aStr.equalsAscii("XXX")
which is both clearer and faster.
Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
bcb51cff22
fdo#63020: Replace ::comphelper::stl_begin()...
...
And use some templates inside include/com/sun/star/uno/Sequence.hxx
Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-11-07 10:43:34 -06:00
5d7bf132bd
remove unnecessary use of OUString constructor in TOOLKIT module
...
Change-Id: I0cc8c507ede20d5db1942b75e0c4b660dcd66c97
2013-11-07 14:27:06 +02:00
ee5661ecd3
fdo#54938: Adapt supportsService implementations..
...
to cppu::supportsService
Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-22 10:28:10 +00:00
da21e9de6a
require OAccessibleContextHelper to be initialized with SolarMutex
...
OAccessibleContextHelper methods are locked by OExternalLockGuard
which effectively only locks its ExternalMutex (i.e. SolarMutex);
so ensure that all sub-classes actually pass in a SolarMutex
by removing the default constructor.
(since these classes are in comphelper they can only use the
SolarMutex indirectly)
This uncovers that AccessibleToolPanelDeckTabBarItem and
OAccessibleControlContext did not pass in SolarMutex before.
Change-Id: Ib9085eeee6225f7c74b158e72f04b1bf62622071
2013-10-04 14:46:24 +02:00
78f05c0a65
toolkit: avoid deadlock in UnoControl::setDesignMode()
...
Avoid deadlock by disposing the accesibility context without the Mutex
locked, since it will eventually try to acquire the SolarMutex...
Thread 1 in UnoControl::getPosSize()
calling from sdr::contact::ControlHolder::getPosSize()
Thread 2 calling from UnoControl::setDesignMode()
trying to get SolarMutex in VCLXWindow::disposing()
Change-Id: I7d0ffe4fa0f8cd0c48e9b9b5e923ce229f97ca57
2013-10-02 23:52:44 +02:00
