Commit Graph

2199 Commits

Author SHA1 Message Date
6c2c974dd3 bnc#885825: Handle ODF import and export of data label border properties.
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-26 16:26:09 -04:00
f1531cdaae bnc#885825: Support borders around data labels.
Change-Id: Ib141413e523cbf73746876f727e9f80dda9f5f7c
2014-07-26 16:26:08 -04:00
cc827ab81d Revert "opengl charts: Move the init from sc to chart2 ...
This reverts commit 46cea34638b371570073c0e86f79969753c543ed.

Conflicts:
	chart2/source/view/charttypes/GL3DBarChart.cxx

Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-23 22:19:58 +02:00
c02e393c7d Revert "Fix OpenGL chart reinitializing"
This reverts commit cbc50c90ad63f0e59b8cf3bbfb6b5b1f61db09b9.
2014-07-23 22:19:27 +02:00
88a874fcb3 convert SfxItemState constants to a proper enum
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
2c5f02539d drop DLG_CHART_WIZARD via .res
Change-Id: I394a42bfb761e2f7cf8c3186f5ec412331b5950c
2014-07-23 10:30:25 +01:00
66178fc9dd fdo#81547, part2: show only relevant widgets in layout tabpage
Set initial status of most of the widgets in .ui file to hidden,
*ResourceGroup::showControls() method will take care of showing
them when appropriate

Change-Id: I19d8df661ea7ee122e06ab854a9eb0a5edf62320
2014-07-22 23:22:26 +02:00
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
f413cb08b8 printf crept in.
Change-Id: I18303af0a2898610566233b814e317cd2fe9f6d0
2014-07-22 00:18:40 -04:00
7df0cb37a4 boost::checked_deleter will do.
Change-Id: I952d9dfcffd85aaae49fc1f1eba9ba070900f672
2014-07-22 00:03:43 -04:00
a630bfb5a0 Perhaps it's time we put ItemConverter etc into the right namespace.
Change-Id: I8082c51ff82568b8a00f92e5ab20263c017f1265
2014-07-21 23:54:44 -04:00
06830a9abc LongAndWordyVariableNameReallyGetsToMyNerveReallyAndEvenMisspelled.
Change-Id: Ifc6f876ca9e2ca77b2ab336ea0668697f32d4066
2014-07-21 23:21:27 -04:00
a1d6f1dfd5 scoped_ptr will do just fine here.
Change-Id: I35701126963047f3e405a6560a90930de99ed3fa
2014-07-21 23:21:19 -04:00
998ab5c405 More on removing (unreasonable) use of std::auto_ptr.
Change-Id: I98f5fb22eecb7749e4c86e1ce52965b0c73641ca
2014-07-21 23:12:34 -04:00
9e970303dd Remove auto_ptr from CharacterPropertyItemConverter.
And adjust all that's necessary.

Change-Id: I121e5aa4d117da2e5e6b11e4fd85960a8b3aa727
2014-07-21 20:31:24 -04:00
b2ffa40c12 Compiler macro in lieu of literal "Label" to make it easier to track it.
Change-Id: I6bc694fcc8f97b308747c097c4fa977d20524377
2014-07-21 20:31:24 -04:00
2d226f4c0b SchLayoutTabPage: that ctor wants a pointer
Change-Id: I7f500186c2ce485e7f6a857286c14d0a64354c31
2014-07-20 21:07:04 +02:00
4fa4f38593 fdo#81547, part1: use ctor reading .ui file, not a resource
This fixes a crash when this tabpage is one of the tabpages in
data series properties dialog (e.g. 3D column chart)

Change-Id: Iacbc689fb410b30515e433bcf4a96c087047ca73
2014-07-20 19:54:56 +02:00
cbc50c90ad Fix OpenGL chart reinitializing
Problem after ChartWindow was disabled and enabled
again, OpenGL content was lost.

Two things:
-After setting a new OpenGLWindow the corresponding
IRenderer must be set (x3DWindowProvider->update)
-InitOpenGL() call should not depend on DummyChart, but on
OpenGLWindow (OpenGLContext).

Change-Id: If74e1945de9973d3921ceea1ca6fef39311add7a
2014-07-20 09:54:06 +02:00
46cea34638 opengl charts: Move the init from sc to chart2, to have the right parent.
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-07-20 09:54:05 +02:00
1e2107e76b fdo#77319: set spinbox value AFTER adjusting no. of decimal places
Doing it the other way round truncates the values

Change-Id: Ieb14c9d1b9dde496eac24737aced7c8da8ce1346
2014-07-17 22:54:16 +02:00
22906fd347 add parenthese to fix precedence issue
Change-Id: Ifb4c750f4ddedd27593acde4e93331e74e9d37c4
2014-07-04 21:21:34 +02:00
b89311b971 coverity#735602-3 Division by zero
Change-Id: I2da9857e4d526b60b3bf50e10ab180c493fb288f
2014-07-04 20:11:46 +02:00
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
8918dabbee coverity#705359 Mixing enum types
and

coverity#705361 Mixing enum types
coverity#705362 Mixing enum types

Change-Id: I557d7178277e5d497e3bbab12b75724c05653f57
2014-07-02 14:00:41 +01:00
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
e123226d87 CreationWizard already inherits boost::noncopyable via OutputDevice
Change-Id: Ie155742ea9fc29b5b1adfa219c0bc6fdd78cb637
2014-06-30 19:53:12 +02:00
483a4b546c Flush modified data to the model when pressing OK in the data table dialog.
This dialog used to have no OK / Cancel buttons, and the data would get
flushed when the dialog got dismissed.  This behavior got lost during the
dialog conversion.

Also, SaveModified() does check whether or not the data table is modified.
No need to call IsModified() before calling SaveModified().

Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
2014-06-27 11:35:11 -04:00
ecde8155fe fdo#79151: No need to offset column index by category labels.
In fact, doing so would lead to a corrupt internal data table.  The
internal data stores category labels separately from the column data, so
there is no reason why we need to offset for category labels here.

Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805
2014-06-26 22:49:35 -04:00
c6da184295 Track all uses of ErrorBarX and ErrorBarY UNO property names.
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
2daceb87b9 clang: Uninitialized argument value
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26 16:29:13 +01:00
8192df3887 Clarify the code a little more.
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26 11:26:15 -04:00
60e94d8982 Move the category level removal code into its own method.
Change-Id: I4f0cfb4b15bc145b7a5c3491a7acbff13999bf5d
2014-06-26 11:26:15 -04:00
a532e2bba1 Remove these pesky ::com::sun::star ....
Change-Id: I5c8e1418cc7e01426b67233e48289497a92868d3
2014-06-25 20:24:09 -04:00
94c56f6a76 Tuck this anonymous namespace inside chart namespace.
This way we can eliminate those explicit '::chart' qualifications.

Change-Id: I764e0ca57c8e10f7eac47f48a4cabf28d0562113
2014-06-25 20:12:46 -04:00
9af5c13851 Re-use DataSeriesHelper::getRole().
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24 22:05:20 -04:00
3f9275bd26 Annotate the code a little more, to make it easier to follow.
Change-Id: Iefc61fdc132a18e73b0136f0248d69ab9e07a5e8
2014-06-24 21:07:43 -04:00
1e0c38bb54 Unwind this logic a bit.
Change-Id: I320b28fb319b42eeae7cada31b6f27f9e342db15
2014-06-24 21:07:38 -04:00
3a7f55924b Reduce indentation levels.
Change-Id: I5de3dea88a1e6f36c995697ba648ce6b82f4e8ae
2014-06-24 19:03:14 -04:00
bdd87b2acd XY chart needs to set the X value property
Change-Id: Ib17b564c187dfec8abb7a17b2602f814362dd34f
2014-06-23 02:32:31 +02:00
c97424f82a remove now unused dialog
Change-Id: I42c340a6aee016e37ee558d46a8eab101837e9c5
2014-06-22 05:05:00 +02:00
77cec206e3 show the property mapping sequences by default
Change-Id: I32417ed53e491a66f700e77ae0fff2154fa5441c
2014-06-22 05:05:00 +02:00
086d93f130 extract common code
Change-Id: I9327f232f1edb9ef052eb7868ac60774f3b6e4cf
2014-06-22 05:05:00 +02:00
fb06300b73 fix windows build
Change-Id: I0de216a8c6259ba6ec825f85f52e2f48b97510d7
2014-06-21 04:46:14 +02:00
00272efc1c I don't see a good reason for marking private methods with SAL_CALL
Change-Id: I9b73b6b6073b3249317f4e1124d840930cbe558f
2014-06-21 04:21:41 +02:00
374160d659 volatile does not make any sense here
Change-Id: I337d845e05007efb29f1c1fa39cdcc046b156281
2014-06-21 04:21:41 +02:00
7fd1fd1dea remove unneeded code for 3D charts in controller
Change-Id: I5c1f624cc05a90878f717abc8ffb0b2220ce94d5
2014-06-21 04:21:41 +02:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
2538e30ccc Use define constant to keep track of all NumberFormat property usage.
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd
2014-06-19 14:46:56 -04:00
d5a0926c23 fix range input in chart data source dialog
Change-Id: I9c139c6298d25c7a7072d0d0538f1945518d36f2
2014-06-19 15:37:04 +02:00