3ee8bc8215
Fix previous commit
...
Change-Id: Ia6437852a5ecd208510af20915bc982d1014458d
2014-07-29 15:11:59 +02:00
edffb444c0
loplugin:stringconcat
...
Change-Id: Iaa5df366118b8766b47e7bd4e9875c44c0e5d8d9
2014-07-29 14:59:33 +02:00
ccdd9a2c54
Further OUString cleanup in xmloff/
...
Change-Id: Ic749119931db569bf26c8d8a58da7d468811f927
Reviewed-on: https://gerrit.libreoffice.org/10598
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-07-29 12:44:23 +00:00
6c2c974dd3
bnc#885825: Handle ODF import and export of data label border properties.
...
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-26 16:26:09 -04:00
fed7294029
Simplify.
...
Change-Id: Id7826839a6177532bb4c3885e798ac5feb95eaca
2014-07-25 23:04:57 -04:00
f350a71df9
Reduce scope levels.
...
Change-Id: I64684a80c79c3c7f5a8f23b07703fbcee3fe5887
2014-07-25 23:04:50 -04:00
52a36fb30a
pImplize XMLPropertyHandlerFactory.
...
Change-Id: Iff524c9065e9374b39db998e3860704555130995
2014-07-25 15:54:19 -04:00
690f7ff883
Store the handler as a const pointer.
...
Handlers are conceptually stateless; we can keep them as const objects.
Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
2014-07-25 15:54:12 -04:00
dbf84a3574
The 'mutable' keyword exists for this kind of use.
...
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
2014-07-25 15:54:02 -04:00
0915d82bec
Document what's in the type of the map entry.
...
And organize xmltypes.hxx a bit to make it easier to follow. Also
rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW.
Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
2014-07-25 14:04:56 -04:00
8a690c88a9
Apply pimpl to XMLPropertySetMapper.
...
Let's hide its implementation for real this time.
Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-25 11:50:02 -04:00
fd641c7b23
Resolves: #i125289# do apply possible changed <GraphicStreamURL>...
...
only for embedded images which already have its stream inside the package
fixes also issue 125290
(cherry picked from commit 9602a121b458e7456fc533dad86f434f846a72ba)
Conflicts:
xmloff/source/draw/shapeexport2.cxx
Change-Id: I5af0093b20f2f291d3a94c690bfbdb59a59320c3
2014-07-23 11:26:34 +01:00
42b9fa4afe
cppcheck: Prefer prefix ++/-- operators
...
Change-Id: If9fa06958c4ebb45a5d4acf3b2994dd3b79f81bf
2014-07-20 09:46:24 +02:00
d18308cf3b
fdo#79358: ODF export: fix index boolean property export
...
Due to inverted conditional, only the default values were exported, not
the non-default ones...
(regression from 8a81f542a6ca566661305c53899b7e422cbaa432)
Change-Id: I0b1fc828230695709db49e1643801842d947403c
2014-07-10 15:30:34 +02:00
6238934272
use SimpleReferenceObject in xmloff module
...
to replace hand-rolled version
Change-Id: I36d4ce14d0c0c8a4b224a240c6e25c8df99b78aa
2014-07-08 08:56:18 +02:00
19100e5e9a
coverity#704112 Unchecked return value
...
Change-Id: Ic1147662012426126c1cfcf7cb496a3d03cab794
2014-07-03 14:52:29 +01:00
aa356e6076
coverity#736024 help coverity out here
...
Change-Id: Ia89ed6792bbe84eb20a4b560b0dab4557ad6e8f9
2014-07-03 12:49:39 +01:00
246cb7e068
coverity#1223084 Unchecked return value
...
Change-Id: I1573d14412b9e01fe7382796275b83405a3bb994
2014-07-03 10:25:40 +02:00
9746dc9ad6
fix ODF validation errors
...
Introduced by 7d9bb549d498d6beed2c4050c402d09643febdfa
Change-Id: I09411486b93a031a0c405579d34d9e744b8002a7
2014-07-02 23:03:09 +02:00
4ff115b3e7
drop UniReference in favour of rtl::Reference
...
since they're doing the same thing.
Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02 15:23:52 +02:00
63bfc8ab10
coverity#705353 Missing break in switch, probably intentional
...
Change-Id: I17d22443f24de5b4bf5c259e38912abc2c14ab94
2014-07-02 10:46:47 +01:00
b398f81576
-Werror,-Wtautological-constant-out-of-range-compare
...
Looks like 7d9bb549d498d6beed2c4050c402d09643febdfa "Related: #i124638# Second
step of DrawingLayer FillAttributes..." accidentally garbled this.
Change-Id: I4cdaad4fdebb8b9947e79afbec4a6e0973c55cac
2014-07-01 13:58:25 +02:00
5f0d957ac6
Resolves: #i125045# For XMLPropertyMapper using TEXT_PROP_MAP_SHAPE_PARA...
...
hide the DrawingLayer FillStyle entries by moving them to the front of
aXMLParaPropMap and using a higher index for construction
(cherry picked from commit 35f3ceaf60f109f45aa7fef7077aead398bed53f)
Change-Id: I8244e4dc685a2aa35e4154a43455ff62c8ee58fe
2014-07-01 13:30:10 +02:00
7d9bb549d4
Related: #i124638# Second step of DrawingLayer FillAttributes...
...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes
(cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b)
Conflicts:
cui/source/factory/dlgfact.cxx
cui/source/factory/dlgfact.hxx
cui/source/inc/bbdlg.hxx
cui/source/inc/cuires.hrc
cui/source/tabpages/bbdlg.cxx
cui/source/tabpages/bbdlg.src
cui/source/tabpages/page.cxx
cui/source/tabpages/tparea.cxx
include/svx/pagectrl.hxx
include/svx/svxdlg.hxx
include/svx/svxids.hrc
include/xmloff/PageMasterStyleMap.hxx
include/xmloff/prstylei.hxx
include/xmloff/txtprmap.hxx
svx/Package_inc.mk
svx/inc/svx/hdft.hxx
svx/source/dialog/hdft.cxx
svx/source/dialog/pagectrl.cxx
svx/source/tbxctrls/tbxcolorupdate.cxx
svx/source/unodraw/unobrushitemhelper.cxx
sw/Library_sw.mk
sw/inc/fillattributes.hxx
sw/inc/format.hxx
sw/inc/frmatr.hxx
sw/inc/frmfmt.hxx
sw/inc/hintids.hxx
sw/inc/hints.hxx
sw/inc/ndtxt.hxx
sw/inc/node.hxx
sw/inc/swunohelper.hxx
sw/inc/unobrushitemhelper.hxx
sw/inc/unoprnms.hxx
sw/source/core/attr/format.cxx
sw/source/core/attr/hints.cxx
sw/source/core/doc/docdesc.cxx
sw/source/core/doc/docdraw.cxx
sw/source/core/doc/docfmt.cxx
sw/source/core/doc/docnew.cxx
sw/source/core/doc/docredln.cxx
sw/source/core/doc/poolfmt.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/docnode/node.cxx
sw/source/core/inc/frame.hxx
sw/source/core/inc/frmtool.hxx
sw/source/core/inc/rolbck.hxx
sw/source/core/layout/atrfrm.cxx
sw/source/core/layout/fillattributes.cxx
sw/source/core/layout/findfrm.cxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/txtnode/ndtxt.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtedt.cxx
sw/source/core/undo/rolbck.cxx
sw/source/core/unocore/swunohelper.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unomap.cxx
sw/source/core/unocore/unoparagraph.cxx
sw/source/core/unocore/unoprnms.cxx
sw/source/core/unocore/unostyle.cxx
sw/source/ui/chrdlg/paradlg.src
sw/source/ui/chrdlg/pardlg.cxx
sw/source/ui/fmtui/tmpdlg.cxx
sw/source/ui/fmtui/tmpdlg.src
sw/source/uibase/app/docst.cxx
sw/source/uibase/app/docstyle.cxx
sw/source/uibase/frmdlg/colex.cxx
sw/source/uibase/shells/basesh.cxx
sw/source/uibase/shells/textsh1.cxx
sw/source/uibase/uiview/viewstat.cxx
sw/source/uibase/utlui/uitool.cxx
xmloff/inc/PageMasterImportContext.hxx
xmloff/inc/xmloff/XMLShapeStyleContext.hxx
xmloff/source/draw/XMLShapeStyleContext.cxx
xmloff/source/draw/sdpropls.hxx
xmloff/source/style/PageMasterExportPropMapper.cxx
xmloff/source/style/PageMasterImportContext.cxx
xmloff/source/style/PageMasterPropHdlFactory.cxx
xmloff/source/style/PageMasterStyleMap.cxx
xmloff/source/style/prstylei.cxx
xmloff/source/text/txtexppr.cxx
xmloff/source/text/txtprhdl.cxx
xmloff/source/text/txtprmap.cxx
xmloff/source/text/txtstyli.cxx
Conflicts:
svx/source/dialog/hdft.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtatr2.cxx
sw/source/core/unocore/unostyle.cxx
Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01 13:30:09 +02:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
924a28a7b1
fdo#80009: xmloff: ignore excessive fo:clip values
...
These cause problems in drawinglayer, and nobody needs a 5km clip.
Change-Id: Ic485250413194adbcd0ccf855f12e89e532d7120
2014-06-28 00:15:44 +02:00
e48a233960
loplugin:unreffun: also warn about redundant redeclarations
...
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
7af733d9ef
tweak assert so comment appears in abort message
...
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-06-27 08:55:56 +01:00
533c6cb6ba
fixes for up-casting to Reference<XInterface>
...
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-25 17:10:43 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
a2aa0e6087
Create SvtSaveOptions() outside of for loop.
...
Helps to save few cycles.
Change-Id: Iea908bd84fa1201f05ec698f8de51ea78d841eb6
2014-06-21 09:42:51 +02:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
d8e7624c9a
Do not dereference null pointer
...
...and XMLTextCharStyleNamesElementExport only requires a non-null rPropSet arg
when its bDoSomething arg is true.
Reported by CppunitTest_sw_odfexport under -sanitize=undefined.
Change-Id: Ia45fa7db250f83d746829c7f411e78bbc50bf721
2014-06-19 17:51:36 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
b7f2cad987
Revert "Make glTF support an experimental feature"
...
Actually make it experimental mode was unecessary on master.
This reverts commit 653bac184f579524bc25a9f40281763a736ae6fd.
Conflicts:
sd/qa/unit/import-tests.cxx
xmloff/source/draw/ximpshap.cxx
Change-Id: Ie8747745a9a89ce4d6500a35d15a98e28bda840a
2014-06-16 18:59:25 +02:00
04b7b2c72f
Fix gltf export: close plugin element before export fallback
...
Change-Id: I2e1f27e535ee45259f7bdf783ea5224b2ad559ef
2014-06-16 13:55:40 +02:00
4d8c4e7fe3
glTF import/export: fallback must be the second one inside the frame
...
The previous solution was good because older LO versions
import the fallback image without changing their code, but
it came out it does not fit to ODF standard so export
fallback image as the second object after the glTF model.
Change-Id: Ib9b2044b1f36b32d980cb79f6dac8dcf94d6209b
2014-06-16 12:59:19 +02:00
9ee69cbd6f
glTF export: Use plural folder names
...
Change-Id: If17628395ede512c00b666efc5511d9711edfb5a
2014-06-16 12:58:52 +02:00
c21979a327
loplugin:staticcall
...
Change-Id: I7691a6d267ea572e3fdd028c1cfae7b721a76da7
2014-06-13 17:54:37 +02:00
e8fcf1153f
Change glTF mime type: {application -> model}/vnd.gltf+json
...
There is no an accepted mime type for glTF models yet, so
follow collada's mime type: model/vnd.collada+xml.
Change-Id: I1e23a95dbb0caea781dade819f8e08235cb5c1dc
2014-06-12 21:43:36 +02:00
653bac184f
Make glTF support an experimental feature
...
Change-Id: I75e69ba1acafbab8362536f02f4d39a8fc2deed1
2014-06-12 21:43:36 +02:00
fe70101856
Introduce HAVE_FEATURE_GLTF to enable/disable gltf related code
...
When it is a release build then enable it only on Windows and
Linux.
Change-Id: I7c462aeb75e6ab60eeaa0fa42ca7853a6369b742
2014-06-12 21:43:35 +02:00
1b450cfd42
WaE: unused function 'isString'
...
Change-Id: I991cbf4a0203debaa98887d2db3fec9654dc1c5b
2014-06-12 19:51:40 +03:00
a2a1a59a44
fdo#77506: More reliable way to determine label strings.
...
Not beautiful, but doable.
Change-Id: I6f3b00d620e7d7d19cc05ec4239deeb14d0d5201
2014-06-12 11:27:19 -04:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
684d79906f
avoid memory leak and invalid documents
...
See e.g. fdo54757-1.xlsx exported to ods.
Change-Id: I81fb9a18519c5770b52dfb8131211e440ad9682f
2014-06-08 07:31:19 +02:00
c2034f3993
fixincludeguards: fix include guards
...
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-06-06 19:16:40 +00:00
61d958f37e
fdo#72727: Revert "-Werror=unused-but-set-variable second try"
...
This reverts commit ccf7b15c0a5776c6431fdcb0c0e2b0f3935ae3dc.
2014-06-05 15:18:15 -04:00
91ca3a92c5
fdo#72727: Revert "fdo#68663 don't blindly force categories when there are none"
...
This reverts commit b090cbdf82e0827234caf5969124f6631311ef35.
2014-06-05 15:04:20 -04:00
0e507ae031
various: remove SAL_THROW macro
...
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
