Commit Graph

268 Commits

Author SHA1 Message Date
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
7bdbe709ea WaE: unused variable
Change-Id: Iad493e5022a36895a30438340826ef4df50b2837
2013-10-02 19:37:30 +03:00
608dec14f1 fdo#62475 removed pointless comments
Change-Id: Ic3743e48ef9055933ff040c180561ef41b3a2990
Reviewed-on: https://gerrit.libreoffice.org/5174
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-31 16:26:12 +00:00
4d220882b4 hair splitting on years in dates in ZIP structure
Change-Id: I9d7a6436e3df75eff592d19dcaca0f655ebf2160
2013-07-05 12:22:04 +02:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
1b049bd2da Accept even more corrupted zip documents as long as we can read them
Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
2013-05-30 12:35:39 +02:00
482d1ae3d0 Revert "Accept even more corrupted zip documents as long as we can read them"
This reverts commit ef2ad0063a530aee186568579378a368180547a4.
2013-05-30 12:35:39 +02:00
ef2ad0063a Accept even more corrupted zip documents as long as we can read them
Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
2013-05-30 12:30:08 +02:00
3c38b7727a zlib: remove ExternalPackage_zlib
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-08 23:34:26 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
78eda507c8 coverity#704243 Logically dead code
Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742
Reviewed-on: https://gerrit.libreoffice.org/2942
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-03-23 21:27:50 +00:00
27d02a348b Improve debug messages
Some of those SAL_WARNs might actually better be SAL_INFOs; please change if
they hit too often.

Change-Id: I2a3b9bd485586b7878194f84bc734b54ce69bc06
2013-03-15 18:51:07 +01:00
1dedb15b17 fdo#46808, Adapt xml::crypto::SEInitializer UNO service to new style
Also create an NSSInitializer service IDL and split it's interfaces
out from SEInitializer.
It looks like this was the intention all along, but someone
took a shortcut.

Change-Id: I53ac1cb5d38b78b6718fe22c9666eae1f194a3b7
2012-11-05 16:43:14 +01:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
5db7ac2392 fdo#49819, fdo#54609: Do not consider timestamp differences as corruption
MSO 2010 can produce a files with different timestamps in the
central directory entry and local file header

Change-Id: Ic6fc0b2fad96eb30babdd7e6ef4a0175936da4c5
2012-09-24 09:27:15 +02:00
9b0198b244 package: convert internal ZIP handling data-types to 64bit
Prepare for a ZIP64 implementation.
Audit all "Size" property fetches through Anys.
Audit all uses of nSize, nCompressedSize, nOffset through the code.
Add FIXME64: comments to all points requiring future work.
2012-09-21 15:37:17 +01:00
363c1edea6 package: kill RTL_CONSTASCII_USTRINGPARAM in zipapi
Change-Id: Ic53f613cfaa5bd4affd0c27b5ed4ed20536ee055
2012-08-31 18:03:22 +02:00
e2f3312ea2 throw earlier on broken zip streams
Change-Id: I0de705b4c6a9176e98baed21b2cd960d4d091563
2012-08-28 13:26:11 +01:00
fcd990f208 Some clean up after previous commit
Change-Id: Ie419c769c5d661d51c1b43b9808791dcf9e1725c
2012-08-23 09:58:25 +02:00
3e7990faa4 fdo#46808, Shiny UNO, Use factory to create XSimpleFileAccess instances
Change-Id: I86e2a8873e5646abd340015f500bf9e872e8e6c5

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2012-08-23 09:58:25 +02:00
4be123fed2 Use memcpy & memcmp insteadof rtl_copyMemory & rtl_compareMemory in package
Change-Id: Ia24406ff31949e00725db74bbe5b016894a22f50
2012-07-29 15:01:55 +02:00
0ffc81ffdb re-base on ALv2 code. 2012-06-22 18:32:47 +01:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
eb0497307b nuke dead code
Change-Id: Id9920ea7b82ea178e904f78bbd41ffc434813e0b
2012-06-07 23:03:11 +09:00
78f614e5ff check key size
Change-Id: Ia909b0abb3ef84a9f0a14d42379f693ae9e70812
2012-05-28 15:35:25 +01:00
3934efe28c sigh, need a 64bit zlib too on windows, reverting 2012-04-13 14:06:55 +01:00
452af5f452 gbuildize internal zlib
and stick headers into the solver in the same hierarchy as is "standard"
so we don't have to patch so much, similiarly rename to libz
2012-04-13 13:15:25 +01:00
ccdb4d5c2c remove dodgy header-guards 2012-02-17 16:36:04 +00:00
39481744b1 drop Z_PREFIX from internal zlib, makes building clucene much easier 2012-02-16 11:13:13 +00:00
dcfc99705f use sal crc32 and skip cast frenzy 2012-02-15 16:08:46 +00:00
372a0d505c these were surely meant to be Z_PREFIX not ZLIB_PREFIX
seeing as Z_PREFIX is what we set in our internal zlib
and one of these was ZLIB_PREFIXB anyway
2012-02-15 16:03:46 +00:00
d0ac36dd66 Better fix for over-zealous Zip package consistency.
Turns out our encrypted zip package code writes out mismatching
compression methods in central directory and local file headers -
so not only be lenient towards the apple bug (n#653688), but also
ours (i.e. keep not comparing nMethod with nHow).
2011-12-16 01:33:51 +01:00
82b71e04a1 Revert "Fix n#653688"
This reverts commit 309f56174aca6adca879f70958892492361dac6e.  It
caused password-protected documents to no longer work and made
sc_subsequent_filters_test's testPassword fail.
2011-12-15 13:36:39 +01:00
3091d423cd Align comment with code for overly zealous check in Zip fix. 2011-12-14 14:42:03 +01:00
309f56174a Fix n#653688
Seems our Zip package is a bit too strict in checking archive
consistency - surely writing it out correctly is good, but rejecting
otherwise fine odf is not.
2011-12-14 13:31:55 +01:00
bbe62f006e remove include of pch header from package 2011-11-27 13:16:23 -06:00
1f5c696c37 add mode-lines to .m files and last round of merged files, etc. 2011-09-30 09:09:25 +01:00
d0c301bba0 convert package to gbuild 2011-08-26 14:33:51 +02:00
0d4720d1e1 undo anything not wizard related in the previous merge-commit 2011-08-21 18:12:16 -05:00
0e56df30f1 Namespace ZipUtils for the Inflater / Deflater classes. 2011-03-29 14:46:38 +02:00
dfb4b89726 make Inflater and Deflater classes available for other packages to use
Currently, those are used within an extension function used by the
Word 2003 ML XSLT filters
2011-03-29 14:46:38 +02:00
5ad6920963 Move OSL_ENSURE(false,...) to OSL_FAIL(...) 2011-03-12 14:12:11 +01:00
221b85ed29 Remove "using namespace ::rtl" 2011-02-26 01:34:14 +01:00
8add752517 Remove bogus comments 2011-02-13 17:35:58 +01:00
18e39b8c4d Merge remote branch 'origin/libreoffice-3-3'
Conflicts:
	cui/source/tabpages/swpossizetabpage.cxx
2011-02-08 00:10:21 +01:00
ba11d549dc Some cppcheck cleaning 2011-02-06 23:16:23 +01:00
2945b56030 Clean up makefiles 2011-02-01 18:21:17 +01:00
aaeacab461 WaE: gcc 4.6.0 various warnings 2011-01-24 14:47:02 +00:00
86f964d438 Remove doubled headers. 2011-01-21 18:32:36 +01:00