c4a6f300f5
uitest: set id for chart window
...
Change-Id: I443dcccf6d560c252da38a0f0c63cc48a212c127
Reviewed-on: https://gerrit.libreoffice.org/26494
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-06-20 02:26:45 +00:00
f35b1397ae
Clean up uses of Any::getValue() in chart2
...
Change-Id: I53224053ea05c715f5e359a4c68e1ae5efbfe792
2016-06-17 08:45:28 +02:00
6786842337
Move accessibility relations to .ui files, Part 8: tdf#87026
...
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.
Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf
Reviewed-on: https://gerrit.libreoffice.org/26018
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
2016-06-10 13:54:37 +00:00
bdd67652b6
Try to get rid of svt::ContextMenuHelper
...
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d
Reviewed-on: https://gerrit.libreoffice.org/26098
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
Tested-by: Jenkins <ci@libreoffice.org >
2016-06-09 12:53:43 +00:00
78b100ec9c
only init the OpenGL context if we need it
...
Change-Id: Ia88a1720d204b9933f1476bd703b99180e45abde
Reviewed-on: https://gerrit.libreoffice.org/26023
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-06-07 16:11:20 +00:00
11b4a6ddce
Convert DeactivePage return code to scoped enum
...
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd
Reviewed-on: https://gerrit.libreoffice.org/25918
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-06 07:02:20 +00:00
9f138ffe9d
remove unused constants in HRC files
...
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-06 07:01:43 +00:00
3498fd9fe9
Remove SetAccessibleRelationLabeledBy calls tdf#87026
...
And make proper changes in the related .ui files
Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-06-02 10:36:59 +00:00
4ca9e85538
replace simple macros in chart2
...
with static constantants or a named value (enum)
Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-02 07:31:39 +00:00
ef3585340e
remove ENABLE_GL3D_BARCHART define
...
enabled since commit dfb2ab0cee2ba04ce8816580447e7db8160ffac4
Change-Id: Ib260ff1ce4089ecf4778114d249d59af67c94c2c
Reviewed-on: https://gerrit.libreoffice.org/25759
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-02 07:29:05 +00:00
850a8d27ca
Convert GRAPHIC to scoped enum
...
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-27 12:59:23 +00:00
9eb2e683ab
tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)
...
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.
Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-27 07:21:45 +00:00
21a68e1745
convert TAB to scoped enum
...
and rename the SID constant to something more meaningful
Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676
Reviewed-on: https://gerrit.libreoffice.org/24986
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-18 10:13:57 +00:00
2c8fe2e737
update unusedmethods plugin to deal with constructors
...
and fix the operator< implementations in some of the other
plugins too.
Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-18 10:03:44 +00:00
ca6c108caa
Missing break in switch
...
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel
in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM
falling through to the default break case. Then
14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines,
tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE,
OBJECTTYPE_DATA_AVERAGE_LINE block in between.
Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10 17:39:13 +02:00
14cd5182c5
Replace fallthrough comments with new SAL_FALLTHROUGH macro
...
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10 16:42:16 +02:00
17076d8ecf
convert OUTLINER_MODE to scoped enum
...
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909
Reviewed-on: https://gerrit.libreoffice.org/24789
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-09 11:15:16 +00:00
0ab7ad3bb0
tdf#92768 Support hiding title objects
...
Change-Id: I879fc3d81a8fe8ca2f928305f5dc7fd9ebcfd294
Reviewed-on: https://gerrit.libreoffice.org/24564
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-05-08 20:20:40 +00:00
2cf939b2da
-Werror=maybe-uninitialized
...
Change-Id: Id516aa921d13ff5c0085fb9cf76fefd56acb31ad
2016-05-04 14:15:43 +02:00
58a32075ca
use Any constructor instead of temporaries
...
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04 12:39:40 +02:00
fc2590cfa1
Fix typos
...
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-30 15:06:45 +00:00
43b4903db3
teach stylepolice plugin about ref-counted-pointer naming
...
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-28 09:31:16 +00:00
81105d9534
-Werror,-Wvarargs
...
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"
just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)
Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-27 13:47:30 +02:00
fe2bf7b059
tdf#99518 Use correct decimal separator
...
Change-Id: I39169e7c7344fcfd594a0e0d2ab0a762cc3d5829
Reviewed-on: https://gerrit.libreoffice.org/23961
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-27 00:29:42 +00:00
279f050554
Some more sal_Bool -> bool
...
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
2016-04-25 16:40:05 +02:00
adff28271b
the container document commands std::set can be static
...
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
2016-04-25 09:21:44 +02:00
b2e2400736
no need to copy the list of available commands on every call
...
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25 09:18:12 +02:00
a82805f8f9
Kill comphelper::MakeMap
...
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-25 06:11:27 +00:00
2b68383e44
Kill comphelper::MakeSet
...
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3
Reviewed-on: https://gerrit.libreoffice.org/24343
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-25 06:11:10 +00:00
59dc694c9f
C++11: disable ctors instead of not implementing them (chart2)
...
replace the old declare and don't implement pattern
with C++11 delete keyword
Change-Id: I10b14cece4ecaddc5f96ee098b5fa36a8782a0fc
Reviewed-on: https://gerrit.libreoffice.org/24340
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-24 21:27:04 +00:00
e1af7f0c43
clang-tidy modernize-loop-convert in c*
...
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21 11:03:55 +02:00
5abc669599
new plugin stylepolice
...
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-21 08:32:47 +02:00
08bb436ff9
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-20 17:25:36 +02:00
79bffab708
Remove redundant comparison against sal_False
...
Change-Id: I6e5e5d730a8e7e3efc50472db08d0ed258ffbb3a
2016-04-20 17:25:33 +02:00
150ac9cf05
clean-up: unused using declarations and includes
...
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.
Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:25:24 +00:00
81c9d54db3
tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionals
...
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the
problem of multiple debug levels
Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad
Reviewed-on: https://gerrit.libreoffice.org/22616
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-14 09:25:38 +00:00
e7d3fa5804
loplugin:passstuffbyref in chart2
...
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
2016-04-14 09:21:41 +02:00
7816dd1bbb
Avoid reserved identifier
...
Change-Id: I8590b2c145a536872d692afcaa50279c99b3f974
2016-04-12 20:03:47 +02:00
9cfa0810bd
clang-tidy performance-unnecessary-value-param in chart2
...
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12 11:25:18 +02:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
b8cd2221bc
cppcheck: noExplicitConstructor
...
Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
2016-04-11 10:07:06 +01:00
e5dd156a44
loplugin:constantparam
...
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11 08:26:01 +02:00
25934decf8
tdf#94306 replace boost::noncopyable in chart2
...
Replace with C++11 delete copy-constructur
and copy-assignment.
Delete default-constructors when comments suggested it.
Change-Id: Ieeaf6ca998a4165d6eacf5e900c6a09aafdcfbe6
Reviewed-on: https://gerrit.libreoffice.org/23903
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2016-04-08 17:40:14 +00:00
a7ec6c29aa
loplugin:constantparam in chart2
...
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-05 11:30:13 +00:00
3ada44f631
tdf99069: lock the solar mutex before updating sidebar
...
Change-Id: I55808b72bcebab95ead3e140c9da94596826c27d
Reviewed-on: https://gerrit.libreoffice.org/23811
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-04 17:09:55 +00:00
f7a75a66fa
cleanup: remove unused Reference.h(xx) includes
...
and unused using-declarations from Reference.h
Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-02 19:01:24 +00:00
96c1ae1d8e
fix headless build
...
disables OpenGL and glew usage, lets --without-gui do what
--without-x did before and disables X related test
Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb
Reviewed-on: https://gerrit.libreoffice.org/23474
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2016-03-25 11:05:47 +00:00
a112d3dc70
Move clipboard stuff to the top like in other modules
...
Change-Id: I0e07e58f058ce7dde57277868597a56273d3b5ce
2016-03-21 13:49:30 +02:00
2d4e9abc07
tdf#93837 chart2: Convert shape context menus to xml
...
Change-Id: Ie0589c576b26dd74b9bc16d78a37a01c9bb2985e
2016-03-21 13:48:16 +02:00
ce66911720
loplugin:constantparam in svtools
...
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d
Reviewed-on: https://gerrit.libreoffice.org/23304
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-17 10:28:09 +00:00
