55bc128636
loplugin:loopvartoosmall
...
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-06-01 09:58:56 +02:00
6140ca9f1d
loplugin:loopvartoosmall
...
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29 08:48:41 +02:00
afcf1ecee1
loplugin:loopvartoosmall
...
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
668408fa1c
Fix accidental mis-uses of VclPtr address-of operator
...
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
2015-05-27 11:40:22 +02:00
bb7ce3137d
convert INVALIDATE constants to scoped enum
...
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer
Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
c7efb51e31
convert TOTOP constants to scoped enum
...
Change-Id: I85ba631ba298f1034dc5b6a04a5ff3d509c41bcb
2015-05-25 10:32:24 +02:00
b419da0f53
convert SHOW constants to scoped enum
...
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-25 10:31:35 +02:00
24600dcf31
loplugin:constantfunction
...
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-22 09:59:46 +02:00
10749bbf82
remove the last of the OUString #defines in header files
...
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-19 09:42:41 +02:00
0d5ff972fb
SAL_WARN_UNUSED Link
...
Change-Id: I646677611e46a7e33e977a5afeea9bf831b28733
2015-05-18 12:00:15 +02:00
d93915b2ae
conver MENU_FLAG_ constants to scoped enum
...
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15 10:05:02 +02:00
4f4cff08aa
convert POPUPMENU_ constants to scoped enum
...
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-15 10:05:02 +02:00
415454cfbc
tdf#86138 Context menu should state the name of the toolbar
...
When Menu::SetText is called, it defines the title of the menu (reuse of
an already defined & not used aTitleText)
Popup-menu with a title defined paint it on top of the popup. Text is bold
with a background slightly darker than the rest of the popup.
Change-Id: Ifca1be60541400f76f562b03f6e3c40dc5fecb29
Reviewed-on: https://gerrit.libreoffice.org/15716
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2015-05-14 17:17:55 +00:00
82d68f9cbc
convert COMMAND_ constants to scoped enum
...
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-11 12:17:42 +00:00
6e66946312
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: Ia1130431fa5206bd007b6ce05488e4a199323c5b
2015-05-11 12:49:41 +02:00
4f00dce2b3
Use IMPL_[STATIC_]LINK_NOARG where applicable
...
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10 11:25:48 +02:00
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
f1ad620b91
coverity#1297236 Uninitialized scalar field
...
Change-Id: I2c19d1a0f8ad31cdf384ab301f3dae99a6ea9933
2015-05-09 17:18:35 +01:00
3842967e52
Ensure progress bar LibreOfficeKit callbacks don't repeat the same percentage
...
Gets rid of superfluous sequential callbacks with the same percentage when
loading large documents.
This reverts commit cec72eff99d1d683f2236c8a86a2814b34ad861e.
Change-Id: I70f43f7e3a650c76cbcbbc60ebb2d47efaca06a5
2015-05-08 21:31:16 +03:00
5eb6bd4db7
lopluign:staticmethods: Handle DECL_LINK
...
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08 19:15:32 +02:00
cce752b1ba
convert SHOWDIALOG_ID constants to scoped enum
...
Change-Id: I58fffa7345f6b5050b8a1b3ac1022c630e64dbb4
Reviewed-on: https://gerrit.libreoffice.org/15651
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-08 06:50:24 +00:00
fc4726a1f4
Use typed Menu::Set[De]actuivateHdl Links
...
Change-Id: I6736383ad0ec5c9f2ea2281bfdcfa280cd712032
2015-05-08 07:50:14 +02:00
0c415f61e4
Use typed Menu::SetHighlightHdl Link
...
Change-Id: I47a35813fddcb90497b621a96bafe74969dc90d0
2015-05-08 07:50:13 +02:00
cec72eff99
Don't bother ensuring progress bar LibreOfficeKit callbacks are monotonical
...
It can well be that the StatusIndicator code is called for multiple
independent sections while loading some document format, and that the first
progress is not the one that actually takes much time at all, so following
just the progress of that would be misleading, the progress would be "stuck"
at the highest value set by the first progress (forever, if it has gone up to
100%).
For example, when loading the odk/examples/java/DocumentHandling/
test/test1.odt sample document, the code first calls the StatusIndicator while
parsing the styles.xml, going from 0% to 100%. But the styles.xml is typically
rather small. Then the code calls the StatusIndicator *again* while parsing
the much more relevant concent.xml. For that particular document, this time
the progress goes from 0% to 27% only, for some reason. Oh well, GIGO.
Change-Id: I87bfc586a53efcbeb94924f21dd365ca63da88d7
2015-05-06 17:55:58 +03:00
0145fa21f5
We don't use <config_features.h> any more here
...
Change-Id: I06a382917717906a0e5fdee57e296bab407c5348
2015-05-06 17:55:58 +03:00
a00cd9025b
Add support for progress bar callbacks to LibreOfficeKit clients
...
The framework bits.
Change-Id: I9cbd649c7766284bfcf8846d2b5e129dd2731ee8
2015-05-06 17:55:58 +03:00
98b5f1164b
Use typed ToolBox::SetMenuButtonHdl Link
...
Change-Id: I00cd35374294ccdcc0ac3223ae81ba8129b9a5d7
2015-05-06 12:54:23 +02:00
e1b8ae4b2e
Use typed ToolBox::SetDataChangedHdl Link
...
Change-Id: Ia4fe932e765651653e6c534e755a8fc32875ffc3
2015-05-06 12:54:23 +02:00
f9830183e1
Use typed ToolBox::SetStateChangedHdl Link
...
Change-Id: I9b574f652e5d999086e32e9c7ede7c68fe5cc99a
2015-05-06 12:54:23 +02:00
1e64fe1364
Use typed ToolBox::SetCommandHdl Link
...
Change-Id: Ieee142ddebb288037647fb77bac6f11b9827c4a8
2015-05-06 12:54:22 +02:00
b13fbd19b7
convert BMP_SCALE constant to scoped enum
...
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
2015-05-06 09:01:30 +02:00
c8fdfc39eb
Use typed ToolBox::SetDeactivateHdl Link
...
Change-Id: Ia2521b000e962a0cc461a54f73b5c97bbe34a602
2015-05-06 08:20:56 +02:00
8ff3a90d3c
Use typed ToolBox::SetActivateHdl Link
...
Change-Id: I15044bd9ea94562c1d4727f64aa0b32543e0cc0a
2015-05-06 08:20:56 +02:00
b515d1f36f
Use various typed ToolBox::Set*Hdl Links
...
Change-Id: Iddfd36ae0de86fdd2d4febb2c05d1fe0c02801f0
2015-05-06 08:20:55 +02:00
8fca0c44e8
vcl: rename other members of StateChangedType for consistency
...
Change-Id: Ifd3339813e5d3dfb54566fd226aaf2d2a199d59a
2015-05-05 15:51:11 +02:00
8cafd08278
Use typed Timer::SetTimeoutHdl Link
...
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
b95427196e
Use typed TabControl::SetDeactivatePageHdl Link
...
Change-Id: I487aad5217cb685ece971717445a68b4fb3d2b3a
2015-05-04 17:54:51 +02:00
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
d883c12556
Get rid of the initial :: for the vcl namespace
...
We used it all over the place without leading :: already anyway, even
in many files in include. So let's be consistent. In the majority of
cases, prefer the easier-on-the-eyes choice, not the "safe" one.
In those files in include where *all* existing uses of ::vcl:: indeed
used the :: prefix, there let's keep it for consistency.
Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-30 07:27:52 +03:00
e6c08b6b30
Remove unnecessary STATIC_LINK macro
...
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
f6d4cd3968
error C2666: 'operator ==' : 2 overloads have similar conversions
...
Change-Id: I2813d08f5f903d4d5115f04f58598b3841facfd0
2015-04-29 10:28:05 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
e19cd844be
Rephrase comparisons between bool and sal_Bool
...
...to cater for forthcoming loplugin:implicitboolconversion improvements
Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
591c319227
More loplugin:simplifybool
...
Change-Id: If173ec26ed53cf99fd23f0930eaeefc595a05722
2015-04-27 15:30:56 +02:00
deb50a2a8a
remove some @author tags from suspiciously unidiomatic code
...
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
2015-04-25 22:45:51 +02:00
9b8dc2ad4d
loplugin:simplifybool
...
Change-Id: I1865fd9c73e83d8305135b67ece3d45997e309f3
2015-04-24 12:36:22 +02:00
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
ac1130130b
Use comphelper::SequenceAsHashMap::getUnpackedValueOrDefault<bool>
...
...instead of ...<sal_Bool>; plus ensuing loplugin:implicitboolconversion
Change-Id: I5400e9d3175b9fe9b6088d37fe6bf3275314d7d0
2015-04-23 17:03:58 +02:00
79e0e713f7
Update to XDocumentEventBroadcaster et al
...
Change-Id: I11633dc1629eac6a1ba79e4b45972a1e4f5fc833
2015-04-22 15:38:44 +02:00
ba150afb07
Update to XDocumentEventBroadcaster et al
...
Change-Id: I27904a961a30042608ae4facae9772d30b86696b
2015-04-22 15:38:44 +02:00