Commit Graph

306 Commits

Author SHA1 Message Date
51906611ab basic: move SbxAppData to a BasicDLL member
... so it is deleted by ~SfxApplication.

Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
2014-10-23 21:30:45 +02:00
ad9498f8b8 More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
df466d79cb fdo#70474: Random number generation weak with Rnd in BASIC
Just reuse the rng functionality. This improves the randomness.

Initialize seed with system time if no argument for RANDOMIZE is given. As the help text
states: "If Number is omitted, the generator uses the current value of the system timer".

Change-Id: I5fa46e8344b2402dff66a8db2449d43e2ca27d6d
Reviewed-on: https://gerrit.libreoffice.org/9349
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-17 12:40:58 +00:00
569ff6727e update_pch: add a bunch of pch files
I had to fix some source files because of macro redefinitions and such stuff.

Small modules like basic have a great win, too:

make basic.clean && time make basic:

                with    w/o
                 pch    pch
accessibility    23s  1m59s
basctl           30s  1m42s
basic            56s  1m35s
comphelper       23s    51s
editeng          48s  2m04s
forms            40s  1m40s
unotools         19s    38s
sd             3m37s  4m33s

Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09 19:50:42 +00:00
cc725643fd Clean up function declarations and some unused functions
Change-Id: I63c4c61847fea4500b667a5ea9f2b32207692033
2014-04-09 10:12:02 +02:00
1eee88dd6b basic: sal_Bool->bool
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
2014-04-07 13:53:50 +02:00
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
88ab8181d9 SbxObject::isClass sal_Bool->bool
Change-Id: I71f7b3603df43924d7374969444b929e1eecca4e
2014-04-04 13:44:16 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-26 11:54:55 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a8d7c510b4 coverity#707629 Uninitialized scalar field
Change-Id: I0e3d9d4dad46e9b88be11cc9ac2c7d3c0c4b6f6e
2014-01-27 14:38:37 +00:00
4b0f171b24 sbxbase.hxx is private to basic
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
2013-12-11 10:49:57 +02:00
d76178b52d sbstdobj.hxx is private to basic
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
2013-12-11 10:48:12 +02:00
444aaceb15 sbprop.hxx is private to basic
Change-Id: I1d7a28652ee7743b6823d78e1565338a324f0a6a
2013-12-11 10:45:57 +02:00
0a33e24d11 sbobjmod.hxx is private to basic
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11 10:39:57 +02:00
dde119c8f2 basic/global.hxx is private to basic
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-12-11 10:36:58 +02:00
4adf622925 fixincludeguards.sh: basic
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
2013-10-28 15:16:20 +01:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
c40cd8a4f2 Remove all occurences of RTL_* and ::rtl prefix from basic
This is a big commit, so thanks for your time reviewing this :)

Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-03 10:07:39 +01:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
117fdb9898 convert users of XDocumentInfo to XDocumentProperties
Change-Id: I10f395f90d554d0ec26fe9f2654ae839e21c7ee5
2012-11-22 12:10:30 +01:00
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
bbf1bcd9ad basic: String -> OUString in basicmanager
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
2012-11-03 20:24:26 -05:00
7580802e9f Remove unused reference class
Change-Id: I17246e036e821c4a8be36cf322dcf23285e3d97a
2012-09-13 19:46:22 +09:00
55223696a2 Bin pointer to non-existent class
Change-Id: I215c84967a53dbadba86913d24bc4aadc6543467
2012-09-13 01:52:32 +09:00
a8a15bd95c Remove unnecessary #ifndef guards
Change-Id: I0b393c97f8781d99bf5d3be4065864379eab004c
Reviewed-on: https://gerrit.libreoffice.org/594
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2012-09-11 17:25:10 +00:00
969e6870e8 sal_Bool to bool
Change-Id: I86e5b49ccc9737517ecde17dbdaba44eeaee2371
2012-09-08 23:05:11 +09:00
b5afbbd8af Bin useless includes
Change-Id: I08a58468a3ce75038b65a8d9641cc2138541a7f5
2012-09-07 09:57:39 +09:00
00b7328732 sal_Bool to bool
Change-Id: Ie8a128db35bebcdcee5eda984a7875339418d9bb
2012-09-07 09:57:39 +09:00
cfa6f85242 sal_Bool to bool
Change-Id: Iebed1c159606ab695b049032da5a3509e468fb91
2012-09-05 10:40:17 +09:00
9e2f8b9ec2 Fix typo ImpLoadLibary
Change-Id: I773678437aae6577f22078e97bcac1377c4307d8
Reviewed-on: https://gerrit.libreoffice.org/495
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-08-28 19:53:36 +00:00
2efc59c9b6 sal_Bool to bool
Change-Id: I38141187c4f0809343a93c5765c0773d2321968a
2012-08-21 22:59:16 +09:00
27f4f9ae8f -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: Ia6f5bf7c3372515c2796d239aeb610fbe6f29f8d
2012-08-16 09:46:59 +02:00
16f75f1f77 reduce static_initialization_and_destruction chain
Change-Id: I9fdefd428b858fd5581412d6f8e896a0eb680fef
2012-08-09 12:47:03 +01:00
747cb47357 remove unnecessary includes of svl/svarray.hxx
Change-Id: Ifec201efc4e97baf2d36d66c4ae6967eadd6134c
2012-07-30 12:47:50 +01:00
bfe1aa0e79 XubString->rtl::OUString
Change-Id: I584ff580e3c8eee401f07c858ecbd63e5b0bf980
2012-07-20 16:26:47 +01:00
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
c3dc9a3ef3 clean up include guards in sbxvar.hxx
Change-Id: I802d142ae93b3e9c7d42ab98d5c757df94a82196
2012-07-05 10:48:19 +02:00
00240d0497 Remove unused defines
Change-Id: Ic36b131ee9964a6671f7f41e1cad1631c43ad565
2012-07-01 18:33:42 +02:00