Commit Graph

320 Commits

Author SHA1 Message Date
b520fca88d coverity#1247647 Uncaught exception
Change-Id: I1e47f3970f944aa3556e4ddb9b7918d9ee23c0eb
2014-10-17 15:19:54 +01:00
be31d107f5 chart2: std::auto_ptr -> std::unique_ptr
Change-Id: Ia92c18858c8ed7cfc2765cc2310f3bf7bfd7e8df
2014-09-30 10:33:24 +02:00
8dbde0845a fdo#82577: Handle Region
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-12 06:08:32 +00:00
9585ba198b Delete commented-out declaration of function members
Change-Id: I118b7a788ee62f75af8b7669cad285952f0e968a
2014-08-16 21:52:28 +02:00
f1531cdaae bnc#885825: Support borders around data labels.
Change-Id: Ib141413e523cbf73746876f727e9f80dda9f5f7c
2014-07-26 16:26:08 -04:00
2c5f02539d drop DLG_CHART_WIZARD via .res
Change-Id: I394a42bfb761e2f7cf8c3186f5ec412331b5950c
2014-07-23 10:30:25 +01:00
7df0cb37a4 boost::checked_deleter will do.
Change-Id: I952d9dfcffd85aaae49fc1f1eba9ba070900f672
2014-07-22 00:03:43 -04:00
a630bfb5a0 Perhaps it's time we put ItemConverter etc into the right namespace.
Change-Id: I8082c51ff82568b8a00f92e5ab20263c017f1265
2014-07-21 23:54:44 -04:00
998ab5c405 More on removing (unreasonable) use of std::auto_ptr.
Change-Id: I98f5fb22eecb7749e4c86e1ce52965b0c73641ca
2014-07-21 23:12:34 -04:00
9e970303dd Remove auto_ptr from CharacterPropertyItemConverter.
And adjust all that's necessary.

Change-Id: I121e5aa4d117da2e5e6b11e4fd85960a8b3aa727
2014-07-21 20:31:24 -04:00
1e2107e76b fdo#77319: set spinbox value AFTER adjusting no. of decimal places
Doing it the other way round truncates the values

Change-Id: Ieb14c9d1b9dde496eac24737aced7c8da8ce1346
2014-07-17 22:54:16 +02:00
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
e123226d87 CreationWizard already inherits boost::noncopyable via OutputDevice
Change-Id: Ie155742ea9fc29b5b1adfa219c0bc6fdd78cb637
2014-06-30 19:53:12 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
36122c2753 Replace auto_ptr with boost::scoped_ptr.
Change-Id: Ibc6d532eff59146d8fbe7dcc7f9155ce6119f474
2014-05-12 19:59:57 -04:00
5707c81218 fdo#77739 UI trendline: limit max values of Degree and Period
Retrieve the number of valid points and limit Degree and Period values

Change-Id: I4e956149e3376eebf39f9e4812bb69a6a06e1758
Reviewed-on: https://gerrit.libreoffice.org/9116
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2014-05-06 20:04:01 +00:00
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
4b243d2201 whitespace cleanup in chart2
Change-Id: I85fdb62ff0e6606e2ac8537f477e7cb5bec3827a
2014-04-06 17:19:55 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
34002c4e5c sfx2: sal_Bool->bool
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-27 13:45:09 +02:00
80ef0dfedc svtools: sal_Bool->bool
Change-Id: I42a341b5805e0b2a7d619ba552700db35815afd5
2014-03-25 14:32:57 +02:00
6292dbc3ef Better to associate true for "enable" and false for "disable".
The code reads better this way, and certainly is easier on human brain
to process their logic.

Change-Id: I3150fca3385931b9fe01ad13cb11fab410331349
2014-03-24 22:24:30 -04:00
885fd98fa3 convert chart type page to .ui format
Change-Id: I2e95e0dec66b8985abad81b02722e1bf632a15e0
2014-03-03 13:27:10 +00:00
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
b0cf499b3e convert chart data dialog to .ui
this one was a complete pig to convert with the
conflicting home-grown existing layout code.

Change-Id: I135bd486d10f7d972e143daae44d6b24a6e8fdb8
2014-02-20 13:50:01 +00:00
bbe3bec949 Drop unused #include
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
51a68b4992 Doxygen warnings corrected
* Doxygen spits out a lot of warnings about not being able to find
  match function signatures, etc. This is because in some headers we
  have a using namespace statement, in others it gets confused between
  ::Window and Window (!).

* Wrong use of tags:
  + Lots of @seealso - should be @see
  + Wrong usage of @overload - corrected with the right function
    signature
  + HTML tags that doxygen doesn't recognize removed

Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-05 09:14:53 +00:00
f985e3add3 fix ambiguities
Change-Id: I27c8ef11a0eedbcaf29865dff83841675b775171
2014-02-04 15:52:23 +00:00
f79bfd0ac5 convert chart type dialog to .ui
Change-Id: I6da39b06629e3913048a48490f45863de24c4f15
2014-02-04 09:21:00 +00:00
9c4032921c Convert chart data source tab page & dialog to .ui
Conflicts:
	chart2/source/controller/dialogs/dlg_DataSource.cxx
	chart2/source/controller/inc/dlg_DataSource.hxx

Change-Id: Ic3e3adc578156161f16254862e1ca33a8ad9e1f6
Reviewed-on: https://gerrit.libreoffice.org/7255
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-17 16:09:50 +00:00
db666bdf0c convert data range tabdialog to .ui
Change-Id: I70e9064a13a751f6b0dae153522953eaf2ac53a5
2014-01-07 09:43:15 +00:00
44029ade1b convert chart shape paragraph dialog to .ui
Change-Id: I5682ccdaa7d0f877310b937ad12ceeeb0b91c350
2014-01-04 19:37:53 +00:00
204c2a1a02 convert chart shape character dialog to .ui
Change-Id: I03917fdceebdf5bd06c04f5719615092ee166852
2014-01-04 19:22:15 +00:00
86fcb2eaae WaE: private field 'm_pParentWindow' is not used
Change-Id: Iad6433396844cae5785b6b8ba80f0593c2dea62e
2013-12-28 11:08:45 +02:00
e6a87e17b2 Convert insert error bars dialog to widget UI
Change-Id: Ie2fbcb0bacb968a784698908c8cc62f73a80cf32
Reviewed-on: https://gerrit.libreoffice.org/7219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-28 08:44:59 +00:00
3596e88b65 Convert chart data label dialog to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: Id9054b3b0c6e7a10a72bc90b05cd7c6bbc5e82a2
Reviewed-on: https://gerrit.libreoffice.org/7205
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 21:19:56 +00:00
27eb33d753 remove unnecessary empty dtor, etc.
Change-Id: Ia2a1d1fe81a07d1e37437539d6d651a7c6ce1111
2013-12-27 20:59:01 +00:00
acf3949da9 Convert chart error bars tab page to widget UI
Change-Id: I9f3cb1fb3186e77b5c5ee57ff3e6086022c80bfd
Note: kept old resouce to allow dialog to be called by dlg_InsertErrorBars, util we find a way to have a dialog to call a tab page and access the resources. Once a solution is found, old- resources can be deleted, RangeEdit and RangeSelectionHelper can be nuked too.
Reviewed-on: https://gerrit.libreoffice.org/7198
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 20:20:35 +00:00
9143eaff72 Convert chart legend dialog to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: Ibc265efe5a8bdf3e0e5fb8135fb0487de7e96764
Reviewed-on: https://gerrit.libreoffice.org/7199
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 16:52:29 +00:00
1568dc2541 Convert chart polar options tab page to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: If9730589e44ab40331ea217986e79d78b926d5af
2013-12-27 15:07:26 +00:00