cb414252b8
loplugin: cstylecast
...
Change-Id: I4aafc170895d8bab47206c7b07b4f1f6105d42d3
2014-10-23 12:36:14 +02:00
aa32583329
3D charts: Update the 3D charts when a value changes.
...
Change-Id: I9c4052108446959ff6f5215d704b496e7a8e6aee
2014-09-12 13:03:52 +02:00
f61e453f84
the DUMMY_CHART_FACTORY variable is not the only indicator for OpenGl charts
...
Change-Id: Idab33c8611526dc4749b4dbe4fe84e68138b4f73
2014-08-29 17:40:35 +02:00
43d23a24fd
opengl charts: Move the init from sc to chart2, to have the right parent.
...
Conflicts:
chart2/source/view/charttypes/GL3DBarChart.cxx
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-08-29 17:40:25 +02:00
f1531cdaae
bnc#885825: Support borders around data labels.
...
Change-Id: Ib141413e523cbf73746876f727e9f80dda9f5f7c
2014-07-26 16:26:08 -04:00
3f3d072dd7
fix indentation
...
Change-Id: Ic2b5e14c3a80d826fd6a31023f3821a333aed2d0
2014-07-25 04:00:35 +02:00
cc827ab81d
Revert "opengl charts: Move the init from sc to chart2 ...
...
This reverts commit 46cea34638b371570073c0e86f79969753c543ed.
Conflicts:
chart2/source/view/charttypes/GL3DBarChart.cxx
Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-23 22:19:58 +02:00
15eb6b2e01
Wrong indent.
...
Change-Id: I0aab6cc1d7a39928e9e8ffd6ae23fcfad42ceae3
2014-07-22 09:36:39 -04:00
b2ffa40c12
Compiler macro in lieu of literal "Label" to make it easier to track it.
...
Change-Id: I6bc694fcc8f97b308747c097c4fa977d20524377
2014-07-21 20:31:24 -04:00
38272ba915
Scope reduction by throwing early.
...
Change-Id: Ic0b7b69b8c4e57064b31ef62ddceaf6094ca9991
2014-07-21 13:52:54 -04:00
46cea34638
opengl charts: Move the init from sc to chart2, to have the right parent.
...
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-07-20 09:54:05 +02:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
942c21a003
coverity#1224984 Dereference before check
...
Change-Id: I93c8326d204d1b15a2a7ac5288a6c767029c6501
2014-07-10 22:11:28 +02:00
462f7e43a0
coverity#1224984 Dereference before null check
...
Change-Id: I05d54983d6231ec0b4293df51c7d55570d10cee7
2014-07-10 13:39:17 +01:00
6cad548ee2
chart2: add some locking to chart::ChartType UNO service
...
On the libreoffice-4-3 branch, chart2_unoapi crashed with what looks
like a corrupted ChartType::m_aDataSeries triggering STL assertions.
Try to protect the mutable members with SolarMutex guards.
Change-Id: I3f2edd36b8ecf37ef60239415f70abfc8b59244d
2014-07-04 15:06:12 +02:00
3575dba98d
remove whitespaces
...
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
1271ac20d4
coverity#706266 Uncaught exception
...
Change-Id: Iba3d2b8cddcd9e0f228d5b9fef1ce3290047c8b0
2014-07-01 10:56:16 +01:00
355c3cbb16
fix invalid memory access in chart tests
...
Change-Id: I056101d146c939ff958c83efc57fd110e8d52509
2014-06-27 10:05:45 +02:00
c6da184295
Track all uses of ErrorBarX and ErrorBarY UNO property names.
...
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
2538e30ccc
Use define constant to keep track of all NumberFormat property usage.
...
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd
2014-06-19 14:46:56 -04:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
c5539bb585
fdo#79676: Initialize with a default chart only from the UI.
...
When creating an embedded chart object during import, we don't want to
create a default chart which would only mess up the chart data.
With this change, ChartModel::initNew() is a no-op.
Change-Id: Id29659c3885ec1e06bed26d2c851123fb63072cc
2014-06-10 10:02:25 -04:00
ac4d9437b3
coverity#706262 Uncaught exception
...
Change-Id: I4fb1642153a0abe66ee9290e31813eb11623b527
2014-06-10 10:48:41 +01:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
439550c9f1
remove unnecessary and unused chart debug functionality
...
Change-Id: Ic8100b2afebe469709723b324394e08b7669d911
2014-06-07 04:48:16 +02:00
f730b62e26
coverity#706265 Uncaught exception
...
Change-Id: I85c77236cd0a3cd791902a3978ea4e13606cea6c
2014-05-28 13:49:51 +01:00
008998decc
coverity#706264 Uncaught exception
...
Change-Id: Ia197a0de24a282bbfcbfc80ee283f530ac12c287
2014-05-28 13:49:51 +01:00
f282994626
coverity#706261 Uncaught exception
...
Change-Id: Ife4d1e828cc2b52c54e425ec7af533ebdacd0f1e
2014-05-28 13:49:50 +01:00
92b447876d
css already means ::com::sun::star
...
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-27 14:00:28 +02:00
e41c33b376
make sure that OpenGL charts are rendered after import
...
Change-Id: I3701a7593d7394abc39532a87b9aa50a3c92d457
2014-05-24 12:36:48 +02:00
227af32d8c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
...
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
0d8908b359
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part16
...
Change-Id: I78b3a0151397d4e69521e6b2451e93ea6e463376
2014-05-18 00:36:10 +02:00
ca52e5ff2c
support property mapping in new 3D charts
...
Change-Id: I3da71e354ed2595c1f5b2eaeb5fb565205d24de0
2014-05-16 12:44:15 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
a1e41fc3d1
Fix previous commit (chart2 part)
...
Change-Id: I9d6491f484eb2a8989b7e3594ca2edf702557b12
2014-05-11 10:44:13 +02:00
bd59628620
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10
...
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11 10:16:42 +02:00
a7eba60df0
the rendering is working on-screen
...
I can't believe that I finally see something on the screen.
Change-Id: Ic374c8a0d0fa5050b0701a5553136759c9c7602c
2014-05-07 21:23:04 +02:00
af578839ca
let us use the new OpenGLWindow
...
Change-Id: I5cbab0aa1707513b62f7a9958fac013b3beb2dcb
2014-05-07 21:23:04 +02:00
a28bcb6e57
provide the OpenGL window
...
This approach looks much better. We get size and position correct
without much work and can easily plug the window into the sc window
hierarchy.
We still have a crash on exit as the ScGridWindow goes out of scope and
the SystemChildWindow is still alive. We need to fix it and bind the
lifecycle of the SystemChildWindow to ScGridWindow.
Another open item is the OpenGL context work. Right now it looks like
the best way forward is to create a subclass of SystemChildWindow that
contains the OpenGLContext.
Change-Id: Ie0a74531e1b818cea92912345464c8fa219bbae2
2014-05-07 21:22:28 +02:00
a371f5de63
fix missing service factory during import, related fdo#74333, cp#1000057
...
Change-Id: I2cce561587d82b0434ef2d3e65e5d35b7ff99260
2014-04-25 20:02:21 +02:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52
chart2: sal_Bool->bool
...
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
692714b7da
chart2: loplugin:saloverride
...
Change-Id: I795c8337f3d5fcf3e39849204867f0d57f40c843
2014-03-29 18:10:09 +01:00
ffaf640b73
Add API wrapper to handle properties of new GL3D chart type.
...
Now the new proprety gets properly imported and exported to and from ODF.
Also, more on replacing string literals with define macro constants.
Change-Id: I4b773d68610a8aeaeb239901dac166e4dc2dd80d
2014-03-29 00:47:21 -04:00
0be6a5ef37
Transfer back properties from the chart type object to template object.
...
Change-Id: I3484a2ae0141087835e34e4e174bdc24b3357854
2014-03-29 00:47:20 -04:00
ef15c94699
Trying to move this RoundedEdge property from Diagram to GL3DBarChartType.
...
Then things stop working. Go figure.
Change-Id: I38893b20104537a64d279063c7b7dd708efb0d2f
2014-03-29 00:47:20 -04:00
68e20faf3f
Start using common symbols for textural UNO property names.
...
This will make it easier to track all uses of a UNO property name using
symbol database lookup, which is much faster and more accurate than grepping.
Change-Id: I8c2857504c29bcce01eb8c1f406dcbfb24331510
2014-03-29 00:47:19 -04:00