908d1b6e63
chart2: fix memory leak due to cyclic reference in VAxisBase
...
The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself,
and apparently that is a cyclic reference. Naively using the
ChartModel's m_xNumberFormatsSupplier in
ChartView::impl_createDiagramAndContent() because it will later be passed
to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be
able to convert it to a ChartModel.
Since passing around the ChartModel as an XNumberFormattingSupplier is
sort of un-intuitive anyway, refactor some methods to use XChartDocument
instead, and only create the VPolarAxis / VCartesianAxis with the
ChartModel's m_xNumberFormatsSupplier.
The drawback is that if ChartModel::attachNumberFormatsSupplier()
is called after ChartView::update() has created the axes, it may not
have an effect on them; not sure if that is a real or hypothetical
problem.
Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f
2014-10-20 17:14:26 +02:00
cbdf857299
coverity#707673 Uninitialized scalar field
...
Change-Id: Ic631ebc74e94f4ccf7e3915db3952714fd4d28d4
2014-10-10 12:50:20 +01:00
1075cd6b5d
coverity#707673 uninitialized member
...
Change-Id: Iab55c2545790bdee7104abf91d7a3df2deb21ec5
2014-10-01 20:28:59 +01:00
af655d2f76
Refactor impl_createDiagramAndContent() to take CreateShapeParam2D.
...
Change-Id: I517c4e4a2296531c0d7f129ff46adca0f85a969d
2014-09-19 18:43:49 -04:00
e55fd119c0
More scope reduction.
...
Change-Id: Ibaabf1122fb3e828c1b7b71e846911d77f312445
2014-09-19 13:46:08 -04:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
aa32583329
3D charts: Update the 3D charts when a value changes.
...
Change-Id: I9c4052108446959ff6f5215d704b496e7a8e6aee
2014-09-12 13:03:52 +02:00
7e2b9fa213
Remove some useless tools/debug.hxx includes
...
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
2014-08-22 16:33:18 -05:00
5021f29841
Remove some unused code
...
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-07-29 14:20:36 +00:00
b2ffa40c12
Compiler macro in lieu of literal "Label" to make it easier to track it.
...
Change-Id: I6bc694fcc8f97b308747c097c4fa977d20524377
2014-07-21 20:31:24 -04:00
7649a14222
Make these non-inline.
...
Change-Id: I0de443a78e3024c7d3834f964a92f5ccdabe3cc3
2014-07-03 15:29:41 -04:00
6c4e21a234
bnc#812796: Correctly handle static value array for OOXML charts.
...
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.
Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values. When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.
Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
3575dba98d
remove whitespaces
...
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
8918dabbee
coverity#705359 Mixing enum types
...
and
coverity#705361 Mixing enum types
coverity#705362 Mixing enum types
Change-Id: I557d7178277e5d497e3bbab12b75724c05653f57
2014-07-02 14:00:41 +01:00
822d0e9db6
Use new GridPrinter instance for each table.
...
resize() sometimes leads to a crash. Need to debug later.
Change-Id: Ia3809eb4f171369a58b84d5b44001692be1453a1
2014-06-26 22:33:55 -04:00
c6da184295
Track all uses of ErrorBarX and ErrorBarY UNO property names.
...
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
95272e7e5b
Prevent a crash while dumping internal data content.
...
Change-Id: I0938b955b460d8c91607e6df0b9d9e1a4a971013
2014-06-26 18:58:41 -04:00
aa6495b6fa
Better way to dump the content of InternalData.
...
Row levels are currently not dumped, but that may change later.
Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355
2014-06-26 14:26:50 -04:00
8192df3887
Clarify the code a little more.
...
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26 11:26:15 -04:00
9af5c13851
Re-use DataSeriesHelper::getRole().
...
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24 22:05:20 -04:00
349132616d
Let's remove these lcl_ fetish.
...
These are not even static local functions anyway, which was what
lcl_ prefix was originally used for.
Change-Id: I0e6b6cebbcf7cdfb449cf17320fb362fc73d92a8
2014-06-24 18:46:46 -04:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
2538e30ccc
Use define constant to keep track of all NumberFormat property usage.
...
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd
2014-06-19 14:46:56 -04:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
08b0691bde
coverity#1158096 Unchecked dynamic_cast
...
Change-Id: I9d02b4e9e4c8dfea73cef3970d11e21eaefb80bd
2014-06-10 16:08:08 +01:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
439550c9f1
remove unnecessary and unused chart debug functionality
...
Change-Id: Ic8100b2afebe469709723b324394e08b7669d911
2014-06-07 04:48:16 +02:00
57517bbf45
coverity#706267 Uncaught exception
...
Change-Id: I3a63546d0797c98c1720f0987293404ec760aeac
2014-05-28 13:49:51 +01:00
75648d6e97
cppcheck: redundantAssignment
...
Change-Id: Icf71dc6735b9b60f6fea4dc8c78877bb652fbe95
2014-05-24 15:46:43 +02:00
227af32d8c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
...
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
0d8908b359
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part16
...
Change-Id: I78b3a0151397d4e69521e6b2451e93ea6e463376
2014-05-18 00:36:10 +02:00
248145f99e
Find places where uno::Sequence is passed by value.
...
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-14 08:10:22 +00:00
4cbfbf4597
m_bOwnershipIsWellKnown is unused
...
Change-Id: I4dee9c4ce674249fca590e1c6d86685ed86da885
2014-05-12 09:46:36 +01:00
fe6308ac60
coverity#1158099 Unchecked dynamic_cast
...
Change-Id: I7c294042a3f4d7293fb6d93d33687eb265871e76
2014-05-11 21:06:01 +01:00
a1e41fc3d1
Fix previous commit (chart2 part)
...
Change-Id: I9d6491f484eb2a8989b7e3594ca2edf702557b12
2014-05-11 10:44:13 +02:00
bd59628620
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10
...
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11 10:16:42 +02:00
2d5581b49a
Reference can be removed
...
See http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4107883.html
Change-Id: I4d29b9d80f8142792f948c6797006fe7e698a2a4
2014-05-07 23:33:23 +02:00
65f127f687
chart2: move RegressionCalculationHelper.hxx to inc
...
Change-Id: Ie49a9e20f72c8e2f81b2d169f5fd19964811c193
2014-05-07 09:29:18 +02:00
f69e74d1a0
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2 + fix some errors
...
Change-Id: I9c889d718a9c91eb4c2bde2389a21dd754cbef36
2014-05-06 21:33:28 +02:00
ebd4986c34
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2
...
Change-Id: Ibca921eff3647507ffb7e9011a84aeefbec58d7a
2014-05-05 23:24:49 +02:00
200963d301
set graphic properties for error bars during import, fdo#78041
...
Change-Id: I43138745b074dcacdafa090d97eeb9aa2ccecf78
2014-05-01 02:31:58 +02:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52
chart2: sal_Bool->bool
...
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
a3354ecf4f
Separate mouse event handlers for GL3D bar chart.
...
They are just skeletons for now.
Change-Id: I7e5e95ad8a2809125cbcf3affd17e663aafa99b0
2014-04-11 09:36:40 -04:00
291bf3b84f
prevent excessive exceptions
...
They hide the interesting parts that I'm interested in and are always
thrown so let us avoid them
Change-Id: I532a3fe678de7d3ac0776db23363df5d35c793eb
2014-04-05 18:34:22 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
c03c9da8c2
fdo#43157 : clean up OSL_POSTCOND
...
Conflicts:
include/sal/log-areas.dox
Change-Id: I770b8b9fb82f873ccb88dc26ac05206f703ddf33
Reviewed-on: https://gerrit.libreoffice.org/8805
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-03 11:23:49 +00:00
c7190108f0
Missing XServiceInfo base class
...
Change-Id: I2a233e60162fd89e4765a57a0de10b430babcaa6
2014-03-28 14:30:30 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
3952fab4ed
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: I8b57f970b31b12902e3772c3306b71379b8d3fe5
2014-03-26 19:02:52 +09:00
