Commit Graph

454 Commits

Author SHA1 Message Date
04740cb7e2 cli_ure (Windows): std::auto_ptr -> std::unique_ptr
Change-Id: Ibe794daffa347d194ff8c66a44c7eec4bcc9b83d
2014-10-02 15:20:26 +02:00
25df8adbc0 cli_ure: adapt destructors in cli_uno library to "C++/CLI"
commit 4b56d82c7d20ba5897d87aaf7fc94da5356b8eec converted the cli_uno
library from "Managed C++" to "C++/CLI", but forgot one detail:

The destructors on "ref" classes were mapped to Finalize() methods in
the old syntax, but the new one maps them to Dispose() methods, which
are only invoked on stack-allocated objects.  Presumably this omission
results in leaking of native C++ UNO objects.

Reading the C++/CLI documentation i get the impression that:
1) the destructor should explicitly call the finalizer
2) the CLR will not call the finalizer itself iff the destructor is
   invoked

http://msdn.microsoft.com/en-us/library/ms235315.aspx
http://msdn.microsoft.com/en-us/library/ke3a209d%28v=vs.110%29.aspx

Change-Id: I509d9b69a399c3d7d6597060ab9b7c78c5916e11
Reviewed-on: https://gerrit.libreoffice.org/11132
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-27 05:06:32 -05:00
5f15f18859 warning C4189: local variable is initialized but not referenced
Change-Id: Ic8a76a9ab73a3466fe155e2ca8eecedeb6e810c9
2014-08-13 10:10:49 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
608ebc6f01 Remove redundant inclusions of header "cppuhelper/shlib.h"
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-08 12:02:16 +02:00
d07539ea5e java: use an empty block rather than an empty statement
Change-Id: I05e60964521d6ec3694483816d91359fb12c8e4b
2014-08-08 09:48:18 +02:00
e7a474b29a java: remove unused variables
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
a0233e6e03 Typo: habe->have
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
2014-06-29 13:15:52 +02:00
b19db6b21d Typo: apend->append
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
2014-06-29 13:15:51 +02:00
0d2542d67a gbuild, cli_ure: Win32 make issues with back and forward slashes
It looks like what works is to give the source file names with
backslashes but everything else with forward slashes?

Change-Id: Iaf910ab5fc41984d1315a30b164a334d28344c16
2014-06-09 17:05:53 +02:00
637b0ef1b5 cli_ure: Win32 make quoting problem, use sed to work around
Change-Id: Ide8a3c574a1904e08921684453256d1d3c98fd78
2014-06-09 17:05:52 +02:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
d0322208bc Combine unoidl::loadProvider and unoidl::Manager::addProvider
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-23 13:44:03 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
acc04202e8 use css prefix consistently
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
2014-05-12 19:52:28 +02:00
49dff05943 cli_ure: fix dbglevel=2 build on windows
Some blocks are completely unused.

According to http://msdn.microsoft.com/de-de/library/ms235298.aspx

rtl_uString * __pin * pp_sInterfaces = &_sInterfaces;

should be

pin_ptr<rtl_uString *> pp_sInterfaces = &_sInterfaces;

Change-Id: I039e94649d542fb5b51231b2e0df0a4dc1170c19
Reviewed-on: https://gerrit.libreoffice.org/9318
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-12 14:53:26 +00:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
11b81c1026 Fix memory leaks
Change-Id: Id67d5375bedc6e6c10082d9c5ee69d6e932be158
2014-04-29 10:14:12 +02:00
da1425650b add missing modelines to idl files
Change-Id: If52651c70ee659c83ef127da4fe5e266cfe7eec2
2014-04-24 11:58:14 +02:00
b8239ac2f9 typo: noone -> no one 2014-04-14 12:32:54 +02:00
f7dca81251 cli_ure: simplify deprecated XTypeProvider.getImplementationId
Change-Id: If6f975bdc3d554828ff1ad3adc656579eda92a42
2014-03-10 17:39:53 +01:00
1712e6c614 Remove visual noise from cli_ure
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56
Reviewed-on: https://gerrit.libreoffice.org/8240
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:15:25 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
bbe3bec949 Drop unused #include
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00
85d1e39d74 gbuild: Fix and check package dependencies.
Change-Id: Ia54def7a404e07974eb1e8a556f4659cd974e7f8
Reviewed-on: https://gerrit.libreoffice.org/7081
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Matúš Kukan <matus.kukan@collabora.com>
2013-12-17 06:26:29 +00:00
a83b2af9ab Clean-up uno/lbnames.h
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
5503a68395 cli_ure: remove CLI version Packages
Tweak the installer so it reads the included files from SRCDIR.

Change-Id: Ic4d3d2c003c2d0c5aebea6dd32f5989f3d4f04e4
2013-10-30 00:01:36 +01:00
8df17a3409 gbuild: set Package default target to INSTDIR
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28 20:17:26 +01:00
e5eac916e8 cli_ure: remove Package_config
- cliuno.snk is used from SRCDIR
- climaker.exe.config is not packaged and appears unnecessary

Change-Id: Ia0e364bd3b488841aeb8ae75c26aa0cd4ff86012
2013-10-28 14:03:13 +01:00
968c735aa7 gbuild: refactor CliLibrary
- stop copying the DLL to OUTDIR
- since that was the main reason for the separation between
  CliLibrary and CliLibraryTarget, merge the targets;
  the newly inherited variables are not expected to cause problems
- hardcode target to URE bin dir for now, no immediate need for
  multiple layers

Change-Id: If0fea1337349c41f231c8cde122852c71d5080a7
2013-10-28 14:01:08 +01:00
decf809674 fdo#69601: refactor CliNativeLibrary
- stop copying the DLL to OUTDIR
- since that was the main reason for the separation between
  CliNativeLibrary and CliNativeLibraryTarget, merge the targets;
  the newly inherited variables are not expected to cause problems
- the Library remains in layer NONE; the derived CliNativeLibrary
  is in INSTDIR
- hardcode target to URE bin dir for now, no immediate need for
  multiple layers

Change-Id: I3bf4859e8c574f84d69eb43d12ddce0d34b5730c
2013-10-28 14:01:07 +01:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
0618b35ebd Fixes for cross-compilation on OS X (to iOS)
Introduce SDKDIRNAME as a configury variable and use it instead of the
gbuild gb_Package_SDKDIRNAME. Then we can easily construct the
SDKDIRNAME_FOR_BUILD variant that is needed to find the specially
named SDK in instdir on OS X when cross-compiling.

Move the version number section in configure.ac earlier.

Change-Id: Iee3db1a50ad4c7a9f91bbc5e0d0b01d76a76f701
2013-09-23 15:38:10 +03:00
814ec7640f cli_ure: copy cli_basetypes to INSTDIR/sdk/bin
The library is already in the URE/bin directory, but that is not
sufficient to be able to run sdk/bin/climaker.exe.

There are apparently 4 ways for a .net/CLR executable to locate
shared libraries:
1) in the same directory as the executable
2) in some mysterious "GAC" thing in C:/Windows
   (which is presumably how it works if you actually install LO)
3) via an application configuration file entry "probing",
   which only works when it's in a sub-directory of the
   one the executable is in
4) via a DEVPATH variable, but that only works with a
   special configuration entry in a system "machine config" file
   of the .net framework

Specifically PATH is apparently ignored.  Since building on Windows is
enough of a PITA already and we don't want developers to have to edit
another config file, put another copy of the library into sdk/bin.

http://tutorials.csharp-online.net/.NET_CLR_Components%E2%80%94Resolving_Names_to_Locations
http://tutorials.csharp-online.net/.NET_CLR_Components%E2%80%94CLR_Loader

Change-Id: I511957ad9a9a918ed0c316126304a1980fb2d289
2013-09-22 11:08:32 +02:00
4ac934946e cli_ure: cleanup in Library_cli_cppuhelper_native
Change-Id: I76b4815208354e78eb3575982235b6f26f1e02fd
2013-09-22 11:08:31 +02:00
f212aa9f84 fix existing comments
Change-Id: I06dca63053dae5d3dceb49bf67adb0c100b56e8b
2013-08-31 22:41:12 +02:00
78ced6235b fix indentation
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
2013-08-31 22:41:11 +02:00
bf42b6f9f5 fdo#62475 - remove visual noise
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
fc456b51fc Missing dependency (see "#using <cli_basetypes.dll>" in climaker_share.h)
Change-Id: I2575da1ccbe1c301dd826588aec2a787176d3cfd
2013-08-22 16:25:27 +02:00
1c7af455ab Re-work 8bit characters in source code, or remove them.
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-08-20 19:30:59 +00:00
6b408d1cc2 gbuild: remove external_headers targets
gb_LinkTarget__add_internal_headers was used only for sdi headers now
anyway, hopefully for no good reason.
One headers target is enough for all.

Change-Id: Ia01fb7a0aac7f72915448424b3393ecd9ba0f8f5
2013-06-10 20:03:00 +02:00
1e4422a4b4 re-base on ALv2 code. Includes:
Patches contributed by Mathias Bauer
        gnumake4 work variously
        http://svn.apache.org/viewvc?view=revision&revision=1394707
        http://svn.apache.org/viewvc?view=revision&revision=1394326
        http://svn.apache.org/viewvc?view=revision&revision=1397337
        http://svn.apache.org/viewvc?view=revision&revision=1397315
        http://svn.apache.org/viewvc?view=revision&revision=1396797

	Patches contributed by Andre Fischer
	Fixed getcsym.awk to handle #-comments that contain special regexp chars.
        http://svn.apache.org/viewvc?view=revision&revision=1230971
	118778: Added ADDITIONAL_REPOSITORIES environment variable and its
	automatic setup in configure.
        http://svn.apache.org/viewvc?view=revision&revision=1232004
	118160: Added external CoinMP library.
        http://svn.apache.org/viewvc?view=revision&revision=1233909

	Patches contributed by Herbert Duerr
	#i119168# use generic LICENSE file for langpacks and sdks
        http://svn.apache.org/viewvc?view=revision&revision=1310178
	macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars
        http://svn.apache.org/viewvc?view=revision&revision=1183367
	allow gbuild with empty sysroot on linux
        http://svn.apache.org/viewvc?view=revision&revision=1179186

	Patches contributed by Ingo Schmidt
	native373: #164472# improvements for msi database
        http://svn.apache.org/viewvc?view=revision&revision=1167540
        http://svn.apache.org/viewvc?view=revision&revision=1167539

	Patches contributed by Jurgen Schmidt
	adapt setup package scripts to handle special DS_Store file for
	developer snapshot builds
        http://svn.apache.org/viewvc?view=revision&revision=1232430
	imported patch extensions_i117681.patch
	http://svn.apache.org/viewvc?view=revision&revision=1172102

	Patches contributed by Michael Stahl
	gbuild: RepositoryFixes.mk should be optional
        http://svn.apache.org/viewvc?view=revision&revision=1166123
	xslt filter: remove the FLA horror
	wordml import filter: replace FLA usage with plain XSLT
	http://svn.apache.org/viewvc?view=revision&revision=1363727

	Patch contributed by Oliver-Rainer Wittmann
	i#88652: applied patch, remove unicows deps
	http://svn.apache.org/viewvc?view=revision&revision=1177585

    Remove lots of OS2 conditionals, re-extract Rhino Java, unwind
    cppunit pieces, cleanup Mac image bits, remove coin-mp and
    re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand
    MPLv2 subset checking.

Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-06-03 11:41:36 +01:00
e39e9e4cd8 Source files shouldn't have executable bit set.
Change-Id: Iafad6249a7998d7c749c1ca2979a606078cfcb5e
Reviewed-on: https://gerrit.libreoffice.org/4070
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-28 12:09:27 +00:00
1728ab7125 Remove dependency of climaker on registry format
See the comment in climaker_app.cxx main about room for improvement.

Change-Id: I11cc2f62c9d42269d5c96253198ee4e730496e75
2013-04-29 13:35:53 +02:00
3a77c4fa06 Fix compilation error after fe4ffd81045144ffb8d69ae9e5df7ef191005128
Whether it works, no idea. But on the other hand, from the dicsussion
in fdo#61503 it doesn't seem as if that commit was deeply insightful
either. (And how it compiled on the commit author's machine, no idea.)

Change-Id: If6355b33c406e8da5bdb2bf77aaf8b2ac0c39343
2013-04-25 12:46:34 +03:00
fe4ffd8104 fdo#61503 fix cli_cppuhelper bootstrap error
Change-Id: I777d2d866cfc8b2363b418fd5cba6576e3a2b8ec
Reviewed-on: https://gerrit.libreoffice.org/3600
Reviewed-by: Peter Foley <pefoley2@verizon.net>
Tested-by: Peter Foley <pefoley2@verizon.net>
2013-04-24 21:28:47 +00:00