Commit Graph

6800 Commits

Author SHA1 Message Date
7acb634f58 Resolves: fdo#85081 terminate if can't load kde addressbook
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
2014-10-28 15:06:36 +00:00
d8a8b5ac59 coverity#706303 Uncaught exception
Change-Id: If3963e0ae2c6477eb074e89f411c22a82d339634
2014-10-28 10:31:25 +00:00
0095bccdf5 coverity#706321 Uncaught exception
Change-Id: Ie3b66520ab0c859272a4b0291f6c907e7fce61e5
2014-10-27 14:34:22 +00:00
6cbdfedde1 coverity#1249674 Missing break in switch
Change-Id: I1e957afe1dc35571128fac4432b54e8ae35aa9ab
2014-10-27 14:34:20 +00:00
5c90f8dd04 cid#1249675 Uncaught exception
Change-Id: I3923a6a83bfc0a35f5a5af86cfd0e5308cfda24c
2014-10-27 11:34:06 +02:00
92f83d8a59 coverity#706329 Uncaught exception
Change-Id: Ia056948df45ade616dd4c434a4c9d319d48d97f2
2014-10-25 16:56:20 +01:00
654d845320 coverity#706328 Uncaught exception
Change-Id: I9182ad75a5b49d5aa9d58cecc690b06220f13272
2014-10-25 16:56:19 +01:00
6c8b24bf3c coverity#706322 Uncaught exception
Change-Id: I4ebfee76cb17562a47d4c2e868539fc70ead530e
2014-10-25 16:56:18 +01:00
9e965e9b15 coverity#706319 Uncaught exception
Change-Id: I7f390151c232d0a96d50b16c0c76aacea569653e
2014-10-25 16:56:17 +01:00
7c896697f2 coverity#706317 Uncaught exception
Change-Id: I8b39addd8d4b9f7d68d0f7a317d1dff7388aba93
2014-10-25 16:56:16 +01:00
d803c5e996 coverity#1202804 Explicit null dereferenced
Change-Id: Iff1ada702f57fba9ba979bc158412b0321921672
2014-10-25 14:38:11 +01:00
c2f4c300ec coverity#736109 Nesting level does not match indentation
Change-Id: I0f1beadc90eae9750b53062df2512f7c886fd267
2014-10-24 09:24:58 +01:00
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
820e64f966 connectivity: firebird: fix temp directory leak
Dispose the dbaccess document, and recursively delete the temp directory
in Connection::dispose().

Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-21 15:08:57 +02:00
a2e4d4329b connectivity: firebird: use Reference for Connection where appropriate
ODatabaseMetaData and OResultSetMetaData apparently have life-times
independent of their creating object, so they need to own the
Connection too.

Change-Id: Idee28a96e318ca4b3d804084d609737a7fc75862
2014-10-21 15:08:57 +02:00
137131b1e0 connectivity: firebird: fix Connection leak in OStatementCommonBase
bin/refcount_leak.py was very helpful here.

Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
2014-10-21 15:08:51 +02:00
52acb42091 cid#1247650 Uninitialized scalar field
Change-Id: I74e1a02602fd5d86790e3c0e71d6a8649fa0aa05
2014-10-17 10:23:08 +02:00
b0f26546ce coverity#706322 Uncaught exception
and

coverity#706330 Uncaught exception

Change-Id: I105e37c88654cf47b50fe6b260b8994622305dab
2014-10-15 16:56:56 +01:00
405a61f916 coverity#706318 Uncaught exception
and

coverity#706317 Uncaught exception

Change-Id: Idd01f4ba68b1ce6590d6c7b79bcff9593f0766ea
2014-10-15 16:56:56 +01:00
ad9498f8b8 More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
298f8d6032 coverity#706320 Uncaught exception
Change-Id: I980e55ab3942c93447573c0af7b7486dfc0a0e10
2014-10-14 17:13:42 +01:00
899e472598 coverity#706319 Uncaught exception
Change-Id: I582bc15b8065c9262c0933f1afa0bda6e1f5d94e
2014-10-14 09:16:40 +01:00
9ab3abd290 coverity#706332 Uncaught exception
Change-Id: I847cea7329a0c9cf370406afe8a7511f58c89901
2014-10-14 09:16:39 +01:00
cc70cff83a coverity#706327 Uncaught exception
Change-Id: I3a84a212abfcf0668b7040c8fa537ad62aaf5224
2014-10-14 09:16:39 +01:00
ada3817a33 coverity#706326 Uncaught exception
Change-Id: I922ce18051eefb4507cc84870ce18ae0a49f4608
2014-10-14 09:16:38 +01:00
15decb9b32 coverity#1158396 Uncaught exception
Change-Id: I0306b8431641d841027b30dfe1c03ecad5df6867
2014-10-13 20:59:49 +01:00
32db3f5dc4 coverity#706331 Uncaught exception
Change-Id: I48e11a07924418721d45fcac55bd5aeb68f115a3
2014-10-12 16:39:55 +01:00
88e1b0215b coverity#735605 Division or modulo by zero
Change-Id: Ic3680ae833ed325ff4afe96fdca02f784ccd7d71
2014-10-11 17:33:52 +01:00
6c2cffdfc6 connectivity: firebird: recursively delete temp directories
TempFile itself will only remove empty directories.

Change-Id: Ibaf986856bde172de40686ae363821b19add8106
2014-10-11 00:28:48 +02:00
f5c8a636a6 coverity#706302 Uncaught exception
Change-Id: I082b7682124053948733efc2dbe5df6196acaa5f
2014-10-10 18:14:35 +01:00
faa6455995 add copy constructor for ONDXPagePtr class
which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb
"remove SvRefBase::QueryDelete"

Change-Id: Ib52b9cb58451abd62f75d7376b069bf6aef550b2
2014-10-10 12:04:09 +02:00
ee12e843c6 fdo#84073: change ODBC/JDBC escapes to lowercase
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8
2014-10-09 18:22:15 +02:00
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09 11:33:33 +00:00
a0a919d2b5 remove SvRefBase::QueryDelete
Move it's functionality into the only place that needs it, in the dbase
driver.
Removes an extra virtual call from a widely used class.
The dbase driver seems to be using to perform some kind of whacky object
recycling, so it's not like we want this functionality to be used
somewhere else.

Change-Id: I41018f71e0b0a79fdd3d527536f0ac95c788e614
Reviewed-on: https://gerrit.libreoffice.org/11786
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09 08:18:24 +00:00
a98f12b0ad connectivity: try to fix build after f641fd15
Change-Id: I6a8534044eb0c245ef8aa80c52cd1a37ba8fa5a5
2014-10-07 22:38:55 +02:00
9de01eeba7 Revert "ADO driver: don't override a virtual method just to call the one of the parent"
This reverts commit 220deb0a0ed7b3efa14088acdab0520709309105.
2014-10-06 19:40:20 +02:00
bf93397189 Revert "ADO: don't override a virtual method to call the one of the parent"
This reverts commit fa8f2fdf45c168a25dd955ebd24780b4863d6cde.

Change-Id: I252e29648fb59a15379ba2f3b63d6914a7fc3a93
2014-10-06 19:39:51 +02:00
fa8f2fdf45 ADO: don't override a virtual method just to call the one of the parent
Change-Id: Ibae309ffbb7b2500c9113a95ca3fc508de378976
2014-10-06 19:20:53 +02:00
f641fd1526 mozab driver: don't pretend to implement an interface one does not
Change-Id: I8ab2e2691ecf35e00283bd3144b2f4c8203adc3a
2014-10-06 18:59:24 +02:00
220deb0a0e ADO driver: don't override a virtual method just to call the one of the parent
Change-Id: I39020452e8ff4b17b0c1cfb9ff54bf650ab97fc3
2014-10-06 18:59:23 +02:00
4f1787a528 ADO driver: don't pretend to implement an interface one does not
Change-Id: I6234974cfc1b7650a35b8f7b9a4132acf797c91b
2014-10-06 18:59:23 +02:00
19c283eaa8 coverity#1242888 Unused value
Change-Id: I3adde518347208cb1ab7a2013c519d9eabcf7b3d
2014-10-03 16:30:26 +01:00
8f539e3f71 cid#704588 Dereference after null check
Change-Id: If84e072da9e59140466262fbeac4dc787a9de898
2014-10-03 16:00:30 +02:00
7d7b289da4 loplugin: cstylecast
Change-Id: I114924d5e0407883b2e77016da3c2e3e55657b21
2014-10-03 15:20:03 +02:00
3b59dbbffd remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html

Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02 20:00:18 +02:00
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
6a5d0b6ad5 coverity#1242903 Result is not floating-point
Change-Id: Id816a9b8845eb9d41bfea5a8399bca86726bebfe
2014-10-02 14:48:52 +01:00
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
173e017209 factorise odbc headers inclusion
it is complicated enough that we should implement that logic only once

Change-Id: I0cc5ffb871223b27df825f21612e3c8f6f2febb3
2014-09-26 18:25:56 +02:00
25a092869c connectivity: typo
Change-Id: Ic4c8637500c13d097f5b26222d7d4005f2251d1a
2014-09-26 16:58:04 +02:00