wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
362,810 Commits 5 Branches 0 Tags
acd62e055ee71f330b1d48c3c3c83aaa5ceca29a
Commit Graph

216 Commits

Author SHA1 Message Date
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
7d7b289da4 loplugin: cstylecast 
Change-Id: I114924d5e0407883b2e77016da3c2e3e55657b21
 2014-10-03 15:20:03 +02:00
Stephan Bergmann
ed95e1c561 connectivity: sal_Bool -> bool 
Change-Id: Id9458a3aa0928eedc87aec39f305b206e2638e67
 2014-09-12 13:11:59 +02:00
Tor Lillqvist
6492c8576e Make the "Mac-like" or "canonical" app bundle structure always used on OS X 
In other words, only executable files go in the MacOS folder. Dynamic
libraries and bundled frameworks (i.e., LibreOfficePython), and
nothing else, go in the Frameworks folder, and all other files go in
the Resources folder.

Especially, note that Java class files and rc (.ini) files also go in
Resources.

Such an app bundle structure is what Apple strongly suggests one
should use, and it has been hinted that future versions of code
signing and/or Gatekeeper will require such a structure.

There is still some ugliness thanks to traces of the historical
separation of URE from "the office". Like there are two separate
"unorc" files, one for URE, one for the LibreOffice application. IMHO,
this should be cleaned up, but is probably controversial.

(Eek! I now see there are actually *three* unorc files in the app
bundle. Not intentional. Need to fix that later.)

Change-Id: Idcf235038deb5b8e1d061734993e9f31869b7606
 2014-09-09 13:55:23 +03:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Noel Grandin
11383f56fb connectivity: remove SAL_THROW macro 
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
 2014-06-05 08:17:47 +02:00
Thomas Arnhold
a2db194ea0 connectivity: fix includes 
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
 2014-06-04 21:18:39 +02:00
Jens Carl
54b85bf51e fdo#68849: Add header guards to all include files 
Added header guards to files in directories avmedia/, basegfx/, chart2/, and
connectivity/

Change-Id: I94ec438ec918ccef1c518edfd9ab4944e9e2961b
Reviewed-on: https://gerrit.libreoffice.org/9555
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-30 01:43:33 -05:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Caolán McNamara
73d4d9a583 Related: #i124896# remove obsoleted pq_allocator.hxx 
Change-Id: I8a2b54c97f20e581b9703bf33dbba537c2f603c2
 2014-05-15 15:03:50 +01:00
Julien Nabet
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8 
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
 2014-05-10 06:19:42 +02:00
Julien Nabet
88db0ab698 Typos 
Change-Id: Id4b79ae8576acaaf9d5ee1c9c030b6ffda3059a5
 2014-05-08 18:46:49 +02:00
Thomas Arnhold
888057cb5c fixincludeguards.sh: connectivity 2014-04-19 11:10:08 +02:00
Caolán McNamara
98a39af312 WaE: -Werror=maybe-uninitialized 
Change-Id: Id9226a5d460c114d4811209020f408779dd2424d
 2014-04-16 16:41:58 +01:00
Noel Grandin
199d333f13 connectivity: sal_Bool->bool 
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
 2014-04-16 11:51:51 +02:00
Thomas Arnhold
618a0f8c03 whitespace for include statements 
Change-Id: I76bd0ef07a2fa134e948724cecdf539ffe6ccb8a
 2014-04-15 13:43:13 +02:00
Thomas Arnhold
2805ac13dc typo: choosen -> chosen 2014-04-14 12:32:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Noel Grandin
358be80f65 comphelper,connectivity: prefer passing OUString by reference 
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
 2014-03-14 07:47:01 +02:00
Stephan Bergmann
8038ea6396 connectivity: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: I4a62143fc46b39525968f10236b10cb547fe8c50
 2014-03-10 17:39:53 +01:00
Stephan Bergmann
7211162081 Clean up uses of rtl_ustr_ascii_shortenedCompareIgnoreAsciiCase_WithLength 
Change-Id: Ie37614dac882bfe05f8ce595ae6b20326dce872e
 2014-03-01 19:28:14 +01:00
Alexander Wilms
ac9212feed Remove visual noise from connectivity 
Conflicts:
	connectivity/source/inc/odbc/OConnection.hxx

Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-27 06:54:35 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Caolán McNamara
61160e0454 add missing vim modelines 
Change-Id: I72d565b77fad98e176e2f47368201ad1585aef3f
 2014-02-18 15:18:09 +00:00
Caolán McNamara
e2a130432d coverity#984079 Uninitialized scalar field 
Change-Id: I48d4b4961b7ef287bec27551de6366a4bdf27ddd
 2014-02-18 15:18:08 +00:00
Caolán McNamara
4a030f1b82 coverity#984081 Uninitialized scalar field 
Change-Id: I076439b3f1f6766f7215ed4342abf97358b09fef
 2014-02-18 15:18:08 +00:00
Caolán McNamara
21211c1ec1 coverity#984082 Uninitialized scalar field 
Change-Id: I9a68f51c5941cdc592a39d4cbe164321cbc05660
 2014-02-18 15:18:08 +00:00
Stephan Bergmann
612dac063a bool improvements 
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
 2014-01-29 11:08:32 +01:00
Stephan Bergmann
ead1525417 bool improvements 
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
 2014-01-28 20:24:39 +01:00
Julien Nabet
151887a955 Fix other typos 
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
 2013-12-22 18:51:41 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM 
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
 2013-11-22 08:07:19 +02:00
Noel Grandin
f8b2265419 remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL calls 
Convert code like:
    defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) );
to:
    defaultValue.startsWith( "nextval(" );

Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
 2013-11-20 13:56:09 +02:00
Noel Grandin
5112f6a6c6 remove RTL_CONSTASCII_STRINGPARAM in OString constructor 
Convert code like:
    OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OString aKeyName("NDX");
which compiles down to the same code

Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
 2013-11-20 13:56:07 +02:00
Noel Grandin
1730df0127 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::append 
Convert code like:
   aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
   aOStringBuf.append( " is missing )" );
which compiles down to the same code.

Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
 2013-11-20 10:07:32 +02:00
Noel Grandin
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls 
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
 2013-11-20 10:07:32 +02:00
Stephan Bergmann
ab5d1fbfb4 SAL_WARN_UNUSED com::sun:⭐:uno::Any 
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
 2013-11-14 21:02:40 +01:00
Noel Grandin
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii 
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
 2013-11-11 12:58:12 +02:00
Noel Grandin
1bdb2b6f06 remove unnecessary use of OUString constructor in CONNECTIVITY module 
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
 2013-11-11 11:21:25 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Marcos Paulo de Souza
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService 
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-09 15:03:38 +00:00
Stephan Bergmann
723412eac5 -Werror,-Wunused-variable 
Change-Id: I3ad7139190758e86cadebf9555a838dbaddbbf3e
 2013-10-02 18:14:38 +02:00
Stephan Bergmann
7f02173bba -Werror,-Wunused-const-variable 
Change-Id: Ic4edbbc0bf74887ab9624e4551b54ecbe3538108
 2013-10-02 16:49:31 +02:00
Andrzej J.R. Hunt
4216518982 Update implementations of ColumnLocate::findColumn to throw on invalid column. 
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:26:12 +00:00
Andras Timar
6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g 
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
 2013-09-07 14:21:22 +02:00