17a99a9074
fdo#84938: replace TIMEF_ constants with enum
...
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e
Reviewed-on: https://gerrit.libreoffice.org/12114
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-28 06:12:28 +00:00
0e36884e78
coverity#982164 silence Unchecked return value from library
...
Change-Id: Ie2479e3dc73a7c7e8d2d0c5c979bde2ea5d05a1e
2014-10-27 14:34:21 +00:00
7ef698355a
fdo#84938: replace KEYTYPE_ constants with enum
...
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328
Reviewed-on: https://gerrit.libreoffice.org/12104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-27 08:09:35 +00:00
2f4546487a
coverity#982164 silence Unchecked return value from library
...
Change-Id: Ibec38a7e7846c463601b0a876778f53003cf0441
2014-10-25 16:56:25 +01:00
28dbb39389
coverity#982163 silence Unchecked return value from library
...
Change-Id: I6b9a3c6ce75472da551706b1c1555eff4ba1abc8
2014-10-25 16:56:25 +01:00
03c7c26cbe
java: final fields that can be static
...
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
d9fa1247be
fdo#84938: replace SYMBOL_TYPE constants with enum
...
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-15 10:13:04 +00:00
cb7ede2d99
convert vcl StateChangedType to enum class
...
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:32 +00:00
72a7450c02
MWERKS etc. are not supported toolchains
...
Change-Id: I449fe34be396114529357388c87162aaf8976292
2014-10-02 20:00:18 +02:00
5cb059e28b
coverity#1242860 Unused value
...
Change-Id: Ibd6d737cf117af0c2fdda7768da6a173c59bd346
2014-10-02 14:48:54 +01:00
e5bf214ebb
loplugin: cstylecast
...
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01 13:08:43 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
3b5345e123
extensions: std::auto_ptr -> std::unique_ptr
...
Change-Id: I2d9d2e145584013d8e94f5aea2ec7732452b240c
2014-09-30 12:28:52 +02:00
8dbde0845a
fdo#82577: Handle Region
...
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.
Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
c353caee1c
loplugin: cstylecast
...
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-29 12:50:35 +02:00
5cefde06ea
remove unnecessary casts in calls to SvStream.WriteUInt32
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26 15:27:17 +02:00
5501c8d222
remove unnecessary casts in calls to SvStream.WriteUInt16
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26 15:26:48 +02:00
bec72dd34f
remove unnecessary casts in calls to SvStream.WriteUChar
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26 15:26:19 +02:00
8305efa9e8
coverity#983665 Uncaught exception
...
Change-Id: I3d0cd9a9bde8c3705abd876e832b6b7e56bb7fad
2014-09-26 10:11:02 +01:00
c91dec0dad
comphelper: std::auto_ptr -> std::unique_ptr
...
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-25 08:40:11 +02:00
d66b757083
Leftover XLIB_Window -> Window
...
Change-Id: I51aa3e3fbf440bbd16d43ab8113cd69937060bf3
2014-09-23 14:19:31 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
cb466794af
Put schema.xml in the correct place, and drop the empty English strings file
...
Change-Id: Ic9d3894611eedcffa9ce79ae8b2745de72eb9117
(cherry picked from commit 0b6555f594095ddc082d555852f7d8e9f7d7f266)
2014-09-23 11:16:55 +03:00
15c609f33d
Use prex.h/postx.h
...
Change-Id: I055ae0426df86a1ea49385bc8c0b176cc4b9d940
2014-09-23 09:29:56 +02:00
04edcd8605
Blind fix for Windows
...
Change-Id: I1b923cba578b0acc2b9ce389c6c7d664fa00b268
2014-09-18 15:27:38 +02:00
39b81563b2
Blind fix for Windows
...
Change-Id: I186024f8a95ada752115750419a54a6231967f57
2014-09-18 15:24:35 +02:00
32d6415617
fdo#83512 Make use of OUStringHash and OStringHash
...
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-09-18 13:12:48 +02:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
a3ad01dc1e
cppcheck: unpreciseMathCall
...
Change-Id: I440dc3e30ee139d6cb261e1308e48e9b63b52bc8
Reviewed-on: https://gerrit.libreoffice.org/11434
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-09-15 07:56:39 +00:00
3d20965ee5
extensions: sal_Bool -> bool
...
Change-Id: I026056e093661d3beb7f7a231d6cf0e8c72e5b50
2014-09-12 15:23:48 +02:00
5490e0a880
Mark template member fns that are supposed to override as SAL_OVERRIDE
...
Change-Id: Ic81b4510aef3476a53c811b7c91ee1941068ce59
2014-09-12 14:57:06 +02:00
ea733ab5b6
Turn SfxItemState into a C++11 scoped enumeration
...
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")
Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2014-09-12 06:08:32 +00:00
ed00d0ddd6
create a master document template type
...
of application/vnd.oasis.opendocument.text-master-template with
suffic otm
https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html
desktop/icons/oasis-master-document-template.icns is just a copy
of
desktop/icons/oasis-master-document.icns
because I can't draw
Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1
Reviewed-on: https://gerrit.libreoffice.org/11350
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-09-11 09:38:21 +00:00
db9cfa672c
fdo#55380 replaced use of obsolete interfaces
...
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef
Reviewed-on: https://gerrit.libreoffice.org/11256
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-09-10 11:48:43 +00:00
2fe5d93f82
semibold->bold
...
Change-Id: I563f4530f2003ea3090cd15696ea53143f7b3aa6
2014-09-09 17:11:31 +01:00
d968c28287
fdo#45071: Remove ENABLE_NPAPI_INTO_BROWSER left-overs
...
...from previous commit
Change-Id: I945faa6215f971ce817c6450fe0786da0696091f
2014-09-09 15:20:35 +02:00
496bc3cd6c
fdo#45071 Remove Libreoffice browser plugin
...
This removes ENABLE_NPAPI_INTO_BROWSER while it should keep
ENABLE_NPAPI_FROM_BROWSER (embed flash in LO) intact.
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
Conflicts:
extensions/source/nsplugin/source/npshell.cxx
Change-Id: I80a9159a75653c74423d8fdc7c188568d3188e04
2014-09-09 15:20:35 +02:00
ed75aa2719
create clang plugin to warn about C-style casts
...
We don't like C-style casts in our nice C++ code
Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-09-07 02:42:30 -05:00
2e3f30c58e
Add help button to dialog
...
Change-Id: I2b4eab22da81379a94b21947872a4dc2e9214c5f
Reviewed-on: https://gerrit.libreoffice.org/11210
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 06:49:58 -05:00
475991cff8
FDO#83283 (part) help btn for Label Field select'n
...
Help button for Calc Label Field Selection
Change-Id: Ia3024992ff804be469cf32caf1a2b84675557415
Reviewed-on: https://gerrit.libreoffice.org/11208
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 06:46:13 -05:00
70946992d4
Fix some *_component_getFactory function types
...
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
2014-08-28 16:11:33 +02:00
27d79b12e1
QueryBox RID_QRY_* -> MessageDialog + string
...
Change-Id: I3349a513a1e1b6fefd1f0f07a8a0798a325d87db
2014-08-25 12:27:52 +01:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
961d061ba1
set names on some UNIX-only threads
...
Change-Id: I4c247916256618312e7d98673d9db4d26e26fa39
2014-08-25 13:21:58 +02:00
32ce5ae15a
Avoid possible memory leaks in case of exceptions
...
Change-Id: Icc073be041ae0b0c690e869a0edaff3515d1d601
2014-08-25 10:27:10 +09:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187
fdo#82577, fdo#82579: Handle Cursor
...
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.
Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
f7a65a1096
Remove useless include tools/debug.hxx from forms and extensions
...
Change-Id: Idc8ecbb65c7c4c63950d8b249e0d0d91788d6d3b
Reviewed-on: https://gerrit.libreoffice.org/11012
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2014-08-21 07:09:21 -05:00
e636997370
rename define too
...
Change-Id: I33c9c867f058d69739d1389c76f76f89f1150b93
2014-08-20 22:02:18 +02:00
