Commit Graph

6125 Commits

Author SHA1 Message Date
911faa4db7 coverity#1242844 Untrusted loop bound
Change-Id: I64a805503d0c044b5c5a80df1513e35df5c39171
2014-10-28 16:10:42 +00:00
2de8674047 coverity#1242746 turn this around to help out coverity
Change-Id: I06cc94395e6421b7e01811b3d5f17c2677650a83
2014-10-25 16:56:21 +01:00
0465ba4c35 Add missing semicolon
Change-Id: I9fb4471082a3c20cf94539a971c9d073fa949584
2014-10-24 11:51:02 +03:00
dc4d6c5963 coverity#704231 Logically dead code
Change-Id: Ic54f25f40416401be3a95880fe1bdc4496be935c
2014-10-24 09:24:53 +01:00
5802eb3a61 coverity#704228 'Constant' variable guards dead code
Change-Id: Ia3ccd40ae4a83b58f7d5986273c5bd7d8310b467
2014-10-24 09:24:52 +01:00
07ff3d965f coverity#703957 Unchecked return value
Change-Id: I3a5c0239f4615ff0ba832ac4c733c26e25c259e6
2014-10-24 09:24:52 +01:00
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
e2548315bf loplugin: cstylecast
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
2014-10-23 12:36:15 +02:00
04d34c63c7 coverity#1242688 Untrusted loop bound
Change-Id: Ic3e2c390de22d3e998daf760d73619218da020ec
2014-10-23 11:13:24 +01:00
d4617ef9c3 coverity#1078541 Division or modulo by zero
Change-Id: Iea43399c70e56ff4e32953a5ddc5751abed39ff7
2014-10-23 11:13:24 +01:00
ce59240410 fdo#85324 Prioritize writerglobal8_template detection
Change-Id: I0454b52dcfe1514f81ddfc97a4f9246d6d2571f7
2014-10-22 16:49:16 +03:00
e8204fe4cb Resolves: ooo#40683 support word for windows 1
via the standard .doc binary filter

Change-Id: I0284fa815e6874d7d59ad1ad8ede4482d2e266a4
2014-10-22 13:11:34 +01:00
9ecac3874d Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.

Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-22 09:30:23 +03:00
d0be09322d coverity#1242908 Untrusted value as argument
Change-Id: If9dd92c361d406c435329d29870dc8bb07a8ba7b
2014-10-21 17:23:17 +01:00
6cc11e591f true on success, false on failure
Change-Id: Iaba5f2634e985cf41d52bedcbf7ac1c060d02c1d
2014-10-21 16:30:07 +01:00
3a6e9fb873 Add a filter for AppleWork's presentation file...
Change-Id: I9f03ecc6d67ad77ccb0d5240fe0b5968c8063bd3
2014-10-20 14:47:57 +02:00
366c658c77 add CVE-2013-4979 test
Change-Id: I54025f46394ec1b16443ba75ff9edf9d8e1f6738
2014-10-20 10:57:21 +01:00
0694856737 add eps import regression test
Change-Id: Iba88c7e54ba83132a859124d51f88be72cb3e3e1
2014-10-20 10:57:20 +01:00
3661bcded8 coverity#703957 Unchecked return value
Change-Id: If9e3e7297b1539c93902895c50af3fb8f6c83a76
2014-10-20 10:57:16 +01:00
1361dfc0aa coverity#1242606 Untrusted loop bound
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-20 10:57:14 +01:00
6118c11a0c coverity#1242582 Untrusted loop bound
Change-Id: I72d2c4979b62a025d212ce5ee3b7141c40376fa7
2014-10-18 10:45:29 +01:00
0445a0ea1b add a regression test for .met files
OS/2 Metafile Format

aka

Presentation Manager Metafile File Format

this format appears to not to have a mime-type

Change-Id: I8b2356fb42272a6e0550abf09f46b051d22b64a5
2014-10-18 10:45:29 +01:00
5bdfa8c124 Resolves: fdo#62682 crash on second export of svg
because the first export has left "dangling" CalcFieldValueHdl Links in
Outliners that got created based on the Drawing Outliner while it had a
temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl
installed when the old Drawing Outliner one was re-installed.

Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17 15:20:00 +01:00
711e74544d coverity#1242624 Untrusted loop bound
Change-Id: If2ae1982eec100f5602a13d648beec247ced6aa2
2014-10-17 15:19:58 +01:00
cf63ebe0f0 coverity#1242717 Untrusted loop bound
Change-Id: I983bba075ab9626c90555fa41f9d473ae60fafea
2014-10-17 15:19:56 +01:00
bbe264a19f coverity#1242724 Untrusted value as argument
Change-Id: I6041d09ef0a4ed4af5f1bf93f31a1eac60be1af7
2014-10-17 15:19:56 +01:00
afcd04f74b Missing const
Change-Id: I8d05851c162ee9215f773ebfb9435e549b1572d4
2014-10-17 14:37:31 +02:00
fc78d8dfba Pass args by const &
Change-Id: I510e1aba6772e1f8d4013b235e95a1e5599fd601
2014-10-17 14:23:46 +02:00
582ef22d3e fdo#84854 it seems long is not enough on 32 bit
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
57d3b5cfa6 Update to last libmwaw version
+ add filters for MacDraw, MacDraw II and RagTime (v2-3 for Mac)

Change-Id: If84abff1baa75f9bfa951039781575b6a8648a84
2014-10-16 17:44:43 +02:00
9341bf3dc3 java: when rethrowing, store the original exception
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
0f86ae0689 java: no need to call toString() on a String object
Change-Id: I05fa4bf198b3d77b1217eb65b5a1c79915016522
2014-10-16 08:15:44 +02:00
cb4cb0c053 one of the oddest things I've seen
Change-Id: Ia0240d212a39401ea119588f4a0731b2b99d1d1f
2014-10-15 16:56:59 +01:00
b1023801e4 Blind Win fix attempt
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15 16:16:46 +02:00
ad9498f8b8 More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
7d05bbd50d avoid double-delete
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e.

Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15 11:41:51 +02:00
bd86b38c5b Make ImportCGM signature match ImportCGMPointer (in sdcgmfilter.cxx)
Change-Id: I363777ff59b1756a15615d3daaa0c95542632361
2014-10-15 09:45:27 +02:00
e9e0ab4777 fix tinderboxen with the right sort of brackets.
Change-Id: I13869771890ce5702d64053e7823dd5cedc82a40
2014-10-14 18:16:52 -03:00
b13591d48f valgrind: init GroupLevels
Change-Id: Idccebc826ade29a507e115108d20fd461b7bb4ec
2014-10-14 17:13:46 +01:00
740617901d stray ;s all other the place
Change-Id: If67bf3361e082c1321f42ae7717cc941dc96e74b
2014-10-14 17:13:46 +01:00
b251762c65 valgrind: multiple errors
Change-Id: Ic0ee492710650165004ad05f523424ba1b094473
2014-10-14 17:13:45 +01:00
2e23493987 check for short reads
Change-Id: I98a7d77cabe0207ff2b0190ccef47b87d1552930
2014-10-14 17:13:45 +01:00
aeea1cab43 sal_True->true
Change-Id: Idbbc50afbb229dca1b62a7a0d1b2eeec9b0418d5
2014-10-14 17:13:45 +01:00
b2b5bc10b6 valgrind: Source and destination overlap in memcpy
Change-Id: I0b83a1955b6752c1253cfd7992a50b932aac078d
2014-10-14 17:13:44 +01:00
61550120b4 valgrind: Mismatched free() / delete / delete []
Change-Id: I78a9e08fb3535f9fe6c61a6e192c7aff4ef0c527
2014-10-14 17:13:44 +01:00
4d82ccb1ed valgrind: Mismatched free() / delete / delete []
Change-Id: I293229dabb9a04f2e76b556e9da66921328ebe23
2014-10-14 17:13:43 +01:00
af5ebbf783 create a macro library for implementing bit-flags types
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
changed from a macro- to a template-based solution.  (Unfortunately MSVC 2012
does not support explicit conversion operators.  Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)

Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13 17:45:57 +02:00
34de4f3e1c coverity#1130166 Unchecked return value
Change-Id: I0730a099463ac77afce4bb999f3f00ad7bb097c7
2014-10-12 16:39:52 +01:00
3d85ec29dd filter: stop leaking temp files in xsltfilter test
Change-Id: Icefec168910ba0b059f4b1887ec67cce8505ffd6
2014-10-11 00:28:47 +02:00