8fbbb94a39
coverity#706537 Uncaught exception
...
Change-Id: I687948ef04e4ffdce51a7ac20854d6ebe96f1f25
2014-10-27 14:34:22 +00:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
e2548315bf
loplugin: cstylecast
...
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
2014-10-23 12:36:15 +02:00
182fc4f184
fdo#84938: replace WINDOW_BORDER constants with enum
...
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21 09:06:40 +02:00
ae218f4895
tweak CaughtException
...
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
2014-10-20 16:17:58 +01:00
66da64c748
Missing include
...
...and only use getCaughtException as first statement in catch block.
Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
2014-10-20 15:42:36 +02:00
9e8a88b6da
coverity#706540 Uncaught exception
...
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
2014-10-20 10:57:19 +01:00
4fd65ac329
coverity#706538 Uncaught exception
...
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
2014-10-20 10:57:18 +01:00
67c9d05451
fdo#84938: replace TIB_ constants with enum
...
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-20 07:16:46 +00:00
03c7c26cbe
java: final fields that can be static
...
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
12b01b920f
java: no need to call String.valueOf to append to a String
...
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
9341bf3dc3
java: when rethrowing, store the original exception
...
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
bbd5a30411
java: ensure that the stream is cleaned up before the method returns
...
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d
Reviewed-on: https://gerrit.libreoffice.org/11991
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-16 10:25:18 +00:00
af5ebbf783
create a macro library for implementing bit-flags types
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >,
changed from a macro- to a template-based solution. (Unfortunately MSVC 2012
does not support explicit conversion operators. Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)
Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13 17:45:57 +02:00
cb7ede2d99
convert vcl StateChangedType to enum class
...
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:32 +00:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
02ace92aba
java: optimise calls to toArray
...
passing in a correctly sized array requires one less allocation
Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07 13:20:01 +02:00
0658889bcd
fdo#39468 Make forms/ German comments clean
...
Change-Id: Iec24928324bec1caee65ca37cbf0fb5b66e6975e
Reviewed-on: https://gerrit.libreoffice.org/11760
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-02 11:38:29 +00:00
4173bc5f7e
forms: enhanced for loop
...
Change-Id: I0c83d6fce9440f5d8b23e5f1bfca71d8f61d056b
Reviewed-on: https://gerrit.libreoffice.org/11719
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-10-01 19:44:53 +00:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
4badca0740
forms: use Arrays.toString in integration.forms.RadioButtons
...
Change-Id: I797692857c874d879192ca9a4ff73b98ed5ebd86
Reviewed-on: https://gerrit.libreoffice.org/11721
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-30 17:42:22 +00:00
73d6c6b51b
forms: replace StringBuffer with StringBuilder
...
Change-Id: Iee1b7ea214e5ed2fdd8bd5fe93dc16fbaaf312a8
Reviewed-on: https://gerrit.libreoffice.org/11720
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-30 17:42:12 +00:00
1c70f59c13
forms: the assigned value is never used
...
Change-Id: I8eadc27ba8880630ec93c68145969f3e8ba6c189
Reviewed-on: https://gerrit.libreoffice.org/11712
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-30 12:19:10 +00:00
62bd1d1783
forms: remove import from the same package
...
Change-Id: Ia15b4586e183bcd24a47c1a072c4d6e8ca280e98
Reviewed-on: https://gerrit.libreoffice.org/11714
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-30 12:16:29 +00:00
3b206d4818
forms: std::auto_ptr -> std::unique_ptr
...
Change-Id: Ia8f045715a508de77c8ce86cf224a3038162faac
2014-09-30 12:28:52 +02:00
bf7ddfdeb7
Fix java.util.Calendar.set in integration.forms.DateValidator
...
Change-Id: I1bd87c623b923469c325ebfcba4ba82e2a648ae2
Reviewed-on: https://gerrit.libreoffice.org/11694
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 12:54:30 +00:00
72f50083e7
forms: getMonth() and getYear() are deprecated in java.util.Date
...
Change-Id: I31664bbd8c1c3b02e8a7381226d4d558b37466a2
Reviewed-on: https://gerrit.libreoffice.org/11690
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 12:44:30 +00:00
16417688ef
forms: Pass array of length equal to the size of the collection
...
Change-Id: Id880953105f6100b15cd78f48ce0c8dbcb7ffb8d
Reviewed-on: https://gerrit.libreoffice.org/11687
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 08:14:26 +00:00
0f8ed32913
fdo#39468 Translate German comments, clean some ws
...
Conflicts:
forms/source/component/FormComponent.cxx
forms/source/component/FormattedField.cxx
Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb
Reviewed-on: https://gerrit.libreoffice.org/11622
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-09-25 08:49:03 +00:00
0e55cc95df
fdo#39468 Translated German to English
...
Change-Id: I7405b8251b977f8e5c1b95c37fbab6ae6cb120e7
Reviewed-on: https://gerrit.libreoffice.org/11461
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-24 18:02:12 +00:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
778dcbc53e
fdo#39468 Translate German comments, clean some ws
...
Change-Id: I4a9b3b3e0d0fefb18808b0b045ffcf3531f4ea28
Reviewed-on: https://gerrit.libreoffice.org/11524
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-19 06:35:35 +00:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
7cd65eef14
Simplify expression to fix bool/sal_Bool ambiguity
...
Change-Id: I249262779519934c3dacc9df76028a994187e3d6
2014-09-15 15:52:30 +02:00
f5e617a6e4
forms: sal_Bool -> bool
...
Change-Id: If69785c37c6c9cd175e149f10bd5497de26a120c
2014-09-15 15:06:45 +02:00
8270808946
Mark template member fns that are supposed to override as SAL_OVERRIDE
...
Change-Id: If940dcf7f7d2144576b4ae55578b8b7bd113295b
2014-09-15 14:58:57 +02:00
86aed3ca6a
fdo#39468: Translated German to English
...
Change-Id: Ica935c641d3858ae875410efc7fe531835feadf8
Reviewed-on: https://gerrit.libreoffice.org/11373
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-09-12 12:09:24 +00:00
ea733ab5b6
Turn SfxItemState into a C++11 scoped enumeration
...
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")
Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2014-09-12 06:08:32 +00:00
ce65d21ddb
Replace uses of old SFX_ITEM_ON alias with SFX_ITEM_SET
...
Change-Id: I64be7ca711dcd3ea7c4d5840a30f2f701d055e1b
2014-09-10 16:37:20 +02:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
26e9e22268
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: I79422149fd25b1531673a517e2a340dbeab43b1a
2014-08-25 13:03:08 +02:00
2d43261c60
Fix *_component_getFactory function type
...
Change-Id: I10414cbc61b5540f1b9f39b19699673868e9c3eb
2014-08-25 12:52:50 +02:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
f7a65a1096
Remove useless include tools/debug.hxx from forms and extensions
...
Change-Id: Idc8ecbb65c7c4c63950d8b249e0d0d91788d6d3b
Reviewed-on: https://gerrit.libreoffice.org/11012
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2014-08-21 07:09:21 -05:00
339d967dbf
forms: CSS -> css
...
Change-Id: Ib2fb1f4f4b64a67cebdebb6ebfb36dbe6878bef6
2014-08-21 09:03:25 +02:00
150df3c020
star* -> css::*
...
Change-Id: I156d40badb1a11727d1320600a9d3af2b8b24e4a
2014-08-21 09:03:22 +02:00
892f4c2ad8
stario -> css::io
...
Change-Id: I4e82694399e72ce17172ac3d3c3cd9f9bcd30ba5
2014-08-21 09:03:17 +02:00