Commit Graph

382 Commits

Author SHA1 Message Date
d701a1a6df Move virtual ScToken members up to FormulaToken
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-23 09:30:09 +02:00
d9f303a030 Remove unused FormulaToken::Is3DRef
Change-Id: Ib720bc4b3bfff8e428d14d65ff73144db82c60e0
2014-10-22 10:58:21 +02:00
08d93506c2 Make these methods non-inline again.
Change-Id: I30c7969ab386f4cba2f0b44cbebe306ce6430b15
2014-10-03 15:31:20 -04:00
1df1c5eed9 formula: std::auto_ptr -> std::unique_ptr
Change-Id: I7b4784abf5177e22a9df33c5d4faccfd39801b11
2014-09-26 15:47:03 +02:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
234fba5b45 convert OSL_FAIL to SAL_WARN
Change-Id: I001f29dca5f2a01d70115bb309c99c64c4a65efb
2014-08-22 19:50:52 +02:00
935147ce9c convert OSL_... to SAL_WARN
Change-Id: I073b6f985c4a67f56319e03790b2bceee2f957ff
2014-08-22 19:50:52 +02:00
0be29a469c reactivate the verify
Missed this earlier. Should be a SAL_WARN, but postponed.

Change-Id: Ia6b178702461c8a0fa5ded3e1c47795b95da7d98
2014-08-22 02:54:32 +02:00
c0aba5007b fdo#82183 do not reset globals while loading a document
Destroying the function list while an instance of the Formula Wizard is
still open is a bad idea. Workaround not doing this when loading a
document due to a DDE function or external reference being entered in
the wizard.

Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
2014-08-22 01:12:18 +02:00
fe4d72b563 it's about time to write GOALSEEK as ODFF ORG.OPENOFFICE.GOALSEEK
Change-Id: Ie5a0464b49baae62e217e87f4d0040151f3aa8a5
2014-08-21 15:43:09 +02:00
7c6a82d66e write COLOR function with extension namespace
and add to Excel import/export maps so it survives saving in that format

Change-Id: I3a8e07fdd1bded77d4bad60eefffeb0b1dbdd734
2014-08-21 15:10:08 +02:00
a240a78cc7 Fixed size of 'formula' dialog in Calc
Fixed:
1. Open Calc
2. Open formula dialog
3. Choose AMORDEGRC function or other with >= 4 params
Edit field is covered by other controls

Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3
Reviewed-on: https://gerrit.libreoffice.org/11035
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 03:12:31 -05:00
e79c427247 remove unused dlg resources from dbu_resource.hrc
Change-Id: I70c5f673413bb6ac2d37a5c15b52fcd26da6683a
2014-08-09 18:12:08 +02:00
3d65212809 fix memory leak around function descriptions
Found by Lsan.

Change-Id: Ia443ed6eb2a20854998a615f3c2bd9fdac156a8c
2014-07-31 22:14:25 +02:00
5021f29841 Remove some unused code
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 14:20:36 +00:00
ce4e7a830d fdo#81038 Fixed FormulaTokenIterator to use std::vector instead of linked list
Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07
Reviewed-on: https://gerrit.libreoffice.org/10565
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-27 04:03:07 +00:00
3fdd4f069d Explicit virtual dtor needed for auto_ptr member for MSVC.
Else it won't build.

Change-Id: I6d857ffc7a444abaf477ee820e577757287a707c
2014-07-08 22:50:04 -04:00
a86d511c1f trivial conversion of RID_FORMULADLG_FORMULA_MODAL to .ui
Change-Id: I25f29821079cf4fa4759daffe78bec8c4b48abbc
2014-07-08 20:49:41 +01:00
08e3e6c223 fdo#73148 add options to Calc function AGGREGATE
matrix-ranges not supported

Change-Id: I902c78da6d9c7a4a5f8c5e4a7e1678b69d49a6fe
Reviewed-on: https://gerrit.libreoffice.org/9449
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-07-08 10:23:03 +00:00
0e09134a4a callcatcher: update unused code
Change-Id: Ia25c686dac799707cae3f6112c731f8cd3f686c2
2014-06-19 10:26:48 +01:00
8309bf5886 remove helpids that are unused or go nowhere
Change-Id: I5af0b84ff4a85e72f5068d450a04d01df0592d3b
2014-06-17 21:13:15 +01:00
73e4a5d091 give refedit in formula wizard an initial size
Change-Id: I8e19c29c47dea2f7cff754e81ef51fc9898fdee8
2014-06-17 21:03:46 +01:00
c842486ab0 restore these for the moment, still in use in sc
Change-Id: I6967a3c871338d1801d913d9bb54eba50a7660ca
2014-06-17 20:49:14 +01:00
b15230153c I could fight with ValWnd to fix it, or I could replace it
it's not handling resizing and redrawing well, so just drop
it in favour of a read-only edit

Change-Id: I5e6f85cf9326b908bf1bf835d8da0c49ca9209c9
2014-06-17 20:42:35 +01:00
0cf14968aa RID_FORMULADLG_FORMULA conversion to .ui
Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8
Reviewed-on: https://gerrit.libreoffice.org/9797
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17 19:42:15 +00:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
c9d037e5e8 resolved fdo#79957 propagate ForceArray through jump tokens
ForceArray parameters weren't propagated and enforced to array arguments
on svJump tokens (FormulaJumpToken), namely IF, CHOOSE, IFERROR and
IFNA.

Change-Id: Icf9074f11b826655a52858d778d9a0122d207aa4
2014-06-13 14:21:34 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
e44e09c400 whitespace clean-up
Change-Id: I10bdfc3356bda66fefa59fa2c9f63f9231d8728e
2014-05-23 02:50:43 +02:00
f824604b5c fix spelling
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-21 13:14:11 +02:00
636581bf87 most certainly == was meant
Change-Id: I1b0833daa576cd8603421e1036b8773badc8c775
2014-05-21 12:45:24 +02:00
c07b8dedf7 ODS load perf: transfer ownership of the ScTokenArray to save cycles.
Add API to wnsure we don't end up allocating 32k bytes of tokens
for each ScFormulaToken, as happens when you Add a token to a new
empty ScTokenArray.

Change-Id: Ib12a3065eb513243a2146ebb009fbaa650385dd9
2014-05-21 10:03:36 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
dd0f844728 add COLOR function
This function makes property mapping in charts more user friendly.

Change-Id: I01cfb31edd749ee474d5078042fa5c4b4a270f86
2014-05-19 08:13:37 +02:00
b6b0b95bae Bail out of group calculation in case the array fetching fails.
Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3
2014-05-14 16:25:38 -04:00
a921d38ad4 No more SetCompileForFAP(). Use respective flag setting methods instead.
Change-Id: Ib2256ebac8a7e63e7e24fb35d13d47b811bd8e19
2014-05-14 13:15:11 -04:00
69a7e7440c Use "stop on error" concept rather than "ignore error if true".
Just to keep the pattern of "true" -> "action", "false" -> "no action".

Change-Id: I6303bc779cd7048eef2fdc3c2abba8be8f15da6d
2014-05-14 13:15:11 -04:00
5db9391c06 Introduce a new boolean flag and use it in lieu of bCompileForFAP.
To make it sound more general than "compile for FAP".

Change-Id: Ia6916b6f3579a290be7d5074f809666be2bd2473
2014-05-14 13:15:10 -04:00
ee636db4dd coverity#1169835 Improper use of negative value
Change-Id: I1857f5c712f9407c8a4b69f30044e8bb444afad2
2014-05-11 21:05:54 +01:00
90c644a862 coverity#707866 Uninitialized pointer field
Change-Id: Ia80922b1819d41e4963689fda87750f0f507fd57
2014-05-10 21:13:04 +01:00
50d100f4ac Make a separate method to detemine if an opcode is a jump command.
Jump to make it a bit more pleasant to follow the code...

Change-Id: Ie9bef122e8bb63a2d8cc54acc9c8ddc9ac9a2e8a
2014-05-01 15:29:24 -04:00
29c9712b04 fdo#73148 (partial patch) Add Excel 2010 function AGGREGATE
Change-Id: If8fc8608699a14e573456af2e1180342be942dd1
Reviewed-on: https://gerrit.libreoffice.org/8475
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-25 09:39:31 +00:00
32efd885e5 formula: sal_Bool->bool
Change-Id: I3280b4d4b02e6a6fa22bc250e56a3c6ae77fc675
2014-04-23 11:10:08 +02:00
0882cc6675 fixincludeguards.sh: formula 2014-04-19 11:10:06 +02:00
eb4c43aa61 Avoid possible memory leaks in case of exceptions
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
625c595fc3 fdo#76294: Intern strings in AddFormulaToken() as well.
And a whole bunch of changes needed to make that happen.

Change-Id: Idd98fbc99322c0d72fb0a7848d89cb1a6abc88b6
2014-04-14 18:34:20 -04:00
b09426b83c fdo#76294: Properly intern string literals in formula on xls import.
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-14 17:00:40 -04:00
712d2793ec Remove unused code
Change-Id: I1355317d6baeb180417cb5f1f34038925c1299cf
2014-04-14 12:49:20 +02:00