wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
362,810 Commits 5 Branches 0 Tags
acd62e055ee71f330b1d48c3c3c83aaa5ceca29a
Commit Graph

5815 Commits

Author SHA1 Message Date
Caolán McNamara
66fae3a2bc coverity#704649 Unchecked dynamic_cast 
Change-Id: Ibeb096d98cba7a55d9d806802473660d30000924
 2014-10-24 09:24:54 +01:00
Caolán McNamara
cf33ce9667 coverity#736876 Negative array index read 
Change-Id: I5e0f2e4633286b320abfb6735232b57aedd3a5b3
 2014-10-23 14:54:52 +01:00
Noel Grandin
035fe8a6aa fdo#84938: replace MENUITEM constants with enum 
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
 2014-10-23 12:55:35 +02:00
Michael Stahl
816e5063b8 framework, unotest: do not override UserInstallation from environment 
The PythonTest_dbaccess_python may fail in incremental builds because of
stale JVM path in workdir/unittest/user/config/javasettings_Linux_X86_64.xml
so it's better to use the fresh UserInstallation that is already passed
in from PythonTest.mk.  To make that work, tolerate non-existing path in
SubstitutePathVariables::SetPredefinedPathVariables() at least when
running in the build environment, which is probably better than
effectively running with "/" as UserInstallation anyway...

This partially reverts commit 6dbb6275ebd1a4299099c3b6bc82ec4ee0e1fb86.

Change-Id: I4d42d53c049056590662828360c4ce5a29af0f4b
 2014-10-22 14:10:16 +02:00
Noel Grandin
67c9d05451 fdo#84938: replace TIB_ constants with enum 
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-20 07:16:46 +00:00
Caolán McNamara
6e417ffe04 coverity#1247630 Uncaught exception 
Change-Id: Ic15d712a26bdb6565b78efc4e9cab1bb09fd1cf4
 2014-10-17 15:19:43 +01:00
Noel Grandin
03c7c26cbe java: final fields that can be static 
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
 2014-10-17 08:26:21 +02:00
Noel Grandin
9341bf3dc3 java: when rethrowing, store the original exception 
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
 2014-10-16 12:27:15 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
cb7ede2d99 convert vcl StateChangedType to enum class 
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-11 15:14:32 +00:00
Noel Grandin
277e98edce cid#1244948 Uncaught exception 
Change-Id: I421f245fd3be90f0e1d08ad92b0723a64121ae12
 2014-10-10 10:14:18 +02:00
Noel Grandin
d7ea649b56 cid#1244950 Uncaught exception 
Change-Id: I1aa4d437838dac42ac1fc803a2ba2a437fa3addb
 2014-10-10 10:14:17 +02:00
Noel Grandin
d79ca9b29a cid#1244951 Uncaught exception 
Change-Id: I3bb5dc5932f4239507920cb9cafa66caab9ff7e0
 2014-10-10 10:14:17 +02:00
Noel Grandin
36ec3ddc0b cid#1244952 Uncaught exception 
Change-Id: Ied23e7df1d8ebda9976e63d03c122c058addf274
 2014-10-10 10:14:17 +02:00
Noel Grandin
fbf3aa391b spelling: instanciated -> instantiated 
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
 2014-10-08 11:02:55 +02:00
Noel Grandin
f635ba0684 java: remove some unnecessary intermediary object creation 
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
 2014-10-07 13:20:01 +02:00
Caolán McNamara
9a65df2513 coverity#1078526 Logically dead code 
Change-Id: I203511fcb1e740d7d371821d49a7c13a72e6fc3b
 2014-10-03 09:07:56 +01:00
Caolán McNamara
ddfb875ba2 coverity#1242768 Unused value 
Change-Id: Ida66a4a4d00caa49e993938f86e357e4351a60c5
 2014-10-02 14:49:00 +01:00
Caolán McNamara
2b08019e2a coverity#1242970 Result is not floating-point 
Change-Id: Icd0b04a2b8d9250418dfec95668fa6c496e45e5e
 2014-10-02 14:48:46 +01:00
Noel Grandin
b1472db9db fix for older compiler, doesn't like <:: 
Change-Id: I8113125b7eb9d919aaf84a1dcde3e58e41e978f4
 2014-10-02 08:48:59 +02:00
Noel Grandin
1777c425fe loplugin: cstylecast 
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
 2014-10-02 07:37:19 +02:00
Noel Grandin
787ca46d94 loplugin: cstylecast 
Change-Id: Idac41288539ff171e1c9fb0e12b172a311878ed6
 2014-10-01 13:08:42 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Stephan Bergmann
00061554c5 framework: std::auto_ptr -> std::unique_ptr 
Change-Id: I6ef5e9018d1e33c205eae934c404d3391a4693f2
 2014-09-30 12:28:52 +02:00
Noel Grandin
83636d2c09 java: when rethrowing exceptions, store the original cause 
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
 2014-09-25 13:47:25 +02:00
Samuel Mehrbrodt
1fb8724f98 fdo#83558 Don't change toolbar tooltip on state change 
Also removed EraseAllMnemonicChars since that method is called later by SetItemText

Change-Id: I10139d437290ccfed6a8a15e8e5ce501e15c2560
Reviewed-on: https://gerrit.libreoffice.org/11306
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-09-24 20:30:17 +00:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Samuel Mehrbrodt
fb1be6943f Always add the keyboard shortcut to the toolbar tooltips 
Change-Id: I6f6e385cf6d09b0a3f18b708daeff2df9aba83c6
Reviewed-on: https://gerrit.libreoffice.org/11595
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-09-22 21:23:46 +00:00
Jan Holesovsky
b1a5e34e27 Revert "Related fdo#81475 Improve toolbar tooltips in Writer standard toolbar" 
Unfortunately this breaks the Edit menu - it is now crowded with long texts;
so while it may improve the toolbar, it definitely breaks the menu.

This reverts commit b59c5ace4b7213ffd62495d0c0e5b6411f5071be.
 2014-09-22 19:00:19 +02:00
Stephan Bergmann
3c6da8e49a Related fdo#77813: $(workdirurl) was always empty 
Regression introduced with cb021fcafba06ccf973f2abe229a4761c0a002de "fdo#46037:
remove 1 comphelper/configurationhelper in framework."

Change-Id: I07727d93315e0d3d87004ce71708271e90a173a3
 2014-09-22 14:16:27 +02:00
Stephan Bergmann
4e0744b002 Unwind one level of cluttering indirection 
Change-Id: Iceaed0e5490b6002c1421d74dfb8f2d0ba38cbf5
 2014-09-22 12:14:24 +02:00
Jan Holesovsky
8da21eca45 vcl: Allow creation of button content from action name (.uno: commands). 
Change-Id: If4b2aef59d45a848fb77de9e1b7bf80d49548a75
 2014-09-22 11:57:00 +02:00
Samuel Mehrbrodt
b59c5ace4b Related fdo#81475 Improve toolbar tooltips in Writer standard toolbar 
and show the shortcut in the tooltip also when there is a custom tooltip

Change-Id: Ia3f5d17df3769479f7aacf63a83507ccb8593103
Reviewed-on: https://gerrit.libreoffice.org/11303
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-09-21 16:06:18 +00:00
Zolnai Tamás
5278a0e3a7 fdo#81237: OpenGL window is not resized by view change 
Reproduce:
- Create a 2D OpenGL chart
- Step out from edit mode
- Zoom in / zoom out

Behavior
- Chart window is not resized, it has a constant size.

When we step out from chart edit mode the chart becomes
an inplace active object (instead of UI active) which means
the m_xDockingAreaAcceptor is removed. On the other hand
it seems we don't actually use this m_xDockingAreaAcceptor here,
so don't need to check whether it exists.

Change-Id: I056109b6e5cac28cdd2aeb8fabd9190413a16ed5
 2014-09-21 15:49:54 +02:00
Noel Grandin
60e78fbb80 fdo#82577: Handle Font 
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
 2014-09-18 08:54:37 +02:00
Stephan Bergmann
b53b5081a8 framework: sal_Bool -> bool 
Change-Id: Ie56d3fe674af048d7aea32f141c5825e4c2aa98b
 2014-09-12 11:48:34 +02:00
Jan Holesovsky
d22edd44b5 vcl: It's a close button, there is no such a thing as a 'closer'. 
Clean up at least vcl + what depends on that, but unfortunately there are
still some "Closer"'s left elsewhere...

Change-Id: I019c863d07ee62d701ff01c8d871334012c105f1
 2014-09-12 08:41:29 +02:00
Julien Nabet
037d03b9fa Typo: (N|n)ormaly->(N|n)ormally 
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
 2014-09-10 22:35:39 +02:00
Jan Holesovsky
846c5a0d3f Fix indentation. 
Change-Id: I0fb904353bc79199d7df957cf756883e425c97eb
 2014-09-09 06:58:27 +02:00
Michael Stahl
57a4337e25 set names on a bunch more threads... 
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
 2014-08-25 13:21:59 +02:00
Tor Lillqvist
30ae83c268 fdo#82577: Handle KeyCode 
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
 2014-08-23 22:33:30 +03:00
Maxim Monastirsky
d15d7b7bba Open the right tab for the More... command 
Partially fixed by Caolán in
3ac80237f310366afef0f7b6c427889d652bd369.

Remaining issues are the paragraph submenu, and the top
menu for both selection and paragraph. Also fixed for
the drawing text and annotations shells (including the
regression created by the above commit, that the dialog
didn't show at all).

Change-Id: I1ba4c825ad48af23ad5c07c8c5f25380952c0be1
 2014-08-22 14:33:28 +03:00
Noel Grandin
c0415d5f1e java: remove unnecessary constructor declarations 
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
 2014-08-20 12:12:15 +02:00
Noel Grandin
8c9fdc4a96 java: remove modifiers implied by the context 
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
 2014-08-20 11:45:28 +02:00
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_ 
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
 2014-08-20 10:35:53 +02:00
Tor Lillqvist
a0de5cc93d fdo#529470: I can't remove a path in AutoText dialog 
This is, not surprisingly, somewhat weird code, but I think this patch does
what is necessary, it does fix the bug.

Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31
 2014-08-19 21:03:05 +03:00
Noel Grandin
4b4bff3402 java: no need to instantiate String objects directly 
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
 2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d java: use 'Short.valueOf' instead of 'new Short' 
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
 2014-08-19 14:57:18 +02:00
Noel Grandin
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long' 
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
 2014-08-19 14:57:17 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer' 
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
 2014-08-19 14:57:17 +02:00