95ca903043
sal_Int16 as the underlying type of WindowBorderStyle
...
because g++ 4.7.2 generates [-Werror=type-limits] as follows:
> [build CXX] vcl/source/window/settings.cxx
> [build CXX] vcl/source/window/paint.cxx
> [build CXX] vcl/source/window/resource.cxx
> [build CXX] vcl/source/window/accel.cxx
> [build CXX] vcl/source/window/accmgr.cxx
> [build CXX] vcl/source/window/brdwin.cxx
> [build CXX] vcl/source/window/accessibility.cxx
> [build CXX] vcl/source/window/legacyaccessibility.cxx
> [build CXX] vcl/source/window/clipping.cxx
> [build CXX] vcl/source/window/stacking.cxx
> [build CXX] vcl/source/window/debug.cxx
> [build CXX] vcl/source/window/globalization.cxx
> [build CXX] vcl/source/window/btndlg.cxx
> [build CXX] vcl/source/window/builder.cxx
> [build CXX] vcl/source/window/cmdevt.cxx
> [build CXX] vcl/source/window/cursor.cxx
> [build CXX] vcl/source/window/debugevent.cxx
> [build CXX] vcl/source/window/decoview.cxx
> In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0,
> from /home/tabe/core/include/vcl/keycodes.hxx:23,
> from /home/tabe/core/include/vcl/keycod.hxx:26,
> from /home/tabe/core/vcl/inc/svdata.hxx:35,
> from /home/tabe/core/vcl/source/window/brdwin.cxx:21:
> /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]':
> /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> cc1plus: all warnings being treated as errors
> make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [vcl.all] Error 2
> tabe@thunk:~/build$
Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c
Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
2014-10-28 08:17:22 +02:00
17a99a9074
fdo#84938: replace TIMEF_ constants with enum
...
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e
Reviewed-on: https://gerrit.libreoffice.org/12114
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-28 06:12:28 +00:00
f70db32aa2
fix writing const arrays on big endian
...
Btw, th unanounced byte-swapping of valuse in the input array in
writeArray seems a bit dubious to me... It could too easily cause
unintentional memory damage. I just hope it is always called either with
data that is not used after that anymore or with a copy of the data.
Change-Id: Ica0e9ea16cd101fe87d7e0a8fa696911769e0654
2014-10-27 16:31:21 +01:00
627a9982f2
cid#705053 Dereference after null check
...
re-arrange the code to help coverity out
Change-Id: Iddc9284cbdcbaae7a0dc17e62d0e8f4b4832297c
2014-10-27 15:32:55 +02:00
3c3257e499
fdo#84844 Sidebar: Use SvxColorToolBoxControl for fill color
...
Change-Id: I0aa9dbef960391334097b68c980064724435db38
2014-10-27 14:28:13 +02:00
7ef698355a
fdo#84938: replace KEYTYPE_ constants with enum
...
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328
Reviewed-on: https://gerrit.libreoffice.org/12104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-27 08:09:35 +00:00
35ae136427
fdo#84844 Sidebar: Use SvxColorToolBoxControl for line color
...
Change-Id: I266cfd8c80088f698ec36662357477bb456a96fe
2014-10-26 12:35:21 +02:00
86bef9224e
Forgot to update this comment
...
Change-Id: I3922bcf22b7efe43fd42c937d88251b230d6384a
2014-10-24 13:06:50 +03:00
b213740cba
-Werror,-Wunused-private-field
...
Change-Id: I2cc9884b23b49eb3e2afd27e5610bf96998a3c7f
2014-10-24 11:20:56 +02:00
518b305279
Related: fdo#84844 Support fill color in SvxColorToolBoxControl
...
Change-Id: I6ccc1d4e71a9fe76cd16dd957f626722aaba543c
2014-10-24 11:45:02 +03:00
0a82645c36
loplugin: cstylecast
...
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-24 08:58:05 +02:00
714c5df9b1
fix LibreOfficeKitInit.h on kFreeBSD
...
Change-Id: I750acd6e3e765a9635829ec2ed8dddf273824595
2014-10-23 22:00:15 +02:00
a7498603d8
basic: pimplify that
...
Change-Id: I0abe66ded0fd69a2720ad64e1a1426aafc7dfffb
2014-10-23 21:30:45 +02:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
8181952731
Fraction: Revert "do not forward-declare templates"
...
This reverts commit 091742e86aeb5287f7236f666fee48946ab4c67b.
2014-10-23 18:34:37 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
143bbb20a3
inline TokenMap::getUtf8TokenName
...
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
2014-10-23 14:30:29 +02:00
f39d69f6b5
Remove few pointless OUString::number() and one method
...
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
2014-10-23 13:24:28 +02:00
d8af144254
FastSerializer: Use faster TokenValue struct when possible
...
Saves another ~100m pcycles for 650k calls in startElementInternal()
Change-Id: I190326edc7feffb900e91fa7e5c3530b5b267f59
2014-10-23 13:24:25 +02:00
035fe8a6aa
fdo#84938: replace MENUITEM constants with enum
...
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23 12:55:35 +02:00
3f89f88651
callcatcher: lots more unused post ww1 filter removal
...
Change-Id: I7bf6dc1d366093e797a19a8e555103c15b311ac8
2014-10-23 11:13:25 +01:00
d45607c4be
Revert recent changes to comphelper::OSequenceOutputStream
...
Some of the changes could be wrong and we don't need them.
This reverts commit 784d4bea86d8cbb3a855e557c465ce50a049cefc.
This reverts commit 8524d5aba59148eef94859289f00ab6477e0e821.
This reverts commit 018f1deae884febbbe639c7ee46b45ce4807e9d3.
This reverts commit 8124fddc5803b4e104d4fc2456cb92cb030d9436.
We use our own helper cache class in FastSaxSerializer
since f736eba5a9df8645849a37b08d2764a5f495ab45.
Change-Id: Iaca6b5b11cb32595db4420a02fa72b0007cf6286
2014-10-23 11:53:19 +02:00
406062334a
FastSerializer: avoid some more OStrings
...
Change-Id: I2d5dbe9adccdd231cc16a1f83a90a4adeb965c64
2014-10-23 11:53:18 +02:00
50d2ffd2a1
FastSerializer: Use FastAttributeList directly to write faster.
...
Change-Id: I28085d4e060bcf052e6aa97a0822a4d653d7c066
2014-10-23 11:53:18 +02:00
e1c503a2e3
fastparser: avoid allocating un-used FastTokenLookup class.
...
This contained an rtl_Sequence complete with horror internal
allocator, caught red-handed serializing threaded loading to no
good purpose.
Change-Id: I837b2c17e4f70fd6a49bed33ad74a7d79f98f35c
2014-10-23 11:53:17 +02:00
20538c2512
FastSerializer: Avoid sequences where possible
...
Change-Id: I359ca9d3b766b71904e4199ebfbdbd5b203775cc
2014-10-23 11:53:17 +02:00
6be21256bd
FastSerializer: Have OString version of write() too.
...
And remove characters() member function.
Change-Id: Ifcedbb6d969b7b057ff378d2fbce09c2dde5ac18
2014-10-23 11:53:16 +02:00
cc3ac382a2
FastSerializer: Do not keep whole sequence in memory; write in chunks
...
Change-Id: Ibca65a2b8397358ac4013c8e5b53389ac6949e4d
2014-10-23 11:53:15 +02:00
8cc5b621aa
Remove mutex from OSequenceOutputStream; it's intended to be fast
...
Make the caller responsible for using it wisely.
AFAICS it's used only in FastSaxSerializer, so far.
Change-Id: I50d48fd7f3e6cdeb9e4637868da213b8171e542b
2014-10-23 11:53:15 +02:00
b7266ddb2f
FastSerializer: Buffer output and write it only at the end
...
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.
The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.
Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-23 11:53:14 +02:00
f89e5ebcf1
vcl: fixup outdev.hxx tab spacing
...
Change-Id: I3ca1784b931dfc4f3dc42abe8f0af588fd6b8bd0
2014-10-23 20:29:40 +11:00
d701a1a6df
Move virtual ScToken members up to FormulaToken
...
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-23 09:30:09 +02:00
a6b01d01f7
gcc4.7.3 complains about the asserts
...
'error: comparison is always true due to limited range of data type'
So just make the underlying type be 'signed int'
Change-Id: Ibf4ff72d85d33e88b7506289c622d34773ca259a
2014-10-23 09:21:48 +02:00
ec1b82e682
Describe text animation types.
...
Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef
2014-10-22 18:07:30 -04:00
f3f1d8eadd
Method descriptions.
...
Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701
2014-10-22 18:07:29 -04:00
9f06a0988d
fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph color
...
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-22 23:25:52 +03:00
e2b84636b3
Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControl
...
The end goal is to convert the Sidebar to use
SvxColorToolBoxControl, and get rid of the Sidebar
specific color popup, so we don't need to maintain
two popups.
Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-22 23:25:52 +03:00
87cb3a7c96
unusedcode: Remove Deflater::setLevel
...
Which makes bSetParams always false; remove that too, together with nLevel.
Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
2014-10-22 16:03:20 +02:00
1a2c28cf0d
callcatcher: update unused code
...
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22 13:11:34 +01:00
f5fc81616c
Avoid unnecessary #include
...
Change-Id: I6ec5de40ce2f4cbcce751dcae16dae60abbc1a37
2014-10-22 13:14:43 +02:00
4b89bd55b0
Speed up xmlreader::Span::equals
...
Change-Id: Id1613a100e96667717cc32f44f84c0916055ea01
2014-10-22 11:46:23 +02:00
d9f303a030
Remove unused FormulaToken::Is3DRef
...
Change-Id: Ib720bc4b3bfff8e428d14d65ff73144db82c60e0
2014-10-22 10:58:21 +02:00
4492b1cf0c
Remove dead CustomerNumber functionality
...
Change-Id: I221d3b9f0bf0f90a117fcf0caead52f2c31f7926
2014-10-21 17:22:55 +02:00
c35fec830a
The only SID supported by PropExec/State_Impl is SID_ATTR_UNDO_COUNT
...
...apparently, given that the SID_ATTR_UNDO_COUNT entry in sfx2/sdi/appslots.sdi
is the only place that mentions those functions. That reveals that all the
other SIDs mentioned there are completely unused. (Also, there seems to be no
need to wrap the remaining PropExec/State_Impl functionality in #ifndef
DISABLE_SCRIPTING.)
Change-Id: Iea7a41aa323b7876d316794cebe962e6e086236d
2014-10-21 17:22:55 +02:00
e73ee8db85
Remove unused SfxInterface::GetResManager_Impl
...
Change-Id: Ia9ad8072b07f0121af18377445c90480ff7c2600
2014-10-21 12:36:08 +02:00
5309cab855
Remove unused pSfxFormalArgs_Impl
...
Change-Id: I0c1e8c42fd03bd861323cbff172031f5405c1597
2014-10-21 12:36:08 +02:00
182fc4f184
fdo#84938: replace WINDOW_BORDER constants with enum
...
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21 09:06:40 +02:00
4332787892
nShearWink -> nShearAngle
...
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
3bb30a68e0
loplugin: cstylecast
...
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20 13:33:58 +02:00
8c8d6f0849
loplugin: cstylecast
...
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20 13:33:11 +02:00
