Commit Graph

181 Commits

Author SHA1 Message Date
d45607c4be Revert recent changes to comphelper::OSequenceOutputStream
Some of the changes could be wrong and we don't need them.

This reverts commit 784d4bea86d8cbb3a855e557c465ce50a049cefc.
This reverts commit 8524d5aba59148eef94859289f00ab6477e0e821.
This reverts commit 018f1deae884febbbe639c7ee46b45ce4807e9d3.
This reverts commit 8124fddc5803b4e104d4fc2456cb92cb030d9436.

We use our own helper cache class in FastSaxSerializer
since f736eba5a9df8645849a37b08d2764a5f495ab45.

Change-Id: Iaca6b5b11cb32595db4420a02fa72b0007cf6286
2014-10-23 11:53:19 +02:00
20538c2512 FastSerializer: Avoid sequences where possible
Change-Id: I359ca9d3b766b71904e4199ebfbdbd5b203775cc
2014-10-23 11:53:17 +02:00
cc3ac382a2 FastSerializer: Do not keep whole sequence in memory; write in chunks
Change-Id: Ibca65a2b8397358ac4013c8e5b53389ac6949e4d
2014-10-23 11:53:15 +02:00
8cc5b621aa Remove mutex from OSequenceOutputStream; it's intended to be fast
Make the caller responsible for using it wisely.
AFAICS it's used only in FastSaxSerializer, so far.

Change-Id: I50d48fd7f3e6cdeb9e4637868da213b8171e542b
2014-10-23 11:53:15 +02:00
b7266ddb2f FastSerializer: Buffer output and write it only at the end
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.

The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.

Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-23 11:53:14 +02:00
f5b1b266bc coverity#1247646 Uncaught exception
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
2014-10-17 15:19:54 +01:00
cb3b90751b coverity#1244953 Uncaught exception
Change-Id: I3c4aeb3318af7cdb964128dd78f7d2cfba48000e
2014-10-10 12:50:16 +01:00
fb6d3b883b disambiguate uniform_int_distribution
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07 14:21:16 +01:00
de78b2ca3c when size_t == unsigned int
Change-Id: If8cd3632d69f6456b0e1351efac0e428e0093e3b
2014-10-06 15:28:27 +01:00
8f436d3de7 use comphelper::rng::uniform_*_distribution everywhere
and automatically seed from time on first use

coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand

Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06 14:13:27 +01:00
c91dec0dad comphelper: std::auto_ptr -> std::unique_ptr
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-25 08:40:11 +02:00
5139fad429 loplugin: cstylecast
Change-Id: I84873c9f84651dc8a1337f37c63020b461314e1b
2014-09-22 12:24:23 +02:00
ed00d0ddd6 create a master document template type
of application/vnd.oasis.opendocument.text-master-template with
suffic otm

https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html

desktop/icons/oasis-master-document-template.icns is just a copy
of
desktop/icons/oasis-master-document.icns
because I can't draw

Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1
Reviewed-on: https://gerrit.libreoffice.org/11350
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-11 09:38:21 +00:00
cb347ddc5c stario -> css::io
Change-Id: Iad96e0a2bfd6c126c696f14919dbfd8e072dd230
2014-08-21 09:03:23 +02:00
edda7dbad7 starcontainer -> css::container
Change-Id: Ie6e75483aa4262a5f66a4c557015af8b3c02d592
2014-08-21 09:03:22 +02:00
123c64ab00 starawt -> css::awt
Change-Id: I76dd16aa2c42a649162ea2e37c824af30cdd557b
2014-08-21 09:03:21 +02:00
78b2d82111 comphelper: starbeans -> css::beans
Change-Id: Iedfc4460194f179b20d734cb7671894213c77008
2014-08-21 09:03:20 +02:00
f133857cc6 comphelper: starutil -> css::util
Change-Id: If4c0d404b0f7027837dcc245b5b7d21b1f749347
2014-08-21 09:03:20 +02:00
32093237b3 comphelper: starlang -> css::lang
Change-Id: Ie8adb5b81df51fd973cbb786f27ea3ef1462679c
2014-08-21 09:03:19 +02:00
007099ea32 comphelper: staruno -> css::uno
Change-Id: I21991280c5b7e4c6d0c200f4489c89a9f4fbc385
2014-08-21 09:03:18 +02:00
f340f04546 Pick a more suitable type for nLength
Change-Id: I6e38b82f08884c4e187e5b3ca2c95a0d4ca8d541
2014-08-20 14:04:58 +02:00
7a54951fbb coverity#1231667 Unchecked return value
Change-Id: I40d8fc61b1e488955faa61c868877c7b6487c529
2014-08-17 16:39:22 +01:00
d005acae3a Resolves: #i125386# secured user request and changed some bools to bitfield
(cherry picked from commit 5e3cbe056c19bea5018dbf1fd4b2bc8f8b030ff3)

Conflicts:
	comphelper/inc/comphelper/embeddedobjectcontainer.hxx
	comphelper/source/container/embeddedobjectcontainer.cxx
	sfx2/source/appl/linkmgr2.cxx
	svtools/source/misc/embedhlp.cxx

Change-Id: I7e9b20a87ca6afe8cb91c577860a6c6b72368ee9
2014-08-09 14:13:08 +01:00
0465a063b9 Fix *_component_getFactory function type
Change-Id: I91b18d4a96d10070fb9e7be76ea39b07541fa4db
2014-08-08 13:25:23 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
f692c88e60 use SimpleReferenceObject in comphelper module
to replace hand-rolled version

Change-Id: Ie4e66d2f1f893c04be589877ef53f470ca74c9eb
2014-07-08 15:16:48 +02:00
2134c9653e comphelper: sal_Bool -> bool
Change-Id: I7d7ae1f5ddff0cf7d11a407b190256f37a71d48a
2014-07-03 11:51:01 +02:00
37b1835972 Revert "comphelper: sal_Bool -> bool"
Oops, this reverts commit c95ff75df274e3d84458e928ee96870bc8b663b3.
2014-07-02 18:54:32 +02:00
c95ff75df2 comphelper: sal_Bool -> bool
Change-Id: Icde90101b6adfa766c8abbeb55c518725e6596e1
2014-07-02 18:49:31 +02:00
ffef410b12 No need for these functions to be virtual
Change-Id: I1f01d07fea397e686609f49b909f5898c7f412e1
2014-07-02 17:58:38 +02:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
5106c5fdca Remove newly unused comphelper::ImplementationReference
Change-Id: If272d5025e08fcf5e67de30ffdf177383ef59370
2014-06-18 11:26:34 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
31778e3eeb coverity#707350 Uncaught exception
Change-Id: Ic338659d34c91baad715c2181f420d919acf1fe9
2014-06-10 16:08:05 +01:00
c2034f3993 fixincludeguards: fix include guards
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06 19:16:40 +00:00
41066fef1c comphelper: remove SAL_THROW macro
Change-Id: I692f1213c4bf42a84fae119f513e609d8874bf0c
2014-06-05 08:17:46 +02:00
909a76c7da New loplugin:inlinevisible to flag inline functions marked DLLEXPORT
...which does not make sense.  On Linux and Mac OS X, they potentially end up
exported from multiple libs (weakly, though), while on Windows the potentially
even end up not emitted at all, which could cause link errors.

Change-Id: I092c9ba39e686c17b6e91581cdd4753f1c4d582f
2014-05-30 14:12:31 +02:00
340bcdea84 Revert "Add function to catenate n copies of a string"
COMPHELPER_DLLPUBLIC of an inline function is wrong. Nevermind that I just
followed the example of the preceding functions.

And it is too bikeshedding-inducing anyway to use recursion.

This wasn't used anywahere yet anyway in committed code, just locally in a
tree of mine. Will add a local copy there.

This reverts commit ee0d7d4c52fe93ef2ac73d403f61b642f1ae2716.
2014-05-30 12:09:18 +03:00
ee0d7d4c52 Add function to catenate n copies of a string
Change-Id: Iba203e18fea2a374e0e0b5c988012ee8fd5369e7
2014-05-29 15:16:51 +03:00
99faf61bcd coverity#983961 Uncaught exception
Change-Id: I4316d9b2465f2608ac5d5992b5a2dc07d1713100
2014-05-24 16:10:59 +01:00
96e6f65907 coverity#983964 Uncaught exception
Change-Id: Ieb298e45512ab4c0384ea2d7ef6adcc4adc39923
2014-05-24 13:03:51 +01:00
652eb268f0 coverity#983966 Uncaught exception
Change-Id: I4928d7e9c9f4cd0dd3f6b1236da9283666766a47
2014-05-24 13:03:50 +01:00
26055db273 coverity#983968 Uncaught exception
Change-Id: I316fba5afdc0ca913d9932eba8a35ad3a9bf0bbe
2014-05-24 13:03:50 +01:00
9329cd7fbe coverity#983969 Uncaught exception
Change-Id: I56c8145f45da3f3265ddcc22a011ec6111b0a8ca
2014-05-24 13:03:50 +01:00
461af81291 coverity#1210079 Uncaught exception
Change-Id: I135e6f7e744afbf6acdb1cfd636e301219ef1420
2014-05-23 14:16:01 +01:00
787d41c26d coverity#1215313 Uncaught exception
Change-Id: I22cd98a35c6c638e3476d54b742762d8a2dfa7fa
2014-05-23 08:54:37 +01:00
9c3e819f06 move boost rng wrapper from sc to comphelper
so we can re-use it in other modules

Change-Id: I6057b1e955f745019fd48f91a754279df0f2b948
Reviewed-on: https://gerrit.libreoffice.org/9348
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-17 12:40:39 +00:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00