Commit Graph

262 Commits

Author SHA1 Message Date
0c0c77af06 coverity#1247635 Uncaught exception
Change-Id: Ic346a5820102a922f54c971e01587601991bd484
2014-10-17 15:19:47 +01:00
4b7b013491 Resolves: fdo#44998 crash when opening context menu of a field
If you right click on a field in an inactive text box, then a mouse down,
context command, mouse up sequence is sent. The mouse up is supposed to be
captured by the context menu here. But it doesn't because the mouse down in
draw sends an artificial mouse down to the editengine which eventually sets up
a MouseCapture window so the context menu doesn't get considered (because it
occurs before the capture window is released) so the mouse up gets send to sd
while the context menu is up and that causes all sorts of havoc.

Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-10-07 16:55:08 +01:00
ede0abe6b1 Bin EE_CNTRL_URLSFXEXECUTE which was only set, never tested
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02 21:09:52 +03:00
1d0636ebc6 Bin commented-out #defines
Change-Id: I01f473658708a75c3eac6219efd38cd8ec5aa44f
2014-10-02 21:09:52 +03:00
4923ac72aa loplugin: cstylecast
Change-Id: I58582059495f7c50880038e2174ea2de026aa1c9
2014-10-01 13:08:42 +02:00
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
9bcd96a36e clean up some weird type-casting in SvxRTFParser
...it was casting between a std::vector and a struct.
Just store the struct.

Change-Id: I37afa2ea27aa45d0849e01b45837129719eaf138
Reviewed-on: https://gerrit.libreoffice.org/11705
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-30 16:38:53 +00:00
c9d4a2887c fdo#82577: Handle PolyPolygon
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
a924606810 editeng: std::auto_ptr -> std::unique_ptr
Change-Id: I25e3599a37d720cbcf70ea13ab30234e54637d53
2014-09-25 17:35:05 +02:00
5001357be9 Remove unnecessary #include
Change-Id: I7cc165095db24761d086680b70ef3ed81fd30f19
2014-09-25 12:24:56 +02:00
e16c8534f4 fdo#47302: Added insert->fields->page title button
Change-Id: Iebc8298a7e6a7d423d2667eec8a46a936cc4d2cd
Reviewed-on: https://gerrit.libreoffice.org/11599
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24 19:30:05 +00:00
4e82025189 Replace some std::auto_ptr function parameters with std::unique_ptr
Change-Id: Ic66d325fd9559c6dde9556c26e5b2a7e60376c49
2014-09-24 16:06:52 +02:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:47:44 -05:00
d59e728be6 Remove (misleading) EditEngine::QuickRemoveCharAttribs
Change-Id: I7a0be4e204a239dfdd9c184b3d54a69debe8a208
2014-09-03 21:05:19 +02:00
c86f7df94d QueryBox RID_SVXQB_* -> MessageDialog + string
Change-Id: I37aeefe36953c80a1218e2634153906dd5cb3c1e
2014-08-25 16:45:23 +01:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
dd1c49d172 Simplify autocorrect loading - removing redundant parameter.
Change-Id: Idc1ebba8d859ec79b6744228cfe3ef1f0992e41d
2014-08-22 16:22:12 +01:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
d2a3b21ade coverity#1132709 Uncaught exception
Change-Id: If828f82e36d12ceca7e6392de5757a131c99462c
2014-08-17 16:39:20 +01:00
af246f9455 Apply a simple pimpl idiom and rename the old Impl to make it non-Impl.
The old Impl instance is ref-counted, which I'd like to convert to using
boost::intrusive_ptr.  But to make it happen, we need to really hide this
from public header...

Change-Id: I1f1e9e500f2112eea04e3e6d661a7dfa74655c62
2014-08-14 11:17:26 -04:00
92c5536cd5 coverity#982278 Resource leak in object
Change-Id: I0d0cf666ac8ecd55b4d3ba783b1e17670d6eb566
2014-08-07 18:00:45 +01:00
7e018afaf7 simplify return argument of SfxPoolItem::GetPresentation
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.

Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-29 11:04:01 +02:00
88a874fcb3 convert SfxItemState constants to a proper enum
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
6db415b150 coverity#706504 Uncaught exception
Change-Id: I727779317672fe58c440aee76762d0a9ae28d8ca
2014-07-06 15:15:11 +01:00
82f291d2f7 Resolves fdo#79276 Add fallback system for autocorrection of French variants
1) Replace the creation of acor_fr-FR.dat by acor_fr.dat since there's no specific for variants of fr
2) Add a fallback system to use it

Change-Id: Ia3e11fff0f266839dc148077b50c1b2f798d1c50
Reviewed-on: https://gerrit.libreoffice.org/9825
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-03 12:43:28 +00:00
59a2e1b9fa Cleanup: removed comments and debugging output
Change-Id: I41f13d33da641153784725344f5bd526ca69542b
2014-06-30 22:54:44 +02:00
4bfa845b3a Associated CharBackColor to EE_CHAR_BKGCOLOR
Change-Id: I3ce7b235aed71a51ccfa154227be16b3b2265d2a
(cherry picked from commit 48647d731c3f85ce2ed9b3f89d73f805976118f5)
2014-06-30 22:54:43 +02:00
f9e020227a Added case in editdoc.cxx
Change-Id: I572d79dfd770eaa13d24b27f1c689a059cb79153
(cherry picked from commit 073be3ab511a33e639135703caa2229c1f105b54)
2014-06-30 22:54:40 +02:00
139ca8f264 Added EE_CHAR_BKGCOLOR
Change-Id: If11271f4b3b8f9ab67961206856938046ea2a416
(cherry picked from commit c2580813426a58cd2ab22efacec9d28423201562)
2014-06-30 22:54:39 +02:00
4693d7cc99 Added class SvxBackgroundColorItem
Change-Id: If10795bbbd9fc911896b57bbab5410bc1e62f71f
(cherry picked from commit ad6a2607f09d2f770e683a21ad7243a077d65a7a)
2014-06-30 22:54:39 +02:00
be34ea6f62 Cleaned up code from operations in vcl
Change-Id: Ica5194f0cf6e30ec099974ae8b794fb2bc5e654a
(cherry picked from commit 4445f361aa2730b61fdd339dcdd7014b266e5c42)
2014-06-30 22:54:38 +02:00
fcbfcc75ed Added EE_CHAR_BKGCOLOR
Change-Id: I767e2df4e5451c208b26c568f1977d820aa4075c
(cherry picked from commit 8118ec855bbc2d55afd0438ba698c24fb0006d58)
2014-06-30 22:54:38 +02:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
05f90a9afe Paragraph argument never used in InvalidateBullet
Change-Id: I07ba855e473fb137551e70de9cfa858c5e079324
2014-06-13 17:06:06 +01:00
26b1c43091 Bin unused file
Change-Id: Ibd4ded85d5d3e1de8bf12934cbe55210d1983b18
2014-06-11 22:43:30 +03:00
eb4cd7e74d some remaining sal_uInt16 to sal_Int32 editeng ESelection bounds
Change-Id: Ib47dea5c2d965cf613c465e624a1bdd81becb1c2
2014-06-09 12:27:56 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
5ceded62aa editeng: remove SAL_THROW macro
Change-Id: I8e36112a10cdef6250dba4b4cf75e5eba443e0b9
2014-06-05 08:17:47 +02:00
b88ab17551 header guard naming consistency
Change-Id: Iebbf5c586f5d2961be98b12638def3adbadef136
2014-05-30 13:05:55 +02:00
9e3cc6b474 fdo#68849: Add header guards to all include files
Added header guard to files in directories i18npool/, include/, and io/

Change-Id: I7ba5b5f0ffdf5dedb8fd40e8efa06936e7c23591
Reviewed-on: https://gerrit.libreoffice.org/9558
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-30 01:45:21 -05:00
abe5aaa726 coverity#706505 Uncaught exception
Change-Id: Ia00361fb1d86223a7ed65f0be295b291183e3ad6
2014-05-28 13:49:51 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
064ca92484 hrc files should have hrc suffix
Change-Id: Iadbedc145c85c5f333e4449704fd01d5e12ddde5
2014-05-18 12:10:02 +02:00