Commit Graph

87 Commits

Author SHA1 Message Date
1361dfc0aa coverity#1242606 Untrusted loop bound
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-20 10:57:14 +01:00
b1023801e4 Blind Win fix attempt
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15 16:16:46 +02:00
7d05bbd50d avoid double-delete
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e.

Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15 11:41:51 +02:00
4c12951a03 Typo: compatability->compatibility
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
2014-10-12 13:00:46 +02:00
ad8c2f7090 fdo#75757: remove inheritance to std::vector
from SvxMSDffShapeOrders.

Change-Id: Idf551f1fbde907759d6a296141e2837264dbbb10
Reviewed-on: https://gerrit.libreoffice.org/11840
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-08 15:18:32 +00:00
b1d48f0d9a fdo#75757: remove inheritance to std::vector
from PptSlidePersistList.

This also puts in assertions that every entry in a PptSlidePersistList
is non-null.
Cf. 9536a28ede89e8c29940e8ba225215a45667062c

Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a
Reviewed-on: https://gerrit.libreoffice.org/11807
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06 14:09:20 +00:00
c9d4a2887c fdo#82577: Handle PolyPolygon
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
402bb706da filter: std::auto_ptr -> std::unique_ptr
Change-Id: Id1d0392e1dbd33de326aa2bd8cbcf8cc03bf7c90
2014-09-26 10:14:30 +02:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
e6fdd7ad0a The bLastBoxInChain fields are unused
Change-Id: I741733a053c8b0123be8efbcb9fde39f53f6d83c
2014-08-22 14:48:25 +03:00
db12d9042c bHasUDefProp is unused
Change-Id: I8eae6f1ed791ba92c3b4679d1b9f8041f16678d1
2014-08-22 14:48:25 +03:00
f8bf090bbb These "newly added" record types are publicly documented nowadays
Use symbolic names from the MS-PPT RecordType documentation,
http://msdn.microsoft.com/en-us/library/dd945336(v=office.12).aspx

Change-Id: I1deecfc69dd3360ef982f144d5ff5348a2953280
2014-08-21 12:33:19 +03:00
439c90916c warning C4800: 'int' : forcing value to bool 'true' or 'false'
Change-Id: I011954c2e12abb8a7551638567474e2123d3221e
2014-08-17 05:15:25 +02:00
245df9b4b3 fdo#78663 : The File gets corrupted when saved in LO
Problem Description:
The docx file contains a word art inside a drawing tool.
After RT, nesting of <txbxContent> tag is happening which
is causing the corruption.

Solution: Created a service in util.cxx for checking
few shapetypes for which textbox with content is not
allowed. This check also helps to find that if we are
already inside a DML then we should purely read VML
Information.An existing UT testWordArtWithinDraingtool
was failing. The UT is related to same issue
(word art inside drawing tool) hence changed it
accordingly. Following is the commit id of the
UT-Change-Id: I00e94712e912ad1977fcb65a945fefb927795d77

Change-Id: I7e456c9f6a69af80da443e29eb02a64ba7d59468
Reviewed-on: https://gerrit.libreoffice.org/10229
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Luboš Luňák <l.lunak@collabora.com>
2014-07-21 15:03:25 +00:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
2537d2dd49 convert some sal_uInt8 fields to bool
Change-Id: Icd5845367157cc0b0c9342c6037b199c49432a76
2014-06-03 08:21:39 +02:00
19b159416d SvxMSDffImportRec: these members are all 32bit "signed integers"
Change-Id: Iee1dab4895970628e5f5c4ee6070f7f67ba2df8c
2014-05-24 18:34:07 +02:00
7b34d19473 sprmids is used only inside sw/source/filter/ww8
Change-Id: Iebae4a08a452117e71f72836ed686221031a61e6
2014-05-14 22:37:25 +02:00
2732f2b18d coverity#707784 Uninitialized scalar field
Change-Id: Ibbe836d360fad481f2828b703871c8a242767cef
2014-05-10 21:13:03 +01:00
371046c6a3 add missing modelines to cxx and hxx files
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-24 11:58:15 +02:00
187a513742 coverity#1202981 Non-virtual destructor
Change-Id: Iabf91e6c8e450b72b83de51c6a1fb6986f88b430
2014-04-16 11:23:14 +01:00
893590f16e The entry points for these are hidden behind OSL_DEBUG_LEVEL > 1 too.
Change-Id: I728e808ac897aa1be184fb4a8bbbf781eb816cf0
2014-04-14 15:46:22 +02:00
52494aad92 Clean up function declarations and some unused functions
Change-Id: I68b488d45c77ebf82029bfede98dca2400e02f2f
2014-04-14 12:25:30 +02:00
6a7d04a9cb Rename .doc SPRM IDs to match current MS specs
I understand that Libreoffice's names for SPRM IDs come from old
documentation for WW8 (Word '97), plus some later additions named by
OpenOffice developers as they encountered newer SPRMs in the wild.

Meanwhile Microsoft has released newer documentation which supplies
names for these previously undocumented SPRMs, plus it renames some
WW8 properties to have the suffix "80" to make room for newer
versions of those properties.

This commit aims to bring LibreOffice's SPRM ID names in line with
the current file format specification from Microsoft.
http://msdn.microsoft.com/en-us/library/dd923581.aspx

Change-Id: I904c1db17a776e2d9e6076f87369160e3b80f2e4
Reviewed-on: https://gerrit.libreoffice.org/8884
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-07 08:47:44 -05:00
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
c78f918a7c Full colour table borders in .doc export
Currently LO writes table cell border information to .doc files as part
of the "sprmTDefTable" property, but this only supports the WW8 (Word '97)
BRC (BoRder Control) structure which can only select from 16 colours.
There is no newer version of this property.

This commit adds output of an alternate property "sprmTSetBrc" which
specifies border details for a sequence of cells.  There is a WW9
(Word 2000) version of this property supporting full colours.

For LO I have used the constant name NS_sprm::LN_TSetBorder following
the existing naming convention here, which is to use *Border for the WW9
version because *Brc is taken for the WW8 version.

Conflicts:
	include/filter/msfilter/sprmids.hxx

Change-Id: Ie091d91c6d187e1c2542f59f58cec9a373a23e11
2014-04-06 16:53:04 +02:00
5fa564d4a9 filter: LN_TSetBrc -> LN_TSetBrc80 to match spec
Change-Id: I81b78e09130141704c7ec62c1c52bf50d5428dfd
2014-04-06 16:53:04 +02:00
abc429987c filter/msfilter: sal_Bool->bool
Change-Id: I24deda680469ce99ba358a68e83551bdb584751a
2014-04-03 09:17:52 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
ad51d4952d Full colour borders in .doc import/export
The BRC (BoRder Control) structure used in .doc files to specify border
properties has undergone several revisions over time.  LibreOffice
supports the WW6 and WW8 (Word '97) BRC versions, which allow the border
colour to be selected from a palette of only 16 colours.

This changeset adds support for the WW9 (Word 2000) BRC version, along
with some new SPRMs (Single PRoperty Modifiers) which use it, so that
border colours are preserved accurately in .doc import/export.

This change covers:
- page borders
- paragraph borders
- borders around a sequence of characters
- table / table cell borders (import only)

Further work is required to extend coverage to borders of pictures and
export of borders in tables.

The LO code was using the same class WW8_BRC to store the bits for either
the WW6 or WW8 BRC.  This becomes a bit unmanagable when adding a third
BRC version, so I have split this into a separate class for each version.

Fixes fdo#68475, fdo#50185

Change-Id: I7ebc15236497cbab9312d8659fe7ed0bee2c59ed
Reviewed-on: https://gerrit.libreoffice.org/8646
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-03-23 12:57:52 +00:00
d593f45886 filter,formula: prefer passing OUString by reference
Change-Id: I332f1a593853283b72ecf4dfd82b36cc091661b4
2014-03-17 09:00:07 +02:00
47ab3749bf hardcoded sprmCFELayout
Change-Id: I911c1cdf503c46ace38afc80ec63bb0696d1c84b
2014-03-11 14:37:11 +01:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
69388f4753 cid#707782 Uninitialized pointer field
Change-Id: I3392cc01c0f7f69d166900a0dca9a9fcef239772
2014-02-21 11:59:07 +02:00
3e971c792c sal_Bool->bool
Change-Id: Ibd5178f35d735e94065a3fbb6b61de53e53b1b0c
2014-02-14 14:15:13 +02:00
0c7f352775 remove SvStream::operator>> methods
in favour of ReadXXX methods.

Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 19:45:10 +00:00
ed5cf167c6 coverity#708947 Empty virtual destructor
Change-Id: I3f660aff0c53b1cd35c7ae57bde612daf0950349
2014-02-11 20:21:47 +00:00
7ab03b245d coverity#707785 Unitialized scalar field
Change-Id: If3a54628ae6dc0deb605ff075695147d6a58762b
2014-02-08 12:30:16 -06:00
618891adc6 coverity#707784 Unitialized scalar field
Change-Id: Iac0a1bb3dd01cc51d17e040a96a8c866fac01058
2014-02-08 12:30:16 -06:00
47a82e10ca coverity#707783 Unitialized scalar field
Change-Id: I7d294c217da28b45fd94fb256d8f990d0f9427f5
2014-02-08 12:30:16 -06:00
bfcd369f9b coverity#707774: Uninitialized scalar value
Change-Id: Icba50e53a162276b90c1602d22f28fa3ef42f05d
2014-02-08 12:30:15 -06:00
3bd0d1f63d sw: hardwired NS_sprm::LN_CCv
Change-Id: Ibbffd00b146369be75c462f9eea243e3582f14e6
2014-02-06 21:59:49 +01:00
a9102eba62 coverity#707781 Uninitialized scalar field
Change-Id: Ic29735bc125b2b9e662e97402dfccf72f7dedb5d
2014-02-06 15:11:56 +00:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
2df08acc4c sw: hardcoded NS_sprm::LN_CPbiIBullet
Change-Id: I51d4638b588da290853422750b90365b454c046f
2014-01-31 10:52:10 +01:00
a797452912 sw: hardcoded NS_sprm::LN_CPbiGrf
Change-Id: I2a63d1c937392be194c00909213bc89ffe26a550
2014-01-28 21:23:23 +01:00
f0dc6cda75 bool improvements
Change-Id: Ib0f16e57ce84a40412fd95bffd4f41a113810a96
2014-01-28 20:24:40 +01:00
4520e37785 filter: add sprmids header
This was generated previously in writerfilter, but keeping around an XML
file of 8000+ lines just to generate these constants is an overkill.

Additionally, these constants are hardwired in all available WW8 files,
so they won't change. By copying it here, it's possible to incrementally
remove what's still remaining from writerfilter's not used doctok.

Change-Id: I1d30da1f635946b15a37de68080fd9eebc2ad88e
2014-01-27 20:19:14 +01:00