Commit Graph

1380 Commits

Author SHA1 Message Date
1d200aa170 coverity#706590 Uncaught exception
Change-Id: I2005b792c74ad5a5f58c831dcc7caa5134280890
2014-10-27 14:34:22 +00:00
c0c8478620 cid#1249676 Uninitialized scalar field
Change-Id: I87df4e9c1d3f36afccf13aebfd95d1b4f3bfa655
2014-10-27 11:36:37 +02:00
95c798409a package: OInputCompStream::m_xStream is never null
... as proven by the un-checked dereference in the dispose() method
called from the dtor; simplify based on that and assert in ctor.

Change-Id: Id369b80bd89fa59d99b209796c33acb39cbb10f3
2014-10-24 13:58:48 +02:00
0e63397d7f Remove pointless functions now that saveChild() is ZipPackageStream's member
Change-Id: Id43ec2e7ddb1035d3306170523764bb9a74c03b8
2014-10-23 14:30:31 +02:00
4b609883f9 Move ZipPackageStream::saveChild to proper source file
Change-Id: Icd108215874e830e5c9587f7dbb38a7f11ee27c8
2014-10-23 14:30:30 +02:00
1b3122a189 package: Add pure virtual ZipPackageEntry::saveChild()
..and adapt what needs to be changed.
So that, we can kill at least some usages of horrible ContentInfo struct.

Change-Id: I32d41f3b8ce2dfb65f0d1df18a540a3f67dcab6d
2014-10-23 14:30:30 +02:00
152c4afef4 package: ZipPackageStream: prefix members
Change-Id: I02a1c3189c6b52f4f539b0eaa8878985cae8b321
2014-10-23 14:30:30 +02:00
3a8bddc18e package: Add ZipOutputEntry to isolate deflating of streams.
Preparation commit for deflating streams in parallel.
We still use the same single XOutputStream (ByteChucker :-) for
sequential writing but this can now be changed more easily.

Change-Id: Idf26cc2187461660e31ac2e12c4708e761596fb2
2014-10-23 14:30:30 +02:00
aa79a832b4 coverity#706585 Uncaught exception
Change-Id: Ic8d2963536b793f0a229901d9e13d8e54842d9b9
2014-10-23 11:13:22 +01:00
e89358aeca coverity#706586 Uncaught exception
Change-Id: I3ec05ae695428f92b7424295b6f2d3e833c6b162
2014-10-23 11:13:22 +01:00
87cb3a7c96 unusedcode: Remove Deflater::setLevel
Which makes bSetParams always false; remove that too, together with nLevel.

Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
2014-10-22 16:03:20 +02:00
79943fac0d coverity#706591 Uncaught exception
Change-Id: I9b705664c3814aea5c433526ad147a8ab11c2d0f
2014-10-17 15:19:47 +01:00
58a96d3cce bff: terminate on SAXException on malformed input
SAXException thrown and not caught

Change-Id: I874ffbcd457e102b572f398f4e531f4be30ca3d3
2014-10-14 10:04:27 +01:00
ae0756d826 ZipOutputStream: No need to explicitly set default values
Change-Id: Ia3a20e0692e658d847e1b825fc97e32ac8a1854b
2014-10-10 13:50:04 +02:00
9f495d128e Split ZipPackageFolder::saveChild into two functions
And make them static. Probably would be better to kill ContentInfo and
add saveChild as pure virtual into ZipPackageEntry, from which are both
ZipPackageFolder and ZipPackageStream inheriting.

This will also create a bit more sensible call graph when profiling.

Change-Id: If8151332cfa6359e8736c912b7a5633a9162ab36
2014-10-10 13:50:03 +02:00
04ebf43708 package: ZipOutputStream: prefix members
Change-Id: I9cc21ba87484560ec0db5424800dd67f80e00540
2014-10-10 13:50:03 +02:00
3d8f059802 package: Add some 'const' and prefix members
Change-Id: Id177c99ba8b91586cf61457ab2ef084af9c7f490
2014-10-10 13:50:03 +02:00
61d048b71b package: std::auto_ptr -> std::unique_ptr
Change-Id: Iac189fef77c930e35cbd20452027662127047e01
2014-09-30 12:28:54 +02:00
0ecf6afbd1 loplugin: cstylecast
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-29 12:50:35 +02:00
ed00d0ddd6 create a master document template type
of application/vnd.oasis.opendocument.text-master-template with
suffic otm

https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html

desktop/icons/oasis-master-document-template.icns is just a copy
of
desktop/icons/oasis-master-document.icns
because I can't draw

Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1
Reviewed-on: https://gerrit.libreoffice.org/11350
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-11 09:38:21 +00:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
e88157144d coverity#706587 Uncaught exception
Change-Id: I33836bfc2d0e18a12774a9e65d814f50ae10d7b8
2014-08-07 18:00:54 +01:00
80231ff414 coverity#706588 Uncaught exception
Change-Id: Ia1672fe61f9bf158a300d5855e46de2747754ca2
2014-08-07 18:00:54 +01:00
3a1c2d9b41 coverity#706589 Uncaught exception
Change-Id: I60820ab1ea8b13ed6d16e714cd22abce3c2588e5
2014-08-07 18:00:54 +01:00
58edf5120d coverity#706593 Uncaught exception
Change-Id: I9cb2057a866d11dec97e5bfd03d0663d09f079f7
2014-08-07 18:00:53 +01:00
a92bd2988e coverity#706596 Uncaught exception
Change-Id: I1fb6ccbe12e3ec760a5474826170bcbf6b5146f9
2014-08-07 18:00:53 +01:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
5b40565e6a coverity#706594 Uncaught exception
Change-Id: Iad8f124706789299f36127f0d0fd0a47db07bace
2014-07-26 21:25:20 +01:00
850be5e3d1 coverity#706577 Uncaught exception
Change-Id: Ifc4c7f3e7a19bad2ae420c0ebab54cf56404de51
2014-07-26 15:39:28 +01:00
219eb78e3a coverity#706572 Uncaught exception
Change-Id: I579d13981aed4b55501a85326ef2ff735937face
2014-07-25 11:46:56 +01:00
96bc7ea1d3 coverity#706579 Uncaught exception
Change-Id: Ie4d2eed7442ab1e234ea20e8230f1fab32b8c896
2014-07-25 11:46:55 +01:00
89b8e673b7 coverity#1209891 Uncaught exception
Change-Id: I366a13bc150085d647788fb085a63a63711731a0
2014-07-25 11:46:54 +01:00
3e33b00ce7 coverity#1209892 Uncaught exception
Change-Id: I7ff87e29769e1d911002d6e1d25cafe40c2d9b8a
2014-07-25 11:46:54 +01:00
ae1a8b38de coverity#706576 Uncaught exception
Change-Id: I818049d10f0ac69eb528e72329bb798c56fcf424
2014-07-14 09:21:03 +01:00
415e04894f coverity#706574 Uncaught exception
and

coverity#706575 Uncaught exception

Change-Id: I91f036d81deff31e47365c37445eb6b4cfcd992b
2014-07-14 09:21:03 +01:00
b166135056 coverity#983698 Uncaught exception
Change-Id: I3f597643c1f743314ca17346901f11dc4f1f7302
2014-07-14 09:21:01 +01:00
82a30a456e fix unhandled exception terminate on ooo48061-1.sxw
Change-Id: Ibacb94e719f42faa87ece48051ed8f72c3c78d02
2014-07-06 21:06:06 +01:00
1f0804bc00 No need to check for NULL before delete.
Change-Id: I8618fe6d3b27eb561137dc1e327e50a41f946494
2014-06-09 13:01:26 -04:00
acf56987b0 Tuck this typedef inside struct scope where it's used.
Change-Id: I2e225fb7afc58f1763e2fc4b9155aafc0e487f34
2014-06-09 12:51:48 -04:00
019617d590 Use for_each with boost::checked_deletor for this.
Change-Id: Iea8ef5138bc98e50a196cb38051a199b326c1405
2014-06-09 12:51:43 -04:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
b312a38797 update_pch: add a bunch of pch files
desktop:    1m51s ->   54s
 framework:  1m55s -> 1m04s
 package:      32s ->   16s
 sdext:      1m31s ->   47s
 svgio:        32s ->   15s
 uui:          49s ->   20s
 vbahelper:  1m44s ->   27s
 xmlscript:    15s ->   10s
 xmlsecurity:  45s ->   23s

Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04 21:18:37 +02:00
7e4c6e1ff1 remove unnecessary linefeeds from the end of exception messages
Change-Id: Id1d7971639b2496dbe0274423ff4150d9295e8d6
2014-05-29 09:01:39 +02:00
9af0abebfd remove unnecessary use of Reference constructor in throw
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
423921b085 fdo#78949 Handle (SAXParse-)Exception that can't pass getAllRelationships
...like it was already done in the similar else branch of
ReadRelInfoIfNecessary.  The call site at GetAllRelationshipsIfAny will
translate an m_nRelInfoStatus that remained RELINFO_NOT_INIT into an
IOException.

Change-Id: I79c601acd23b3b0020c7b4de4c20b0282524bce1
2014-05-20 11:17:22 +02:00