ba1d2677af
cid#738785 Uninitialized pointer field
...
Change-Id: I2256682639084c8889d1137f087e34f7b0dab6e7
2014-10-28 11:42:24 +01:00
1eb82c78a2
fdo#85215: Ensure that formula broadcasting works after sort.
...
When the reference update on sort is turned off.
Change-Id: I547dd1525a638dd447fe331e22583af4a7947308
2014-10-27 08:54:42 -07:00
8af112febc
sc: assert SfxPoolItem::operator==
...
Change-Id: I69b7d2b9e580b08ebd59866f1244e0e61c4b1dcb
2014-10-27 14:25:52 +01:00
10fc138307
fdo#85215: Don't adjust references wrt cell position when disabled.
...
Change-Id: Ie1a12cc189bcb66fad59ea9901ac0dc95bb68788
2014-10-26 14:45:52 -07:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
d4867ddae6
Fraction: Revert "conversion to double should not be necessary"
...
This reverts commit 166eaf213b3d43e54f2f5206d9680f75f720847f.
2014-10-23 18:34:33 +02:00
229eed079c
loplugin: cstylecast
...
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
2014-10-23 12:36:16 +02:00
2e363d1135
Remove ScToken from the formula::FormulaToken hierarchy
...
...to keep UBSan from complaining about illegal downcasts from FormulaToken to
ScToken (which were practically harmless, given that ScToken did not add any
data members).
Change-Id: I8fdc026eec363442cc4b720b71d65c972b4a4446
2014-10-23 09:30:10 +02:00
19d2f42119
Make ScToken::GetSingleRef etc. return * instead of &
...
...so that default implementations can return nullptr without further ado
Change-Id: Idc8778fe868efa00b1de597a54aa07a2e6fa3bc0
2014-10-23 09:30:09 +02:00
e5084fbf72
Be sure to copy the cell text attributes values to and from clip.
...
Otherwise we'd have to unnecessarily re-calculate the script types again
which is not cheap...
Change-Id: Ie589fb4a7e5ec9b5ef646dabea4e6bd0c0aca560
2014-10-22 18:07:27 -04:00
5156c5937b
Set script type to latin for formula cells with numeric results.
...
But only when the column contains only standard number format types.
Change-Id: I83982d2e87f9776cf03754beaf183e35675be992
2014-10-22 18:07:27 -04:00
90f2f34267
Exit early in case the column has no cell notes to copy to destination.
...
Change-Id: Ifca77ccda7b2065b00ee29f29f377da599929843
2014-10-22 18:07:27 -04:00
beb2d06e2e
Set latin script to numeric blocks of applicable columns.
...
Change-Id: Ib81ef144f168fed38100127bd63f43ea5a835a13
2014-10-22 18:07:27 -04:00
a4b7d8a401
Check for standard number format rather than just for 'General'.
...
That's what the ods import filter does.
Change-Id: Ibcd9a80a51785a448594d29a02283cca0ec53e95
2014-10-22 18:07:27 -04:00
f1fcac4bc9
Try to determine whether or not a column has all 'General' number format
...
during import. We'll then use this information to set script type to latin
for all numeric cells in those columns rather than leaving the script type
'unknown'.
Change-Id: I69eae1effc32c57290b0265bc6c87e58f51944b1
2014-10-22 18:07:26 -04:00
e0d62d8ef7
Move SetAttrEntries from ScDocument to ScDocumentImport.
...
Since that method was really an optimization for xls(x) import code.
Change-Id: Ie2530f5dc27411bd45d72440681689c6c7a8b10a
2014-10-22 18:07:26 -04:00
8922f72d1e
Annotate FindEditCellsHandler.
...
Change-Id: Ib49a7a3eccee62e5496f7f19824631866e072b6a
2014-10-22 18:07:25 -04:00
04ee80c1a6
Store height array to RowHeightContext and reduce function arg counts.
...
Change-Id: I09b79bc76ffc55e25c24bbfa8f000f4a46df0a1c
2014-10-22 18:07:25 -04:00
9ecac3874d
Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING
...
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.
Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-22 09:30:23 +03:00
166eaf213b
conversion to double should not be necessary
...
Change-Id: I12ad83453b68077fe672576680b0cd5fd9acf49f
2014-10-21 10:54:43 +02:00
4332787892
nShearWink -> nShearAngle
...
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
7fef943114
fdo#80284: Avoid broadcasting during cell delete & shift.
...
Broadcasting it here and marking formula cells dirty prevents them
from being entered into the formula tree at the end. They get marked
"postponed dirty" during reference update, and are supposed to be
set dirty at the end.
Change-Id: I65977300ee4ee26b6166d170acd2145abcbbf288
2014-10-17 21:53:21 -04:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
f9aa686432
Resolves: fdo#81496 crash in calc format page
...
Change-Id: Ic70f6f605e13a5c95b504f1bf0322e11313a21e7
2014-10-16 09:09:46 +01:00
91502a72c1
fdo#83141: also optimize ScTable::HasAttribSelection
...
applying same strategy than 1e721077b43de84edab2a3ed2f316ddcbec6e3ec
Change-Id: I8c226d5d66ba8371ea1baec73e72b3e50886bb4f
Reviewed-on: https://gerrit.libreoffice.org/11877
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-15 19:33:53 +00:00
da77897d19
nDrehWink -> nRotationAngle
...
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
268d5a7e3c
speed up range list generation from multi marks, fdo#75486 related
...
Change-Id: Id2114652948d12c92b0e7be7afa304bfffc8fbe0
2014-10-15 02:20:09 +02:00
0b29a16d1d
fdo#83901: ROW() and COLUMN() to be properly recalculated on cell move.
...
For cases where ROW or COLUMN references another cell that has shifted.
Change-Id: Ic4bef8672dab811ceff6886d9af0388306a66485
2014-10-12 10:21:00 -04:00
8044acf2db
convert SFX_CALLMODE constants to SfxCallMode enum class
...
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident
Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:52 +00:00
4307473975
remove warning: ‘nIndex’ may be used uninitialized
...
Change-Id: I317c2f4409f556ab967e4f08caa99cffcfce26cc
Reviewed-on: https://gerrit.libreoffice.org/11876
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us >
Tested-by: Kohei Yoshida <libreoffice@kohei.us >
2014-10-09 12:31:10 +00:00
2b6619c597
fdo#84810 Avoid calc crash when using Paste Special - Link
...
Change-Id: I52c072578ccc0b9f75a850613056e74d400eb532
Reviewed-on: https://gerrit.libreoffice.org/11867
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us >
Tested-by: Kohei Yoshida <libreoffice@kohei.us >
2014-10-09 11:38:12 +00:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
1e721077b4
fdo#83141: optimize slow performance after when using replaceall or searchall
...
- problem was hang after replaceall or searchall function
- fix slow performance by looping only selected cols.
Change-Id: Ic0178af33bf381e52584bd4366bff9e128891b64
Reviewed-on: https://gerrit.libreoffice.org/11829
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Matthew Francis <mjay.francis@gmail.com >
Tested-by: Matthew Francis <mjay.francis@gmail.com >
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-08 15:56:24 +00:00
0c57f31a8b
convert ParamType enum in SC to enum class
...
mostly to get the NONE constant out of the global namespace, so I can
convert other enums which also want to use the NONE constant
Change-Id: I988d5d7e5316dd5e4ca0be0cc8f043f69bbb900c
Reviewed-on: https://gerrit.libreoffice.org/11848
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-08 09:35:18 +00:00
8f436d3de7
use comphelper::rng::uniform_*_distribution everywhere
...
and automatically seed from time on first use
coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand
Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06 14:13:27 +01:00
f3fae7d3c6
Add menu entry for the "formula to value" feature.
...
Not sure 100% if that's the best place for this. Feel free to move it
to a better place.
Change-Id: Id66a92e1184e988bd71f7d845ea370b021c02c21
2014-10-04 13:19:40 -04:00
d6c842e0e9
WaE: private fields 'mnTab' and 'mnCol' are not used
...
Change-Id: I449b85b00aeaf690644e17be0a6b2b9398a3cd3f
2014-10-03 11:35:38 +03:00
dd617c0bbe
New feature to allow converting formula cells to static values.
...
You used to have to convert formula cells to static values by copying
them and pasting them as values onto the original place. Why not just
allow converting them in place?
This is something I've always wanted to implement.
2014-10-02 21:32:24 -04:00
a23801b740
Scope reduction by early bail-out.
...
Change-Id: Iacbf9f46a1b5683b6de5dd93002a69078af46951
2014-10-02 15:35:10 -04:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
89c72084b2
sc: std::auto_ptr -> std::unique_ptr
...
Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
2014-09-30 17:51:30 +02:00
423142538e
add a RAII class that tries to acquire the SolarMutex and releases it
...
Motivated by ScCompiler::IsMacro() which has an error return that does
not release the SolarMutex.
Change-Id: I064219bb3c0d68839a133101491d5f8828a26c7a
2014-09-26 23:24:32 +02:00
dedfa972bc
remove unnecessary casts in calls to SvStream.WriteInt16
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26 15:26:48 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
0ef6263ed2
fdo#83764: Ensure that the row position is below MAXROW.
...
When attempting to split formula groups, else multi_type_vector would
try to locate a block outside its logical range.
Change-Id: I424ede112138de459b5ba3bff5e021c4407ccf3d
2014-09-18 13:38:28 -04:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
40825c4369
Typo: excatly->exactly
...
Change-Id: Ica1e1399bc4a9b9ca61d09cf26e8c47e2368f644
2014-09-17 20:15:27 +02:00
902564bfe5
bnc#592918: Display data description in pivot table.
...
When there are no column fields and exactly one data field.
Change-Id: I10d2af7e626f98a4d8a981e078e99e7da9207d1c
2014-09-17 11:29:39 -04:00
2d9cdbd9d9
Another Windows build fix - too much C++11 for MSVC 2012...
...
Change-Id: I2ae08bd7b850e26bd58d8cb9fad830edb0395259
2014-09-17 12:39:46 +02:00
