wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
362,810 Commits 5 Branches 0 Tags
acd62e055ee71f330b1d48c3c3c83aaa5ceca29a
Commit Graph

914 Commits

Author SHA1 Message Date
Caolán McNamara
5652f529b5 coverity#1237350 use our double-locking templates for this 
Change-Id: I589468e9663ffd01a237a1684345985396bc4eac
 2014-10-24 13:43:09 +01:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Norbert Thiebaud
39c8834d21 coverity#1209004 Unchecked return value 
Change-Id: I8749a5d6f176406e181312d94a1e643974d87617
 2014-10-05 13:26:10 -05:00
Stephan Bergmann
609e22b0dc scripting: std::auto_ptr -> std::unique_ptr 
Change-Id: I91f4a037dfcfbea83cb1ea546ea73880f0480961
 2014-10-01 12:17:17 +02:00
Michael Stahl
212f25c227 scripting: another missing SolarMutex guard 
Change-Id: I762dad4d94ab4f27912b4ddac5b6a77f7d685cb8
 2014-09-30 17:34:26 +02:00
Daniel Sikeler
32d6415617 fdo#83512 Make use of OUStringHash and OStringHash 
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-09-18 13:12:48 +02:00
Stephan Bergmann
a01ef1978c Improve logging 
Change-Id: I9c879cc16de0d5353a5ab8ce4c8a8cd7f000a170
 2014-09-17 11:48:20 +02:00
Stephan Bergmann
27d5b5c6dd BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layout 
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
 2014-09-17 11:45:14 +02:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Caolán McNamara
d375986dae coverity#707084 Uncaught exception 
Change-Id: I89459f7a77fcb5785cfb2e8288326fce65202d9c
 2014-09-02 15:36:28 +01:00
Caolán McNamara
2f1eed4839 createNonDocMSPs->ensureNonDocMSPs 
put the double-lockery into ensureNonDocMSPs and
the contents into a new createNonDocMSPs

Change-Id: Id09c933396e1a6ae1c45be79131a75729b16932b
 2014-09-02 12:14:50 +01:00
Stephan Bergmann
70946992d4 Fix some *_component_getFactory function types 
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
 2014-08-28 16:11:33 +02:00
Takeshi Abe
4d32244437 Avoid possible memory leaks in case of exceptions 
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
 2014-08-26 19:47:14 +09:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Stephan Bergmann
c7d7582452 Fix *_component_getFactory function type 
Change-Id: I966824af73effed95d975c09cb8a7f9ae022843f
 2014-08-21 17:49:13 +02:00
Stephan Bergmann
bf640ba048 Fix *_component_getFactory function type 
Change-Id: Id16c653554f5573dc862e0798747b7337ff74d44
 2014-08-21 17:44:40 +02:00
Caolán McNamara
a107bdfdfc ErrorBox->MessageDialog 
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
 2014-08-18 10:57:21 +01:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp() 
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
 2014-06-27 17:08:04 +02:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface> 
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-06-25 17:10:43 +02:00
Julien Nabet
d59da701c6 Related fdo#58774 Alternative dialog Find & Replace for Writer 
After having installed the extension from http://extensions.libreoffice.org/extension-center/alternative-dialog-find-replace-for-writer/releases/1.4
I had a crash, extract of bt:
5  0x00002aaad3ee13df in rtl::OUString::copy (this=0x7fffffff2510, beginIndex=147, count=-15) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:1481
6  0x00002aaad3edc10e in stringresource::StringResourcePersistenceImpl::implScanLocaleNames (this=0x8e2bba0, aContentSeq=uno::Sequence of length 24 = {...})
    at /home/julien/compile-libreoffice/libreoffice/scripting/source/stringresource/stringresource.cxx:1728

So add a quick check to be sure iDot > iSlash

Change-Id: I944a852d6cc9a35c451985ac96032f0d848136e8
 2014-06-21 22:33:17 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Noel Grandin
db246b491c scripting: remove SAL_THROW macro 
Change-Id: I535a57d043ac51926ae6f640d721d0dd1571c3fa
 2014-06-05 08:17:52 +02:00
Noel Grandin
adc20c3937 compareToAscii -> equalsAscii 
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
 2014-06-04 11:52:31 +02:00
Jens Carl
f3e1f476e9 fdo#68849: Add header guards to all include files 
Added header guards to files in directories sal/, sal/, and scripting/

Change-Id: Ieb7f224f2d27bd671618c516f47f5b7f08c1d294
Reviewed-on: https://gerrit.libreoffice.org/9582
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-01 16:07:41 +00:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin
0f2824b117 remove more unnecessary use of OUString constructor 
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
 2014-05-27 08:20:12 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Tsutomu Uchino
a00c4c5e2f Resolves: #i113481# query script invocation from the current frame... 
when the controller is not yet attached

(cherry picked from commit 03a410876fbdb5f9e1a7216d9d622557275d4896)

Change-Id: I1da3b3da258445d5187dcc75c4d151d08f9017dc
 2014-05-18 08:53:07 +01:00
Chris Laplante
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way. 
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
 2014-05-17 12:38:38 +00:00
Noel Grandin
b2096deaff various loplugin:passsequencebyref 
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
 2014-05-14 16:54:27 +02:00
Julien Nabet
e3d01ad336 Fix previous commit (scripting part) 
Change-Id: Ib451642924909c11db4252e81d0c6db690c0e838
 2014-05-11 10:37:30 +02:00
Julien Nabet
bd59628620 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10 
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
 2014-05-11 10:16:42 +02:00
Noel Grandin
2ff8ae7c9e scripting: sal_Bool->bool 
Change-Id: I1550c49cce2ad64f9d62b06ec20512a750f83b84
 2014-04-24 10:53:16 +02:00
Thomas Arnhold
97a5ba4a71 remove comments why a file gets included 
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
 2014-04-21 18:08:28 +02:00
Thomas Arnhold
8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Stephan Bergmann
5e3c993155 Clean up function declarations 
Change-Id: Ie204bb9dc1fb4ded416087f5a3d962924b3dec82
 2014-04-14 15:51:53 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Caolán McNamara
e57401aeb0 coverity#704287 Logically dead code 
Change-Id: Iab22d2d12319bc01f9aebc1dcf40f47881d40446
 2014-03-29 18:12:06 +00:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Stephan Bergmann
55461af2bd scripting: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: If0d9a6f1c56dc560df078eb59313aaba393ee372
 2014-03-10 17:39:57 +01:00
Stephan Bergmann
25cedf1dc7 Introduce com.sun.star.beans.theIntrospection singleton 
...deprecating com.sun.star.beans.Introspection (single-instance) service.

Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
 2014-03-07 10:33:07 +01:00
Marcos Paulo de Souza
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService 
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-04 07:30:02 -06:00
Donizete Waterkemper
c4cff5a645 fdo#54938: Convert some places to use cppu::supportsService 
Change-Id: Ib941c6ec82d81b1da815561eee87ee91dc8de200
Reviewed-on: https://gerrit.libreoffice.org/8443
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-03 15:53:46 -06:00
Stephan Bergmann
5133b44601 Remove unused ScriptingContext 
Unused and not even built since 11ddfdb8563901bf515fa2eb07fa27244cc58ced/
4516589f91e03fa5d8589a52ed8b72af8f9e4521 "INTEGRATION: CWS scriptingf2 (1.7.2);
FILE MERGED."

Change-Id: I06eec282877a91955b3f20109c3c1189b660f2da
 2014-02-27 11:09:54 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
b0308236d2 Remove visual noise from scripting 
Change-Id: Id9f177a20d911ce1e041407aa556c9cf13f0efc8
Reviewed-on: https://gerrit.libreoffice.org/8305
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 08:37:40 -06:00