17a99a9074
fdo#84938: replace TIMEF_ constants with enum
...
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e
Reviewed-on: https://gerrit.libreoffice.org/12114
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-28 06:12:28 +00:00
66d105b10a
coverity#1242429 Explicit null dereferenced
...
Change-Id: I30f65243995288008fbc41de76bd3f4e2d21b00e
2014-10-24 13:43:08 +01:00
518b305279
Related: fdo#84844 Support fill color in SvxColorToolBoxControl
...
Change-Id: I6ccc1d4e71a9fe76cd16dd957f626722aaba543c
2014-10-24 11:45:02 +03:00
312d903b8e
Register the item type based on the SID
...
Change-Id: If954191b71daf52c4f49fb7638e583cd0a2c97a5
2014-10-24 11:45:02 +03:00
239a586fb7
coverity#735385 try and silence Copy-paste error
...
Change-Id: Ifc3c705db7f3d88f26753bd189db34ca8ef8160d
2014-10-24 09:24:57 +01:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
f76d21ca73
Fraction: Revert "boost::rational throws if 0 is passed as denominator"
...
This reverts commit 1c8695ecf65174298ebd9edb5b0289db07af98ca.
2014-10-23 18:34:37 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
0bab8aee77
fdo#85247: copy and paste of a slide results in a blue slide in presentation mode.
...
Seems like "Default" is handled specially or probably
the copy-buffer is broken
This now checks for slide 'type' as well, before cosidering it a duplicate
Change-Id: If8c472bcefb54cee72e7411f92a76b4e2db2b6ce
2014-10-23 20:30:26 +05:30
b7266ddb2f
FastSerializer: Buffer output and write it only at the end
...
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.
The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.
Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-23 11:53:14 +02:00
1a2c28cf0d
callcatcher: update unused code
...
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22 13:11:34 +01:00
9ecac3874d
Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING
...
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.
Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-22 09:30:23 +03:00
d1e9aa23a7
Resolves: fdo#83588 Revert "center slide after changing zoom"
...
This reverts commit b179235f702e474b115ca479b603052f422346fd.
2014-10-21 16:18:45 +01:00
92360e7413
Resolves: fdo#84417 restore focus window after preview
...
regression due to changes of sd/source/ui/slideshow/slideshow.cxx
in cc5518ca61b209408a9d5262bbdcc39efccdd72d
commit cc5518ca61b209408a9d5262bbdcc39efccdd72d
Author: Steve Yin <steve_y@apache.org >
Date: Thu Nov 28 12:09:19 2013 +0000
Integrate branch of IAccessible2
Change-Id: I6b399d68c1f3ef32b702135b981100a23760569b
2014-10-21 14:35:27 +01:00
a29301cf69
fix debugging build
...
Change-Id: I7264f670dd60f6121a23a4cb5524edc3bf1dcee7
2014-10-21 09:10:10 +01:00
182fc4f184
fdo#84938: replace WINDOW_BORDER constants with enum
...
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21 09:06:40 +02:00
4332787892
nShearWink -> nShearAngle
...
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
6e355d9561
Revert "at least fix the crash when calling SdXImpressDocument::dispose
...
... for now"
This reverts commit 599473a13e3c5ba669d995c913ad415bd674a16c.
moggi says the unspecified crash happened with the tests following the
comment in chart2import.cxx:75, but the tests run fine in valgrind now.
The commit creates a memory leak in the CppunitTests as
SfxBaseModel::dispose() returns early, because mbDisposed is set.
Change-Id: I987dce6a4090784d166a4a3b2e7f9e2c0cddd289
2014-10-20 15:26:57 +02:00
9f65dff35e
coverity#704010 Unchecked return value
...
Change-Id: I90750c51ce3b38defdba7ecdb7734172983efa8c
2014-10-20 10:57:18 +01:00
67c9d05451
fdo#84938: replace TIB_ constants with enum
...
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-20 07:16:46 +00:00
ddac852282
-Werror=shadow
...
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-19 12:02:47 +02:00
51d86c9e62
Consistency around SdrAngleItem in svx/sxciaitm.hxx
...
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."
Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17 15:36:13 +02:00
b9789a6319
There is no ExportCGM
...
Change-Id: I84b0d4daa3a6090aadaa7f64bdb9277efbba371f
2014-10-17 14:23:46 +02:00
fc78d8dfba
Pass args by const &
...
Change-Id: I510e1aba6772e1f8d4013b235e95a1e5599fd601
2014-10-17 14:23:46 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
d49eabcc56
ensure UserData dtors are done while SolarMutex is locked
...
otherwise I can't even reorder two slides in the slide pane with
dbgutil enabled without a SolarMutex assert in RemoveListener
(and we have two SolarMutexes here for some reason, one should be enough)
Change-Id: If224568f1b90d62c17bde65a896534aa10f8a661
2014-10-16 11:16:41 +01:00
165059674d
Restore my pretty slide highlighting
...
and which got horribly destroyed by merge-conflict resolution of
78f6407978aa48c3cbb116bc281940dbf1f2dcbc
Change-Id: Ie560416f4aa435e80c57a4449ee499fc5af20022
2014-10-15 17:38:19 +01:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
d9fa1247be
fdo#84938: replace SYMBOL_TYPE constants with enum
...
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-15 10:13:04 +00:00
da77897d19
nDrehWink -> nRotationAngle
...
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
72cb37b685
fdo#84236 Remove view modes from sd context menu
...
Change-Id: I7146ee946c7f882decae2c8d93c63002d00dd511
2014-10-14 16:34:00 +02:00
a24f9d9197
remove duplicate definitions of PPT_TRANSITION_TYPE constants
...
Change-Id: I8b6743c4f2c5c3d52c7df33953ed3dd7b32a1a46
2014-10-14 15:51:36 +02:00
2fff4927c4
coverity#1242426 Dereference after null check
...
Change-Id: I59c96846aa5bf4780e4c5bfb0b71242e3b928976
2014-10-14 13:42:19 +01:00
ba39577890
fdo#84938: convert EPP_LAYOUT constants to enum
...
Change-Id: Ibf43bf9ca241c6286659a16906a45bbafa798748
Reviewed-on: https://gerrit.libreoffice.org/11961
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-14 12:18:42 +00:00
1175b25bf2
fdo#84213 Add show/hide ruler to sd context menu
...
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13 21:21:25 +02:00
1c8695ecf6
boost::rational throws if 0 is passed as denominator
...
Change-Id: I312fd6b964555b3b4aa4e22cec6054c9a83b2c52
2014-10-13 10:02:26 +02:00
4d7806f73b
Wording: 'Audio/Video' -> 'Audio or Video'
...
Change-Id: I9572d4c7fb5f50b869e69436302ac8c20e500392
2014-10-12 15:30:16 +02:00
475df8db91
fdo#84916 Fix string: Insert Audio/Video
...
Change-Id: I76cd8502f9cb2af379dd732d2081feb094599aca
2014-10-11 17:37:16 +02:00
8044acf2db
convert SFX_CALLMODE constants to SfxCallMode enum class
...
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident
Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:52 +00:00
cb7ede2d99
convert vcl StateChangedType to enum class
...
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:32 +00:00
8a2da50632
coverity#704776 Dereference after null check
...
Change-Id: Ifbad1fc30665ff6b9238b5fb4728fc302b0458fa
2014-10-10 12:50:23 +01:00
86b0762bbb
coverity#708132 Uninitialized scalar field
...
Change-Id: I830210b44459cf94eabb983b99bfcc104f865492
2014-10-10 12:50:20 +01:00
a1b7164742
coverity#1242757 Result is not floating-point
...
there was two of these, see
commit 164bd64255d71d96e35e908f6425acf8372795fb
Date: Thu Oct 2 04:44:33 2014 -0500
coverity#1242757 Result is not floating-point
Change-Id: I1f66191f329b2d87bdeb52aa1a7528ca662064a6
2014-10-10 12:50:18 +01:00
cb3b90751b
coverity#1244953 Uncaught exception
...
Change-Id: I3c4aeb3318af7cdb964128dd78f7d2cfba48000e
2014-10-10 12:50:16 +01:00
86de557ea2
Unused PowerPointExport::mpMasterFSArray member
...
Change-Id: I02b9c31146396a39a624fbb869a5880b176e0f9e
2014-10-10 13:50:02 +02:00
fb365e63ab
cid#1244955 Uncaught exception
...
Change-Id: Iedf06cc78cda022112699be3db650d11c7249adc
2014-10-10 10:14:18 +02:00
1958ca235b
German comment translation.
...
Change-Id: I479da454235a7cfc084ae1517ab9ffa07580ab0c
2014-10-09 17:44:58 +01:00
c78d5fae81
German comment translation.
...
Change-Id: I98526bfd6f69d95d5c309e67c397bc85fb8817ab
2014-10-09 17:44:58 +01:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00