5651dd471e
coverity#1157745 Unchecked return value
...
Change-Id: I06e8e946063dc54335f3b672105d5cd0b3ff71a4
2014-10-28 15:06:35 +00:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
d9fa1247be
fdo#84938: replace SYMBOL_TYPE constants with enum
...
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-15 10:13:04 +00:00
ff7c2cd0dc
Resolves: fdo#84887 TabBar::ImplShowPage crash
...
Change-Id: I84250c6a40baeabd0d12958dfe0aea346d2b4fc8
2014-10-14 17:13:43 +01:00
af5ebbf783
create a macro library for implementing bit-flags types
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >,
changed from a macro- to a template-based solution. (Unfortunately MSVC 2012
does not support explicit conversion operators. Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)
Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13 17:45:57 +02:00
cb7ede2d99
convert vcl StateChangedType to enum class
...
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:32 +00:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
11d22e164e
cid#1194925 Resource leak
...
reorganise the code to keep coverity happy
Change-Id: I18fc2dfd17f97edf1d17c57caaed4cc9d2fedd13
2014-10-03 15:18:46 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
8dbde0845a
fdo#82577: Handle Region
...
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.
Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
0ecf6afbd1
loplugin: cstylecast
...
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-29 12:50:35 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
77fd06e18d
Remove shadows in tabs to make them look more flat.
...
Change-Id: I7c125c10538a641ec723d95be987ad77cdebc9ba
2014-09-16 23:45:10 +02:00
f9c77344c6
Make tab label padding dependent on font height.
...
Change-Id: I7de52945bdf3062174b49e12e2f05075632c7e4a
2014-09-16 23:45:10 +02:00
1a2b2d2cf4
Change tabs (sheets in Calc) to better looking rectangle shape.
...
Change-Id: Ib0b2812792ac7447bfb1d9e3d4d404bc5d5afb0b
2014-09-16 23:45:10 +02:00
051b29e102
convert Edit autocomplete Hdl to boost signals2
...
Here it also keep track of the connection, as it needs to be explicitly
disconnected in one place.
Change-Id: Id3e2882106ae55c2d880898956a36f84d3ce70ef
2014-09-14 22:07:17 +02:00
7af850c896
vcl: sal_Bool -> bool
...
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-10 08:36:06 +02:00
aa906f3e8a
Typo: childs->children
...
Change-Id: Ib27b3e125581884b90efc9cc33b6b2aadab73851
2014-08-31 21:36:08 +02:00
d54b2bd8dc
Resolves: fdo#83068 ignore spaces in font-size unit detection
...
Change-Id: Id9a5c2ee576bd533d8b0a2b4356e319354abbbac
2014-08-29 09:27:38 +01:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
b3d9852309
Remove more useless includes of tools/debug.hxx
...
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-20 09:10:01 -05:00
ef4fb3976a
svtools: show spin for FormattedField
...
User can increase / decrease values in FormattedField with scrolling
with the mouse, so there is no reason to hide the spin buttons.
Change-Id: Ie342f456cdb45c1d7287df70faa786c0e7dc2425
2014-08-17 10:41:12 +02:00
e1683c2d13
callcatcher: update unused code
...
lots of ResID stuff going away now
Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
086611d2ce
coverity#1202783 Division or modulo by zero
...
Change-Id: I17892b9daa3be450001ac88239008d0d27f4a01f
2014-08-07 18:00:49 +01:00
b0cdd038ee
fdo#51534 - rulers should have app-background by default (apparently).
...
Change-Id: I981febb02074ed323732ef7c19e89f1e946604f1
2014-07-24 14:26:54 -04:00
c1dd91a93c
callcatcher: update unused code
...
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
ebdb4a00fa
coverity#1202783 Division or modulo by zero
...
Change-Id: Ida169195697d3976500a16e3cced40b25664a02e
2014-07-18 15:36:17 +01:00
b43fdc54e5
cid#1194925 Resource leak
...
add an assert so that coverity knows the leak can't happen
Change-Id: I0109309ccc53b1b22420cbf9ac497d8d677a4ea7
2014-07-14 11:07:47 +02:00
f38bf4c6c2
Avoid possible memory leaks in case of exceptions
...
Change-Id: I04a0a2c296206f155ee4916b15b853a7f10c2c2a
2014-07-04 10:49:10 +09:00
cfdf9a6c5a
coverity#706081 Unintended sign extension
...
and
coverity#706080 Unintended sign extension
Change-Id: Ieb5bd639567767b4c6b2957a9e628eb841713198
2014-07-03 14:52:27 +01:00
bca68c4a34
coverity#736898 Unintended sign extension
...
Change-Id: Ie09d25b2f9993435ebffc52c7257cd9396672c8f
2014-07-03 14:52:24 +01:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
78bea877ff
OSL_ENSURE->assert where guaranteed deref follows
...
Change-Id: I6e007cc3a9fd222c1c1381c8b4f890966c05cbab
2014-06-27 17:22:09 +01:00
358c1fa7fa
coverity#736899 Unintended sign extension
...
Change-Id: I4fcd7df318cec8dccd1516c6d52b7d0c67885a6c
2014-06-18 11:12:09 +01:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7eceffef49
Resolve fdo#79913 by checking index bounds
...
Change-Id: I023a625d73724332245d612a61cb786acefc4cf2
Reviewed-on: https://gerrit.libreoffice.org/9791
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-16 10:54:37 +00:00
30069114fe
loplugin:staticcall
...
Change-Id: If7b285a2214bc878e8464a986538d0445078fcb3
2014-06-13 17:54:34 +02:00
6f2edd4514
new loplugin: inlinesimpleaccessmethods
...
Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.
Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-04 14:49:08 +02:00
f634cda2a2
avoid problems with poppler's and vcl's FontInfo during runtime
...
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04 07:49:15 +02:00
0d20725fcc
remove whitespace
...
Change-Id: Iae0f6b9818f84a92c46b24f90d3051c7b6a45d94
2014-06-04 07:49:14 +02:00
41a1f95abe
remove whitespace
...
Change-Id: Iff12a4106369114eb785c0ce242c0e296a877495
2014-06-04 07:49:14 +02:00
5f743ea308
remove whitespace
...
Change-Id: I08a89e40d24bc6f4b106c5063c197fe201f32bf6
2014-06-04 07:49:13 +02:00
57217e1e9f
fdo#68849: Add header guards to all include files
...
Added header guards to files in directories stoc/, and svtools/
Change-Id: Ib6691b0e3fa09d71696ab947d357e489eb35df66
Reviewed-on: https://gerrit.libreoffice.org/9584
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-06-01 16:13:05 +00:00
3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
a325ce63db
fix-includes.pl: svtools
...
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
b7d30cb50e
svtools: sal_Bool->bool
...
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
93f5d5a919
The opaque PostUserEvent IDs are actually pointers
...
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
