wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
429,413 Commits 5 Branches 0 Tags
ae9f37ba753519ae4a2ae6384d052d417359602f
Commit Graph

1031 Commits

Author SHA1 Message Date
Noel Grandin
35e80e9726 when calling std::lower_bound 
it's not enough to compare != end(), you also need to compare the key
against the iterator result

Change-Id: Ide5f151ba2297a35e5546f47fbc3c53cbe5ab533
Reviewed-on: https://gerrit.libreoffice.org/62014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-20 08:00:32 +02:00
Noel Grandin
2c1b7e8d6a clang-tidy readability-container-size-empty 
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422
Reviewed-on: https://gerrit.libreoffice.org/61967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-19 10:02:39 +02:00
Noel Grandin
ccb2a1f650 clang-tidy readability-redundant-smartptr-get 
redundant get() call on smart pointer

Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd
Reviewed-on: https://gerrit.libreoffice.org/61837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-17 08:25:47 +02:00
Stephan Bergmann
206b5b2661 New loplugin:external 
...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-09-17 09:05:38 +02:00
Gabor Kelemen
cc7280efdb tdf#42949 Fix IWYU warnings in include/cppuhelper/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45
Reviewed-on: https://gerrit.libreoffice.org/59297
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-09-10 09:58:12 +02:00
Jochen Nitschke
b678dee6a8 cppcheck: variableScope in basic 
use a range based loop in one case

Change-Id: I3d3acc35739634797e2b6e4d1cc2909b3fe33750
Reviewed-on: https://gerrit.libreoffice.org/60188
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-08 14:45:42 +02:00
Noel Grandin
c2139cafe6 loplugin:simplifyconstruct in accessibility..bridges 
Change-Id: I08f6a64b50f03d1b08027a2ac9e51442255d64bc
Reviewed-on: https://gerrit.libreoffice.org/59976
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-05 09:28:12 +02:00
Jochen Nitschke
89b47b5eb2 cppcheck: useInitializationList in basic 
Change-Id: I97fefc25076c2c163f6010745081772ee8c17712
Reviewed-on: https://gerrit.libreoffice.org/59908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-03 08:34:25 +02:00
Andrea Gelmini
718f63002e Fix typos 
Change-Id: I6ca53ead2b125618d0aceff05d5fdfa374662799
Reviewed-on: https://gerrit.libreoffice.org/58809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-08-29 17:10:21 +02:00
Noel Grandin
d977e02ec6 unnecessary null check before dynamic_cast, in various 
Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b
Reviewed-on: https://gerrit.libreoffice.org/58774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-10 08:21:55 +02:00
Andrea Gelmini
618e1fdac1 Fix typos 
Change-Id: I563ea72a1e3870f5c362527f018c6b63607b4011
Reviewed-on: https://gerrit.libreoffice.org/57597
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-07-18 09:52:44 +02:00
Noel Grandin
dbf8ad9bc3 loplugin:useuniqueptr in SbUnoStructRefObject 
now that we have upgraded to VS2017, we can use std::unique_ptr in
std::map

Change-Id: Id01af07ccae7447405b8f0bc44b08043f453e54b
Reviewed-on: https://gerrit.libreoffice.org/57384
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-13 11:58:10 +02:00
Gabor Kelemen
7af90cc93b Add missing sal/log.hxx headers 
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030
to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from a* to configmgr

Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a
Reviewed-on: https://gerrit.libreoffice.org/57170
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-07-09 10:49:06 +02:00
Tor Lillqvist
cac718bfe6 Factor out AsyncQuitHandler to be usable elsewhere, too 
Or do we already have the corresponding functionality somewhere, and
SbModule::Run() could be changed to use that instead?

Change-Id: I6f45d4a023f9f9d9a24ab6934117a712ccbe75e2
Reviewed-on: https://gerrit.libreoffice.org/55048
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2018-05-30 11:28:35 +02:00
Noel Grandin
1cb646dc5f loplugin:useuniqueptr in SbiImage 
Change-Id: I24ee5de3628d6436dc045cb543d35b16074ef189
Reviewed-on: https://gerrit.libreoffice.org/53700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-02 08:25:37 +02:00
Noel Grandin
fcd589d4f3 loplugin:useuniqueptr pStringOff in SbiImage 
Change-Id: I05de3e910bf857e095c99cade6fec22ccb2dd99d
Reviewed-on: https://gerrit.libreoffice.org/53606
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-29 18:22:23 +02:00
Jochen Nitschke
b4d36b5dcf remove some unused comphelper includes 
and fix the fallout

Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359
Reviewed-on: https://gerrit.libreoffice.org/52894
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2018-04-15 11:17:24 +02:00
Noel Grandin
08ab1f46b1 loplugin:oncevar extend to tools/gen.hxx types 
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-26 07:21:04 +01:00
Julien Nabet
3ceb01afc3 Use for range loops in basegfx and basic 
Change-Id: I5b2086c245695aeb30630150b3c5ccf61fbd6a56
Reviewed-on: https://gerrit.libreoffice.org/50280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-02-24 17:28:43 +01:00
Caolán McNamara
7faa218231 ofz#6311 still problems with SdrEdgeObj listening to same obj at start as end 
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30
Reviewed-on: https://gerrit.libreoffice.org/49821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-16 00:35:10 +01:00
Tor Lillqvist
73256b9181 Decrease fragility in odd use cases with no current document 
Change-Id: I9966166561d4c6e577f3f7e8e04572f97a0b295e
Reviewed-on: https://gerrit.libreoffice.org/49450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-02-09 00:50:02 +01:00
Noel Grandin
44853cc8be loplugin:useuniqeptr in SbxVariable 
Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c
 2018-01-19 08:58:46 +02:00
Noel Grandin
24cbc7a1fc loplugin:useuniqueptr in SbUnoMethod 
Change-Id: Ibeae1754a18152c3a17379c95e3caa536a8822db
 2018-01-19 08:58:46 +02:00
Noel Grandin
5954878448 loplugin:useuniqueptr in SbiGlobals 
Change-Id: I0ebec3193b4369039f90be4223ebdf6d048b8478
 2018-01-19 08:58:46 +02:00
Noel Grandin
263d732569 loplugin:useuniqueptr in SbModule 
Change-Id: I20525bd69c91ff35c9e569525a0d4556bc184982
 2018-01-19 08:58:46 +02:00
Stephan Bergmann
3a40d3de89 More loplugin:cstylecast: basic 
Change-Id: I0bb219632da384ab047a2b1fc3f2b041dacaf2cb
 2018-01-15 09:07:14 +01:00
Stephan Bergmann
6070aaa47d More loplugin:cstylecast: basic 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I20b38196ee1b6a34384dc46d9de1b6e1b44947ae
 2018-01-12 20:29:14 +01:00
ekuiitr
728104b31c tdf#96099 Removed some trivial typedefs related to UnOrderedMap and size_t. 
Change-Id: I59d3d0b2c1097b5ca96505dc99a4a104b4f8ab48
Reviewed-on: https://gerrit.libreoffice.org/47082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-10 15:20:44 +01:00
Noel Grandin
884cbe174e RID_* can be extern global variables 
no need to access them via methods

Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2
Reviewed-on: https://gerrit.libreoffice.org/47245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-02 12:19:01 +01:00
Noel Grandin
2a421b26c0 loplugin:passstuffbyref improved return in basic,framework 
Change-Id: Ib19836febb59f4e2bb07dc874cfc6baabc653237
Reviewed-on: https://gerrit.libreoffice.org/47065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-26 19:56:02 +01:00
Mike Kaganski
8de8e0ce21 Get rid of loop counter variable 
Change-Id: Ia4f4e24819525287e720a9c016b3666bc006b545
Reviewed-on: https://gerrit.libreoffice.org/46531
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-15 19:54:16 +01:00
Eike Rathke
d915cb417b Resolves: tdf#114231 do not mask ErrCode with GetRest() 
Regression from

    commit 7ca950ec744b7af1d15724ec2abc296573a641e4
    Date:   Wed Aug 23 19:25:02 2017 +0200

	no need to use ERRCODE_RES_MASK here

	the relevant usage sites already call GetRest() before comparing

which exactly is the reason that it didn't work anymore.

Old StringArray ItemList resources stored only 16-bit values,
hence ERRCODE_RES_MASK was used to mask the ErrCode values in the
resource for which code had to mask ERRCODE_RES_MASK as well to
compare values. Now the full ErrCode is stored, so code must not
use GetRest() on a value to compare against, or use GetRest() on
both values (which theoretically could lead to ambiguities, but
probably doesn't in resources that are restricted to one module).

Change-Id: I835e47424bb008bc680dc4f8c502c9558397db36
 2017-12-05 15:20:07 +01:00
Caolán McNamara
df2e78f1a8 replace check of eof and GetError with good 
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291
Reviewed-on: https://gerrit.libreoffice.org/45076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-22 13:33:46 +01:00
Caolán McNamara
2161d04688 drop duplicate method 
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-22 13:33:25 +01:00
Andrea Gelmini
d71bcc4dc5 Fix typos 
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
 2017-11-13 08:43:17 +01:00
Noel Grandin
3dde9d988f loplugin:constparams in various(1) 
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-04 07:50:01 +01:00
Noel Grandin
5d618d73ed loplugin:constantparam in basic,basctl 
Change-Id: If918c42d4b82d78c07786cfa47c74d0dfb7493d6
Reviewed-on: https://gerrit.libreoffice.org/44131
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-01 07:14:13 +01:00
Noel Grandin
87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin
ead920a48a loplugin:redundantcast handle dynamic_cast 
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb
Reviewed-on: https://gerrit.libreoffice.org/43621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-10-21 15:44:11 +02:00
Mike Kaganski
daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Tor Lillqvist
6978f506a4 Bin some noise comments and ASCII graphics 
Change-Id: Ib0e786b0e8401da3e3c93bf254727411774e8f43
 2017-09-20 09:47:38 +03:00
Tor Lillqvist
a1eecccadd Clean up a couple of overly verbose SAL_INFOs 
Change-Id: I2b17bfb95f687617967d4e43356d39aa3bb6e041
 2017-09-19 13:59:28 +03:00
Noel Grandin
84cbd6a543 clang-tidy modernize-use-emplace in b* 
Change-Id: I51e0369ba2e1fe0b7c934531f71d3bda95ba09ec
Reviewed-on: https://gerrit.libreoffice.org/42109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-08 20:17:31 +02:00
Noel Grandin
4e70d0b6bf rename SBX errorcodes to BASIC 
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f
Reviewed-on: https://gerrit.libreoffice.org/41706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 19:50:11 +02:00
Noel Grandin
ae8e1ad2e3 convert code-class in ErrCode to scoped enum 
Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7
Reviewed-on: https://gerrit.libreoffice.org/41601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-27 21:24:16 +02:00
Noel Grandin
9881bea8d4 remove unnecessary use of OUString::getStr 
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:55:13 +02:00
Noel Grandin
d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Andrea Gelmini
35a2d88288 Fix typos 
Change-Id: Ib7f43bf17ab8b9fb9d961a908d7620b50826a975
Reviewed-on: https://gerrit.libreoffice.org/40688
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-08-05 00:32:50 +02:00
Caolán McNamara
13fac4894f normalize resource locale ctor construction mechanisms 
make them all the same and share std::locales more

various OModuleClient, etc, classes go away

Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5
Reviewed-on: https://gerrit.libreoffice.org/40634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-02 10:36:07 +02:00