4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
0a1d822372
Many spelling fixes: directories a* - g*.
...
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit a6efc99d19d533fcf53106b6667bafba4d364370)
Conflicts:
accessibility/bridge/org/openoffice/java/accessibility/AccessibleTextImpl.java
accessibility/bridge/org/openoffice/java/accessibility/Component.java
accessibility/bridge/org/openoffice/java/accessibility/Container.java
accessibility/bridge/org/openoffice/java/accessibility/DescendantManager.java
accessibility/bridge/org/openoffice/java/accessibility/Dialog.java
accessibility/bridge/org/openoffice/java/accessibility/Frame.java
accessibility/bridge/org/openoffice/java/accessibility/List.java
accessibility/bridge/org/openoffice/java/accessibility/Menu.java
accessibility/bridge/org/openoffice/java/accessibility/Table.java
accessibility/bridge/org/openoffice/java/accessibility/Tree.java
accessibility/bridge/org/openoffice/java/accessibility/Window.java
accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx
accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx
accessibility/source/extended/accessibleiconchoicectrlentry.cxx
accessibility/source/extended/accessiblelistboxentry.cxx
accessibility/source/extended/accessibletablistbox.cxx
accessibility/source/extended/accessibletablistboxtable.cxx
accessibility/workben/org/openoffice/accessibility/awb/canvas/Canvas.java
accessibility/workben/org/openoffice/accessibility/misc/OfficeConnection.java
apple_remote/AppleRemote.m
autodoc/inc/ary/cpp/c_gate.hxx
autodoc/inc/ary/cpp/cp_ce.hxx
autodoc/inc/ary/cpp/cp_def.hxx
autodoc/inc/ary/cpp/cp_type.hxx
autodoc/inc/ary/doc/d_parametrized.hxx
autodoc/inc/ary/idl/i_type.hxx
autodoc/source/ary/inc/cross_refs.hxx
autodoc/source/ary/inc/sorted_idset.hxx
autodoc/source/display/html/outfile.hxx
autodoc/source/display/html/pagemake.cxx
autodoc/source/display/idl/hi_env.hxx
autodoc/source/parser/inc/tokens/tokproct.hxx
autodoc/source/parser_i/inc/s2_luidl/tokproct.hxx
autodoc/source/parser_i/inc/tokens/tkp2.hxx
automation/inc/automation/commtypes.hxx
automation/inc/automation/simplecm.hxx
automation/source/server/recorder.cxx
automation/source/server/recorder.hxx
automation/source/server/statemnt.cxx
automation/source/simplecm/packethandler.hxx
automation/source/simplecm/simplecm.cxx
avmedia/source/framework/soundhandler.cxx
basegfx/inc/basegfx/range/rangeexpander.hxx
basic/inc/basic/sbxdef.hxx
basic/source/classes/sbunoobj.cxx
basic/source/classes/sbxmod.cxx
basic/source/comp/dim.cxx
basic/source/comp/exprgen.cxx
basic/source/runtime/step1.cxx
basic/source/runtime/step2.cxx
basic/source/sbx/sbxint.cxx
basic/source/uno/namecont.cxx
basic/workben/mgrtest.cxx
bean/com/sun/star/beans/LocalOfficeConnection.java
bean/com/sun/star/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/LocalOfficeConnection.java
bean/com/sun/star/comp/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/OOoBean.java
bridges/inc/bridges/cpp_uno/bridge.hxx
bridges/source/cpp_uno/cc50_solaris_intel/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_intel/uno2cpp.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_macosx_powerpc/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/except.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_os2_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_os2_intel/except.cxx
bridges/source/cpp_uno/gcc3_os2_intel/uno2cpp.cxx
bridges/source/cpp_uno/mingw_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/msvc_win32_intel/except.cxx
bridges/source/cpp_uno/s5abi_macosx_x86-64/except.cxx
bridges/source/cpp_uno/shared/component.cxx
bridges/source/jni_uno/jni_base.h
bridges/source/jni_uno/jni_bridge.cxx
bridges/source/jni_uno/jni_java2uno.cxx
bridges/source/jni_uno/jni_uno2java.cxx
canvas/inc/canvas/base/doublebitmapbase.hxx
canvas/inc/canvas/base/floatbitmapbase.hxx
canvas/inc/canvas/base/integerbitmapbase.hxx
canvas/source/cairo/cairo_canvasbitmap.cxx
canvas/source/cairo/cairo_textlayout.cxx
chart2/source/controller/dialogs/ObjectNameProvider.cxx
chart2/source/view/diagram/VDiagram.cxx
chart2/source/view/main/ChartView.cxx
cli_ure/source/native/makefile.mk
cli_ure/source/uno_bridge/cli_data.cxx
codemaker/source/javamaker/javatype.cxx
comphelper/inc/comphelper/componentcontext.hxx
comphelper/inc/comphelper/interaction.hxx
comphelper/inc/comphelper/locale.hxx
comphelper/inc/comphelper/string.hxx
comphelper/source/container/embeddedobjectcontainer.cxx
comphelper/source/misc/accessiblecontexthelper.cxx
comphelper/source/misc/asyncnotification.cxx
comphelper/source/misc/locale.cxx
comphelper/source/misc/mediadescriptor.cxx
comphelper/source/misc/numberedcollection.cxx
comphelper/source/misc/proxyaggregation.cxx
comphelper/source/misc/scopeguard.cxx
comphelper/source/misc/sequenceashashmap.cxx
configure.in
connectivity/source/commontools/parameters.cxx
connectivity/source/drivers/dbase/DTable.cxx
connectivity/source/drivers/evoab2/NStatement.cxx
connectivity/source/drivers/file/FPreparedStatement.cxx
connectivity/source/drivers/jdbc/DatabaseMetaData.cxx
connectivity/source/inc/flat/ETable.hxx
connectivity/source/parse/sqlnode.cxx
cosv/inc/cosv/persist.hxx
cosv/inc/cosv/ploc_dir.hxx
cosv/inc/cosv/tpl/dyn.hxx
cppu/source/LogBridge/LogBridge.cxx
cppu/source/uno/data.cxx
cppuhelper/source/bootstrap.cxx
cppuhelper/source/component_context.cxx
cppuhelper/source/propshlp.cxx
cppuhelper/source/servicefactory.cxx
cpputools/source/registercomponent/registercomponent.cxx
cui/source/customize/acccfg.cxx
cui/source/dialogs/about.cxx
cui/source/dialogs/commonlingui.hxx
cui/source/dialogs/showcols.cxx
cui/source/inc/cuihyperdlg.hxx
cui/source/inc/cuitabline.hxx
cui/source/options/optsave.src
cui/source/tabpages/tpline.cxx
cui/source/tabpages/transfrm.cxx
dbaccess/source/core/api/CacheSet.cxx
dbaccess/source/core/api/KeySet.cxx
dbaccess/source/core/api/RowSet.cxx
dbaccess/source/core/api/RowSet.hxx
dbaccess/source/core/api/RowSetBase.cxx
dbaccess/source/core/api/RowSetBase.hxx
dbaccess/source/core/api/RowSetCache.cxx
dbaccess/source/core/api/querycomposer.cxx
dbaccess/source/ext/adabas/Acomponentmodule.hxx
dbaccess/source/ui/app/AppControllerDnD.cxx
dbaccess/source/ui/app/AppDetailView.cxx
dbaccess/source/ui/browser/brwctrlr.cxx
dbaccess/source/ui/browser/sbagrid.cxx
dbaccess/source/ui/browser/unodatbr.cxx
dbaccess/source/ui/dlg/AdabasStat.hxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/dlg/directsql.cxx
dbaccess/source/ui/dlg/generalpage.hxx
dbaccess/source/ui/dlg/tablespage.cxx
dbaccess/source/ui/inc/JoinTableView.hxx
dbaccess/source/ui/inc/TableController.hxx
dbaccess/source/ui/inc/UITools.hxx
dbaccess/source/ui/inc/brwctrlr.hxx
dbaccess/source/ui/inc/datasourcemap.hxx
dbaccess/source/ui/querydesign/JoinTableView.cxx
dbaccess/source/ui/querydesign/QueryDesignView.cxx
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
dbaccess/source/ui/querydesign/TableWindow.cxx
dbaccess/source/ui/querydesign/querycontroller.cxx
dbaccess/source/ui/relationdesign/RelationTableView.cxx
dbaccess/source/ui/tabledesign/TableController.cxx
desktop/source/app/app.cxx
desktop/source/app/appinit.cxx
desktop/source/app/langselect.cxx
desktop/source/app/officeipcthread.cxx
desktop/source/deployment/manager/dp_extensionmanager.cxx
desktop/source/deployment/misc/dp_misc.cxx
desktop/source/deployment/misc/dp_resource.cxx
desktop/source/deployment/registry/dp_backend.cxx
desktop/source/deployment/registry/package/dp_package.cxx
desktop/source/migration/cfgfilter.cxx
desktop/source/migration/migration.cxx
desktop/source/splash/splash.cxx
desktop/win32/source/QuickStart/QuickStart.cpp
desktop/win32/source/setup/setup.cpp
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
dtrans/source/win32/clipb/MtaOleClipb.hxx
dtrans/source/win32/clipb/WinClipbImpl.cxx
editeng/source/editeng/editview.cxx
editeng/source/editeng/impedit2.cxx
editeng/source/editeng/impedit3.cxx
editeng/source/editeng/impedit4.cxx
editeng/source/editeng/textconv.hxx
editeng/source/misc/unolingu.cxx
embeddedobj/source/commonembedding/persistence.cxx
embeddedobj/source/general/dummyobject.cxx
embeddedobj/source/msole/olecomponent.cxx
embeddedobj/source/msole/olepersist.cxx
embeddedobj/test/Container1/NativeView.java
extensions/source/bibliography/framectr.cxx
extensions/source/macosx/spotlight/OOoContentDataParser.m
extensions/source/macosx/spotlight/unzip.h
extensions/source/macosx/spotlight/unzip.m
extensions/source/oooimprovement/myconfigurationhelper.hxx
extensions/source/propctrlr/eventhandler.cxx
extensions/source/propctrlr/formcomponenthandler.cxx
extensions/source/propctrlr/pcrcomponentcontext.hxx
extensions/source/scanner/twain.cxx
extensions/source/update/check/updatecheckconfig.hxx
external/mingwheaders/mingw_atl_headers.patch
extras/source/misc_config/wizard/web/layouts/source.xml.xsl
fileaccess/source/FileAccess.cxx
filter/inc/filter/msfilter/msocximex.hxx
filter/inc/filter/msfilter/svxmsbas.hxx
filter/qa/complex/filter/detection/typeDetection/Helper.java
filter/source/config/cache/basecontainer.cxx
filter/source/config/cache/cacheitem.hxx
filter/source/config/cache/contenthandlerfactory.cxx
filter/source/config/cache/filtercache.cxx
filter/source/config/cache/filtercache.hxx
filter/source/config/cache/filterfactory.cxx
filter/source/config/cache/frameloaderfactory.cxx
filter/source/config/cache/querytokenizer.hxx
filter/source/config/cache/typedetection.cxx
filter/source/config/cache/typedetection.hxx
filter/source/config/cache/versions.hxx
filter/source/config/fragments/makefile.mk
filter/source/config/tools/merge/pyAltFCFGMerge
filter/source/flash/swfwriter.cxx
filter/source/flash/swfwriter1.cxx
filter/source/msfilter/msdffimp.cxx
filter/source/msfilter/msocximex.cxx
filter/source/msfilter/msvbahelper.cxx
filter/source/msfilter/svxmsbas.cxx
filter/source/xmlfilterdetect/filterdetect.cxx
filter/source/xslt/import/uof2/uof2odf.xsl
filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
filter/source/xsltfilter/com/sun/star/comp/xsltfilter/Base64.java
forms/source/xforms/convert.hxx
forms/source/xforms/model.cxx
fpicker/source/aqua/SalAquaFilePicker.mm
fpicker/source/office/fpinteraction.cxx
fpicker/source/unx/gnome/SalGtkFolderPicker.cxx
fpicker/source/unx/kde4/KDE4FilePicker.cxx
fpicker/source/win32/filepicker/PreviewCtrl.cxx
fpicker/source/win32/filepicker/PreviewCtrl.hxx
fpicker/source/win32/filepicker/VistaFilePicker.cxx
fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx
fpicker/source/win32/filepicker/helppopupwindow.hxx
fpicker/source/win32/folderpicker/MtaFop.hxx
framework/inc/classes/droptargetlistener.hxx
framework/inc/classes/filtercache.hxx
framework/inc/classes/filtercachedata.hxx
framework/inc/classes/protocolhandlercache.hxx
framework/inc/classes/servicemanager.hxx
framework/inc/commands.h
framework/inc/dispatch/basedispatcher.hxx
framework/inc/dispatch/blankdispatcher.hxx
framework/inc/dispatch/closedispatcher.hxx
framework/inc/dispatch/createdispatcher.hxx
framework/inc/dispatch/dispatchprovider.hxx
framework/inc/dispatch/helpagentdispatcher.hxx
framework/inc/dispatch/mailtodispatcher.hxx
framework/inc/dispatch/menudispatcher.hxx
framework/inc/dispatch/oxt_handler.hxx
framework/inc/dispatch/popupmenudispatcher.hxx
framework/inc/dispatch/selfdispatcher.hxx
framework/inc/dispatch/servicehandler.hxx
framework/inc/dispatch/startmoduledispatcher.hxx
framework/inc/dispatch/systemexec.hxx
framework/inc/helper/fixeddocumentproperties.hxx
framework/inc/helper/ocomponentaccess.hxx
framework/inc/helper/oframes.hxx
framework/inc/helper/otasksenumeration.hxx
framework/inc/helper/persistentwindowstate.hxx
framework/inc/helper/statusindicator.hxx
framework/inc/helper/statusindicatorfactory.hxx
framework/inc/helper/tagwindowasmodified.hxx
framework/inc/helper/titlebarupdate.hxx
framework/inc/helper/vclstatusindicator.hxx
framework/inc/interaction/quietinteraction.hxx
framework/inc/jobs/helponstartup.hxx
framework/inc/jobs/job.hxx
framework/inc/jobs/jobdata.hxx
framework/inc/jobs/jobexecutor.hxx
framework/inc/loadstate.h
framework/inc/macros/debug/assertion.hxx
framework/inc/macros/debug/event.hxx
framework/inc/macros/debug/filterdbg.hxx
framework/inc/macros/debug/memorymeasure.hxx
framework/inc/macros/debug/timemeasure.hxx
framework/inc/macros/xserviceinfo.hxx
framework/inc/queries.h
framework/inc/recording/dispatchrecordersupplier.hxx
framework/inc/services/autorecovery.hxx
framework/inc/services/backingcomp.hxx
framework/inc/services/contenthandlerfactory.hxx
framework/inc/services/desktop.hxx
framework/inc/services/detectorfactory.hxx
framework/inc/services/frame.hxx
framework/inc/services/frameloaderfactory.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/services/license.hxx
framework/inc/services/logindialog.hxx
framework/inc/services/modulemanager.hxx
framework/inc/services/pathsettings.hxx
framework/inc/services/pluginframe.hxx
framework/inc/services/substitutepathvars.hxx
framework/inc/services/task.hxx
framework/inc/services/taskcreatorsrv.hxx
framework/inc/stdtypes.h
framework/inc/threadhelp/fairrwlock.hxx
framework/inc/threadhelp/inoncopyable.h
framework/inc/threadhelp/itransactionmanager.h
framework/inc/threadhelp/lockhelper.hxx
framework/inc/threadhelp/readguard.hxx
framework/inc/threadhelp/resetableguard.hxx
framework/inc/threadhelp/transactionguard.hxx
framework/inc/threadhelp/writeguard.hxx
framework/inc/uifactory/uielementfactorymanager.hxx
framework/inc/xml/acceleratorconfigurationreader.hxx
framework/qa/complex/dispatches/checkdispatchapi.java
framework/qa/complex/framework/autosave/AutoSave.java
framework/qa/complex/framework/autosave/Protocol.java
framework/qa/complex/framework/recovery/RecoveryTest.java
framework/qa/complex/loadAllDocuments/StreamSimulator.java
framework/source/accelerators/acceleratorconfiguration.cxx
framework/source/accelerators/acceleratorexecute.cxx
framework/source/accelerators/acceleratorexecute.hxx
framework/source/accelerators/keymapping.cxx
framework/source/accelerators/presethandler.cxx
framework/source/application/framework.cxx
framework/source/application/login.cxx
framework/source/classes/framecontainer.cxx
framework/source/classes/menumanager.cxx
framework/source/classes/taskcreator.cxx
framework/source/dispatch/closedispatcher.cxx
framework/source/dispatch/dispatchprovider.cxx
framework/source/dispatch/helpagentdispatcher.cxx
framework/source/dispatch/interceptionhelper.cxx
framework/source/dispatch/mailtodispatcher.cxx
framework/source/dispatch/menudispatcher.cxx
framework/source/dispatch/oxt_handler.cxx
framework/source/dispatch/servicehandler.cxx
framework/source/fwe/classes/framelistanalyzer.cxx
framework/source/fwe/dispatch/interaction.cxx
framework/source/fwe/helper/titlehelper.cxx
framework/source/fwe/helper/undomanagerhelper.cxx
framework/source/fwe/xml/eventsdocumenthandler.cxx
framework/source/fwe/xml/statusbardocumenthandler.cxx
framework/source/fwe/xml/toolboxdocumenthandler.cxx
framework/source/fwi/classes/protocolhandlercache.cxx
framework/source/fwi/threadhelp/lockhelper.cxx
framework/source/fwi/threadhelp/transactionmanager.cxx
framework/source/helper/persistentwindowstate.cxx
framework/source/helper/statusindicatorfactory.cxx
framework/source/helper/vclstatusindicator.cxx
framework/source/inc/accelerators/acceleratorcache.hxx
framework/source/inc/accelerators/acceleratorconfiguration.hxx
framework/source/inc/accelerators/presethandler.hxx
framework/source/inc/accelerators/storageholder.hxx
framework/source/inc/loadenv/actionlockguard.hxx
framework/source/inc/loadenv/loadenv.hxx
framework/source/inc/loadenv/loadenvexception.hxx
framework/source/inc/pattern/frame.hxx
framework/source/inc/pattern/storages.hxx
framework/source/inc/pattern/window.hxx
framework/source/jobs/helponstartup.cxx
framework/source/jobs/job.cxx
framework/source/jobs/jobdata.cxx
framework/source/jobs/jobdispatch.cxx
framework/source/jobs/jobresult.cxx
framework/source/jobs/joburl.cxx
framework/source/jobs/shelljob.cxx
framework/source/loadenv/loadenv.cxx
framework/source/services/autorecovery.cxx
framework/source/services/backingwindow.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/modulemanager.cxx
framework/source/services/pathsettings.cxx
framework/source/services/substitutepathvars.cxx
framework/source/uiconfiguration/moduleuicfgsupplier.cxx
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
framework/source/uiconfiguration/uicategorydescription.cxx
framework/source/uiconfiguration/uiconfigurationmanagerimpl.cxx
framework/source/uiconfiguration/windowstateconfiguration.cxx
framework/source/uielement/uicommanddescription.cxx
framework/source/unotypes/fwk.xml
framework/source/xml/imagesdocumenthandler.cxx
framework/test/test.cxx
framework/test/test_componentenumeration.bas
framework/test/test_statusindicatorfactory.bas
framework/test/threadtest.cxx
framework/test/threadtest/threadtest.cxx
framework/test/typecfg/cfgview.cxx
framework/test/typecfg/xml2xcd.cxx
include/basegfx/polygon/b2dpolygon.hxx
include/canvas/base/graphicdevicebase.hxx
include/canvas/canvastools.hxx
include/comphelper/configurationhelper.hxx
include/comphelper/embeddedobjectcontainer.hxx
include/comphelper/propagg.hxx
include/comphelper/sequenceashashmap.hxx
include/connectivity/sqlerror.hxx
include/connectivity/sqlnode.hxx
include/cppuhelper/propshlp.hxx
include/editeng/AccessibleContextBase.hxx
include/framework/framelistanalyzer.hxx
sfx2/source/dialog/backingcomp.cxx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
Change-Id: I2618bf83c0e30f68f23ff25f6eb466df04d34c6d
2014-04-30 12:13:36 +01:00
061130bd6d
fdo#75280 Started cleaning up of sal_uIntPtr usage.
...
Converted wrong usage of sal_uIntPtr to appropriate other types in basic
module.
The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain.
Update due to code review comments:
Fixed forgetting to change some declarations in iosys.cxx.
Cleaned up the one remaining sal_uIntPtr in iosys.cxx
Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx
Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG .
Conflicts:
basic/source/runtime/iosys.cxx
Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
2014-03-28 20:08:46 +01:00
f288d7dcbd
basic: sal_Bool->bool
...
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
2014-03-27 13:45:08 +02:00
6a38eace8c
Remove visual noise from basic
...
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-25 21:09:17 +00:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
70b3006002
fix crash when importing unsupported macro content, related fdo#59374
...
Change-Id: I960c8174454074fd9ddb27fb17244d782c4cb24c
2014-02-12 01:01:35 +01:00
bd20500cf3
Simplify access to theCoreReflection singleton
...
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
2014-02-07 12:03:03 +01:00
6c820a2816
basic: _FIND_STATIC likely not an error in SbiExprNode::GenElement()
...
All other _FIND_* are explicitly not errors, and probably CWS npower10
forgot to adapt this assertion.
Change-Id: If721c275eb1bc31d76140898602b41e11c23d82e
Reviewed-on: https://gerrit.libreoffice.org/7863
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2014-02-05 10:16:09 +00:00
a5090ccf75
Related: #i123862# use O*String's isEmpty() method...
...
to check for emptiness in modules starting with 'b'
Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 87204b0f4062ef8fc8f138ad15f4378da609d4e2)
Conflicts:
basctl/source/basicide/baside2.cxx
basctl/source/basicide/bastype2.cxx
basctl/source/basicide/localizationmgr.cxx
basctl/source/dlged/dlgedobj.cxx
basic/source/basmgr/basmgr.cxx
basic/source/basmgr/vbahelper.cxx
basic/source/classes/sbunoobj.cxx
basic/source/comp/sbcomp.cxx
basic/source/runtime/iosys.cxx
basic/source/runtime/methods.cxx
basic/source/runtime/methods1.cxx
basic/source/runtime/step2.cxx
basic/source/uno/namecont.cxx
basic/source/uno/scriptcont.cxx
binaryurp/source/bridge.cxx
binaryurp/source/bridgefactory.cxx
binaryurp/source/reader.cxx
binaryurp/source/unmarshal.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/shared/vtablefactory.cxx
bridges/source/jni_uno/jni_data.cxx
Change-Id: I37bd84e0a1d6426759dba81854faf32c88147fe1
2014-02-04 12:47:59 +00:00
f96f38f8f8
bool improvements
...
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
2014-01-28 20:26:30 +01:00
8cccfb8f8f
coverity#441077 Dereference after null check
...
Change-Id: Ia6a04846068e0bc500942e9a2dc6ee2e72d9d527
2014-01-27 14:38:39 +00:00
7acea5ae4c
coverity#707649 Uninitialized scalar field
...
Change-Id: I1a95a051463860dc9c7b087bfaf17f3b70f297ee
2014-01-27 14:38:37 +00:00
9e77ddcd19
Resolves: #i123817# prepare codebase for updating to boost 1.55
...
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)
Conflicts:
basic/source/comp/parser.cxx
basic/source/comp/token.cxx
dbaccess/source/ui/dlg/generalpage.cxx
sc/source/ui/unoobj/chart2uno.cxx
vcl/quartz/salbmp.cxx
Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2014-01-06 16:32:20 +00:00
0a33e24d11
sbobjmod.hxx is private to basic
...
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11 10:39:57 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
8b308d510e
basic: include <> for external includes
...
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
2013-11-11 22:37:24 -06:00
e9c4ee996d
remove unnecessary use of OUString constructor in BASIC module
...
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
2013-11-11 11:21:25 +02:00
54a17dd246
windows: warning 4355 is disabled globally in com_MSC_defs.mk
...
So there is no need to do this locally, too.
Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-28 01:02:13 +01:00
8396cce9b5
clean up places accessing the NULL at the of an OUString
...
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.
Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-23 13:12:55 +02:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
66a96c8274
clean up SbiScanner::NextSym() a little, fdo#70319 follow-up
...
Number recognition was suboptimal and didn't properly resync scan
positions after having detected an error.
Change-Id: I278fdaaf17ed40560785deaaad0e3412a249d90a
2013-10-15 12:52:15 +02:00
b680e35254
Test WNT instead of the vague UNX
...
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
2013-10-12 09:55:48 +03:00
39022b8b7d
little String to OUString + documentation
...
Change-Id: I982e44150fd2909da0571409f16051d79377d7a3
Reviewed-on: https://gerrit.libreoffice.org/6192
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-10-10 17:58:31 +00:00
9cff818949
CID#708773 unused pointer value
...
Change-Id: Ib394a444882f5ffa1e0c5e833d59f4e4985479df
2013-10-07 11:46:59 +01:00
470af978eb
CID#707648 uninitialized member
...
Change-Id: Ib8371710dd6c856b143782ca9c18f4ee76798f0e
2013-10-07 11:46:58 +01:00
3c2983ded9
CID#707646 uninitialized member variables
...
also CID#707647
Change-Id: I9962bd2417119944a243d8a92711866548248e36
2013-10-07 11:46:58 +01:00
ef53bd8ab2
CID#707643 uninitialized members
...
Change-Id: I23386c780bf484652a518d907d7dc0cc3c910040
2013-10-07 11:46:58 +01:00
ad7b757a25
'ist' -> 'is' here and there.
...
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-04 20:27:30 +02:00
ea1e3b77d4
sal_Bool to bool
...
Change-Id: I16ddbcf100e21d6c05fccbe24faca2932a605902
2013-10-02 10:00:44 +09:00
dbff5bd4cd
CID#736166 unlikely out of bounds
...
Change-Id: I8a0f97be1723766df9f8fe287417365febf54966
2013-09-12 13:09:05 +01:00
17fb3ac805
WaE: C4101: 'ex' : unreferenced local variable
...
Change-Id: If56eaa48c176138cd1b74da2f7f0aa71e3845894
2013-09-03 13:55:18 +03:00
d3ff876f3c
GSOC work, small fixes after
...
Fixed some errors after the merge.
Change-Id: I8c0360d7fd04425a00dacb37f673d10efffa0ebe
2013-09-02 18:17:03 +02:00
755a74906e
GSOC work, multiple fixes
...
Code completion: parser recognizes extended types ony when the checkbox is checked.
Fixed a crash caused by a misspelled uno type.
Fixed function CodeCompleteDataCache::Clear() to clear both internal variables.
Change-Id: I82fdd2e1cf749237e2e2de4a9a2fc7d07fb7eb4a
2013-09-02 18:17:01 +02:00
9b534193a3
GSOC work, behavior fixes
...
Code completition: left/right arrow keys handled. Left arrow dismisses the dialog when reaches the dot. Right arrow dismissed the dialog when reaches the next line.
ListBox appearance fixed.
TAB key can insert the first matching entry.
Autocorrect:
"Autocorrect Keywords" has been renamed to "Autcorrect" (in the UI, and the config file, after this patch a make dev-install is needed). Keyword case correction is not just capitalizing the first letter ( eg. Elseif -> ElseIf ).
Autoclose procedures:
cursor is being placed inside the preocedure.
Change-Id: Ie7e9ae96b49bd94562db83f96e1c4ad63ab3f3d6
2013-09-02 18:16:58 +02:00
b4319d8726
GSOC work, Extended types correction
...
Stucts can be autocompleted when extended types disabled.
Created two functions to make the code brighter. They extract the methods/fields from an XIdlClass and return them in a std::vector<OUString>.
I had to modify file basic/source/comp/dim.cxx, to check on UNO types when code completition is on.
Change-Id: Id93a6fe896424efb7868f6102985f59fb419b17e
2013-09-02 18:16:55 +02:00
61ee2598b1
GSOC work, code complete option, menu entry fixes
...
Menu entry is added under View->Enable Code Completition when in Experimental mode.
Fixed the call of funtion SbModule::GetCodeCompleteDataFromParse() to be called only when code completition is enabled.
Replaced the occurences of SvtMiscOptions to CodeCompleteOptions.
Change-Id: If0520123ab5f612d7d24fb98f8e9bf6881af76cb
2013-09-02 18:16:47 +02:00
728bc0518b
GSOC work Window appearance fix 2 + code fixes
...
Added a function to select the first entry in the ListBox by default.
Selected entry can be inserted with the ENTER key.
Fixed some code in basic code generation class (SbiCodeGen).
Change-Id: Ia6eb43ee5661a0a3ae0b738b619f19972f019eac
2013-09-02 18:16:45 +02:00
5beb4be54c
GSOC work week 5, some recent fixes
...
This week I've managed to fix the ListBox appearance. Also, I've modified the code: it gets the data on insert/remove/change, and gets updated only when the dot is pressed. This makes the data to be up-to-date. Next, I wrote a Split(OUString , char) function to do the nested reflection (It works, but it will need some tweaks later). Also, code generation is disabled for code completition (just a boolean value, maybe it could be done in a more "elegant" way, like the error supression).
Change-Id: I43d250c0a065351950ac6424dcd88266d70bcef3
2013-09-02 18:16:44 +02:00
025e7ff3e1
GSOC work week 2, getting infromation from variables and print on terminal
...
This is an early version. I use the BASIC parser to parse the source,
then the infromation is extracted from the symbol table built by parser.
Error reporting is suppressed, beacuse it is not needed fro code completition.
I placed my function inside SbModule, and created a struct called CodeCompletitionData, which holds the object's name, it's parent, and it's type name.
This function, SbMethod::GetCodeCompleteDataFromParse() is called from Basic IDE's Notify function, which updates a cache(actually, reassigns a viariable :) ).
Later, in the EditorWindow::KeyInput function there is a check wheteher dot key is pressed. After that, the actual variable (or word) is being looked up in the vector that holds code completition data. And finally, if it is found, it's methods are printed on the terminal.
Change-Id: Idaf19baa8f720b8b117a76dc3cc2f90dd04fd155
2013-09-02 18:16:42 +02:00
f97d794654
GSOC work week 0-1, allowing BASIC to recognize UNO interfaces
...
Introduced a new function calles IsUnoInterface in SbiParser to determine, if
a variable is a type of an UNO interface. It uses reflection.CoreReflection to
do that, on success it returs true otherwise false.
Change-Id: I18895127bcbd92dc7a25feb5d82a7d1343bde851
2013-09-02 18:16:42 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
4c9a08e78b
fix for fdo#62323 bad conversion of Hex strings for certain values
...
Basic hex literals are basic Integer ( e.g. 4 byte ) types with
-2,147,483,648 through 2,147,483,647 range. Interally the scanner
was using a long to form/scan the literal, this led to bad behaviour
on 64bit linux ( where normally long -> 8 bytes )
Change-Id: I1d0fcc55ed0eda636da1445329737d1684e69f33
2013-08-20 08:59:54 +01:00
392c5b2a70
Mark as const
...
Change-Id: Idd1d0641d5b7d8594f354c7d2e2a9093ecc6b2f7
2013-08-01 04:33:23 +09:00
bddd4d4598
Mark as const
...
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
6a08067902
OUString convertion for unotools
...
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-02 07:31:30 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
caecf6102f
SbiScanner::NextSym: check status after rtl_math_uStringToDouble()
...
For example, 10e308 is overflow, not 0 ...
Change-Id: Ib7d622865bfb73581732bda45c76e078ee7d05d0
2013-03-21 19:32:45 +01:00
ead0a6038b
coverity#705627: fix memory leak
...
Change-Id: I4f73f77b27d2ed28a9f97757105c8a6cc5521b33
2013-03-09 17:59:12 +01:00
f5ca04caca
Related to fdo#60724: correct spelling
...
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml
Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
