wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
406,824 Commits 5 Branches 0 Tags
b7324ecbf36aae49627d5a5ff250a94de3abc4aa
Commit Graph

268 Commits

Author SHA1 Message Date
Andrea Gelmini
6fab286b2a Fix typos 
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 07:42:39 +00:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Noel Grandin
8a16f665b1 makeAny->Any in canvas..configmgr 
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e
Reviewed-on: https://gerrit.libreoffice.org/33869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 10:44:01 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Noel Grandin
3a705ab405 OSL_TRACE->SAL in avmedia..canvas 
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
 2016-12-13 08:14:00 +02:00
Noel Grandin
d6f2dd831a remove useless Mutex guards 
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-12 09:16:09 +00:00
Noel Grandin
f31d98f63c loplugin:expandablemethods in avmedia..canvas 
Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54
Reviewed-on: https://gerrit.libreoffice.org/30753
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 07:00:18 +00:00
Noel Grandin
78b4a1fb01 update vclwidget loplugin to find ref-dropping assigment 
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.

Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 06:55:41 +00:00
Noel Grandin
5a5731cd05 loplugin:expandablemethodds in include/basic..comphelper 
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e
Reviewed-on: https://gerrit.libreoffice.org/30120
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-21 09:57:38 +00:00
Michael Stahl
b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos) 
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
 2016-09-15 12:01:11 +02:00
Jochen Nitschke
f1018190a8 tdf#88205 use list ctor for uno::Sequence a11y to canvas 
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18
Reviewed-on: https://gerrit.libreoffice.org/28866
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 07:23:51 +00:00
Noel Grandin
1e49e33c26 loplugin:constantparam in chart2..connectivity 
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 06:40:30 +00:00
Muhammet Kara
0bd4154b17 tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor 
in basctl, basegfx, canvas

Change-Id: I59383d2599793b99b560333387e163a3d80eecec
Reviewed-on: https://gerrit.libreoffice.org/27778
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-04 05:40:11 +00:00
Mark Page
8561f8bfcc tdf#96099 Remove various smart pointer typedefs in canvas 
Change-Id: Ied6ec5f7830c53a339de985d173c1dec711ac8f7
Reviewed-on: https://gerrit.libreoffice.org/26092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-06-09 12:56:27 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Stephan Bergmann
a30148d3fc loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ie7f382fb47463d9bc315dc767c1d0550145ec935
 2016-04-20 17:25:36 +02:00
Noel Grandin
9b640c03e0 loplugin:passstuffbyref in canvas 
Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358
 2016-04-13 13:27:51 +02:00
Rohan Kumar
f0de4374ff tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals 
I removed the OSL_DEBUG_LEVEL > 1 conditionals with OSL_DEBUG_LEVEL > 0
or SAL_INFO macros

Change-Id: Ia2a483ea0f992bf182a6beed2b4558a4fb7c5680
Reviewed-on: https://gerrit.libreoffice.org/23079
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-04-07 12:15:50 +00:00
Noel Grandin
5adde1bf69 loplugin:unuseddefaultparams various 
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546
Reviewed-on: https://gerrit.libreoffice.org/22852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-03 11:39:56 +00:00
Noel Grandin
5c43ca5518 convert SpriteChangeRecord::ChangeType to scoped enum 
Change-Id: I29696f37a023317bdaa8f53d753ccaeb8e68a3c2
 2016-02-24 11:48:37 +02:00
Noel Grandin
81b7de3d9f convert canvas::IRenderModule::PrimitiveType to scoped enum 
Change-Id: Idf2e7449ce5b595386f437597ce7ccf00d141db0
Reviewed-on: https://gerrit.libreoffice.org/22634
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-24 08:11:12 +00:00
Noel Grandin
b2bb094f6b convert GradientType to scoped enum 
Change-Id: Icef1d8d38481022104a957ac9deac1c03dc2d6fb
Reviewed-on: https://gerrit.libreoffice.org/22632
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-23 10:17:24 +00:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
Andrea Gelmini
92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Noel Grandin
1f86864e97 loplugin:unusedfields various 
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
 2015-11-25 13:57:29 +02:00
Noel Grandin
ce6170dafe loplugin:unusedfields in canvas 
Change-Id: Ic532ebf1f929044d72ee3abca29c8275cbe837ac
Reviewed-on: https://gerrit.libreoffice.org/20078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-20 13:25:18 +00:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann
c40c7a8c36 loplugin:nullptr (automatic rewrite) 
Change-Id: I9e064592c4ee18a600aadfa20b3c89ecafc818d4
 2015-11-10 10:31:18 +01:00
Thorsten Behrens
368b657f4b Partial revert 'for_each -> range-based' 
There was a subtle change in semantics, the earlier loop was only
iterating until aEnd, covering only unique elements of the vector.

This partially reverts commit c04fd82433e9155ad61ebd92ca7b43a729a87890

Change-Id: I75c5f1b343c3fa8855f6d7f8f706b9259bc9f6df
 2015-11-02 13:45:45 +01:00
Mario J. Rugiero
d841b44243 std::for_each -> range based for in canvas/source/tools/verifyinput.cxx 
Change-Id: I71c714a459ea81a268f93f8ffc5286eb532794ca
Reviewed-on: https://gerrit.libreoffice.org/19711
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:30:15 +00:00
Mario J. Rugiero
c04fd82433 for_each -> range-based for in canvas/source/tools/spriteredrawmanager.cxx 
Change-Id: Ibe089e53488a9ba6baded637b17a1aeee0908f79
Reviewed-on: https://gerrit.libreoffice.org/19709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:29:31 +00:00
Mario J. Rugiero
1bd101d91d boost::bind -> lambdas in canvas/source/tools/surface.cxx 
Change-Id: I9a9c4832cf18b10e15d2a4de8944b404b082e990
Reviewed-on: https://gerrit.libreoffice.org/19710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:28:33 +00:00
Noel Grandin
065c8b48a6 use uno::Reference::set method instead of assignment 
Change-Id: I58410209f32f988f258a588364e0b037c2790211
 2015-10-30 08:10:22 +02:00
Noel Grandin
c7e8f21a53 loplugin:unusedmethods 
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 05:58:41 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Noel Grandin
6d7353deb8 eliminate typedef only being used once 
Change-Id: I1e54968a67f3edce3b2297ea1932d5b07e2da643
 2015-10-07 08:27:25 +02:00
Noel Grandin
b1b6f163d3 inline ISurfaceProxySharedPtr typedef 
some places were not using the typedef anyhow

Change-Id: Idf92ad63b05101832827113701a85eca48c084c6
 2015-10-07 08:27:25 +02:00
Andrea Gelmini
2957be02c5 Fix typos 
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-10-02 08:54:51 +00:00
Caolán McNamara
22b80ac8e2 boost->std 
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 12:54:25 +00:00
Caolán McNamara
0f36d4a923 coverity#1323755 Using invalid iterator 
try and help coverity to know that aEnd and maFragments.end() are the same
place

Change-Id: I9ce4187d5ed15d0ae26b69bb360dbd47c2a6a185
 2015-09-11 09:31:45 +01:00
Daniel Robertson
cf9fbdb379 canvas: simplify PageManager::nakedFragment loops 
Convert while loops and break statements in PageManager::nakedFragment
into for loops

Change-Id: I671f4eea140f26c2f451d54911d017325084bd08
Reviewed-on: https://gerrit.libreoffice.org/18138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-09-04 23:16:29 +00:00
Daniel Robertson
b7f4940c15 canvas: replace while loops with range-based for 
Change-Id: Ide16bee666cf4df41646f9336a585e22a7fe53bd
Reviewed-on: https://gerrit.libreoffice.org/18131
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-08-30 13:03:22 +00:00
Thorsten Behrens
f7274c6347 canvas: whitespace/comments cleanup 
The more redundant cases of whitespace/comments had to go...

Change-Id: Id0bfab5f60f123c0a4d3d9f8468791e0d8046225
 2015-08-15 21:54:47 +02:00
Daniel Robertson
849f1d37d5 canvas: replace for_each with range-based for-loop 
Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: I6f96833d7f251d44e2308278bb92a7d49fd49bcd
Reviewed-on: https://gerrit.libreoffice.org/17763
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-08-15 18:51:31 +00:00
Daniel Robertson
647b5aecd4 tdf#92459 remove compat_functional from canvas 
Replace all uses of deprecated features from the o3tl in
compat_functional.hxx with lambda expressions in canvas. There should
be no side effects due to this patch.

Change-Id: Ia08ff1642a4f64035441dfdbac03c6fb09fa0443
Reviewed-on: https://gerrit.libreoffice.org/17586
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-11 13:29:20 +00:00
Norbert Thiebaud
e5ec630414 stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxx 
also clean-up and 'standardize' the include sections of canvas' source code

Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73
Reviewed-on: https://gerrit.libreoffice.org/17633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2015-08-11 03:57:18 +00:00
Norbert Thiebaud
326777b5d9 remove VERBOSE use from canva 
in preparation to kill --enable-verbose in configure.ac
convert modules that use VERBOSE-YES/NO (uppercase) env variable
to do things differently at compile time
Convert canvas to use SAL_INFO/SAL_WARN mechanism instead of its
home-grown 'verbose logging'.

Change-Id: I2898d2309d421457839e3cd7078166c6da919882
Reviewed-on: https://gerrit.libreoffice.org/17619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2015-08-10 17:14:18 +00:00
Michael Stahl
9e90038b73 canvas: replace boost::function with std::function 
Change-Id: Ia3644bc0d9db2159aa4e9f05ca2f36e60b63e6f4
 2015-07-31 21:24:26 +02:00
Noel Grandin
a60cc5d62a com::sun::star->css in canvas 
Change-Id: I23c3f774834bb7e84e2f02fe05fa9d844adadc9d
Reviewed-on: https://gerrit.libreoffice.org/17259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-22 09:04:57 +00:00
Takeshi Abe
b854086df8 tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, in canvas.

Change-Id: I8604e6b6e0f45539e3411c98a166518b837b6758
Reviewed-on: https://gerrit.libreoffice.org/16798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-10 07:39:31 +00:00