Commit Graph

5274 Commits

Author SHA1 Message Date
8c8f2a5285 remove unnecessary explicit linefeeds from end of SAL and OSL log calls
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf
Reviewed-on: https://gerrit.libreoffice.org/36727
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21 09:15:11 +02:00
841e1a6f36 remove some old MSVC workarounds
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222
Reviewed-on: https://gerrit.libreoffice.org/36660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21 09:14:45 +02:00
3241d0125e loplugin:redundantcast (clang-cl)
Change-Id: I97ff3f7c4ebfb7c9db2ceed234da1095ed0eeed6
2017-04-19 17:36:25 +02:00
3c3f7d784e Removed duplicated includes
No automatic tools. Manual checked and tested.

Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754
Reviewed-on: https://gerrit.libreoffice.org/36371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13 07:46:16 +02:00
7635e0c1c7 sal_Bool -> bool
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-11 18:38:51 +02:00
1b81754f3f tdf#106866 query character size instead of bytes
Change-Id: I7639fb1accdf728a8170ddb7dc9caf84bad8d3ef
Reviewed-on: https://gerrit.libreoffice.org/36289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-04-10 06:16:12 +02:00
b6637ca811 KAB lo:redundantinline plugin
Change-Id: I522be5260b8f61afb2b133a6e32bd0b66c1b7522
2017-04-06 11:52:17 +02:00
7662e92c64 loplugin:redundantcast find cstyle double casts
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8
Reviewed-on: https://gerrit.libreoffice.org/36187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06 07:47:30 +00:00
f8cff53299 loplugin:redundantcast (clang-cl)
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef
Reviewed-on: https://gerrit.libreoffice.org/36065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04 12:08:43 +00:00
071dcb5f6a loplugin:redundantinline (clang-cl)
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430
Reviewed-on: https://gerrit.libreoffice.org/36063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04 12:06:18 +00:00
5676ced825 make UNO enums scoped for internal LO code
this modifies codemaker so that, for an UNO enum, we generate code
that effectively looks like:

   #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR
       enum class XXX {
           ONE = 1
       };
       constexpr auto ONE = XXX_ONE;
   #else
      ...the old normal way..
   #endif

which means that for LO internal code, the enums are scoped.

The "constexpr auto" trick acts like an alias so we don't have to
use scoped naming everywhere.

Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4
Reviewed-on: https://gerrit.libreoffice.org/34546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04 06:38:03 +00:00
12e88e3b28 fix typo: databse --> database
Change-Id: I3ae198eb599a6b0db1be900a2c464ab7b4c20e89
Reviewed-on: https://gerrit.libreoffice.org/35236
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31 15:02:02 +00:00
da56de9ac4 remove type decorations on char literals
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30 12:21:40 +00:00
17cc6627f9 tdf#39468 Translate German comments
Translate German comments and terms in connectivity/

Change-Id: Id32217529e02d3efd070bc226b0078dcab73a602
Reviewed-on: https://gerrit.libreoffice.org/35820
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-29 19:38:52 +00:00
7668d4e616 Fix typos
Change-Id: I56e429ff1b8ee55ccb8df16002b509770762172c
Reviewed-on: https://gerrit.libreoffice.org/35618
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 16:17:21 +00:00
a12b484be3 loplugin:redundantcast
Change-Id: Icc700698711174246c5fc800105ac5b7c6102296
2017-03-23 20:00:15 +01:00
6291574d94 Remove unused #include <ctype.h>
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23 17:55:31 +01:00
13de958fc3 loplugin:redundantcast toNumericWithoutDecimalPlace returns sal_Int64 already
Change-Id: Iccb11bb5067d6de06ff8786c0acd1af27ffaf8fd
2017-03-23 16:37:33 +00:00
ed76d1d350 loplugins:redundantcast teach it about c-style typedef casts
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23 09:48:10 +00:00
47a9523f3f Fix typos + some German translations
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 10:05:45 +00:00
23bdf47e68 KDE fix various clang plugin complains
Fixes clang plugin reported problems in the KDE and KDE4 backend.

Change-Id: I0280beae9dd6f33ee59bdbe89cd38222f33fdc68
2017-03-16 13:36:11 +01:00
cd1a9bc6b6 loplugin:subtlezeroinit (clang-cl)
Change-Id: I3f080f0c77ba7c5976c8b764e0c7e1f7c78ab47d
2017-03-14 14:42:35 +01:00
0f0ebddb81 Fix typos
Change-Id: Ic54e808956e5cf4e8079942c0ff799f802cd4b6c
Reviewed-on: https://gerrit.libreoffice.org/35053
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-11 05:08:01 +00:00
567ee77154 connectivity: warning C4389: '==' : signed/unsigned mismatch
Change-Id: I95e3d7ac5c78aa18dabcdcff19ec1844e45aee3c
2017-03-09 22:42:16 +01:00
dfad3e8730 Revert "add memory include"
This reverts commit 74961e42d14ca09a33bbf7c932fce58259e2fcdd.

Because 37376e6edf074112671616d855e770a44510ec54 was faster by
31 minutes.
2017-03-09 13:16:31 +01:00
74961e42d1 add memory include
Change-Id: I7904a643eafce296ee7f9a0136d80c0a35a2fdbb
2017-03-08 17:32:35 +00:00
37376e6edf Missing include
Change-Id: I4b054f37eefbb7ab1c971fcf990ae4c457cc6c61
2017-03-08 18:01:17 +01:00
bbbd1f1eec valgrind: fix leak
Change-Id: I569698af09dfe71c0c8b89c40ab111ce71635492
2017-03-08 16:10:34 +00:00
4f61fdba53 nothing inherits, protected->private
Change-Id: I254ffe76603a9c5900ea2ed26d281eba453c059d
2017-03-08 16:10:33 +00:00
14881451de valgrind: fix leak
Change-Id: I8510a59a3d4409bf7203495114e239b4c7effcd8
2017-03-08 15:56:52 +00:00
002f0815b2 nothing inherits, protected->private
Change-Id: Ic38550db57cf44556697f28df00d2f4e764d80ae
2017-03-08 15:48:47 +00:00
f6262b3dcb Remove redundant 'inline' keyword, Linux redux
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-07 08:12:52 +01:00
c7637cf6df remove unused #include
Change-Id: I97111309432359968e890aacd0a285d068991307
2017-03-06 17:55:42 +01:00
6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
6fab286b2a Fix typos
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03 07:42:39 +00:00
f25a8fdff8 Remove bogus source code comments
Change-Id: I616ca3483d926c8e4155512ef5138e3f7978ece3
Reviewed-on: https://gerrit.libreoffice.org/34842
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-03-03 06:05:12 +00:00
198c41c4fe new loplugin unoany
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28 10:17:47 +00:00
a407e4da65 loplugin:loopvartoosmall
Change-Id: Ib90fb2c3f4d976dce764d4c91af797351317397b
2017-02-26 22:00:26 +01:00
e8218371c2 Cleanup
Following 26843cea83292632b4ed92dfd1b3da9a46c12995 (from 2008!)

Change-Id: I09713a6c39994d98dfb82c1ee4cc90b7711e7317
Reviewed-on: https://gerrit.libreoffice.org/34655
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-26 19:08:14 +00:00
7bc1c43800 Fix typos/translations, following 04644956e53d
No automatic tools

Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428
Reviewed-on: https://gerrit.libreoffice.org/30874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21 13:34:20 +00:00
6a77b9b6fa loplugin:subtlezeroinit: connectivity
Change-Id: I4091b05ecc2f8c2daca94870f2fec9e5c928c07f
2017-02-21 07:35:10 +01:00
b802ffe3fd warn->info on icedove/seamonkey profiles
Change-Id: I25fe8a433670effbbfd5c530587602697e4f6cf4
2017-02-19 20:37:40 +00:00
34da3c1244 Firebird: css::sdbcx::Driver is implemented
in Driver.cxx around line 253 and declared as such
in FirebirdDriver::getSupportedServiceNames_Static

Change-Id: I3ca6f144f019ba41af02e2f3ac63395015f7f812
Reviewed-on: https://gerrit.libreoffice.org/34427
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-02-19 17:34:26 +00:00
2c06083c75 remove unused NONE from TAscendingOrder enum
Change-Id: I31c793df40b2a687b4a6c84854f34aba72ac0494
2017-02-17 09:56:19 +02:00
6de3688cc6 Drop :: prefix from std in c*/
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-15 23:01:23 +00:00
367baee6ed Some simplifications, using UNO_QUERY_THROW
Change-Id: I3bfa7b8896c9eb191047edf469749bb7f0128dfd
Reviewed-on: https://gerrit.libreoffice.org/34270
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15 14:19:04 +00:00
8aff36d87f Various typos about property
Change-Id: I7585a1346fb19a886240db8dd393554efee862cc
Reviewed-on: https://gerrit.libreoffice.org/34174
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 16:06:46 +00:00
8646ab97dc Remove MinGW support
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10 18:01:27 +00:00
7cf66202f2 convert SearchParam::SearchType to scoped enum
and drop unused SRCH_LEVDIST enumerator

Change-Id: Ic5118757060656562e04dd7da24a3f143abec3fb
Reviewed-on: https://gerrit.libreoffice.org/34065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10 06:05:09 +00:00
3783df2027 rtl_str_shortenedCompare_WithLength -> OString::startsWith
Change-Id: I3eabdeba10d8d1064f00b817b04f03aad8a6b352
2017-02-08 10:14:20 +01:00