8c8f2a5285
remove unnecessary explicit linefeeds from end of SAL and OSL log calls
...
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf
Reviewed-on: https://gerrit.libreoffice.org/36727
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-21 09:15:11 +02:00
b2764a9b66
convert EDynamicMenuType to scoped enum
...
and drop unused E_HELPBOOKMARKS
Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc
Reviewed-on: https://gerrit.libreoffice.org/36728
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-20 12:55:51 +02:00
ec1a44969e
This doesn't have to be member variable, it is used just once
...
and then forgotten again
Change-Id: Id94639415bd1679b67d5d3094dee8b8f8f3d3167
Reviewed-on: https://gerrit.libreoffice.org/36690
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
2017-04-19 22:35:37 +02:00
8fced917aa
clang-tidy readability-simplify-boolean-expr in accessibility..cui
...
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc
Reviewed-on: https://gerrit.libreoffice.org/36677
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-19 14:38:35 +02:00
2b83e73fd7
remove freshly unused menu support from src files
...
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b
Reviewed-on: https://gerrit.libreoffice.org/36646
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-04-19 13:42:07 +02:00
f3ab7e1403
remove sfx2/sfxcommands.h
...
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-18 14:19:31 +01:00
93d58279cd
Related tdf#105922: step increment is a property of the shape
...
not of the gradient. Therefore don't reset selection in the gradient
list if step increment changes.
This hopefully fixes also the failing UI test
Change-Id: Ia3da23d80ee9601b40309a2f213bd3b2c850ff5a
Reviewed-on: https://gerrit.libreoffice.org/36508
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
2017-04-13 11:58:38 +02:00
3c3f7d784e
Removed duplicated includes
...
No automatic tools. Manual checked and tested.
Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754
Reviewed-on: https://gerrit.libreoffice.org/36371
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-04-13 07:46:16 +02:00
f1bbafc584
Convert rtl_uString -> OUString in jfw_get/setVMParameters
...
Change-Id: I55f96873661f686cd9625d69523718ccb54659dc
2017-04-12 09:36:20 +02:00
346b5cfd90
Convert some rtl_uString -> OUString in jvmfwk
...
Change-Id: I08de5cab29dabc6fd824d5df8bac12c8520a05ae
2017-04-12 09:36:20 +02:00
87d4fd3b13
Remove unnecessary casts to void
...
Change-Id: Ib817e07d4becd7c4cf92501b747d7628ef231c55
2017-04-11 19:00:55 +02:00
7635e0c1c7
sal_Bool -> bool
...
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-11 18:38:51 +02:00
33cf2b6613
Let jfw_isVMRunning return the result; there are no error conditions
...
Change-Id: I004b3d6f6b7b32d1bb41072d7fdd4a66f944d992
2017-04-11 18:33:31 +02:00
16f29aa720
sal_Bool -> bool
...
Change-Id: Iec70d6726e36af607a0a5b5a0f6dc86d05322435
2017-04-11 18:28:43 +02:00
f0454e72c1
Use std::unique_ptr<JavaInfo> for lifecycle management in jvmfwk/framework.hxx
...
Change-Id: Ie604c75e92c407ff3118aaa58155648d956c91fb
2017-04-11 18:04:54 +02:00
6bb4c48812
Determine accurate position for already added JREs
...
Change-Id: Ieef6aaeccd3368fa1cf79b3eab510b6b6c24427e
2017-04-11 17:52:50 +02:00
be8b9b4d29
loplugin:redundantcast find cstyle arithmetic casts
...
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577
Reviewed-on: https://gerrit.libreoffice.org/36253
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-07 12:16:13 +00:00
0791c51c72
Improved loplugin:redundantcast, static_cast on arithmetic types: cui
...
Change-Id: I2060dc58167e5bf5ee8244a56970c399f53fe237
2017-04-06 18:32:51 +02:00
f747390b4f
tdf#106943 Lock down Experimental features and Macro recording
...
Visually disable these features if they are locked by
system administrators
Change-Id: Ib35840312ad9c506e689ec6c9d432a88c07a5c28
Reviewed-on: https://gerrit.libreoffice.org/36095
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2017-04-06 11:24:05 +00:00
4a84cbaa37
prev/next buttons start invisible in the .ui
...
Change-Id: Iec577adb469109a11188e83d95de6ed3960bc1c4
2017-04-05 15:45:16 +01:00
572e9cde74
loplugin:redundantcast find c-style bool casts
...
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2
Reviewed-on: https://gerrit.libreoffice.org/36137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 12:21:19 +00:00
ff339c89b5
loplugin:constantparam part2
...
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 06:42:40 +00:00
0f89d964b2
coverity#1403732 Mixing enum types
...
and
coverity#1403735 Mixing enum types
coverity#1403737 Mixing enum types
Change-Id: I278b7d5116d4157e6aa4483d8eef42325e4bc03b
2017-04-04 12:52:15 +01:00
6eabb8fc77
coverity#1403734 Mixing enum types
...
Change-Id: I46a9a85e7f70502f703ee9fb0f94abd83952d120
2017-04-03 10:39:02 +01:00
334e6e2f1a
Typo: TopToBotton -> TopToBottom
...
Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655
Reviewed-on: https://gerrit.libreoffice.org/36014
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-04-02 08:09:13 +00:00
b1e5e37256
Hide useless label for adjacent cells on border tabpage
...
This adjacent cell settings is used only for Calc documents.
Check box was hidden, but label was not.
Change-Id: I6dcf3bb4ee316c9f3d653fc4f8f9dbcaf393e416
Reviewed-on: https://gerrit.libreoffice.org/36013
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-04-02 08:08:50 +00:00
011e1cdbf3
Related: tdf#106515 show OpenSymbol if unavailable StarSymbol requested
...
Change-Id: I442df1c44839642bd1f91afedee577214032466b
2017-03-31 15:25:11 +01:00
54f8ed8b83
const these up
...
Change-Id: If79187b8e2624da132ed47f5baf374211cc6e449
2017-03-31 15:25:11 +01:00
f4b7338f98
Resolves: tdf#106515 use OpenSymbol, not StarSymbol as the default bullet font
...
For choosing a bullet from a real font it matters while otherwise its a synonym. Of
course we have this code duplicated three times.
Change-Id: I2428b9a23d997925de3e731b8afe9fb8cf18ed54
2017-03-31 15:25:11 +01:00
ff1f83dd08
tdf#105922: Apply custom gradient/hatch even if not saved as preset
...
Change-Id: Ide35eb2c186d1ef5daaf96b1bd6d52448dfe69f9
Reviewed-on: https://gerrit.libreoffice.org/35961
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
2017-03-31 10:54:34 +00:00
dcffc21805
use actual UNO enums in svx
...
Change-Id: I00f53260667861ca2595892b5605479da3401adb
Reviewed-on: https://gerrit.libreoffice.org/35913
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-31 06:59:31 +00:00
a5a571307f
tdf#82580 tools: rename Rectangle to tools::Rectangle
...
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-03-31 06:27:11 +00:00
84f7839224
Related: tdf#106080 support a 'none' color in search by format
...
so we can show the initial no-color selected state differently
than the automatic color default color
Change-Id: Ib3020e507b1555cb446c2b501f60b67222dc115c
Reviewed-on: https://gerrit.libreoffice.org/35863
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-03-30 07:53:47 +00:00
902ed60438
tdf#39468 Translate German comments
...
Translate German comments and terms in cui/
Change-Id: I119ec4e5d87a4db300c5cf53ebdb13f297824940
Reviewed-on: https://gerrit.libreoffice.org/35821
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-29 19:40:14 +00:00
d7f1a1689d
Resolves: tdf#106080 fix explicitly setting automatic in search by format
...
this is still somewhat broken in that what you see is not what you get
if you don't explicitly set automatic, but clears the regression part
of things in that the old broken behavior is restored instead of the
new broken behavior
Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a
2017-03-29 17:04:56 +01:00
71af22ce8c
expand these unhelpful macros
...
Change-Id: I38b5948d4782f97f6de62057a42b414dd0db8512
2017-03-29 15:43:43 +01:00
9bfd742d8c
loplugin:unusedmethods
...
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 11:43:40 +00:00
5f2d57fb32
convert EViewType to scoped enum
...
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617
Reviewed-on: https://gerrit.libreoffice.org/35822
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 10:21:35 +00:00
65aa28cc1c
tdf#42949: clean up includes in include/svx/[a-c]* with iwyu
...
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e
Reviewed-on: https://gerrit.libreoffice.org/26582
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-28 09:12:04 +00:00
913395e99b
Use hub link for git log
...
Change-Id: Ie8c6cafe9322466c7403bc3ebfd6cd3b73847bff
Reviewed-on: https://gerrit.libreoffice.org/35655
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2017-03-27 07:14:08 +00:00
7668d4e616
Fix typos
...
Change-Id: I56e429ff1b8ee55ccb8df16002b509770762172c
Reviewed-on: https://gerrit.libreoffice.org/35618
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 16:17:21 +00:00
ed76d1d350
loplugins:redundantcast teach it about c-style typedef casts
...
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 09:48:10 +00:00
b66b3050c4
“Hyperlink” is NOT a dated word, it’s just a precise one
...
We should always be clear and precise, given that LibreOffice handles various
kinds of links.
Nobody at L10n wanted this change, but they were ignored.
This should fix tdf#103093, which was a consequence of the introduced ambiguity.
This reverts commit a1297fc2df243d765ffb14f18bbdde158459b9f4.
Change-Id: I29232c7a8384c3fa501c61aab26e061ebcb1a0d8
2017-03-23 00:40:28 -06:00
f512cf5b1b
Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg
...
Change-Id: Ifcc531df2b780e446dd4c2cccf74fa902ab4a259
2017-03-22 21:44:16 +01:00
7299481834
loplugin:redundantcast find redundant c-style enum casts
...
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-22 06:47:35 +00:00
e9c7d259e8
create SfxDisableFlags enum
...
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f
Reviewed-on: https://gerrit.libreoffice.org/35514
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-22 06:46:10 +00:00
c16a4380fe
remove EE_RESSTR preprocessor abuse
...
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58
Reviewed-on: https://gerrit.libreoffice.org/35370
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-18 00:35:05 +00:00
9bb21ef311
cleanup itempool includes
...
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10
Reviewed-on: https://gerrit.libreoffice.org/35313
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-03-17 11:00:09 +00:00
f2a873cd13
convert SvxBorderStyle to scoped enum
...
and rename to SvxBorderLineStyle
Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-17 06:04:30 +00:00
2b3f043ad7
remove unused defines from HRC files in cui
...
Change-Id: I170dfc5970896365322dedf4fb797478653578a0
Reviewed-on: https://gerrit.libreoffice.org/35250
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-16 08:34:55 +00:00