de030cd7a2
gbuild: Remove MSVC 2013 legacy code
...
Uwinapi is discontinued.
Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org >
Tested-by: David Ostrovsky <david@ostrovsky.org >
2017-04-21 18:18:44 +02:00
c48ad62924
convert HTML_OPTION_IDS to scoped enum
...
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6
Reviewed-on: https://gerrit.libreoffice.org/36748
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-21 09:20:50 +02:00
8c8f2a5285
remove unnecessary explicit linefeeds from end of SAL and OSL log calls
...
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf
Reviewed-on: https://gerrit.libreoffice.org/36727
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-21 09:15:11 +02:00
1c5cae479b
loplugin:unusedmethods
...
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-20 10:07:10 +02:00
447a013299
clang-tidy readability-simplify-boolean-expr in dbaccess..framework
...
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99
Reviewed-on: https://gerrit.libreoffice.org/36678
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-19 14:52:50 +02:00
8d09f10cbb
unused ids
...
Change-Id: Ifba0092edf5839646be9745f8e9da680946db97a
2017-04-18 11:45:40 +01:00
d0b1f66aa7
convert query functions menu to .ui
...
Change-Id: Iba4fc93d6042d873c45c58f11b7b54638ed54d82
2017-04-18 11:45:40 +01:00
057cde3f8a
convert join table view menu to .ui
...
Change-Id: I249cf0ba1ffcc7e2736ac7270bc988a0916947dd
2017-04-18 11:27:07 +01:00
a642632726
convert join menu to .ui
...
Change-Id: I4e38e431df00a8a97772c5eb0056f824beaf8912
2017-04-18 11:21:43 +01:00
1660bdd08b
convert primary key menu to .ui
...
Change-Id: I78b4f6edc33ddc908402d8ab952bfebc11e4f929
2017-04-18 10:55:04 +01:00
2f30782b03
we surely don't want to fall through after showing a menu
...
Change-Id: Ib6577b85c444930cee298cccef445a842a541d7b
2017-04-18 10:39:12 +01:00
9714e7460c
convert table design row menu to .ui
...
Change-Id: I8a6be28ccd7cbd2b8f18255e3da01df2dfe13fb8
2017-04-18 10:39:11 +01:00
a36997c15b
convert column menu to .ui
...
Change-Id: I3a41b716c473a17821969f09945ac1a94b024d41
Reviewed-on: https://gerrit.libreoffice.org/36569
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-04-15 20:08:40 +02:00
9f565f5cb6
can use gb_CppunitTest_use_configuration and still access .ui files
...
after...
commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91
Author: Caolán McNamara <caolanm@redhat.com >
Date: Wed Apr 12 16:14:10 2017 +0100
take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR
Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258
Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f
Reviewed-on: https://gerrit.libreoffice.org/36482
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-04-12 22:59:42 +02:00
82dca420f9
loplugin:inlinefields in dbaccess::SubComponentLoader
...
Change-Id: Idc4ac037d023a7019e62ec3b7d12bc7717c11be8
Reviewed-on: https://gerrit.libreoffice.org/36345
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-10 11:05:21 +02:00
d3f7146db6
Clean up uses of SAL_U/SAL_W: dbaccess
...
Change-Id: I08816442e63ccd33148d233f21f3d761bcdde13c
2017-04-10 10:14:55 +02:00
3e1977abc6
convert RID_QUERYCOLPOPUPMENU to .ui format
...
Change-Id: Idcf8566db964c475a0b9049f215af6fc57f0978b
2017-04-07 18:36:59 +01:00
132307c089
RID_SBA_GRID_COLCTXMENU has the same odd pattern
...
Change-Id: Ie05b8d0fe706656f9d9fb66b43af11fac87c8d46
2017-04-07 18:36:58 +01:00
ff8b873936
RID_SBA_GRID_ROWCTXMENU is strangely used to insert entries into another menu
...
Change-Id: I61fdb3141c345f1d8dd04ee73d9b1bc332cef754
2017-04-07 18:36:58 +01:00
7d98edfa49
tdf#39468 Translate German comments
...
Translate German comments and terms in dbaccess/, extensions/, formula/,
include/, reportdesign/, rsc/, sd/, svtools/, and vcl/
Change-Id: Ie20dadda0eeb0786eb328c6c652287d5481c5e3b
Reviewed-on: https://gerrit.libreoffice.org/36249
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-04-07 11:15:03 +00:00
bc4176fa43
tdf#95386 More Help Agent cleanup
...
These methods were creating and passing URLs for the
long dead Help Agent
Change-Id: I5e3eafc2ca3bf5c1ca0032b9cb19ed30c8f06e66
Reviewed-on: https://gerrit.libreoffice.org/36172
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2017-04-07 08:42:41 +00:00
f4cd4b3cf9
Improved loplugin:redundantcast, static_cast on arithmetic types: dbaccess
...
Change-Id: Ic6331f8532254c7fc69e15c14b7f44c872ba7c62
2017-04-06 18:32:47 +02:00
7662e92c64
loplugin:redundantcast find cstyle double casts
...
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8
Reviewed-on: https://gerrit.libreoffice.org/36187
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-06 07:47:30 +00:00
ff339c89b5
loplugin:constantparam part2
...
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 06:42:40 +00:00
9ac98e6e34
Finally switch MSVC to sal_Unicode = char16_t, too
...
There is lots of (Windows-only) code that relied on sal_Unicode being the same
as wchar_t, and the best change may be different in each case (and doing the
changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding
functions to sal/types.h, remove their uses one by one again, and finally drop
those functions again.
Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea
Reviewed-on: https://gerrit.libreoffice.org/36077
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-04-04 16:12:11 +00:00
12e88e3b28
fix typo: databse --> database
...
Change-Id: I3ae198eb599a6b0db1be900a2c464ab7b4c20e89
Reviewed-on: https://gerrit.libreoffice.org/35236
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-31 15:02:02 +00:00
a5a571307f
tdf#82580 tools: rename Rectangle to tools::Rectangle
...
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-03-31 06:27:11 +00:00
da56de9ac4
remove type decorations on char literals
...
they are only needed where type deduction fails.
left them in defines for now.
Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-03-30 12:21:40 +00:00
ad3681df0a
tdf#39468 Translate German comments
...
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/,
and idl/
Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945
Reviewed-on: https://gerrit.libreoffice.org/35888
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-30 10:27:35 +00:00
90305526ee
loplugin:unusedenumconstants
...
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c
Reviewed-on: https://gerrit.libreoffice.org/35854
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-30 06:26:26 +00:00
fd34499464
Fix typos
...
Change-Id: Ibef75de246fb31884153437fe8c05e299fe5962f
Reviewed-on: https://gerrit.libreoffice.org/35782
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-28 20:43:04 +00:00
f924422a05
tdf#39468 Translate German comments
...
Translate German comments in dbaccess/
Change-Id: Ib8e5e737c5d3cd6cd968be45e74d8d015c855e16
Reviewed-on: https://gerrit.libreoffice.org/35620
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-27 13:03:40 +00:00
3c8efc29d6
Fix typos
...
Change-Id: If350d22ed9365fa8924dc049f23d7f5cd92b9872
Reviewed-on: https://gerrit.libreoffice.org/35625
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 16:54:57 +00:00
7916487cf4
convert ViewShellId to o3tl::strong_int
...
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09
Reviewed-on: https://gerrit.libreoffice.org/35421
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-24 06:14:17 +00:00
ed76d1d350
loplugins:redundantcast teach it about c-style typedef casts
...
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 09:48:10 +00:00
2b06401622
remove unused defines from HRC files in dbaccess
...
Change-Id: Ib6ef44769318e133db5744260ff9103d310ff848
Reviewed-on: https://gerrit.libreoffice.org/35268
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-17 06:04:38 +00:00
f645294d39
remove unused RID constants
...
found with the attached bin/find-unused-rid.py script
Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf
Reviewed-on: https://gerrit.libreoffice.org/35136
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-14 08:37:44 +00:00
7e9857c293
templatize SvXMLEnumMapEntry
...
in preparation for "scoped UNO enums".
This is a little hacky: In order to limit the scope of this change,
the templated SvXMLEnumMapEntry struct actually has a fixed size field,
and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various
places, to avoid carrying the type param around.
Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83
Reviewed-on: https://gerrit.libreoffice.org/34987
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-13 09:02:22 +00:00
fba66b325c
Fix typos
...
Change-Id: I19d30a1ef4236dbe0a0053dad67a5ba7b1586fc8
Reviewed-on: https://gerrit.libreoffice.org/35054
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Johnny_M <klasse@partyheld.de >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-11 05:04:40 +00:00
9b95093950
convert SvxCellHorJustify to scoped enum
...
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33
Reviewed-on: https://gerrit.libreoffice.org/34968
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-09 07:25:29 +00:00
5753ac2e28
loplugin:loopvartoosmall
...
Change-Id: Id82051b633050165077deb9a6a88d82707d53e75
2017-03-07 19:47:34 +01:00
aadf790bbc
remove some unnecessary use of OUString constructor
...
found with
git grep -nP '<<= OUString\(\w*[A-Za-z]+'
Change-Id: I43354842f1e0418fb292f2e8e0cb30f1229d1c67
Reviewed-on: https://gerrit.libreoffice.org/34864
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-06 05:59:56 +00:00
6cb9e6dad7
Remove redundant 'inline' keyword
...
...from function definitions occurring within class definitions. Done with
a rewriting Clang plugin (to be pushed later).
Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-03-03 20:55:50 +00:00
2e0db91d90
Fix typos
...
Change-Id: I6b547a864e7a8c8eeedcd7f7c56796e2b3a606d1
Reviewed-on: https://gerrit.libreoffice.org/34807
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-03 07:06:52 +00:00
4730b23b1d
use std::vector::insert when inserting multiple of the same thing
...
instead of looping
Change-Id: I7b8c1663e303449302e0b96dc5b483367c2a52ba
2017-03-02 11:28:37 +02:00
198c41c4fe
new loplugin unoany
...
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-28 10:17:47 +00:00
451d372795
OSelectionBrowseBox::AddGroupBy parameter _nCurrentPos is unused
...
...since ef40dde69e7fff331b7e31460638703a2c82bc9d "INTEGRATION: CWS dba30d"
Change-Id: I2dbd73bd77f71cbf88768dcc2dc4a38f65b84eef
2017-02-27 18:10:38 +01:00
ab92c84dfe
Revert "Fix typos"
...
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7.
Caused some problems, need to be broken down.
Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52
Reviewed-on: https://gerrit.libreoffice.org/34534
Reviewed-by: jan iversen <jani@libreoffice.org >
Tested-by: jan iversen <jani@libreoffice.org >
2017-02-22 08:46:44 +00:00
ffd7f8fcfc
Fix typos
...
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447
Reviewed-on: https://gerrit.libreoffice.org/34476
Reviewed-by: jan iversen <jani@libreoffice.org >
Tested-by: jan iversen <jani@libreoffice.org >
2017-02-22 07:21:20 +00:00
0649622956
loplugin:unusedmethods
...
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c
Reviewed-on: https://gerrit.libreoffice.org/34508
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-21 10:07:37 +00:00