c48ad62924
convert HTML_OPTION_IDS to scoped enum
...
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6
Reviewed-on: https://gerrit.libreoffice.org/36748
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-21 09:20:50 +02:00
ea537ecffa
SvxSpellWrapper::ReplaceAll doesn't use it's second param
...
Change-Id: I79b82d37e6cf4c1dde474f0f90b6370c2359a0b3
Reviewed-on: https://gerrit.libreoffice.org/36673
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-20 08:26:28 +02:00
447a013299
clang-tidy readability-simplify-boolean-expr in dbaccess..framework
...
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99
Reviewed-on: https://gerrit.libreoffice.org/36678
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-19 14:52:50 +02:00
81291d6223
cppcheck: useInitializationList
...
Change-Id: Iee4db89fe3bd256da0b7ff0f40a3c4789666c525
Reviewed-on: https://gerrit.libreoffice.org/36633
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
2017-04-18 13:05:05 +02:00
15ac3f9f4d
Fix vertical text and bitmap bullet rendering
...
Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e
2017-04-15 15:40:56 +02:00
c671094154
Introduce text rotation for Impress tables
...
* Introduce new table property for text rotation
* Support only two rotation angle (270° and 90°)
* Implement editing and rendering of 270° rotated
text (90° rotation was already implemented)
Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e
2017-04-15 15:40:56 +02:00
dd700ceda7
loplugin:inlinefields in SvxAutoCorrect
...
Change-Id: I09aa52551dd1ed96bc9a72baec6afe5a4a05c1dd
Reviewed-on: https://gerrit.libreoffice.org/36346
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-10 11:26:20 +02:00
be8b9b4d29
loplugin:redundantcast find cstyle arithmetic casts
...
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577
Reviewed-on: https://gerrit.libreoffice.org/36253
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-07 12:16:13 +00:00
a48fadd261
Improved loplugin:redundantcast, static_cast on arithmetic types: editeng
...
Change-Id: I64be28eb18822c29e3d540decb465c9204d16894
2017-04-06 18:32:40 +02:00
f1945405b0
loplugin:redundantcast check for c-style float casts
...
Change-Id: I86b6f58887cb398a80698f8d8564b5bc3f55eabb
Reviewed-on: https://gerrit.libreoffice.org/36198
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-06 11:41:46 +00:00
0c82dff153
loplugin:singlevalfields
...
Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1
Reviewed-on: https://gerrit.libreoffice.org/36145
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-06 09:21:58 +00:00
dea248f5cb
unnecessary pre-all-oustring copy
...
Change-Id: Ife45898482b74b1b911001d99d04bb8daeacfb41
2017-04-06 09:25:40 +01:00
7d4b68fa47
Fix typos
...
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4
Reviewed-on: https://gerrit.libreoffice.org/36100
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-04-06 07:53:19 +00:00
572e9cde74
loplugin:redundantcast find c-style bool casts
...
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2
Reviewed-on: https://gerrit.libreoffice.org/36137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 12:21:19 +00:00
ff339c89b5
loplugin:constantparam part2
...
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 06:42:40 +00:00
6b4a149a65
tdf#39468 Translate German comments
...
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.
Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-04-03 19:25:49 +00:00
df039e89c5
Remove DBG_ASSERT since it's always wrong
...
Indeed EditHTMLParser constructor calls HTMLParser constructor,
the last one calls "SetSrcEncoding(RTL_TEXTENCODING_UTF8);"
Change-Id: If749674c3d4f2b9f9fccbf0b99f1e7d62fd0450d
Reviewed-on: https://gerrit.libreoffice.org/36011
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-04-03 19:19:10 +00:00
1e30d2afac
Add SvxTextRotateItem inherited from SvxCharRotatItem
...
I will be use it later for text rotation inside a table.
Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc
Reviewed-on: https://gerrit.libreoffice.org/36021
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-04-02 19:11:19 +00:00
2f33a8cd23
coverity#1403662 Mixing enum types
...
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947
Reviewed-on: https://gerrit.libreoffice.org/36020
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-04-02 16:31:48 +00:00
7acbf45fcc
use actual UNO enums in editeng
...
Change-Id: I58e794f161f3c4dd103985f575bc25202d4989b3
Reviewed-on: https://gerrit.libreoffice.org/35907
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-31 06:58:55 +00:00
a5a571307f
tdf#82580 tools: rename Rectangle to tools::Rectangle
...
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-03-31 06:27:11 +00:00
b5c26668a0
editeng: tweak comment
...
Change-Id: I587fafea157a02d2c903dda4b85448b1fe349c3e
2017-03-30 12:26:12 +02:00
5aaaa9408a
tdf#39468 Translate German comments
...
Translate German comments and terms in editeng/
Change-Id: I9bd15ca0914b34839d83751f530dd212d91e029e
Reviewed-on: https://gerrit.libreoffice.org/35884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-30 10:14:53 +00:00
a34b33d2b9
convert SvxDateType to scoped enum
...
Change-Id: I5ce04f252642cb3a6c1b08ee22255f6c7b97f0f8
Reviewed-on: https://gerrit.libreoffice.org/35842
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-30 06:26:12 +00:00
2f200f1e76
Resolves: tdf#106079 automatic color described as 'white'
...
move RID_SVXSTR_AUTOMATIC from svx to editeng for this
Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29 15:24:14 +01:00
b6853991fc
split ImportState enum into RtfImportState and HtmlImportState
...
and convert to scoped enum
Change-Id: I23e44e78ce96ed5fc19374e3e069e1cdc2166a35
Reviewed-on: https://gerrit.libreoffice.org/35840
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 12:30:31 +00:00
1672b25eb4
Fix integer type of EditCharAttrib nStart/nEnd members
...
Looks reasonable to replace assignment to nEndField from USHRT_MAX with -1 in
ImpEditEngine::AddPortionIterated (editeng/source/editeng/impedit4.cxx). This
apparently needs to just be an arbitrary value that EditPaM::GetIndex() will
never have. Looks like 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and
tools/string.hxx final straw" missed that (as that commit's message
acknowledges).
Change-Id: I5840d52d12a71937a5ed2779bfd5de071f702300
2017-03-29 13:48:33 +02:00
9bfd742d8c
loplugin:unusedmethods
...
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 11:43:40 +00:00
4e808469d5
Make loplugin:loopvartoosmall look past top-level ExprWithCleanups
...
Note the two "//TODO!" in the fix of the one newly found issue.
Change-Id: I181691da4b74cd55611452e002b37bd6798ff1e6
2017-03-27 15:50:48 +02:00
55cc79f33f
Fix typos
...
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2
Reviewed-on: https://gerrit.libreoffice.org/35629
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 09:27:18 +00:00
7916487cf4
convert ViewShellId to o3tl::strong_int
...
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09
Reviewed-on: https://gerrit.libreoffice.org/35421
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-24 06:14:17 +00:00
6291574d94
Remove unused #include <ctype.h>
...
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23 17:55:31 +01:00
ed76d1d350
loplugins:redundantcast teach it about c-style typedef casts
...
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 09:48:10 +00:00
7299481834
loplugin:redundantcast find redundant c-style enum casts
...
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-22 06:47:35 +00:00
47a9523f3f
Fix typos + some German translations
...
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-19 10:05:45 +00:00
d948d66509
Fix typos
...
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085
Reviewed-on: https://gerrit.libreoffice.org/35413
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-19 05:49:15 +00:00
109210e5b7
Revert "Revert "Implement export and import of author field in fixed format""
...
This reverts commit cae16645e17df6a1f87443c00b6abfd26dabd27f.
Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf
Reviewed-on: https://gerrit.libreoffice.org/35391
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
2017-03-18 11:54:54 +00:00
c16a4380fe
remove EE_RESSTR preprocessor abuse
...
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58
Reviewed-on: https://gerrit.libreoffice.org/35370
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-18 00:35:05 +00:00
93412700af
get rid of pointless EE_DLL macro
...
Change-Id: Ide055b4c1c6d26e4ade1ceed0f3669c4cb7d8392
Reviewed-on: https://gerrit.libreoffice.org/35369
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-18 00:34:49 +00:00
f2a873cd13
convert SvxBorderStyle to scoped enum
...
and rename to SvxBorderLineStyle
Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-17 06:04:30 +00:00
cae16645e1
Revert "Implement export and import of author field in fixed format"
...
This reverts commit 5de40734af30a8b897c6c5b7f681759e36a25557.
Change-Id: Ib09fb1dc54066cadcd9503c92140d78e7482ae6c
Reviewed-on: https://gerrit.libreoffice.org/35281
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
2017-03-16 16:17:40 +00:00
82981b94fe
remove useless casts
...
Change-Id: I900b72372a56d341d18091b0d4721d31002d147f
Reviewed-on: https://gerrit.libreoffice.org/35223
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 18:36:37 +00:00
8ccbc16b5e
convert SvxFrameDirection to scoped enum
...
Based on the casts in chart2/source/view/main/ChartView.cxx
and the similarity of naming of values, I conclude that this
enum was intended to abstract over css::text::WritingMode2.
Added a comment to that effect.
Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57
Reviewed-on: https://gerrit.libreoffice.org/35164
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 08:35:10 +00:00
8b378dac00
-Werror,-Wformat (clang-cl)
...
Change-Id: I7a3f58e5967a31999f45ce15086f048fb39650c7
2017-03-14 14:44:19 +01:00
f645294d39
remove unused RID constants
...
found with the attached bin/find-unused-rid.py script
Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf
Reviewed-on: https://gerrit.libreoffice.org/35136
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-14 08:37:44 +00:00
250995d2b8
change SvxFrameDirectionItem base to SfxEnumItem
...
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091
Reviewed-on: https://gerrit.libreoffice.org/35160
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-14 07:58:49 +00:00
975bfbe29d
make this a member of SvxBrushItem
...
Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b
2017-03-12 16:44:06 +00:00
fba66b325c
Fix typos
...
Change-Id: I19d30a1ef4236dbe0a0053dad67a5ba7b1586fc8
Reviewed-on: https://gerrit.libreoffice.org/35054
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Johnny_M <klasse@partyheld.de >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-11 05:04:40 +00:00
c54bb4a9f7
tdf#99352: create editeng::SharedVclRessources
...
- instead of keeping vcl resources in a rtl::Static
- these are shared owned by all EditEngines
- they let go of them when disposed
- thus, this should prevent VclPtrs to leak beyond dispose()
Change-Id: Ic6198c19d0ff9c09ecdea377d07807f08711d6a0
Reviewed-on: https://gerrit.libreoffice.org/34986
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-10 13:00:49 +00:00
1a044b25c2
tdf#99352: dispose EditEngines when SfxApp dies
...
In an ideal world, by the time we reach DeInitVCL() there should be
neither non-null VclPtr nor EditEngine instances around. This fixes the
former for those VclPtrs owned by EditEngines, by disposing them when
SfxApplication is dying. The goal is -- for now -- to not have any
non-null VclPtrs around by DeInitVCL(), so we can e.g. assert() on that
to pick up regressions.
Should we one day have all EditEngines accounted for with proper smart
pointers that get torn down before DeInitVCL(), the Dispose() introduced
here might be removed again.
Change-Id: I47b17f7fd31fce2ac5fd6f6b146d356d7d07e677
Reviewed-on: https://gerrit.libreoffice.org/34985
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-10 12:59:26 +00:00
