be8b9b4d29
loplugin:redundantcast find cstyle arithmetic casts
...
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577
Reviewed-on: https://gerrit.libreoffice.org/36253
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-07 12:16:13 +00:00
f1945405b0
loplugin:redundantcast check for c-style float casts
...
Change-Id: I86b6f58887cb398a80698f8d8564b5bc3f55eabb
Reviewed-on: https://gerrit.libreoffice.org/36198
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-06 11:41:46 +00:00
572e9cde74
loplugin:redundantcast find c-style bool casts
...
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2
Reviewed-on: https://gerrit.libreoffice.org/36137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 12:21:19 +00:00
ff339c89b5
loplugin:constantparam part2
...
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-05 06:42:40 +00:00
6b4a149a65
tdf#39468 Translate German comments
...
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.
Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-04-03 19:25:49 +00:00
1e30d2afac
Add SvxTextRotateItem inherited from SvxCharRotatItem
...
I will be use it later for text rotation inside a table.
Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc
Reviewed-on: https://gerrit.libreoffice.org/36021
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-04-02 19:11:19 +00:00
2f33a8cd23
coverity#1403662 Mixing enum types
...
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947
Reviewed-on: https://gerrit.libreoffice.org/36020
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-04-02 16:31:48 +00:00
7acbf45fcc
use actual UNO enums in editeng
...
Change-Id: I58e794f161f3c4dd103985f575bc25202d4989b3
Reviewed-on: https://gerrit.libreoffice.org/35907
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-31 06:58:55 +00:00
a5a571307f
tdf#82580 tools: rename Rectangle to tools::Rectangle
...
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-03-31 06:27:11 +00:00
a34b33d2b9
convert SvxDateType to scoped enum
...
Change-Id: I5ce04f252642cb3a6c1b08ee22255f6c7b97f0f8
Reviewed-on: https://gerrit.libreoffice.org/35842
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-30 06:26:12 +00:00
2f200f1e76
Resolves: tdf#106079 automatic color described as 'white'
...
move RID_SVXSTR_AUTOMATIC from svx to editeng for this
Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29 15:24:14 +01:00
9bfd742d8c
loplugin:unusedmethods
...
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 11:43:40 +00:00
ed76d1d350
loplugins:redundantcast teach it about c-style typedef casts
...
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 09:48:10 +00:00
7299481834
loplugin:redundantcast find redundant c-style enum casts
...
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-22 06:47:35 +00:00
109210e5b7
Revert "Revert "Implement export and import of author field in fixed format""
...
This reverts commit cae16645e17df6a1f87443c00b6abfd26dabd27f.
Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf
Reviewed-on: https://gerrit.libreoffice.org/35391
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
2017-03-18 11:54:54 +00:00
c16a4380fe
remove EE_RESSTR preprocessor abuse
...
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58
Reviewed-on: https://gerrit.libreoffice.org/35370
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-18 00:35:05 +00:00
f2a873cd13
convert SvxBorderStyle to scoped enum
...
and rename to SvxBorderLineStyle
Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-17 06:04:30 +00:00
cae16645e1
Revert "Implement export and import of author field in fixed format"
...
This reverts commit 5de40734af30a8b897c6c5b7f681759e36a25557.
Change-Id: Ib09fb1dc54066cadcd9503c92140d78e7482ae6c
Reviewed-on: https://gerrit.libreoffice.org/35281
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
2017-03-16 16:17:40 +00:00
82981b94fe
remove useless casts
...
Change-Id: I900b72372a56d341d18091b0d4721d31002d147f
Reviewed-on: https://gerrit.libreoffice.org/35223
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 18:36:37 +00:00
8ccbc16b5e
convert SvxFrameDirection to scoped enum
...
Based on the casts in chart2/source/view/main/ChartView.cxx
and the similarity of naming of values, I conclude that this
enum was intended to abstract over css::text::WritingMode2.
Added a comment to that effect.
Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57
Reviewed-on: https://gerrit.libreoffice.org/35164
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 08:35:10 +00:00
f645294d39
remove unused RID constants
...
found with the attached bin/find-unused-rid.py script
Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf
Reviewed-on: https://gerrit.libreoffice.org/35136
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-14 08:37:44 +00:00
250995d2b8
change SvxFrameDirectionItem base to SfxEnumItem
...
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091
Reviewed-on: https://gerrit.libreoffice.org/35160
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-14 07:58:49 +00:00
975bfbe29d
make this a member of SvxBrushItem
...
Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b
2017-03-12 16:44:06 +00:00
5de40734af
Implement export and import of author field in fixed format
...
Change-Id: I1975bfcdc8436f2b05e2fab2a4c9c09838330b30
Reviewed-on: https://gerrit.libreoffice.org/33520
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com >
2017-03-10 04:47:48 +00:00
9b95093950
convert SvxCellHorJustify to scoped enum
...
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33
Reviewed-on: https://gerrit.libreoffice.org/34968
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-09 07:25:29 +00:00
1f4e0359d3
convert SvxShadowLocation to scoped enum
...
Change-Id: Ie51995579312328538263172cd3173641df89bca
Reviewed-on: https://gerrit.libreoffice.org/34965
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 09:07:34 +00:00
9cacb6ad9f
convert SvxCaseMap to scoped enum
...
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd
Reviewed-on: https://gerrit.libreoffice.org/34963
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 09:04:30 +00:00
9cb57a50d7
convert SvxAdjust to scoped enum
...
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639
Reviewed-on: https://gerrit.libreoffice.org/34941
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 06:30:49 +00:00
f736175749
Resolves: coverity#1402073 Mixing enum types
...
Change-Id: Ifb8ca51cd8937b740c810083b45d5e7fbb06d91f
2017-03-07 10:01:14 +00:00
177f5c2e50
Proper fix for multiply defined SfxEnumItem<sal_uInt16> with MSVC
...
With --disable-pch the original hack from
f091259ad2ec1590714645839668580cd7b8c7c4 "convert SfxEnumItem to type-safe
template class" doesn't happen to work: When linking sd, the occurrences of
SfxEnumItem<sal_uInt16> in sd/inc/sdattr.hxx clash with those from editeng
(where LanguageType is a typedef for sal_uInt16) and svl (as the respective
include files from editeng and svl happen to not be included). For whatever
reason, the explicit instantiation declaration without a __declspec(...) in
include/svl/eitem.hxx doesn't seem to make a difference (at least with MSVC 2015
Update 3).
Change-Id: I51b5943fe19a7184db9414192c6364f7c26b79eb
Reviewed-on: https://gerrit.libreoffice.org/34903
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2017-03-05 15:10:37 +00:00
1cfedbc960
drop SvxNumType and rename SvxExtNumType->SvxNumType
...
Both of them are abstractions over the css::style::NumberingType
constants.
SvxNumType serves no useful purpose, since it's just a typedef to
sal_Int16.
At least SvxExtNumType wraps up the css::style::NumberingType constants
in a nice enum.
Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e
Reviewed-on: https://gerrit.libreoffice.org/34816
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-03 12:13:44 +00:00
2675f26f1a
remove unused CreateDefault methods
...
Change-Id: Ifbdd7d41f0938e9a03693f88416792ff8087f8c2
Reviewed-on: https://gerrit.libreoffice.org/34850
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-03 11:09:46 +00:00
afa675469c
use SvxExtNumType in SvxNumberType
...
and follow the rabbit trail, fixing various other types in the process
Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d
Reviewed-on: https://gerrit.libreoffice.org/34814
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-03 06:45:05 +00:00
f091259ad2
convert SfxEnumItem to type-safe template class
...
and drop the SvxChartTextOrientItem class, unused.
Change-Id: I99100837d1beb953450f57b2cda47d165df1620c
Reviewed-on: https://gerrit.libreoffice.org/34747
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-03 06:44:41 +00:00
198c41c4fe
new loplugin unoany
...
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-28 10:17:47 +00:00
b57d51e32f
Drop :: prefix from std in [de]*/
...
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4
Reviewed-on: https://gerrit.libreoffice.org/34377
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Tor Lillqvist <tml@collabora.com >
2017-02-17 18:41:19 +00:00
08d063eefe
manage pField with tools::SvRef
...
since it is a SvRefBase subclass
Change-Id: Ib7d1e22336d673405d7455d40464df29f547d351
2017-01-18 10:59:59 +02:00
cd8fdb46fd
new loplugin: useuniqueptr: editeng
...
Change-Id: I6df65eab882780d996ee996b5fef8020186b6d98
Reviewed-on: https://gerrit.libreoffice.org/32958
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-13 13:08:52 +00:00
d15b4e2045
teach sallogareas plugin to catch inconsistencies
...
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-15 06:45:14 +00:00
c3586b684c
OSL_TRACE->SAL in chart2..oox
...
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-13 06:12:00 +00:00
50151db9f7
convert FSysStyle to o3tl::typed_flags
...
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05 12:49:02 +02:00
bfde4866e0
convert DecodeMechanism to scoped enum
...
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
b1dd9a631a
loplugin:unnecessaryoverride (dtors) in editeng
...
Change-Id: I7a268a1e991e84304e5435e0f7b633873f6829eb
2016-12-05 09:04:59 +01:00
3662061633
editeng: assert SfxPoolItem::operator==
...
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-18 22:21:55 +01:00
72ffa98e89
make the element names in dumpAsXml match the class names
...
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f
Reviewed-on: https://gerrit.libreoffice.org/30894
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-16 09:20:59 +00:00
5abd8d2eee
coverity#1371263 Missing move assignment operator
...
Change-Id: Ifb4117afac4aa86893e674a581e1a7bb80925ee3
2016-11-11 17:03:11 +00:00
f731296e0c
check for self-assignment
...
Change-Id: I74eb934d19c0b511870e5a675917ca4baaf768cc
2016-11-11 17:03:11 +00:00
4a862a6a01
make it more typical copy ctor
...
Change-Id: I0367e24b966a5bcc0d4838022ae12054e097270e
2016-11-11 17:03:10 +00:00
d5233a94fd
seems dubious to copy the state, but drop the load again bit
...
if the assigned-to item had loaded its original content, but the assigned-from
item hadn't, then surely the assigned-to item will never load the new content.
if the assigned-to item hadn't loaded its original content, but the
assigned-from had, then why load it again
Change-Id: I68c2cf2682a517e7e630ab6cbc637b35a2b9c7aa
Reviewed-on: https://gerrit.libreoffice.org/30781
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-11-11 17:02:38 +00:00
d34572d39d
these are going to get overwritten immediately
...
Change-Id: I065ae2aa2dead0679d05f080124ed54c27f0d68f
2016-11-11 16:21:48 +00:00